summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-06tdf#101856 create bookmarks w/ new hidden/cond attrs, save as odtBernhard Widl
Committer's note: this is forward ported from 5.2+backports branch, with numerous conflicts. tdf#101856 add new checkbox/editfield for hidden/condition attrs Conflicts: sw/uiconfig/swriter/ui/insertbookmark.ui Author: Bernhard Widl <bernhard.widl@cib.de> (cherry picked from commit c347e00821791377731ab32acd103ea006f3cc1b) tdf#101856 Fix crash in Insert Bookmark dialog Author: Serge Krot <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/50616 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit bcc16920eec647f2a3753d60c4d969862f272942) Change-Id: Ib1df7a4c1477693aa2d0ec067635cdcbd393cebd Reviewed-on: https://gerrit.libreoffice.org/46820 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-06solenv: adapt native-code.py to xsec_xmlsec_component_getFactory removalMiklos Vajna
Change-Id: Ic8bfac8b0d0741abeaa38c75d1bad254fe6acaeb
2018-07-06Karasa Jaga: Add missing Impress menubar icons & Common Align actionsRizal Muttaqin
Change-Id: I8a6a9774e40b0ea68fca37e0eb80e59e10241459 Reviewed-on: https://gerrit.libreoffice.org/57016 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-06xmlsecurity: convert last non-uno-consturctor based serviceMiklos Vajna
Change-Id: Ib8a16c69aa2a05118e329a6552682b7a21d4536a Reviewed-on: https://gerrit.libreoffice.org/57023 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-06Added text transformations for external dataVikas
- Uppercase, which sets all text in the selected columns to upper case. - Lowercase, which sets all text in the selected columns to lower case. - Capitalize Each Word, which makes all words in the selected column start with a capital letter and sets all subsequent letters in a word to lower case. - Trim, which removes any leading or trailing whitespace characters from text. Change-Id: I6da37bec9d820887a155da57d0b0c75f36e8ac69 Reviewed-on: https://gerrit.libreoffice.org/56780 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I72d34c875951a8b4a349d92b0d893fdaecd718e7 Reviewed-on: https://gerrit.libreoffice.org/57033 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt
Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06Simplify string concatenation.Mike Kaganski
Change-Id: Ib478a7371599309f68b6fffd4dbed0f17c9ecb01 Reviewed-on: https://gerrit.libreoffice.org/57032 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-06tdf#117903 Add signature line feature to calcSamuel Mehrbrodt
Change-Id: I4e9121803a26cba1f40f8f1c673c7809543ef2ec Reviewed-on: https://gerrit.libreoffice.org/57015 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-06add a selection for the DB range to Dataprovider dlgMarkus Mohrhard
Change-Id: I02c63b46e21cd8d04e6b515e2cbbee08743d5657 Reviewed-on: https://gerrit.libreoffice.org/49459 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Added Delete Column Transformation in Data Provider DialogManuj Vashist
Change-Id: Ibebd92c426d1653642c5b9d037d6368636561fcd Reviewed-on: https://gerrit.libreoffice.org/56786 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Limit GetNextPos() loops to range also for nMoveX, tdf#68290 follow-upEike Rathke
And straighten the code a bit to use one init block and return early if nothing marked or not protected. Change-Id: I4c9247479a137cb7f9435180f3f54667d28a29ef Reviewed-on: https://gerrit.libreoffice.org/57025 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-05Colibre icons: add 32px size iconsandreas kainz
Change-Id: Ib9b16fe037d1ecaac3c52723a002d0b6c440ba31 Reviewed-on: https://gerrit.libreoffice.org/57019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-05cid#1437407: create class loader in doPrivilegedStephan Bergmann
Change-Id: Iade079e44c8d88a13830258157d9481f4b8b3358 Reviewed-on: https://gerrit.libreoffice.org/57013 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-05Only access css::drawing::PointSequence when not emptyArmin Le Grand
Had to adapt EscherPropertyContainer::GetPolyPolygon due to it using conversions from UNO API drawing::PointSequence to old tools::polygon, containing unsafe memory accesses. It is not useful to fix that, use new tooling instead. Before correctly testing nCount for zero in b2dpolygontools.cxx when you look closely always a point was added - a random one due to accessing random memory. This is corrected, so in test case for "tdf104115.docx" a PolyPolygon with two polys is used, the first being empty (had one point due to the error mentioned above). When having no points, CreatePolygonProperties in escherex.cxx does badly calculate and alloc the pSegmentBuf array used to write to doc formats (in the test case - 20 bytes alloced, 22 written). This did not happen before due to having always a point due to the error before - argh! Corrected that and hopefully this will work now. To be on the safe side and to not need to redefine that whole CreatePolygonProperties I will turn back that little change and better sort-out empty polygons inside GetPolyPolygon alrteady. That should bring us back to the original state, at the same time avoiding that CreatePolygonProperties has to handle empty Polygons at all. That stuff urgently needs cleanup - I took a look and thought about using std::vector<sal_uInt8> so no wrong alloc or write too much could happen, but that nTotalBezPoints needs to be pre-calculated because it gets itself written to that buffers... Change-Id: Iefc885928f5bb29bceaf36c2a1555346bb21fd26 Reviewed-on: https://gerrit.libreoffice.org/56927 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-05sc: Prefer std::vector to std::dequeTakeshi Abe
There seems no need for choosing deque in the first place 5099046dccb69af04e2a3adafad8e06c0832bd06. Change-Id: I194e6bee37d8f6f177aee96681b3014119aa11c1 Reviewed-on: https://gerrit.libreoffice.org/56997 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-05Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9696a9ad3c0f5c3e6bb12a81dd2386e927eebed2 Reviewed-on: https://gerrit.libreoffice.org/56987 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-05FontFeatureTest set weight/italcs explicitlyTomaž Vajngerl
Font featrues can depend on the state. To make the state more stable we need to set the the font properties explicitly. This sets the weight, italics, width type to "NORMAL", which changes the number of available features. Change-Id: Ida6be4191762c3acfeb7b95182b80717e9774c62 Reviewed-on: https://gerrit.libreoffice.org/57011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-05fix HSQLDB_JAR define in scp2/InstallModule_ooo.mkRene Engelhard
for one HSQLDB_JAR is already a path and secondly, gb_Helper_make_path doesn't even exist (anymore). It's supposed to end up in URE_MORE_JAVA_CLASSPATH_URLS so use gb_Helper_make_url Change-Id: I52c6117299caeb4fac8c894fc54564befc673e67 Reviewed-on: https://gerrit.libreoffice.org/55552 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-05tdf#118546: GetNotebookBar() may return nullptrMike Kaganski
Change-Id: I411ea0abcb5fd5fac0db7fe0c4bad16a0c1b9d77 Reviewed-on: https://gerrit.libreoffice.org/57006 Reviewed-by: Kshitij Pathania <kshitijpathania@gmail.com> Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-05Adjust indentation to match surrounding codeSamuel Mehrbrodt
Change-Id: I631fe8553907c5ddc979a139c8cc77d3902d204a Reviewed-on: https://gerrit.libreoffice.org/57014 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-05Fix for commit ae412b4Andrea Gelmini
In commit ae412b486e02aa5890769bebcfc46e485a72103c I missed a '>', to close tag. Change-Id: Id60b88b5b2a38ede2a2c0680abcc8af32f900586 Reviewed-on: https://gerrit.libreoffice.org/57007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-05-Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
Change-Id: I97cbb82fc0912e9b9ccdfdf78c424c478251362b Reviewed-on: https://gerrit.libreoffice.org/56993 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-05block ocText for calc's threadingLuboš Luňák
It may end up calling XColorList::CreateStdColorList(), and XPropertyList is not thread-safe (gnome#627759-1 with disabled mnOpenCLMinimumFormulaGroupSize). Change-Id: I79c8335c6e8e3aaf39e01c68e6dbf6011820971a
2018-07-05tdf#105225 fix new background tab page in calc format cells dialogJim Raykowski
Change-Id: I56cca8d22e98364eb369f3ccf54ca1acb3eb8516 Reviewed-on: https://gerrit.libreoffice.org/56983 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-05Honor border width in a welded color picker for gtk3/x11Maxim Monastirsky
Change-Id: I1b59e85edb8e9df5be453dc0be1d7d1ffd100ceb Reviewed-on: https://gerrit.libreoffice.org/56996 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05Fix initial width of the color palette in welded pickerMaxim Monastirsky
Problem can be seen with non-gtk3, if the initial palette has no scrollbar (e.g. "standard" palette). The cause is that in non-gtk3 we don't have overlay scrollbars, so the palette area needs to be enlarged when switching from a palette with a scrollbar to a palette without a scrollbar. In practise, this was happening also on initial show, although the palette already had the correct width. To fix that, start with a never scrollbar policy by default, and add the scrollbar later if needed. Change-Id: I5286f301b3c7ef5c72b650290ace784222f7922d Reviewed-on: https://gerrit.libreoffice.org/56995 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05tdf#117745 - Split Options/Formatting Aids/"Display of"heiko tietze
Field options moved into another frame Change-Id: I42a1422617183e5059e66b4f280cbf9cc6daa79d Reviewed-on: https://gerrit.libreoffice.org/56090 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-05sw HTML import: strip query & fragment for <object data="..."> and file URLsMiklos Vajna
There are two cases: when the <object> is a child of an outer <object> (we create an embedded object) and the non-embedded <object> case (we create an image). Call the new SwHTMLParser::StripQueryFromPath() in both cases. INetURLObject considers this query/fragment part as "name" (end of "path"), so just do it manually. Change-Id: Icb7991082b6e595db5729f3c4c84073c80834f27 Reviewed-on: https://gerrit.libreoffice.org/56989 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-05use std::unique_ptr for ScTable in ScDocumentNoel Grandin
Change-Id: Ic817fbd7953afe9007f9ec6071f53c8beca6dd18 Reviewed-on: https://gerrit.libreoffice.org/56949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-05Menubar Impress: add missing icons to menubarandreas kainz
Change-Id: I5116e214ab64923c28dda4d10feab1193b5d9d31 Reviewed-on: https://gerrit.libreoffice.org/56978 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-05vcl: experiment for font related test fails on WNTMichael Stahl
Change-Id: I7471299c1f0d4c0431e9b896cd2fbf5a056f31f8 Reviewed-on: https://gerrit.libreoffice.org/56892 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-05Impress Menu -> Insert -> Slide Number fixed wrong commandandreas kainz
Impress Menubar -> Insert -> Slide Number open the Header and Fooder Dialog Change-Id: Ie6c03358254265422ef2b760aa182515a44480d4 Reviewed-on: https://gerrit.libreoffice.org/56976 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-07-05UBSan apparently still needs --dynamic-list-cpp-typeinfoStephan Bergmann
...(presumably due to it using -fvisibility-ms-compat, cf. solenv/gbuild/platform/com_GCC_defs.mk), or else things start to fail like <https://ci.libreoffice.org/job/lo_ubsan/962/console>'s CustomTarget_testtools/uno_test: > /cpputools/source/unoexe/unoexe.cxx:502:24: runtime error: member call on address 0x60600000c288 which does not point to an object of type 'com::sun::star::lang::XMain' > 0x60600000c260: note: object is base class subobject at offset 40 within object of type 'bridge_test::TestBridgeImpl' > #0 0x50dc0b in sal_main() /cpputools/source/unoexe/unoexe.cxx:502:24 > #1 0x507762 in main /cpputools/source/unoexe/unoexe.cxx:348:1 > #2 0x2b2ede591444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #3 0x429425 in _start (/instdir/program/uno.bin+0x429425) Change-Id: I7f2c38ef2f3cedae07d71246980ad1f21220db72
2018-07-05tdf#43438: SwContentTree: handle ModeChanged notificationMike Kaganski
Change-Id: Iebb53af7fb06ebab6d5cdd1ce514480caec1b17e Reviewed-on: https://gerrit.libreoffice.org/56985 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-05find-unneeded-includes: stop proposing internal libstdc++ headersGabor Kelemen
They wouldn't really compile anyways and only cause unnecessary blacklist entries. Some '- memory' entries can already be removed from the blacklists. Change-Id: Iab53d5a57121f61abe935e712dc23a55390235bf Reviewed-on: https://gerrit.libreoffice.org/56979 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-05pdfium: replace FPDFPath_GetMatrix() patch with backportMiklos Vajna
Change-Id: Ibf358e42f6411777819d0f46a4fe93c9b5ed9594 Reviewed-on: https://gerrit.libreoffice.org/56975 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-05Karasa Jaga: add icons to some Calc menubar entriesRizal Muttaqin
Change-Id: I3730aea8f4b5c14b48bc1020687cb037c06b28eb Reviewed-on: https://gerrit.libreoffice.org/56964 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-05tdf#117901 Write signature line images as emf to ooxmlSamuel Mehrbrodt
Change-Id: Idbf60be3cef2d9dde454da0279d2810488b1e157 Reviewed-on: https://gerrit.libreoffice.org/56871 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-05related tdf#82175 writerfilter: use docDefault, not w:defaultJustin Luth
Commit b8fa3952 for tdf#104713, added this w:default test to only override style inheritance on well-formed documents (i.e. all default values have been specified in the document. Otherwise the document will have no defaults at all). However, checking on w:default is not the best test of a well-formed document. W:default had no impact on inheritance anyway, so it was a bad test, and if we used that, shouldn't we setParent to the default style instead of assuming it is "Standard"? Besides, FindDefaultParaStyle() already exists, so a separate boolean value wasn't necessary in that scenario. So lots of reasons to tweak my old commit. It is prep work for setting the parent to -none- instead of "Standard". Change-Id: I0846c09775c9a86b506f13e3588aab437a9a93cc Reviewed-on: https://gerrit.libreoffice.org/56824 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-05tdf#116543: don't forget to commit registrations in DB field editorMike Kaganski
This avoids revoking the uncommitted registration when any mailmerge doc is destroyed. Also don't forget to pass relevant SwDocShell when registering data source. This allows to register the data source for current document. Change-Id: Id89be82b0120661700e9fee6a075e5877d76e3b0 Reviewed-on: https://gerrit.libreoffice.org/56891 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-05Turn SAL_WARN into assertEike Rathke
... as it indicates a programming error. Change-Id: I526846fe695fc7ed28336ea20cdba0c0db2e922a
2018-07-05Limit GetNextPos() loops to range, if available, tdf#68290 follow-upEike Rathke
It's unnecessary to check all columns if there was a range marked anyway. Also use GetPrintArea() only for bUnprotected and enlarge the result a bit to cover the case where a protected form may be empty but not have vidsual indications either. Also adding nMoveY to nCol was nonsense all the time already, what was actually meant is to add the direction of movement. Worked by chance because nMoveY was always +1/-1. Change-Id: Ic1175a607a1169f3ef0e28d0f3a91f8c526314f4 Reviewed-on: https://gerrit.libreoffice.org/56966 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations with the updated submodules Change-Id: I0f59e5cb8f567d52c1124c2d13095d4b7ad4bfac
2018-07-04Dead declarationStephan Bergmann
...without a matching definition. (And the now implicitly-declared copy assignment op will be defined as deleted, as the SfxPoolItem base class has a deleted copy assignment op.) Change-Id: I5dbe2954bf920a902f44d72fde3c481386633d54 Reviewed-on: https://gerrit.libreoffice.org/56962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-04Make brittle SortedAutoCompleteStrings ownership handling more explicitStephan Bergmann
Change-Id: Ieaf2231a84d97528bb1b9a410c4ee0c38966dd27 Reviewed-on: https://gerrit.libreoffice.org/56950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-04reset submodules to their corresponding branchChristian Lohmaier
was broken after gerrit update Change-Id: I56cc1ab0e9d5bb4acb54d5ca5538fefae290253c
2018-07-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for 6.1.0 rc1 and also test the auto-update of the core module Change-Id: Id4556effa916c1d274f818bb5a5b700617fa6436 - update translations for 6.1.0 rc1 Change-Id: Ibff5b92a1b44ed2546d3ad25312e272ada2fa350
2018-07-04move helpfiles pattern rule above the plaing get_target oneChristian Lohmaier
as mac's make might pick the one without the dependency on the direcotry when trying to "make" that <module>.helpfiles target Change-Id: I60a55be118bc9a41352dad94326247b02aef1dd6 Reviewed-on: https://gerrit.libreoffice.org/56960 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-04tdf#118506: Disable orientation page in read onlyXisco Fauli
Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19 Reviewed-on: https://gerrit.libreoffice.org/56875 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>