summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-09Simplify Sequences initializations (i*->p*)Julien Nabet
Change-Id: I6bf0eaa2233de2487d90a2f9ae7de263b4ddf1bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116865 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09external/pdfium: Latest MSVC now needs the GCC workaround, tooStephan Bergmann
...or else a build with MS VS 2019 16.10.0 and --with-latest-c++ would cause a stack overflow during CppunitTest_xmlsecurity_pdfsigning in the same way as described at 6391e3c4dcd4d61c2f95f996e797e49b5586dbd1 "external/pdfium: Work around GCC C++20 recursive comparison issue". Interestingly, builds with recent Clang (on various platforms) and --with-latest-c++ do not run into that stack overflow issue, so it appears that Clang implements subtly different rules for C++20 and beyond here than do GCC and MSVC. (The GCC issue <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94141> "c++20 rewritten operator== recursive call mixing friend and external operators for template class" mentioned in external/pdfium/UnpackedTarball_pdfium.mk may not be the most accurate description of the precise issue at hand here, but lets keep it at that for now. Its comments do mention "that some people are going to try and change the rules to avoid breaking code like this.") But regardless of what the exact rules are for C++20 and beyond, these problematic overloads are only needed for C++17 and earlier anyway, as C++20 can cover them with automatic rewrites of other operators. So lets generally disable them for C++20 and beyond. Change-Id: I99033d6f09f069f00a6916ef40fd03dd4962a5c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-09Even more simplification in initializations (reportdesign)Julien Nabet
following https://cgit.freedesktop.org/libreoffice/core/commit/?id=bd536744ec947090819d59e0f0ec9f2c454aa428 author Julien Nabet <serval2412@yahoo.fr> 2021-06-08 22:00:41 +0200 committer Julien Nabet <serval2412@yahoo.fr> 2021-06-09 07:43:32 +0200 commit bd536744ec947090819d59e0f0ec9f2c454aa428 (patch) tree c970950805e3953e5b7c663fa8095cbd20beb737 parent 96f8ed6619a73655f9c3b94e6a4a3979cc67f551 (diff) Simplify Sequences initializations (reportdesign) Thank you Mike! Change-Id: Ib1dbcb3def89c2060534e30304cd8f35e5486efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116880 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09gtk4: implement some more of the menu requirementsCaolán McNamara
just give each radiobutton its own group Change-Id: I0239a3f1364cde91a668fe890a4178e4ce73f78b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-09gtk4: default that empty button labels are invisibleCaolán McNamara
Change-Id: If64e9592b48ac376933aac1e30ef76b096a3a0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116859 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-09sw: allow the width of a line portion to be larger than 65536 twipsMiklos Vajna
The line portion width can be quite large if the line contains an as-char image. Found by asking -fsanitize=implicit-unsigned-integer-truncation -fsanitize=implicit-signed-integer-truncation to flag the problematic conversions. Change-Id: I303b9c71dcd979d79b9c9aee5283b268cc4e3b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116835 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-09unit test: lok: text selection message testDennis Francis
Change-Id: Ie551461e323a2705c5b0b159dd50e8a1eef7d364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116429 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 42b08e239983063e559af8bd249213bba79eee48) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116543 Tested-by: Jenkins
2021-06-09autocomplete: allow cycling through possible matchesDennis Francis
Conflicts: sc/source/ui/app/inputhdl.cxx Change-Id: I4a4b11312f36885d1c6fbe43c4850d55293b2557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115859 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit ccbbd6bac6aaf5691a66a56b82d2592153336191) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116539 Tested-by: Jenkins
2021-06-09-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...since the (only) read of sText got removed with 4e6be990eaf6a524740299e8d00fb5401c1a21c0 "weld SwTOXEntryTabPage" Change-Id: I24bceb37c106cc840cef60d6a08953ca25cc3d15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116854 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-09-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
The only read of nChgFormatLevel (spelled "nChgFmtLevel" back then) back at 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import" was in a > #ifndef NUM_RELSPACE block that was removed with f917bb6900bad2c9382374a2cbc5678b278dde2e "INTEGRATION: CWS swnumtree". It apparently was dead code, as sw/inc/sw.mk had included > CDEFS+=-DNUM_RELSPACE ever since at least 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import" (which was later removed with 58003f28fc09cb2021e145afa0d0d692a7a402a7 "INTEGRATION: CWS writercorehandoff" when all its remaining uses were also removed in that CWS writercorehandoff). Change-Id: I5972e2c949d21970e7f3f98a0a61600265ccb66b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116844 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-09CppunitTest_sw_ooxmlimport: rework to avoid the FailTest hackMiklos Vajna
Change-Id: Ic59398c15f4caa04191dbf4d6252361a330fc8c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116863 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-09external/mdds: -Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
> In file included from svl/source/misc/gridprinter.cxx:16: > In file included from workdir/UnpackedTarball/mdds/include/mdds/multi_type_matrix.hpp:37: > In file included from workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector.hpp:1358: > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector_def.inl:851:15: error: variable 'start_pos' set but not used [-Werror,-Wunused-but-set-variable] > size_type start_pos = m_cur_size; > ^ > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector_def.inl:3926:15: error: variable 'start_row_itr' set but not used [-Werror,-Wunused-but-set-variable] > size_type start_row_itr = start_row_in_block1; > ^ Change-Id: I1f5e7e1f6a2b8457eb6d65dbd65336d3684c2b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116808 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2021-06-09Simplify Sequences initializations (reportdesign)Julien Nabet
Change-Id: I06f2675ee1270f04c6107761fbfc26a5570cc9c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116866 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09Fix typosAndrea Gelmini
Change-Id: I3539edf26a793f89d38f3df376002f4ed4295343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116869 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-06-09Missing includeMike Kaganski
Change-Id: I020424db94a6fbdba22ff887b912d3f7bb459502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116709 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08Unset TZ when starting UITests on WindowsMike Kaganski
This workarounds a problem that some tests in trackedChanges.py fail on Windows in specific time spans, at least in Europe/Moscow time zone: the change date in the dialog is reported according to local system time, while the expected date string is created in Python wrong, likely because datetime.datetime.now in the native Windows Python takes into account both system timezone data and the TZ environment variable coming from Cygwin (or some other kind of Python bug). The time reported by datetime.datetime.now was off by -2 hours, and resulting date string was wrong from 00:00 till 02:00. See upstream bug at https://bugs.python.org/issue44352. Change-Id: Ife3bcf000acac37f624a1065512513cc41dae596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116862 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08fix packaging on mac/linux re cairo/pixmanChristian Lohmaier
1193c331945481dd155a55c6695ff6fd88bd3d10 tried to simplify the makefiles for the Android case, but removed the conditional that would skip registering cairo/pixman for install for mac/windows (USING_X11, ENABLE_CAIRO_CANVAS & DISABLE_GUI all unset) Change-Id: I21509aaa1b2b1bffb583885148190b28fb097ecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116860 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-06-08WMF tdf#142625 Refactor Bitmap records, to better handle missing featuresBartosz Kosiorek
Change-Id: If3334158e6e0ef9bc3aa33656ad0ee45cf460dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116827 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-06-08tdf#104995: Fix opposite cropping issue on flipped images in WriterBayram Çiçek
In Writer, cropping an flipped image crops the opposite side of the image instead of the selected side. Fix: update crop values after the flipping(mirroring). Change-Id: I55cfed086bbf63b0c516e1cb6b2624c02b04a6da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116770 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-06-08set entry to expand and combobox to fill its assigned spaceCaolán McNamara
Change-Id: Ia70513d3d6d6fa5ce69936231202f3a52fc56fe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116857 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08tdf#109388: Mouseover effect added to palettes in the Area tabBayram Çiçek
In 'Format > Page Style... > Area' Tab, Mouseover effect added to the palettes on Color, Gradient, Bitmap, Pattern and Hatch sections. Change-Id: Idf036adc01b6b2ef6d62d2dd670ed6fb432bfbf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116395 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-06-08resave with latest gladeCaolán McNamara
Change-Id: Ia2aa23dfa82728ac38e18bcc15e20ad72b35aa6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08gtk4: expand the first child of the end groupCaolán McNamara
if there are start group entries Change-Id: I91188b0e5961a53730f6e157e8ea9be6b69ff92d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08gtk4: reverse the order of the pack-type=end widgetsCaolán McNamara
Change-Id: I912dfa86f1f3cdb03c523530d8c3df510241831c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08sd: split CppunitTest_sd_export_tests-ooxml2 into twoXisco Fauli
Change-Id: Ida23d59cd010d6fb9bf4fb8b5f82d2d764281773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116826 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-08This API change is since 7-2.Mike Kaganski
Change-Id: I5ca672a9c67f9a7082ef72c63b388c953d77c22c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116843 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08Simplify Sequences initializations (desktop/e*/filter/forms/formula/fpicker)Julien Nabet
includes removing of unused TOKEN_SEP Change-Id: Ic72d9d94bd8d07232699ee4d948f3b203d524491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116833 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08Simplify Sequences initializations (dbaccess)Julien Nabet
Change-Id: I38ecf7f13a853909fc746ee9bf1167f9c15cbc5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116832 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08Simplify Sequences initializations (cui)Julien Nabet
Change-Id: Iaf6a27f3a8dd156e91751a2fe242e8388f8d6b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116829 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08Addendum to: Remove SfxItemState::READONLYArmin Le Grand (Allotropia)
unfortunately forgot to remove some of the out-commented lines in f3b737ab76efaf1a70dfb22c6b60b08b340cf343, thanks to Julien for hinting me to that. So this is no semantic change at all, just syntax. Change-Id: If45b0cf1aeed870723914c2c02f6060d8f1bbfb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116838 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08tdf#47365 PPTX export: support loop attributeTibor Nagy
Follow-up to commit ad2809b4b6dc4837b0c1cadd89a14a234d995fb2 "tdf#47365: import support for PPTX presentation's loop attribute". Change-Id: I7f75acc2bbd6301384883691d5ef4069b1757a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116560 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-08Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 8459f8839e7fc029963d35c81cf6768777209fa0 - Python support for SF_Document service This patch also adds the Forms method to the SF_Calc help page. Change-Id: I317378db271c60ab97ac44e293aa7cbb54c81d0e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116696 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-06-08Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to fa92861a200b3716202bb859b6e5b7f116e59501 - Python support for SF_Base service Change-Id: I4175aecd307d70367eea49cc7a8407d2bca60634 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116707 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-06-08chart2: use registerOOXMLNamespaces and registerODFNamespacesXisco Fauli
Change-Id: I2ee15ec29fbf5fc4fcaea035a9cd99ba49453a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116831 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-08Resolves tdf#131817 - Option to globally switch toolbar locking on/offHeiko Tietze
Reverts 6993d5d0f1079fe720a7da004b70b57361c99fc6 and sets Locked in GlobalSettings to true New UNO command ToolbarLock to toggle the state added to the toolbars menu Change-Id: I246280b2b7930f2bf686e6fc26383da4799b5028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115797 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-08tdf#142404 DOCX c15: add compat flag TabOverSpacingJustin Luth
DOCX in 2013 (compatibilityMode 15) no longer supports TabOverMargin (i.e. the text margin), but it does a similar kind of thing if the tab goes into the spacing-after of a paragraph. So add a compat flag to handle this in-between kind of situation. I grepped -i "tab_*over_*margin" to see if I was missing anything. Decimal/Center proved to be only tabOverMargin. IsInSect shouldn't matter since it fits inside the printing range. The other places where I didn't insert TabOverSpacing didn't seem relevant based on a code read. Tab-after-tab still doesn't work great, but what we have is already a massive house of cards that will just collapse if changed. No real provision for handling tabs-over-paragraph-end. -auto-tabs are created instead of "beyond nMyRight" tab, unless it is the first tab defined. -doesn't allow auto-tabs to fill the remaining space. But on the other hand, MS Word's implementation of tabs follows some kind of incomprehensible bizarre logic, so just ignore the tabs completely, please. Change-Id: I3723107b29ec3e287ea8661544711c13eee3ca48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116667 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-08Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 55408cd1b3e29b3706c2cb8b44dd55284f3c3fff - Update SF_Basic service help page Adds the following methods: - CDate - CDateFromUnoDateTime - CDateToUnoDateTime - GlobalScope.BasicLibraries - GlobalScope.DialogLibraries - ThisComponent - ThisDatabaseDocument Change-Id: I963ad0d850987b1047b28b34b9a1e264b2414eff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115965 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-06-08editengine-columns: PPTX support (tdf#118458)Mike Kaganski
The unit tests that used to check the workaround using tables to emulate columns (implemented in tdf#120028) are changed to test import of the columns. This reverts some commits related to the mentioned workaround, namely aef569ed83a3ccc02639e5b2a1c7cc131ba262fc, c50ae6a282ed83762bf634fed5c91033eb305c88, 7b64bd90637a6722438bf873b1ded74ab3424c46, 33696b2820ce3c8b21b753d2c2bf92345ecb9276, 99dff69b561a8fe2d9437e6aa67a9581a6666f41. Change-Id: I97693ad4a981780e822070938992f274920df5a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116738 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08editengine-columns: Implement layoutMike Kaganski
This changes the way how different parts access positions of lines and paragraphs. Now there is ImpEditEngine::IterateLineAreas, which performs uniform iteration over all ParaPortions and lines in order, calling a user-provided callback function for each portion and line; it passes all information about current portion, line, area, and column to the callback, and checks the return from the callback, to decide if it needs to continue iteration (in case when callback indicated that if doesn't need further data), and if it needs calling the callback for the rest of current portion's lines. This allows to have the code that calculates and iterates dimensions of lines in one central place, without the need to have duplicating logic in several places. One important exception is ImpEditEngine::Paint, which iterates without ImpEditEngine::IterateLineAreas, because it does many atomic paint operations in different points of iteration process, and implementing ImpEditEngine::IterateLineAreas to call callback in the required places would require increased complexity, which is left for a future change. To make that possible, ImpEditEngine::IterFlag should be extended to indicate additional requirements. Note that in fact, ImpEditEngine::Paint was taken as the model for implementation of ImpEditEngine::IterateLineAreas, with its detailed handling of all the vertical offsets like additional line spacing and interparagraph spacings that depend on context. The notable result of the centralization of the iteration code is slight change of heights reported by ImpEditEngine::CalcTextHeight. Previously it simply added all pre-calculated heights of portions, and not taking into account all the spacing handling that ImpEditEngine::Paint did, which was inconsistent (calculated height was different from painted height). Now ImpEditEngine::CalcTextHeight should provide more accurate results, which required small changes in the unit tests. Change-Id: I33cbb978deb974b314d36fda8674186a03991107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08editengine-columns: ODF support [API CHANGE]Mike Kaganski
This uses existing ODF markup, as used by Writer's text frame: style::columns child element of style:graphic-properties, its fo:column-count and fo:column-gap attributes. No ODF extension is required. Since currently only columns with same width and spacing are implemented, without additional settings, style:column child elements are exported, but ignored on import. This adds new property to css::drawing::TextProperties service: TextColumns (of type css::text::XTextColumns). Change-Id: I7e63293e5814b281ceec8a9632e696322d3629e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116035 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08editengine-columns: Create document model and dialog pageMike Kaganski
Change-Id: I056aad9474ca18134d1f1686a53618cc9ab3d525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...ever since the code's introduction in ea1ca189b561e47d3b872f40628e6af224355626 "added api for glue points" Change-Id: I221632d243c8c778c711c3f001676ff26043d0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to cfd0aa4ba18b58179724d50d7d1ac4f500ca1db4 - Remove literals that prevent proper L10N - extra index - index relocation Change-Id: Ia52c0db88406dd5b24514280c663cfb5de157091 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116169 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-06-08Simplify Sequences initializations (comphelper+connectivity)Julien Nabet
Change-Id: I8a91f4bd2a1117acb571f1058af18071bc058c9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116815 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08cid#1485166 silence Uninitialized scalar variableCaolán McNamara
seeing as there are no warnings about SvxRTFItemStackType::SetStartPos try that pattern Change-Id: Icad28503047323b01d8e048061c6b037bcdcb83c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08cid#1485887 Unchecked return valueCaolán McNamara
Change-Id: Ie7cf188ef4aa72ea5266b0925363c904b4a7812c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116814 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-08Simplify Sequences initializations (cppcanvas)Julien Nabet
Change-Id: If2d882060422b4e450de9ddda28d8d5c624c8e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116816 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann
...ever since the code's introduction in 59560e4c13de5787a586ea643f6e58371ecf4c14 "INTEGRATION: CWS dba22" Change-Id: Ic8acc06c85a3f82d24467cb403250df095c6b869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116812 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08tdf#142128 sw: set author-color strikethrough for AS_CHAR imagesLászló Németh
(anchored as character) during change tracking instead of using always the same NON_PRINTING_CHARACTER_COLOR blue one. Follow-up to commit 76dc21860ce185bd5495adde8858d2f23284c78e "tdf#142128 sw: set author-color strikethrough for deleted images". Change-Id: I3fa02f6ec6cd1f71ae3b3c06644dd24f6c684f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116795 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-08Silence -Wunused-but-set-variable (Clang 13 trunk) on volatile variableStephan Bergmann
(see the comments starting at <https://reviews.llvm.org/D100581#2795966> "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable" that warning on volatile variables is intentional) Change-Id: I2f9d0ed4a7f11f0bc2bdea57c0434654cd9fdf95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-08 00:17:17 +0000