summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-18tdf#63130 reduce duplicated work when pixel snappingNoel Grandin
Cache the calculations so we don't repeat work unnecessarily. Shaves 5% off load time. Change-Id: Iffbdd08768fea5b25ac83926b812067f52cba3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-18Removed remaining macro concatenations from xmloff/Vojtěch Doležal
For PropertyMaps.cxx used: (MAP_FULL\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_ENTRY\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_ENTRY_ODF12\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_ENTRY_ODF_EXT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_ENTRY_ODF_EXT_IMPORT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_CONTEXT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_SPECIAL\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_SPECIAL_ODF12\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ (MAP_SPECIAL_ODF13\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_ For xmlexppr.cxx used: ENTRY\( *([A-Za-z0-9_]+) *\) => { GET_PROP_TYPE(XML_TYPE_PROP_\1), XML_\1_PROPERTIES } For OOo2Oasis.cxx used: (OOO_IMPORTER\( *)([A-Za-z]+) => \1xmloff_\2_get_implementation For xformsapi.cxx used: TOKEN_MAP_ENTRY\( *([A-Za-z0-9"]+) *, *([A-Za-z0-9_]+) *\) => { XML_NAMESPACE_\1, xmloff::token::XML_\2, xmloff::token::XML_\2 } For xformsexport.cxx used: TABLE_ENTRY\( *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *\) => { \1, XML_NAMESPACE_\2, xmloff::token::XML_\3, \4 } elementexport.cxx and property_meta_data.cxx done by hand. Change-Id: Ifb0c76a60f95e74ff1f9d596afdaff138c2228c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151867 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-18sw: fix undo comment of FN_DELETE_SECTIONSMiklos Vajna
It's sections, not section. One has to dispatch .uno:DeleteSections to see this in action, which does something if the document already has existing sections. I think this was the last place where the relatively new biblio-related UNO commands had a wrong undo comment. Change-Id: I55074174a498f26ea7bda721988940a86ad2e458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-18tdf#86630 sw page number wizard: add to notebookbar insert menus #2Justin Luth
Well, I wasn't very thorough in my previous patch. I guess chalk it up to my first realization that there even was a separate config for this side menu. In any case, all of these all have the nice little menus and all should have the same access to insert page wizard. Change-Id: Id2513b61e34aa5e3ed94f88a6af495ee02439455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151788 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-18sd: remove unused documentXisco Fauli
Added in 2704821c6b6e829b5ef5c32cdc8eb2a03b6114a9 "smartart : test documents" without any code using it Change-Id: I5a31701466ff8cf97a23c9b034b2b33814cefde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151934 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f2c3da66938bdb8802d1225bf25fbc2f7ad49493 - Fix some D'oh! you found a bug ... Change-Id: Ifb98179340e64ddd4e9c672ec56ba886264bf02f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151935 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 500b29ddfcf067e5831c3ecef5bd386b725a463c - Exclude file from indexing This file is source for embeds and don't need to be indexed. Change-Id: I458da5804e7152bc5e684e356df5d62e8dbca9e3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151908 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-17vcl: fix crash in Window::GetOutDev()Miklos Vajna
Crashreport signature: program/libmergedlo.so rtl::Reference<vcl::WindowOutputDevice>::get() const include/rtl/ref.hxx:208 program/libmergedlo.so vcl::Window::GetOutDev() vcl/source/window/window.cxx:574 program/libswlo.so SwViewShell::ImplEndAction(bool) sw/source/core/view/viewsh.cxx:294 program/libswlo.so SwViewShell::EndAction(bool) sw/inc/viewsh.hxx:611 i.e. GetOutDev() is called on a disposed vcl::Window. Change-Id: I5b17225fced85c6804fc93fd12021c92966d3aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151857 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-17CppunitTest_sc_opencl-1: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
Avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: Ifd12aaa560be4aa69db87a3aa3f37e03940f68eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151878 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17CppunitTest_sc_opencl-1: remove commented out testsXisco Fauli
These were commented out in 9247a100e3aa0c1ebd81254683eef2311a516a17 "The test documents for these tests are not available." Change-Id: Icbaf29de91c7828efbca3c8e55a123b44591d308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151877 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17sw: remove unused document in testXisco Fauli
Added in e9b6e7f6b4e78bd098b3a32e9288253938a00881 "ooxml: extend roundtrip test with w14:props3d" became unused in 22d5d14d1aed73f36938b49d0ea1e9281e19dafd "ooxml: extend roundtrip test - ligatures, numForm, numSpacing" Change-Id: I123ac624a23e5e2a6b29b2730b6f1f0bb86c5305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151881 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17Simplify a bitMike Kaganski
Change-Id: I3d10e85a6141aae6c7741aebb1c0b1ac68ac4364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151785 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-17tdf#63130 when getting the size, do not do a full paintNoel Grandin
otherwise we end up doing double work when called from ImplWindowFrameProc, which is the main driver of painting on the screen This reduces the load time by 10% Change-Id: I9eb82a180344875f707fbf3d8128351a35def6a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17tdf#92824 spell checking: limit suggestions only for the best onesLászló Németh
Apply Hunspell fix to keep only the best suggestions, if they exist to avoid of overgenerating worse suggestions especially for short bad words. See Hunspell commit b88f9ea57bdb9b219f3c1d2c67f4f882f1f23194 "Keep only REP, ph: or 2-word dictionary phrase suggestions These are the best suggestions, no need to search other ones to avoid annoying redundant and long list. For example to suggest only "a lot" to the bad form "alot", add the 2-word phrase "a lot" to the dic file. Or for a very typical spelling mistake, enough to specify the bad form with a ph: in the dictionary file to remove the other suggestions." Change-Id: I0272bb9ed2dd493aa372feb68d1937e359910e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151868 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-17tdf#153790: sc_uicalc: Add unittestXisco Fauli
Change-Id: Idf1628f3367fba3c196a63766ea298996bcbbb73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151875 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17tdf#155345 sw tracked table column: hide them in Hide Changes modeLászló Németh
And if all columns are deleted, hide the table in Hide Changes mode. Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7 "tdf#150673 sw xmloff: import/export tracked table column" and commit f481c2c8e74bded11fac754e493560391229dbcd "tdf#144057 sw track changes: hide deleted table rows". Change-Id: Ic8f0254d607d629ed6386df94b16a939cde17506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151805 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-17tdf#155324 sw: add unit testMichael Stahl
Change-Id: I0df173be99b8b9fa3920431a8386e14fd1d2260e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151876 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-17sw a11y: Replace some uses of magic numbers with proper constantsColomban Wendling
Change-Id: I61b1924c22a66a08ac165546811daeaf20176954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151650 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-05-17menus all black with SAL_RTL_ENABLED=1 and SAL_USE_VCLPLUGIN=genCaolán McNamara
export SAL_USE_VCLPLUGIN=gen export SAL_RTL_ENABLED=1 run writer and the menus are all black a problem since: commit 622e8cd9e5c96d0fe0bb02e07d95efa93c156c44 Date: Wed Jan 11 11:00:43 2023 +0000 reuse CairoCommon GetGraphicsWidth from X11CairoSalGraphicsImpl so restore the use of mrParent.m_pFrame as done in original implementation Change-Id: I21f76b2e57b7ea6d910552d3b07830811152bfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-17tdf#154477: sc: filter: html: fix missing color scale conditional formatHenry Castro
When copying a range cell to an external application that request html data, the color scale conditional format does not have an associate a set attribute. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I82b466a2100abc5070e92f844dc706d9b015c2e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151837 Tested-by: Jenkins
2023-05-17tdf#154477: sc: copy cache values when clone color conditional formatHenry Castro
When clone a conditional format list, also copy the cache values that hold the min and max values, otherwise if clone occurs when copying to the clipboard the values have wrong data due to limiting range cells copied. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id9085a1488a3bde24842e0d2e062c9b425074157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151836 Tested-by: Jenkins
2023-05-17fire less "index hint out of range, ignoring" warningsNoel Grandin
after commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 4 10:06:14 2023 +0200 tdf#105404 [API CHANGE] add index to accessiblity change event Change-Id: I52d6b7b7368b780c1c9fdf60628311cb02429eff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17tdf#154477: sc: add "updateValues" method to conditional format listHenry Castro
When copying a range cells to a clipboard, if exists a color scale conditional format from different ranges, it should update the min and max values, otherwise the color scale conditional format could not calculate min and max values due to limiting range cell copied. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I660e18090a60b99ddf2b55ce1f713fd41121290e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151835 Tested-by: Jenkins
2023-05-17Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to ae42bcbf34f4674bcdb9eaee2117bea67b1dc5cd - update translations for master and force-fix errors using pocheck Change-Id: Id394cdfeec287ffc3faa0c1c738ae4d3f8587e69
2023-05-17Silence loplugin:external and lopluign:unreffun in (WIP?) a11y.cxx for nowStephan Bergmann
Change-Id: Iea207bca4fee57e8c7dd5d307ccd42efc0dd2542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151866 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17Avoid loplugin:unreffunStephan Bergmann
> vcl/unx/gtk4/a11y.cxx:295:1: error: redundant function redeclaration [loplugin:unreffun] > G_DEFINE_TYPE_WITH_CODE(LoAccessible, lo_accessible, G_TYPE_OBJECT, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:1730:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE' > #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_) _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END() > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:2213:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN' > _G_DEFINE_TYPE_EXTENDED_BEGIN_PRE(TypeName, type_name, TYPE_PARENT) \ > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/gobject/gtype.h:2160:17: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_PRE' > static void type_name##_class_init (TypeName##Class *klass); \ > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > <scratch space>:47:1: note: expanded from here > lo_accessible_class_init > ^ > vcl/unx/gtk4/a11y.cxx:236:13: note: previous declaration is here [loplugin:unreffun] > static void lo_accessible_class_init(LoAccessibleClass* klass) > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I22bad5cf5e546d3a4dff4c1de3b3bb06638d1200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151865 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17loplugin:externalStephan Bergmann
"externally available entity '...' is not previously declared in an included file (if it is only used in this translation unit, make it static; otherwise, provide a declaration of it in an included file)" Change-Id: Id53a4fd0b01ea7a91735231750c32200ea1529b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151864 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17loplugin:reservedidStephan Bergmann
Change-Id: Ia24f5214f44a5ef4f5ac4397b8adcd6d46a99676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151863 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17tdf#154628: XML Form Document: Sending data with GET fires very oftenJulien Nabet
See rationale here: https://bugs.documentfoundation.org/show_bug.cgi?id=154628#c5 Change-Id: I26556baceec8823d2c3bed382d51731d18bd2ccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151852 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-05-17tdf#63130 use a simpler, SIMD-friendly algorithm for matrix invertNoel Grandin
which is 10% faster loading this document Algorithm copied from https://github.com/niswegmann/small-matrix-inverse/blob/master/invert3x3_c.h, which is CC0-1.0 licensed. Change-Id: I7aa272cae90b1aee30eb6b3e8e5acb260b92ceef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17Update git submodulesSophia Schroeder
* Update helpcontent2 from branch 'master' to c439137cdb1055ddd262b9169c7a59e138b9472d - Gradual Improvements get rid of xml-lang="en-US" improved code indentation and removed empty lines for better readability checked menu paths (leave 000000413.xhp mostly untouched for now, should be moved to Draw anyway, Impress doesn't have a Shape menu) added alt text to icon where missing. Change-Id: If4aaf69dd21544c073fbb42ea336e6da534866ea Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151621 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-17tdf#154114 Formatting active cell applies to entire cell rangeNoel Grandin
regression from commit ac859a4c6a7fce4efee9cdd45821a0c9e40e9e9a Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Oct 17 16:36:23 2022 +0200 tdf#147842 shrink selection to data area when applying to entire sheet Change-Id: I6fd8504d3995878fc9aedd461c0f374695d1f48e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-17ofz#57493 reduce num_edges required to triggerCaolán McNamara
Change-Id: Idb6127d8943dbf62d8cacb7f2f5382a1e8619aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-17navigator: use toggle available for all appsSzymon Kłos
Change-Id: I3136071ee943b120ebb2ad6491c91d8ebbcd6244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151573 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151752 Tested-by: Jenkins
2023-05-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 59f138dd11466e07ac0e615356f4ef36afee6ac2 - Remove bad example Change-Id: Ic6307c884458c0303f88d42e19b8a4f1c924c05b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151777 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-17tdf#155328 sw tracked table column: add DOCX export/importLászló Németh
Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7 "tdf#150673 sw xmloff: import/export tracked table column" and commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06 "tdf#79069 DOCX: support tracked table (row) deletion". Change-Id: Ifbe7b8b83e7071367104a09b4b559513227db786 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151709 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-05-17loplugin:fakeboolStephan Bergmann
Change-Id: I8c7fe59223dfda4c376e50bb4b6fedee341bd85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-17tdf#154118: ppt: use SetTextLeft instead of SetLeftXisco Fauli
and for that, call SetTextFirstLineOffsetValue first Also simplify the code a bit Regression from a0875d09d9eeb368e9e319f3f2f29ec3be71b56c "editeng: remove SvxLRSpaceItem::nTxtLeft" Change-Id: If45ded4602f2c9acc885439940db9741d16a5534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151827 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-17Drop redundant conditionMike Kaganski
Whenever (i != 0), this whole subcondition will be true; and (i != 0) can only be false when (nPrevDepth != 0) is also false. Change-Id: Icfd6dae3ecbbcd7307c42762d245d58725256c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-17sc: change (char, background) style colors when changing the themeTomaž Vajngerl
This adds a Calc specific ThemeColorChanger, which changes the character and background colors in styles. In addition add the changes that make this possible - support in SvxBrushItem for the ComplexColor, making sure that ComplexColor is properly passed to other items (mainly from color picker),... Change-Id: Id2e98c42bbe195a0f75cc8951ff69f6d7eea6be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151667 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-17sw floattable: disable chain UI if the frame is allowed to split alreadyMiklos Vajna
This is similar to d9cd177b9b08d454882dd77ffeb825a184a1b540 (sw floattable: disable UI if the frame is chained already, 2023-05-16), but here the fly is split and we disallow chaining, not the other way around. Change-Id: I637d594d41ba9a80d58bc0bef37627d8104293ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151856 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-17ScriptForge - database.GetRows() tdf#155204 error when no dataJean-Pierre Ledure
The complete expected bheviour is: when there is no data returned by the query, - either GetRows() returns an empty array, (Header := False) - or GetRows() returns an array with a single row containing the column names only (Header := True) In the example given in the bug report, GetRows() gives an unexpected error. Actually the "end-of-file" status is tested with the isAfterLast() indicator. It seems better to rely on the Boolean value returned by the first() and next() methods applied on the resultset. Change-Id: Ibe97dbbcb03d45ebb9184fab2733abe4e04963a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151844 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-05-17Removed more constant concatenationsVojtěch Doležal
Change-Id: I4fce6eeb6652914e1883037b41a2dc3c09a88ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-17CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfTable2Miklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: Id55d735693be8d87cbc9b7048ef5533a5b7b41d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151849 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-17tdf#138726 LRSpaceItem ooxmlexport12: don't test implementationJustin Luth
To get the desired effect, properties were being spammed as direct formatting. Now that LRSpaceItem has been split, there is no/less need to spam like that. Allows https://gerrit.libreoffice.org/c/core/+/151821 make CppunitTest_sw_ooxmlexport12 CPPUNIT_TEST_NAME=testTdf108493 Change-Id: I7b7f109eacb79737d898da5bcf87162b9fa6529e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151850 Tested-by: Jenkins Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-17Resolves: tdf#153790 Suppress duplicated end part sheet reference, tdf#103890Eike Rathke
Also keep explicitly given sheet reference relative to the same sheet as user wished. Affected only when moving formula cell position like with cut&paste and drag&drop. Change-Id: I6b1da6aea58b88a24567189ef6aa212dab01de49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151845 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-05-17dynamic_cast followed by static_castCaolán McNamara
Change-Id: I2b2105e577184f87723c85ed79533983fdd60405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-16Remove remnant commented code concerning recently dropped "XAccessibleStateSet"Julien Nabet
Change-Id: Ib11e37dbc6bf9bfc7ba8cdf3b5cb28d5a11f31a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151847 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16tdf#155327 Detect default color in WordArtRegina Henschel
It is possible to not set the character color explicitely in a WordArt shape. In such case MS Office uses the scheme color 'tx1' from current active scheme. The import of the character properties does not set this color in the fill properties. The patch adds it, when the character fill properties are converted to shape fill properties. Change-Id: Ic72fd9f55bac1e2874cbf701ffa692ca4fbc9435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151851 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-05-16tdf#155324 sw: layout: try not to MoveFwd onto a page created by page breakMichael Stahl
There is a ToX that is updated; it has about 4 pages worth of entries. When the old entries are deleted, 2 of the pages become empty, and since commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb these pages are deleted. While layouting the new entries, these are moved onto the page following the ToX, which starts with a page break and contains lots of footnotes. Now the footnotes reduce the space on the page available for the ToX entries, and thus after CalcLayout() there are 5 ToX pages instead of 4. Then the page numbers are inserted into the entries, and another layout action deletes one of the ToX pages; now all the page numbers are too large by 1. Some ideas to fix this: 1) ignore a footnote when formatting a frame that is before the footnote anchor frame; similar to commit c79bf7865bff4e88cc201357370d8faeef8e6ad9 2) invalidate the last content on the page when moving forward the footnote container, similar to commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf; this doesn't look easy to do because as it turns out the footnote container is moved in SwLayoutFrame::Cut() 5 function calls inside MoveFwd() while the frame on which MoveFwd() is called is still on the page, so would probably somehow need to be detected in MoveFwd() itself? 3) don't move frames forward onto a page that was created by a page break - instead create a new frame. Let's try 3) for now, only in SwFrame::GetNextSctLeaf(). (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I641f586799a5ddb4e2a6ff8e9de784e422ecc214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151711 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-02-05 09:57:10 +0000