summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-08-11Initial APNG export supportParis Oplopoios
Change-Id: I27877d4bdf27cd92bdd939fd25e3820edad10f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155387 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-11autorecovery: DLG_RET_OK_AUTOLUNCH => DLG_RET_OK_AUTOLAUNCHJustin Luth
Change-Id: I3f1436fa1b8ff5b34c65b103b0dd26dffc0e558d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155566 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-08-11autorecovery: add some documentationJustin Luth
Change-Id: I9a037e263ecdc374df9450ee9a066468dc6ab5e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155426 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-08-10partial Revert "tdf#144512 autorecovery: always wait for user idle...Justin Luth
... with timed save" in order to restore useful comments This reverts 24.2 commit 75d7464e7eb94df1ad9904ad750b27d99d91abc5, where the ResettableMutexGuard's safety is cancelled by a g.clear() // } /* SAFE */ and re-instated with a g.reset() // /* SAFE */ { Thanks Mike for explaining the obvious to me. Change-Id: I98016a50221b734a38d14bce0a958c6af9e57944 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155514 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-08-10tdf#156270: use double for width/heightXisco Fauli
Otherwise 0.313159 is rounded to 0 Regression from commit 99f43923b66a98b75c78a50577f19293aa480998 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Tue Apr 18 14:37:32 2023 +0200 sw: fix divide by 0 Change-Id: Ib8bf0a770834e0ff73d215c27788df7a3b98404d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155561 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-10tdf#155799: sc: fix paint the reference markHenry Castro
If a reference mark is initiated with the first click, the initial range points are the same and extended if merged cells, but if the user drag&drop more cells the Range end has to extend if merged cells Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ife7c4514a9303226b73bff61bd0df689f81af42f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155533 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ebd1a4d6fc3f9ba533a29fa54acf7b3b41c398d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155483 Tested-by: Jenkins
2023-08-10ITEM: improve SfxItemSet notification callbackArmin Le Grand (allotropia)
When browsing cachegrind data I stumbled over the notification callback used by Writer in SfxItemSet::Changed. That is a virtual method that gets called in quite some places to forward item changes, SW uses it to record these. For that purpose always (quite some) data gets prepared without checking if this is necessary, this uses calls to ::Get and ::GetDefaultItem to have either the old or new Item from the parent or default (pool). This is not needed - except for Writer. Even there this mechanism is not always active. Thus I: - removed SfxItemSet::Changed, replaced with a settable callback member of type std::function<...>. Thus one less virtual function and depenence in SfxItemSet - added a callback functor to SwAttrSet that can be set at the SfxItemSet it is derived from - setting/releasing this only in used cases. It is not even used all the time in SW. - moved the creation/processing of needed data to a member function in SW (SwAttrSet::changeCallback). All processing and evtl. needed data is now created there - on demand. - adapted all places in SfxItemSet where that mechanism is used to only call it if set & without pre-calculating anything - since all former calls/usages were pretty similar I could put all of this to SwAttrSet::changeCallback This leads to use that only when needed now. Naturally, SW will potentially profit less than the other apps. Here are callgrind numbers with this change using OfficeStart, DocLoad, DocClose, OfficeShutdown. This change also has potential avantages @runtime/UI which also did all preparations to call SfxItemSet::Changed all the time: Writer doc: 0,9907 ~1% old: 93842 mio new: 92971 mio Draw/Impress doc: 0,9971 ~2,8% old: 170023 mio new: 169544 mio ::Get reduces from 1416103 to 293874 calls ::GetDefaultItem reduces from 2252336 to 1927209 calls (nearly half) Calc doc: 0.9868 ~1,3% old: 194708 mio new: 192130 mio ::Get reduces from 882298 to 880087 calls ::GetDefaultItem reduces from 4611901 to 2633555 calls (nearly half) Of course this highly depends on the used test documents, so it can only be a excerpt result. Also adapted SfxItemSet::MergeRange a little bit: Do nothing not only when a single new slot is already contaioned, but check if all slots are already present. This works well and fast using the formally added caching mechanism. Change-Id: I4d369d2e5b21aa7a21687177518150515e3de954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-08-10Related tdf#156629 force snapshot of alpha maskPatrick Luby
On macOS, with Skia/Metal with a Retina display (i.e. 2.0 window scale), the alpha mask gets upscaled for the font color and the character background color icons in Writer's properties sidebar with most icon sets. The Breeze and Colibre icon sets running in light mode are the most obvious cases. This bug appears to be caused by asynchronous rendering of the returned image. So, we force a copy of the alpha mask in case it changes before the image is actually drawn. Change-Id: Ie3aa3b26acaee4bd9173e6b356137980c070c7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155562 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-08-10tdf#156492 sw: fix alt-Enter in cells merged verticallyLászló Németh
Inserting empty paragragh after the tables didn't work, if the bottom right corner of the table contains cells merged vertically. Manual test: positionate the text cursor at the end of the last paragraph of the bottom right cell of the table (which contains also cells merged vertically), and press alt-Enter to insert an empty paragraph after the table. Note: SpecialInsert, i.e. inserting empty paragraph by pressing alt-Enter is the quick and sometimes the only possible way to insert an empty paragraph before or after tables and sections. Change-Id: Ic845c3d683a561784afe69588b3b1538e82c35c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155556 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-08-10related: tdf#151103: simplify codeXisco Fauli
Keep the text line in the SvgTextNode and not in each SvgCharacterNode Change-Id: Ia33e46cc974a39a915e7b933337b4c529e6eeca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155558 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-10svgio: move SvgTextPosition to its own fileXisco Fauli
In order to avoid a circular dependency in a follow-up commit Change-Id: Ib7b16e73282dfa6f3ca87aab1044cb92df72b6bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155555 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-10svgio: handle addGap internally inside SvgCharacterNodeXisco Fauli
Also add the gap at the beginning of the current node, not at the end of the previous one Change-Id: I6583059b4a7418010ac2af459e00fb0d02d39605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155552 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-10svgio: avoid dynamic_castXisco Fauli
Change-Id: I9a2e2c4341476a59ffb001c42e7812cb8249c856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155548 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a78e5c75ae11f7c401353e526a30f16187cc1f92 - tdf#156715 Housekeeping on files that must not be indexed Change-Id: I5dfbc2e3261d66cc81964b3f88d08420c7b5e72a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155557 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-08-10tdf#32415: Always accept English symbol names in mathKhaled Hosny
If symbol name does not match localized names, try to find a match using English (export) names. Change-Id: Id668ee68b07c8431c2780b78e26e07d3aef043aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155553 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-10sw: improve naming of ApoTestResults membersMiklos Vajna
- Sp29 -> PPc or TPc (paragraph or table position code) - Sp37 -> PWr (paragraph wrap) Change-Id: I49400cc325e9981586490f5221a6a5f5d59c0084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155554 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-08-10tdf#156630 eliminate opaque parts when drawing animated PNG imagesPatrick Luby
Due to the switch from transparency to alpha in commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, flip the background colors for the VirtualDevices and invert an alpha mask. On macOS, with Skia/Raster with a Retina display (i.e. 2.0 window scale), the alpha mask gets upscaled. Also, when Skia is enabled, the alpha mask gets inverted in the first export to PDF after launching the application. These two bugs appear to be caused by asynchronous rendering of the returned bitmap. So, we force a copy of the alpha mask in case it changes before the bitmap is actually drawn. Lastly, respect system animation settings when determining if the image should be animated. Change-Id: I8144691a6c99bf8361b301b88d22172991463f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155429 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-08-10Simplify conversion, and fix a commentMike Kaganski
Change-Id: I0a952b26e486dcfdedf586e33afa6771b480ac65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155540 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-10Update git submodulesStéphane Guillou
* Update helpcontent2 from branch 'master' to dfda7b1348f262821f25d18d8f275602cb57bb25 - tdf#142705 consistent order of keys for shortcuts Change-Id: Iffb7c5e5cb872eb5e2c1bfcbdf5e83357e7896fe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155476 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-08-10tdf#80467: Fix math rendering in elements dock with RTL UIKhaled Hosny
Make sure to disable RTL on the OutputDevice, otherwise the math will be rendered right-to-left without even mirroring the parenthesis. Change-Id: Iea43dbc0d7efe914120d5cc1605522254344b4fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155538 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 539abfa7c3bbc9f0b234402083c743890b965cf7 - tdf#155193 Do not deliver Help files with indexer=exclude + Add condition to skip indexer=exclude files. + delete empty files generated by exclude + delete empty directories generated by exclude Change-Id: Id992e6c83086d3cd3911b84890a50b309ad92c3b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151897 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-08-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to dfca100198e690f05987033bcd2b74e9057bcf8d - tdf#155462 Help for tool tips when dragging scrollbars Change-Id: I6ded8c8a2e463154cac8c2b7602eda7dcd70dfe7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155525 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-08-10tdf#156594 - A11Y - add fix button for "Avoid background images."Balazs Varga
- add fix button for "Avoid background images." - add .uno:PageAreaDialog command to navigate page style-->Area tab Change-Id: Ibad4e8896d05e72713189a0042c3f156a0733171 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155464 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2023-08-10tdf#156619 - A11Y - fix not clickable warning about content controlBalazs Varga
in header/footer. Goto content controls in header and footer. Change-Id: I1e7eda0e9ab73a94d3f4963630901ff6701b521f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155535 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-10Related tdf#156614 Improve wording of non-interactive forms textSamuel Mehrbrodt
Change-Id: I063cb144a7d94e15e9405135ad321d9f2e74d414 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155534 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-10sw floattable: handle AllowOverlap==false in the layoutMiklos Vajna
The bugdoc has two floating tables, and these would normally overlap, but SwFormatWrapInfluenceOnObjPos::mbAllowOverlap requests tweaking the position at a layout level to avoid that overlap. This is similar to what commit d37096f59e7e0286e55008153591a60bab92b9e8 (Related: tdf#124600 sw anchored object allow overlap: add layout, 2019-09-19) did, but that was for draw shapes and this is for split flys. Fix the problem by extending SwToContentAnchoredObjectPosition::CalcOverlap(): the overlap detection can be reused, just need to look for split flys on the entire page + need to check split flys against other split flys. The ODT filter works out of the box. Change-Id: Id31308a67ba502bcc830f15a1679996ec153f209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155536 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-08-10tdf#156553 tdf#156554 A11Y: fix issue update after image deletionBalazs Varga
Reset accessibility check issues when deleting graphic/ole nodes. Change-Id: I5f0698f6cf9e97045be22482de64518ab22d5946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155355 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-08-10tdf#156615 - A11Y - fix not clickable warning about empty table cellsBalazs Varga
Make "Empty table cells for formatting" warning clickable and go to the table. Change-Id: I65a258cd559b423692307af9bbbb778754076894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155532 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-10UITest_librelogo: use oneprocess modeMiklos Vajna
Before: 0m22,417s After: 0m18,233s Also UITest_sw_fieldDialog: 0m34,065s -> 0m23,113s And UITest_sw_options: 0m38,468s -> 0m32,033s Change-Id: I709205bb8ebe55fe71bc2713d9443b672380b9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155530 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-10tdf#156614 - A11Y - fix not clickable warning about fake formsBalazs Varga
Make the warning message clickable and select the text. Change-Id: I5b503ba278980c128bbef83631dabc897bb33b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155519 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-09tdf#146619 Remove unused includes from sal/ [system.hxx]Gabor Kelemen
Change-Id: I30f3ce338e86f1a6dad5e16023ce4c883079fbcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155351 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I34a8ec2f69d9d58f8847e9cfb45937eae6159590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I2c89096c306e1537622fc52644d20ae605183b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I09285716b6d17d8de95af91d822966520af35605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09tdf#120715: handle LOK caseMike Kaganski
Commit 690d4eb71509649ad147cfe60f5b97e2cfaaa519 fixed the two problems of wrong paragraph mark position and wrong cursor position, calling AddExtraBlankWidth from SwTextPainter::DrawTextLine. Since this function is called before calculating cursor position in desktop case, this fixed them both: SwCursorShell::EndAction calls SwViewShell::EndAction before UpdateCursor; the former calls ImplEndAction, and in it, PaintSwFrame is called when not in LOK mode. But in LOK mode, PaintSwFrame is not called until SwViewShell::PaintTile runs in a later request; thus, UpdateCursor operated on unadjusted data. The cursor position arrived wrong, but the paragraph mark was painted OK when tiles were rendered. To avoid dependency on the call order, also call AddExtraBlankWidth from SwTextCursor::GetCharRect, which is called inside UpdateCursor. Change-Id: I0984d7c6235a7f2573f9fa8b7ed0cefee5747658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155531 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-09svgio: get rid of SvgTextPositionsXisco Fauli
and make SvgText inherit from SvgTspan Change-Id: Ief25e52ba2a493936f82f1674f73168ed5647278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155521 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-09svgio: remove recurrent checksXisco Fauli
Change-Id: I26c37e6b58e7c54e2bdc2c77543896daceb638d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155520 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-09Use _beginthreadex instead of CreateThreadMike Kaganski
The documentation for ExitThread [1] has this comment: A thread in an executable that calls the C run-time library (CRT) should use the _beginthreadex and _endthreadex functions for thread management rather than CreateThread and ExitThread; this requires the use of the multithreaded version of the CRT. If a thread created using CreateThread calls the CRT, the CRT may terminate the process in low-memory conditions. Since ~all our code uses CRT, be safe and use _beginthreadex. [1] https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createthread Change-Id: If3e566592e921b00240e08aa759d8cdbc421d44b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155513 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I2869e115941b3e1f52911d58d54ec1b2831d0524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: Id94c6615f857f3ad3497b1abef1e1f2bd67bd4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I0752d158c648f6ebfa17c9273bab2176e1ca6c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09tdf#156487 sw tracked table column: fix Hide ChangesLászló Németh
In Hide Changes mode, deleting table columns with change tracking wasn't applied on the table layout immediately, only using Show Changes and Hide Changes again. Now the deleted column removed from the table instead leaving an empty table column. Also revert commit 33058b5dc47a140516669945efbdd30ea65138a6 "tdf#156544 sw tracked table column: delete empty column". See also commit a74c51025fa4519caaf461492e4ed8e68bd34885 "tdf#146962 sw: hide deleted row at deletion in Hide Changes". Change-Id: If03d2bc5996a168cb44839b0753effb9031edbc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155522 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-08-09use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: Ibb8637e4648f56d7f9895a31df006915df8f8fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-09tdf#147938 sw_redlinehide: move fix into SwNodes::UndoTableOfText()Michael Stahl
Reproducing tdf#151866 on the .odt attachment, it becomes clear that the fix for tdf#147938 is in the wrong place. There a node has the merge flag None although it is the last node of a merge, because CheckParaRedlineMerge() first sets the node flags and then calls DelFrames(), which now resets the flags. In case there's another caller of DelFrames() that needs this, it's not obvious, can be added later. (regression from commit 5b55ccfd384d3c0c11e05f22bd7e956b4bc7e43a) Change-Id: Iba0cb83260ecb18a4b96ded20a95b2b20d696fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155516 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-09wina11y: Drop "#CHECK#" commentsMichael Weghorn
... and "#CHECK XInterface#" comments; it's obvious that this is what the next lines do. Change-Id: I09234d1a2f5c58cfab1580f188229d28d27fc402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155506 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-08-09wina11y: Use return value instead of out paramMichael Weghorn
... to return the `IAccessible*` in `AccObjectWinManager::GetIAccessibleFromXAccessible` and `CMAccessible::get_IAccessibleFromXAccessible` and adapt the call sites accordingly. This is more straight-forward and the extra bool return value didn't add anything, since it was also just saying whether the pointer was a nullptr, so rather check that directly. Also drop `AccObjectWinManager::GetIMAccByXAcc` that does the same thing and switch the only call site to use `AccObjectWinManager::GetIAccessibleFromXAccessible` instead. Change-Id: I72933df62aa9ac1ff3f2a84c5045dfae354c18e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155505 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-08-09SCriptForge (SFDatabases) manage database credentialsJean-Pierre Ledure
When not embedded, databases usually require user and password to grant access to scripts. When the access was refused, so far the execution was stopped brutally with an error message provided by LO internal code. This was made visible during some tests with a MySql database server. The code to be reviewed is located in the creation of the "database" service. This service has the sungularity that it can be called from several other service instances. As from this commit unsuccessful tentatives to login to a database from code are rejected with a clean SF error message. The different scenarios to create a database service have been (re)tested. Change-Id: I695d108242872d27671688af76916784908aeebe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155507 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-08-09vcl: Organize CoreText font code a bitKhaled Hosny
The code was all over the place with classes split between files or grouped in some files and I couldn’t make a head or tail of it. Move each class to a dedicated source/header file. Change-Id: I35daa05b4684c13339c637819dc30fa47a60cf65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155503 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-09tdf#144512 autorecovery: always wait for user idle with timed saveJustin Luth
Only the "active" document was waiting for a user idle. But that doesn't make sense because the background apps still lock the foreground app during file save. So all timed backups should wait for a user idle period before starting their recovery / autosave. Once an idle loop is triggered, no autosave will ever run again until an idle timeout occurs! So a busy user who switches from one doc to another without ever pausing still wouldn't ever get a backup - even from the background docs! Without this patch, only the first modified documents (if backgrounded within 10 minutes) would ever get a recovery save. So in pretty much every case this patch makes sense AFAICS. Change-Id: I6e9e04aa2e50895e53826b427cb52c129da43701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155459 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-08-09Resolves: tdf#156661 only set a fixed height for the single row caseCaolán McNamara
of the insert special character dialog. The character popdown uses multiple rows instead. Change-Id: If3c5578a018a31dbdb0a0d9785f18b570e13112f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-12 18:21:45 +0000