summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-08-15Removing old SfxItemSet::getHash usageVarun Dhall
Change-Id: I902da0f6e00253d5daf4bf65784dade2ae02740c Reviewed-on: https://gerrit.libreoffice.org/41155 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-15remove redundant SvxFrameDirection castsJochen Nitschke
and replace remaining C-style casts Change-Id: Ie83e2706391c05946ab46dfd7d26059101579153 Reviewed-on: https://gerrit.libreoffice.org/41143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15Remove unnecessary user-provided copy functionsStephan Bergmann
...with the added benefit of the implementation-provided versions being trivial and so avoiding GCC 8 -Werror=class-memaccess when these classes are subject of memcpy/memmove in store/source/stortree.cxx and store/source/storpage.cxx. Change-Id: I684109d8743eb7f1fa57c6925d738b11d934a7cf Reviewed-on: https://gerrit.libreoffice.org/40977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-15loplugin:checkunusedparams in scNoel Grandin
Change-Id: Ib4572899caeb7bc2dceb2c188ceb306b8ffc9193 Reviewed-on: https://gerrit.libreoffice.org/40629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15sw RTF export: indentation fixesMiklos Vajna
Change-Id: I33e20b23430483ce318c98a43bde07200802a4d6
2017-08-15tdf#100864 Assign a tooltip to the button to close paneTakeshi Abe
which appears at the top-right corner of both Impress's Slide Pane and Draw's Page Pane. Change-Id: Ida52ccc35e42546cd6260001e22335b04608034d Reviewed-on: https://gerrit.libreoffice.org/40803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-15external data: add merge column transformationMarkus Mohrhard
Change-Id: I112650bbb0ed279b386389e7df6b372bde080b62 Reviewed-on: https://gerrit.libreoffice.org/41157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-15external data: add split column transformationMarkus Mohrhard
Change-Id: I7a06f1a5c3f28b47288b0a2b191a34cd81efb439 Reviewed-on: https://gerrit.libreoffice.org/41156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14Related to tdf#109863: Crash when trying to modify background slide styleTamás Zolnai
Remove character highlighting tab from background style since there is no text content in the background. Change-Id: I5fcc3c76a3e60a37c3be72a14fa2f6668875bab6 Reviewed-on: https://gerrit.libreoffice.org/41154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-14Fix typosAndrea Gelmini
Change-Id: Ic95ec7c8a36ef5d19eac93b7eed8a7de2ec8904f Reviewed-on: https://gerrit.libreoffice.org/41153 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-14external data: add first test for data transformationsMarkus Mohrhard
Change-Id: I300cf3b9f094c912eb4b7618e405ad320e43e008 Reviewed-on: https://gerrit.libreoffice.org/41147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14external data: add initial work for data transformationsMarkus Mohrhard
Change-Id: I728ca764a2ea2926f8b8f76ea576b8be1091a29a Reviewed-on: https://gerrit.libreoffice.org/41146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14external data: handle child elements of td correctly in html providerMarkus Mohrhard
Change-Id: Id4451c13931eaf52adebca13fd237ba6d73a880c Reviewed-on: https://gerrit.libreoffice.org/41145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14Creating a button for the hamburger menuGökhan Gurbetoğlu
Things done in this commit: - Created a hamburger menu button on the right. - Moved the opening menu to match the new hamburger button. - Added 1 pixel at the end of shortcut toolbox so no overlapping with the tabs would occur. Change-Id: I3d05eec72e260575563e4d016945af0777541cfb Reviewed-on: https://gerrit.libreoffice.org/38450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-14updater: fix -Werror=undef problemsMarkus Mohrhard
Change-Id: I5a76a302419e911f541ad75e85ed6462ebe5f07f Reviewed-on: https://gerrit.libreoffice.org/41148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14external data: avoid crash due to exception when downloading failsMarkus Mohrhard
Change-Id: I96c310cf28c29795b1b211e430d944a9efa5353b Reviewed-on: https://gerrit.libreoffice.org/41144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14updater: fix dependency for desktop testMarkus Mohrhard
Change-Id: I699124813f375185b408a1a0c4f49a91b518971e Reviewed-on: https://gerrit.libreoffice.org/41141 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14updater: reference the correct new static library nameMarkus Mohrhard
Change-Id: Ib5920b27429f8414db761387645713498a60904f Reviewed-on: https://gerrit.libreoffice.org/41142 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-14Fix testVLOOKUP to actually use formula groupsTor Lillqvist
Change-Id: I3e2b626731a3508d1c4cd8abbe6de1660dbef11f
2017-08-14Test VLOOKUP, try to handle various special cases and errorsTor Lillqvist
Change-Id: I0ea9b9d882bf95c81ad784537671e22cb48d8c65
2017-08-14Removing unused SetVersionMap from editengVarun Dhall
Change-Id: I04b2cb17271365a7967e51c7d551f538ee9a5c68 Reviewed-on: https://gerrit.libreoffice.org/41102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14Removing unused SetVersionMap from swVarun Dhall
Change-Id: I453efd9fd93941dcdf193b461de1377b76506cde Reviewed-on: https://gerrit.libreoffice.org/41099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14Removing unused SetVersionMap from scVarun Dhall
Change-Id: I16e4a80b721e8f419352ed2d546bd3d7197ed4f7 Reviewed-on: https://gerrit.libreoffice.org/41101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14Removing unused SfxItemPool serialisation from svxVarun Dhall
Change-Id: I778ae09c4b0fd3e18a37db4aa3f2affda2c8e86c Reviewed-on: https://gerrit.libreoffice.org/41053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14Using static_cast instead of dynamic_cast:Mohammed Abdul Azeem
This is just a downcast and the object is always expected to be SvXMLImportContext. Change-Id: I755b6b366144d86104b1284fabe3dba74fb54452 Reviewed-on: https://gerrit.libreoffice.org/41063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-14new loplugin:droplongNoel Grandin
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-14Test division and especially error handlingTor Lillqvist
Change-Id: Ife4396bf8856178194497b724d4635468a58994d
2017-08-14Bin some unnecessary temporary codeTor Lillqvist
Change-Id: Ia9fef2a500ed0a6177612e845aa58976c602a66f
2017-08-14Delete sheet when doneTor Lillqvist
Change-Id: Ic35d21ee2cc5ab1481dd5b72150bfc8c82237f80
2017-08-14tdf#109863: Crash while trying to set pattern fill in ImpressTamás Zolnai
This line was missed to add in this commit: 76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I2fb8c90b34ecbdfdd2bdc62adaa5e0a0d074ce33 Reviewed-on: https://gerrit.libreoffice.org/41129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-14Decrease duplicated codeTamás Zolnai
Change-Id: Icadb800c8c31649a8db3da68ff6e9761a8f4d916 Reviewed-on: https://gerrit.libreoffice.org/41128 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-14vcl: Drop unused #includeTakeshi Abe
Change-Id: If0b27ed7d837000cfe5b3d30180096cd2bfab510 Reviewed-on: https://gerrit.libreoffice.org/41047 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-14Use the proper names for enabling\disabling master slide objectsTamás Zolnai
Same name are used in slide context menu (Slide Features submenu). Change-Id: I0063f35b0577f7600f6f053a95a9c83630dff186 Reviewed-on: https://gerrit.libreoffice.org/41127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-13ofz#3028: use of uninitialized valuesCaolán McNamara
Change-Id: I87bf37e4ae559c8057ac34b7d6dea52cf9468540 Reviewed-on: https://gerrit.libreoffice.org/41114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-13tdf#110988 Middle click does not paste primary selectionNoel Grandin
regression from commit 65b7b6322b662785bf032e66c76abc36c9a2bb0e "loplugin:unusedenumconstants read-only constants in vcl" Change-Id: I262dd4c9cd1dc6eca82521f5fd9fbfc952fb7745 Reviewed-on: https://gerrit.libreoffice.org/41111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13cppcheck: really remove the memsetJulien Nabet
Change-Id: Ic84e5ca6175d718548e9ee4f9f406ffc899f791a Reviewed-on: https://gerrit.libreoffice.org/41121 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-13log details of exception when we catch std::exceptionNoel Grandin
Change-Id: Ibfaba3473b11e24381d5a71a722c021ecde3488b Reviewed-on: https://gerrit.libreoffice.org/41112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13tdf#85909: EDITING: Native tables visualization not refreshedTamás Zolnai
... after changes to borders Regression from: 26b06662ebc3e5d664400bc95c39d6220de03136 "avoid repeated table layouting (fdo#75622)" It was a performance change, but it was a bad idea to avoid table layout refresh on this way Anyway I added a call for border update even if not all the table layouting is done. I tested with the test document attached to fdo#75622, import time seems similar so it does not cause perfromance issue to do that. Change-Id: I7c6fcf105c89233512390dc2ecbd111a32f6779a Reviewed-on: https://gerrit.libreoffice.org/41116 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-13updater: fix crash on windows while creating the updater command lineMarkus Mohrhard
Change-Id: I606f5ede0fe70af4b30c68a10b7c400612fddaee Reviewed-on: https://gerrit.libreoffice.org/41115 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: fix the updater path on windowsMarkus Mohrhard
Change-Id: I69ff622c12a289c4ac240ee4a7313eeffc3203b9 Reviewed-on: https://gerrit.libreoffice.org/40987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: use desktop.updater log scope consistentlyMarkus Mohrhard
Change-Id: I242890aeda4820ada6f06e4cbe01b73d5faf549e Reviewed-on: https://gerrit.libreoffice.org/40924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: make sure we pass the correct path for the updater executable on winMarkus Mohrhard
Change-Id: Ia7655317582b891e109f3b310498264cc59a3924 Reviewed-on: https://gerrit.libreoffice.org/40923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13updater: call the updater executable on windowsMarkus Mohrhard
Change-Id: Ibbcfea2e42bc55cf5c018bfb1856be7f1981f57d Reviewed-on: https://gerrit.libreoffice.org/40922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-13cppcheck: Using 'memset' on struct that contains a 'std::unique_ptr'Julien Nabet
+ use constructor initialization Change-Id: I52cb85bf7102dd3f8cf2105fc1c23229b76f28bc Reviewed-on: https://gerrit.libreoffice.org/41107 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13fix loplugin:externandnotdefinedMarkus Mohrhard
Change-Id: Ic819c0304b2f45481a77e53c4b6564d5ac3f2950
2017-08-13Revert "cppcheck: variableScope"Markus Mohrhard
This reverts the updater related code changes. I still might need to merge Mozilla changes into the code once more which becomes much more difficult with unrelated changes. Only helpful fixes for now please. Change-Id: I67b386d12d03250323cce21f4f65b262ce4abcf9
2017-08-13external data: add a test that shows that cropping to DB area worksMarkus Mohrhard
Change-Id: Ic883a5f625d54bf8cc95785a9ab1a83f0c8aa2ec
2017-08-13external data: reenable the test and adapt to new interfacesMarkus Mohrhard
Change-Id: I2d82b560e0bd499eb85c6ce22f5969f82dfe8937
2017-08-13add char highlighting (background) tab to graphics styles dialogCaolán McNamara
Change-Id: I2cf3872116ae59051847d73612a2f4f8385d34d8 Reviewed-on: https://gerrit.libreoffice.org/41030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-13move the SvxBackgroundColorItem<->SvxBrushItem conversionCaolán McNamara
into the dialog itself Change-Id: I83db9f02145a4927257dd5691f82dad1a11eaea6 Reviewed-on: https://gerrit.libreoffice.org/41029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>