summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-12loplugin:useuniqueptr in XclImpChangeTrackNoel Grandin
Change-Id: I360720b5c0402982e58416f9c902388034e5ecee Reviewed-on: https://gerrit.libreoffice.org/57301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12installer: exit on the other errors in resolve_filelist_flag tooMichael Stahl
Nobody reads these error messages if the build succeeds. Change-Id: Ib1e52bf188d0da2bc35a0d2d2f79fff409e15977 Reviewed-on: https://gerrit.libreoffice.org/57270 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-12loplugin:useuniqueptr in XclExpChTrTabIdNoel Grandin
and write the buffer in one go in SaveCont Change-Id: Id41bb132ff3b4176b1fcb1798d10191c3d45fffc Reviewed-on: https://gerrit.libreoffice.org/57298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12KJ: ^ some table related, font, align icons etc, + PivotTable menu iconRizal Muttaqin
Change-Id: Icfa28a165d6697ca105b95fcc846ae05edbbdb11 Reviewed-on: https://gerrit.libreoffice.org/57282 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-12Make setPagePrintSettings() accept IsLandscape againThorsten Behrens
Regression from 80c35d97b9b3b60a091aae77de0ffef38cbf531a - invert the check for boost::optional validity. Change-Id: If4e041e1fe349c1fcb2c74b2e5780bf57300486f Reviewed-on: https://gerrit.libreoffice.org/57309 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-12Bin support for Visual Studio 2015, leaving just 2017 for nowTor Lillqvist
Change-Id: I6e604a8a463ff453b82ca60f1bf92b7c73870482 Reviewed-on: https://gerrit.libreoffice.org/56455 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-07-12pdfium: replace FPDFTextObj_GetMatrix() patch with backportMiklos Vajna
Also remove unused FPDFTextObj_GetUnicode() and FPDFTextObj_GetText(). Change-Id: I4b1f88f878f2754ff790b67d286a9d5366acc641 Reviewed-on: https://gerrit.libreoffice.org/57292 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in RootDataNoel Grandin
Change-Id: Ibb053d17a1da6e3db74b97b4f66a4ad03147b3bc Reviewed-on: https://gerrit.libreoffice.org/57297 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in SwUndoSaveSectionNoel Grandin
Change-Id: I0d4efde9ffa3a026052303eda4fe4dbbd48b22bc Reviewed-on: https://gerrit.libreoffice.org/57306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in SwRedlineItrNoel Grandin
Change-Id: I74f4b9bef04b67380035eb7dcfdc73c89bf0c0d1 Reviewed-on: https://gerrit.libreoffice.org/57305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in SwGrammarContactNoel Grandin
Change-Id: I13b346751a001871fe2db04c0b40a0201d55352b Reviewed-on: https://gerrit.libreoffice.org/57304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in ExtConditionalFormattingContextNoel Grandin
Change-Id: I3816fda10378852e06290e358b2bf18d48bee13d Reviewed-on: https://gerrit.libreoffice.org/57302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in LotAttrCacheNoel Grandin
Change-Id: Ic28b2aa9488b4a85e18d3777798bc1106cfb7c5f Reviewed-on: https://gerrit.libreoffice.org/57299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in TokenPoolNoel Grandin
Change-Id: I25ff554e1dae45ff62bb3f036590a57a79d54b28 Reviewed-on: https://gerrit.libreoffice.org/57296 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12loplugin:useuniqueptr in LotusFontBufferNoel Grandin
Change-Id: I1039d3f40409a0839c35d6270741aae8017ddf62 Reviewed-on: https://gerrit.libreoffice.org/57295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12return SvMemoryStream by std::unique_ptrNoel Grandin
Change-Id: I60a41111e76d72a7384cbb15f2d2a73c95af8c2d Reviewed-on: https://gerrit.libreoffice.org/57280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12uitest logger: log key according to DSL inside dialogs tooSaurav Chirania
Change-Id: I30cfbf7ba87dda43ecb75ffd5f69253d77b6a00b Reviewed-on: https://gerrit.libreoffice.org/57233 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-12tdf#117895: "Edit document properties before saving"...Henry Castro
option leaves just-saved document modified; changes are not saved Change-Id: Icad48fe1edcfb4c10c40f297326c23110144df53 Reviewed-on: https://gerrit.libreoffice.org/57211 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-12fix the buildMarkus Mohrhard
Change-Id: I661666166594ce3012767fac6edc64aa424442e5
2018-07-12Added Number transformation in Data Provider DlgManuj Vashist
Change-Id: I9a2e1e16d7683d790826fdc772fbcfbcf8af9881 Reviewed-on: https://gerrit.libreoffice.org/57149 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-12Added Aggregate functions to data provider dlgManuj Vashist
Change-Id: Ic6de5319f936095fa1d165fc5901f13d0e7776f5 Reviewed-on: https://gerrit.libreoffice.org/57027 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-12Added Sort Transformation in Data Provider dlgManuj Vashist
Change-Id: I68ea3d2fc40163d0f3a67bb3723341f8e382db27 Reviewed-on: https://gerrit.libreoffice.org/56914 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-11Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - tdf#118314 Delete help content related to obsolete “Input Method Status” feature Change-Id: Ie80279915e3ee9a123204a729325ca9e119ab6bb Reviewed-on: https://gerrit.libreoffice.org/57224 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-11ODF export data transformations -follow-upVikas Mahato
Change-Id: I31a0b29d94abb59e7633c45aa1536772b2d8c102 Reviewed-on: https://gerrit.libreoffice.org/57217 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-11tdf#116861: better default settings for minimize Presentationandreas kainz
Change-Id: I6d05cb5591791afc438bfe38f179aa26d6cee920 Reviewed-on: https://gerrit.libreoffice.org/57285 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-11NB Implementation: fix Underline command and add CharmapControlandreas kainz
The new CharmapControl action will be used instead of InsertSymbol Change-Id: I9a2e519fb7b8b773763b4c58f8aaa40e6af810b6 Reviewed-on: https://gerrit.libreoffice.org/57283 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-11tdf#118232 Allow load and insert of SVGs with no GeometryArmin Le Grand
Change-Id: Iaf3d6a0423c5f11dda1e623dd730af01dbd6551c Reviewed-on: https://gerrit.libreoffice.org/57284 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-11ScGlobal::OpenURL: support relative references as URI references in hyperlinksEike Rathke
Instead of failing with "is not an absolute URL" error. For example in the HYPERLINK() spreadsheet function where Excel supports it, but also anywhere else that calls OpenURL(). A relative reference is relative to the current document, or for yet unsaved documents or if no object shell is available relative to the work path, as usual. Additional benefit is that "\\" UNC path names are accepted as smb:// Samba shares and DOS \ path name separators resolved for a proper file:// URI. Users are asking for this, found no related tdf# bug/RFE. See https://ask.libreoffice.org/en/question/160280/relative-and-absolute-hyperlinks/ and other linked q&a therein. Change-Id: Ib314b71d68fbe1793ec614cbf7c0c058fad14a10 Reviewed-on: https://gerrit.libreoffice.org/57277 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-11tdf#118564 sw/ww8filter - map NFC 11 to SVX_NUM_NUMBER_LOWER_ZH.Mark Hung
The attribute name of the numbering format code 11 is "japaneseCounting" [1]. Although it seemd like a Japanese counting guessing from its name, it's actually use the same characters used by Chinese lower numbers [2]. Ref: [1]https://msdn.microsoft.com/en-us/library/dd923798(v=office.12).aspx [2]https://msdn.microsoft.com/en-us/library/dd772856(v=office.12).aspx Change-Id: I241be1e5e118197207cbc51334272b532e23c25f Reviewed-on: https://gerrit.libreoffice.org/57138 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-11sw/qa: CjkNumberedListTestHelper -> getNumberingTypeOfParagraphMark Hung
Move CjkNumberedListTestHelper to swmodeltestbase.hxx to get rid of copy-pasted code, and rename it to getNumberingTypeOfParagraph. Change-Id: I36f14be30bcd9a9d22d1d5071220a13c02602a22 Reviewed-on: https://gerrit.libreoffice.org/57137 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-11related tdf#114845 oox: ensure rXShape.is()Justin Luth
Change-Id: Ic5a78d3f650bff82ce8d86a62ecfc025ca2062e0 Reviewed-on: https://gerrit.libreoffice.org/57276 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-11Colibre icons: fix links.txt link and update addwatch iconandreas kainz
Change-Id: Iddb48d2cde206824f7721c5f4374166cc4979ad9 Reviewed-on: https://gerrit.libreoffice.org/57272 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-11tdf#118672 sw layout, TabOverMargin: allow using the area over the tab portionMiklos Vajna
TabOverMargin in general is about allowing the cursor to jump over a margin if there is an explicit tab stop there. A corner-case is what to do when there is enough content so a line break is necessary for the characters after the tab portion. Allow using the area up to the edge of the whole text frame (i.e. over the tab position), this matches what Word does. Change-Id: Ie86edf030d54fba556eee26e7ea563fb8d4fbee4 Reviewed-on: https://gerrit.libreoffice.org/57275 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-11sysui: try to fix Mac instsetsMichael Stahl
7c6ca00e61c42bb7c43cbb7a3203d8bad5c0ed0e broke the Mac build, because the files from infoplist Package have double "/" because of the empty path in the call to gb_Package_add_files. Change-Id: I3a72e8de0a8f2256b068a491231aaaa3d3b00b6e
2018-07-11loplugin:useuniqueptr in SwAttrIterNoel Grandin
Change-Id: I204250a02ac88cc36267b79ef1d70cd361230752 Reviewed-on: https://gerrit.libreoffice.org/57245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11related: tdf#118571 installer: error out if path contains "//"Michael Stahl
No point in creating funny MSIs that don't work. (Thanks to bubli for the help with perl) Change-Id: I54aa39ed282e31270de69566656d33b803a73802 Reviewed-on: https://gerrit.libreoffice.org/57266 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-11tdf#79878 perf loading docx file, improve threading heuristicNoel Grandin
this gives another 2% perf Change-Id: Ia2983339f3f11daef37c48044904c8037a7a0bf6 Reviewed-on: https://gerrit.libreoffice.org/57265 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11clean up UNO available() implementationsNoel Grandin
There seems to be some confusion here. available() is actually the number of bytes that can be read without blocking, but most implementations seems to be just returning the number of bytes remaining in the stream. Since we're doing that, let's do it properly. (*) some of them were just casting, instead of clamping, which will return wrong values sometimes. (*) FileStreamWrapper_Impl/OInputStreamWrapper/OTempFileService were doing unnecessary work, instead of just asking the underlying SvStream for it's remaining size Change-Id: I3ef26e0363e989ed3e00be0fdb993e1cdeb7819f Reviewed-on: https://gerrit.libreoffice.org/57264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix more typos in GIMMICKS name here and there Change-Id: Iae95e2aaa42f273effa3b7576da7e6c45495c5c6 Reviewed-on: https://gerrit.libreoffice.org/57273 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-11tdf#79878 perf loading docx file, more saxNoel Grandin
(*) in GetTokenWithPrefix, use rtl_str_reverseCompare_WithLength faster than strncmp (*) No need for NamespaceDefine to be stored via std::shared_tr Change-Id: Ibd262a3f4f5a0f518ec6abe1fb19e7803f78fe8b Reviewed-on: https://gerrit.libreoffice.org/57261 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11Make sure to re-enable UI after saveMike Kaganski
Change-Id: I9e8ea29893b372daa27262b2224481c67b4e4482 Reviewed-on: https://gerrit.libreoffice.org/57258 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-11tdf#79877 perf loading docx file, activate SAX threadingNoel Grandin
our nice threaded parser was not kicking in because it checks the size of the stream with available(), and this available() implementation was just returning 0. This makes for a 5-10% performance improvement Change-Id: I6516862c9c63136b54ca825dd98e35e6d87d4227 Reviewed-on: https://gerrit.libreoffice.org/57263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Typo in GIMMICKS Basic library name Change-Id: I15a491ae867f16c13faf1a102ec3b11a6dcfc638 Reviewed-on: https://gerrit.libreoffice.org/57252 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-11CppunitTest_sw_uiwriter: fix --without-fonts buildMiklos Vajna
Member function was defined, but not declared. Change-Id: Ia7aeae264be9e833f5ba1714df0bd7f976b21437
2018-07-11tdf#63561 docx export: "clear" unused inherited tabsJustin Luth
If a style contains tab definitions, then the paragraph inherits these. They are added to any tabs defined at the paragraph level. Unwanted inherited tabs must be explicitly removed. (TODO: LO ought to be inheriting from ALL parents, so the same logic ought to apply to a style's parent tabs, but currently LO does not import that way. So the proof unit test looks different in MSO compared to LO.) Change-Id: Ida8ed2792482655d512c753fdff8d02062d895a8 Reviewed-on: https://gerrit.libreoffice.org/57255 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-11sc: Prefer std::vector to std::deque or std::stackTakeshi Abe
as the queue is modified only by either appending or clear(). Change-Id: I6866c047eaf7149221c77ff4f1f3759dbf10492e Reviewed-on: https://gerrit.libreoffice.org/57182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-11xmlsecurity UI: restore lost AdES default for PDF signingMiklos Vajna
Regression from 13596e704e4b48e8b0892867b3f3fc351a2729f9 (Don't pass ODF version, just retrieve it directly, 2018-05-17). Change-Id: Ia031e597c610000db2820920c3dc1b58430dcc12 Reviewed-on: https://gerrit.libreoffice.org/57246 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-11Breeze icons: sync with Colibreandreas kainz
Change-Id: I1bf2a55bc9fe7f70c5cc8ff51062b9c51cf70f80 Reviewed-on: https://gerrit.libreoffice.org/57248 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-11tdf#65353 test for font embedding in ODF documentsTomaž Vajngerl
Change-Id: I97fdb9ffb506a005dac08f7c78a3fa4383098b0b Reviewed-on: https://gerrit.libreoffice.org/57169 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-11font feat: prioritize Graphite descriptions, use UI lang., fixesTomaž Vajngerl
When collecting font feature description do prioritize Graphite collected descriptions over OT. This is important for descriptions for ssxx and cvxx only contain general description and not what exactly they do. When collecting for Graphite use the UI language for descriptions. Fix gathering the descriptions with graphite to include all of the descriptions available. Change-Id: I6b3b92eb160fc3fd70214edf0d37095865f9c563 Reviewed-on: https://gerrit.libreoffice.org/57250 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>