summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-12-18use more concrete UNO in swNoel Grandin
Change-Id: Ie83d957349f123bca0fd46ce3144ce778c3ec101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178704 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-18scp: Drop reference to no longer existing acc filesMichael Weghorn
These are no more since commit 9283da858506fe3b4383e4cfe0506e470a4356f6 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Dec 17 12:04:04 2024 +0100 a11y: Merge accessibility module into vcl , so drop the reference. Fixes the build failure seen in the macOS daily build [1]. Thanks to Christian Lohmaier for pointing it out. [1] https://ci.libreoffice.org/job/lo_daily_tb_mac/1946/console Change-Id: Ib4a5c4cb2774f596332715fe6dd2faea678e9ce5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178721 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-18vcl mtfxmldump : allocates less OUStringArnaud VERSINI
Change-Id: Ibd78e40817f6a0ec071c9f45bb41c38e476dd02d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176408 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-18Send attachments to xdg-email also as --attach argumentsMike Kaganski
Intended to handle the potential end of support of "attach" in mailto URLs, as discussed in https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/177. Change-Id: If1e9a7161e9805f634fcab5fb83e6f172af54d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178701 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-12-18android-viewer translated using WeblateWeblate
Afrikaans currently translated at 70.6% (82 of 116 strings) Change-Id: I71381e8730922f481c5d7cf1d0b5aa879e8dd8f3 android-viewer translated using Weblate Afrikaans currently translated at 56.8% (66 of 116 strings) Change-Id: Id75cae5888d66e89e6fb673deda1d4160892b8bb Added translation for android-viewer using Weblate (Afrikaans) Change-Id: Ia75e38962a94682d1b9e927da51ec018d54d7158 android-viewer translated using Weblate Tagalog currently translated at 100.0% (116 of 116 strings) Change-Id: I9d1b4fced291230fb73082bb8a00ed911e918ca6 Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com> Co-authored-by: Paul Roos <iNetRoos@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/af/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tl/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178391 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-18Resolves tdf#140298 - SQL dialog must not become oversizedHeiko Tietze
SQL history becomes quickly too large for the dropdown control The patch sets a fixed width so this control wont take over the dialog size. Change-Id: I106ae19dfd505388e5b528becbc06e9d6110d45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178702 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-18add a way to update config from kitCaolán McNamara
arg is a path to a "presets" dir similar to instdir/presets/ where autotext/wordbook/xcu may exist initially just update xcu if that is present, autotext itself typically is updated dynamically if a new file is found, while wordbooks are not and the diclist can be explicitly reinitialized here if there are wordbooks. Change-Id: Ibeb9d23d143c710f12e6c9d75b2861e0e6d44a01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177372 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 30f83f2dff9f80db0b4a467fb30f9a9b2531fa3c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178664 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-18CppunitTest_sw_tiledrendering2: make this more stable, try 3Miklos Vajna
I got the workaround condition wrong in commit d248d8f5271c380e51af9482b6724d471e2cb929 (CppunitTest_sw_tiledrendering2: try to make this more stable, 2024-11-20), the intent was to return early when we get no state changes, but we did the early return when there *were* state changes, fix this. Change-Id: I90abcec062c59360642da87069911f937cc2110a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178706 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-18cid#1606564 silence Overflowed constantCaolán McNamara
Change-Id: I6a4e36e9905278673577b543b27c50bc7988cc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178707 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-18Update git submodulesBogdan Buzea
* Update helpcontent2 from branch 'master' to 6c4a6bbc4f688feeabeb307c0dea1ef0c8f2baab - tdf#124954 Improve Help about cache spreedsheet formula Change-Id: If9fdd7fa699afd9735b98fb42def1c1700556591 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178535 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-12-18Fix typoAndrea Gelmini
Change-Id: I75ce750a6073d4baed29c8cb737e1ad406bba6a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178713 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-12-18tdf#164359 editeng RTF export: track unused parent styles recursivelyMiklos Vajna
Start edit mode for the shape in the document, double-click on a word which has a "level 2" bullet associated with it -> crash. This is a regression from c8b607b7c0096c58dc5187262bf0133dee728d50 (tdf#163883 editeng RTF export: fix broken offsets into the para style table, 2024-11-19), the direct cause is that ImpEditEngine::WriteRTF() maps all style pointers to a style ID and once we write the parent property in the style table, we unconditionally dereference our search result, because we know all styles should be in that map. The root of the problem seems to be that once parent styles are marked as used for the "only write used styles for the clipboard" case, those parents themselves can have parents, and we didn't mark those as used. Combined with the unconditional dereference, this leads to a crash. Fix this by walking up the parent chain till we get no parent. This assumes that importers create a valid document model, so there can't be loops while walking the parent chain. If that would be a problem in practice, we could check for that in the future. Change-Id: I4b416e78f26bf455040d95ee8ed220cfe870e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178703 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-18tdf#114441 change the sal_uLong to sal_uInt8 in msdffimpManish
Change-Id: I22dacda7966d0f680006f0e589bd6d95b5a6f4fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178436 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-18tdf#164225: Only install MAR update_service when it will be neededStephan Bergmann
...where "will be needed" is approximated by "install location is under C:\Program Files" (i.e., where admin privileges will be necessary to do an update) Change-Id: I00c93df8c0c2c5132fffa4056b88af098cb4a644 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178679 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-12-18Update git submodulesRobert Muir
* Update dictionaries from branch 'master' to c3ff53711dcac4bdec24f23a2c1f9712a0833b67 - tdf#164366: fix wrong REP count in mongolian .aff file Commit d169602 broke parsing of this file by the lucene hunspell support, because now a `REP 3619` is followed by 3621 REP rules. Fix the count to be correct. Change-Id: I2c971dec7c44793e3d5b7a4030940014ddbebbb4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178710 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-18Revert "boost: upgrade to 1_87_0" for now to unbreak android arm32 buildMichael Weghorn
For some (still unknown) reason the upgrade from boost 1.86 to 1.87 caused the 32-bit ARM Android builds to fail with errors like <inline asm>:1:41: error: expected '%<type>' or "<type>" .pushsection ".debug_gdb_scripts", "MS",@progbits,1 ^ <inline asm>:318:12: error: .popsection without corresponding .pushsection .popsection ^ 2 errors generated. make[1]: *** [/home/tdf/lode/jenkins/workspace/android_arm/solenv/gbuild/LinkTarget.mk:339: /home/tdf/lode/jenkins/workspace/android_arm/workdir/CxxObject/configmgr/source/groupnode.o] Error 1 make[1]: *** Waiting for unfinished jobs.... [build CXX] configmgr/source/node.cxx <inline asm>:1:41: error: expected '%<type>' or "<type>" .pushsection ".debug_gdb_scripts", "MS",@progbits,1 ^ , see e.g. [1] and the list of all Android ARM 32 bit builds [2]. A local bisect points to this commit, and reverting it fixes the build. Do this for now to work around the build failure and give time for finding a better solution. This reverts commit 25e7e1677b13db818b5458cd0c3fd3d9dfc88557. [1] https://ci.libreoffice.org/job/gerrit_android_arm/43354/console [2] https://ci.libreoffice.org/job/gerrit_android_arm/ Change-Id: Ifad1412b691adce74bb16805975e3439898e3b74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178697 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-12-18Resolves: tdf#156398 use same color combination as used in tdf#51300Caolán McNamara
so we don't get white text on yellow background Change-Id: I346decaab293e2bb15c1110dfa61df5838607d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178694 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-12-18Some --disable-zxing fixesStephan Bergmann
For one, UITest_writer_tests3 would crash soffie.bin in an --enable-dbgutil build with > include/vcl/vclptr.hxx:109: VclPtr<reference_type>::~VclPtr() [with reference_type = AbstractQrCodeGenDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. from within that test_insert_qr_code. But even with that out of the way, the test would still hang (in any kind of --disable-zxing build, not just --enable-dbgutil), with the Python process at > File "uitest/uitest/test.py", line 129, in wait_and_yield_dialog > time.sleep(DEFAULT_SLEEP) > File "uitest/uitest/test.py", line 151, in execute_dialog_through_command > yield from self.wait_and_yield_dialog(event, xDialogParent, close_button) > <built-in method next of module object at remote 0x7fb6fc6a0230> > File "instdir/program/python-core-3.10.16/lib/contextlib.py", line 135, in __enter__ > return next(self.gen) > File "sw/qa/uitest/writer_tests3/insertQrCodeGen.py", line 18, in test_insert_qr_code > with self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog: and the soffice.bin process idly yielding at > #14 0x00007fa582369b78 in Application::Yield () at vcl/source/app/svapp.cxx:473 > #15 0x00007fa582368a40 in Application::Execute () at vcl/source/app/svapp.cxx:360 > #16 0x00007fa58ca42fba in desktop::Desktop::Main (this=0x7fffe69ca960) at desktop/source/app/app.cxx:1679 Change-Id: I007d1497e6f0c968039af3649f6252794e222226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-12-18tdf#163319 Do not decrement destination position when moving a tabAlin Andrei Abahnencei
to the right Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com> Change-Id: Id8da1a1b199927bb2f1b71b814737b8287ea2a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178362 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-18Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 86672eb8932b6779dd5b6d036c083662d4bcd15f - update translations for master/25-2 and force-fix errors using pocheck Change-Id: Ie775663b93d82f8392fa6317099ad158661dbdc7
2024-12-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7001361d995b74c7ea2bb334e442797e57feaea7 - Typo Change-Id: I9ffdecb64a9a6adec25e6516615b65ea79e1e788 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178684 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-12-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 46b1c476e1b92773ea63f3e74460acb1cf5792a5 - Typos Change-Id: I19aac6bc535a8ca337fe11247cb2823db64eb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178692 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-12-17[API CHANGE] a11y: Drop UNO service to create a11y contextsMichael Weghorn
Drop the com.sun.star.accessibility.GetStandardAccessibleFactoryService UNO service that was used to create instances of the a11y classes for (mainly vcl) widgets. The service was needed to break a dependency cycle. However, with Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Dec 17 12:04:04 2024 +0100 a11y: Merge accessibility module into vcl and all the preparatory commits in place, there is no more dependency cycle, as the a11y classes for vcl widgets no longer depend on any modules "above" vcl. Therefore, drop the UNO service and the abstract vcl::IAccessibleFactory class and other related classes. Make all methods in the AccessibleFactory class (that was previously subclassing the abstract IAccessibleFactory) static helper methods, and call them directly. The UNO service dropped in this commit was introduced in commit 1af510e95147374e5289ae1c12f1f280931919f4 Date: Wed Feb 21 11:30:47 2024 +0200 Create an UNO service to do the symbol lookup in toolkit::AccessibilityClient and its documentation was already clearly stating that it's only meant for LibreOffice internal use: > /** > The toolkit module uses this to get a pointer to the AccessibleFactory from the acc module. > Because we have a dependency in our modules that goes the "wrong" way. > > @since LibreOffice 24.8 > > @internal > > ATTENTION: This is marked <em>internal</em> and does not > have the <em>published</em> flag, which means it is subject to > change without notice and should not be used outside the LibreOffice core. > */ Change-Id: Ib97396a4bad486d9530361dd851ad3ee0f9681b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178689 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-17a11y: Drop unused UnoWrapper::maAccessibleFactoryAccessMichael Weghorn
Unused since commit 739b0716504d2526fb7283100420e4bd5eacb7c2 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Dec 4 15:48:51 2024 +0100 a11y: Move menu a11y classes to vcl, no more use factory Change-Id: I492bc5dee8ccadba3d608ffb1cef011cc6f1e250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178688 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17a11y: Use #pragma onceMichael Weghorn
Change-Id: I99b22c542c673c5633ebd9fe270e32759eb54457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178687 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17vcl a11y: Move AccessibleFactory declaration to headerMichael Weghorn
... in preparation of using it directly elsewhere. Change-Id: I50e773fb359418838d7fd42846772ff4f1546ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178686 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-17a11y: Merge accessibility module into vclMichael Weghorn
Now that the accessibility module no longer depends on toolkit and svtools and there's therefore no more cyclic dependency, merge it into the vcl library, where the vcl widgets are located, for which the classes in the accessibility module (primarily) provide the a11y classes. Initially, take over the existing UNO service "com.sun.star.accessibility.comp.GetStandardAccessibleFactoryService" to vcl as is. It used to be necessary to break the cyclic dependency between the vcl, svtools, toolkit and accessibility module. (vcl is the lowest and accessibility used to be furthest up in the dependency chain; yet vcl needed it to create the objects providing the XAccessible/XAccessibleContext for its widgets.) Further simplification can happen in upcoming commits. Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178647 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17a11y: Merge toolkit::IAccessibleFactory into vcl oneMichael Weghorn
toolkit::IAccessibleFactory and vcl::IAccessibleFactory are abstract classes providing methods to retrieve the XAccessible or XAccessibleContext for different vcl widgets. Both are implemented by the same class in the accessibility module: AccessibleFactory Merge toolkit::IAccessibleFactory into vcl::IAccessibleFactory to have things in one place, and have everything in vcl, i.e. no longer part of it in toolkit that itself depends on vcl. Change-Id: I5da571899c9987267cbec2950630d0c44ff4d2f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178643 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17weld: Drop now unused weld::Widget::{g,s}et_grid_*Michael Weghorn
These methods were superseded by corresponding methods in the weld::Grid class in Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions Now that all existing code has been ported to the new API, drop the unused old methods. Change-Id: I94ffa6a9de5e052e8248276b60f6fe4f10dff697 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178638 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port SwTableColumnPage to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I75184bd5522c9ae53981a7260ee5de110b7565f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178637 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17sw: Resave tablecolumnpage.ui with glade 3.40Michael Weghorn
Change-Id: I671a272f60dfd12325f760681cb3c6f988467c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178635 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port SwCreateAuthEntryDlg_Impl to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Deduplicate the code a bit by introducing a `pTargetGrid` local var that points either to `m_xLeft` or `m_xRight`. This dialog can be triggered in Writer via "Insert" -> "Table of Contents and Index" -> "Bibliography Entry", then clicking the "Edit" button. Change-Id: Ib75c5f1225d9590849f1eaed083857dbe30ce551 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178634 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port SwTOXWidget subclasses to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I7d6d23f0d1fec640c1de38c896f3e9b7e06ed70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178633 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port SwAssignFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I6ba9008c4ab9b049d9703c13c15d3df262436e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178632 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-17Port SwAddressFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I1ee227fbf9eaa4048e1a9c86ae0280ef473d6af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178631 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-17Port ScDataFormFragment to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I1e0202182dc1f4f3136cfcabdb451ab52ee17294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178625 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port ScIconSetFrmtDataEntry to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I310bade49f4732e1da34486dcfb2dc23a3c3ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178624 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port ScCondFrmtEntry to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I0d808c4738e14321c9d0a9b022abd4d215030910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178623 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17weld: Drop unused CustomWeld::{g,s}et_grid_left_attachMichael Weghorn
It's currently unused, so drop it. If there's ever a need to adjust grid positions in the future, this should instead be done by calling the corresponding methods on the weld::Grid, see previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: Ia573a850d62233a0500b8d3b38f2ddd47c2ce680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178622 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Fix and port ScHFEditPage grid handling to new APIMichael Weghorn
The code was calling weld::Widget::get_grid_left_attach and weld::Widget_set_grid_left_attach on the wrong widgets that are not direct children of the grid, but children of the grid children, triggering these warnings with gtk3: (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach' To trigger: * start Calc with the gtk3 VCL plugin and SAL_RTL_ENABLED=1 * "Format" -> "Page Style" * select the "Header" tab page * click on the "Edit" button Fix this by assigning IDs for the GtkScrolledWindows that are actually the direct children of the grid and using these instead. Port to the new weld::Grid API instead of calling the methods directly on the weld::Widget children, see previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I22c31a2f6b5eade56f6061023f5b914b615f4ba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178615 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port SvxSplitTableDlg to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: I82b5d9c6ac3577cf247c64b88466fb0b0ba3f877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178614 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port FontFeaturesDialog to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. To trigger dialog: * open context menu for paragraph in Writer * select "Character" -> "Character" to open the "Character" dialog * in the "Font" tab, click on the "Features" button Change-Id: I9b87a82c65c59b5d02ddf44df96ca85113f7ffc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178613 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17Port OBrowserLine to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. Change-Id: If0e0ea858a64411a137f07f33b1963185025e4d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178572 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17weld: Port AdditionsDialog to new weld::Grid APIMichael Weghorn
See previous commit Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Dec 16 11:02:00 2024 +0100 weld: Add weld::Grid to handle grid child positions for more background. The changed code path can e.g. be triggered in Writer as follows: * "File" -> "Templates" -> "Manage Templates", * click the "Manage" combobox * select the "Extensions" entry Change-Id: I28f258fde8700ade4d5c6ded39d6063f31bc2e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178571 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17weld: Add weld::Grid to handle grid child positionsMichael Weghorn
Currently, weld::Widget provides methods that can be used to retrieve and change the position (and column span) of widgets that are located inside of a grid (parent), e.g. weld::Widget::set_grid_left_attach to set the column. These methods however only make sense for widgets that are actually direct children of a grid, not for any "random" weld::Widget. Generally, it's the grid's responsibility to manage child positions, and the gtk3/gtk4 implementations actually assume that the parent is a GtkGrid, retrieve that parent and then call the corresponding GTK API functions for that grid. Align the weld API more with the concept of the grid being responsible for positioning its children by introducing a new weld::Grid class with methods equivalent to the current weld::Widget ones, but that take the child widget as an additional parameter. Take over the existing logic from the corresponding weld::Widget methods for both, the gtk and vcl implementations (e.g. GtkInstanceWidget::set_grid_left_attach -> GtkInstanceGrid::set_child_left_attach). Add an assert that the passed widget is actually a grid child. Deprecate the existing weld::Widget methods for grid position handling. They will be removed once existing code has been ported to the new weld::Grid API. The fact that the vcl implementation, VclGrid (used by vcl's new SalInstanceGrid implementation of weld::Grid), still relies on its vcl::Window children having the corresponding members set correctly remains unaffected. Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178570 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-17tdf#161623 Handle windows that macOS forces to native full screen modePatrick Luby
Starting with commit c1452e73091412ba0bb72306329e1912df2ba513, native full screen was disabled. However, in certain cases, macOS will force a window into native full screen mode and this caused numerous bugs. So add the following fixes to support native full screen windows. Note: the green titlebar button will still zoom the window. That button will only escape native full screen mode only when macOS has already forced a window into native full screen mode: - When in native full screen mode, -[NSWindow styleMask] will include NSWindowStyleMaskFullScreen which can affect the frame and content rectangle calculations so always use -[NSWindow styleMask] instead of the mask that was used to create the window when doing such calculations. - A comment in commit c1452e73091412ba0bb72306329e1912df2ba513 mentions crashing after ordering out a native full screen window. I have not experienced any crashing, but I did find that ordering out would leave the application in a state where there is no Desktop and both the menubar and the Dock are hidden. The fix, which is to close windows instead of ordering them out, was copied from the following NeoOffice source code file which is licensed under the Mozilla Public License, v. 2.0: https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/java/source/window/salframe.mm - In AquaSalFrame::GetWindowState(), add both the original and the curent frame when the window is in LibreOffice and/or native full screen mode. - Track LibreOffice and native full screen state in separate instance variables so that both modes can be activated independently and the window is not set back to its original size unitl a window has exited both full screen modes. LibreOffice also has its own full screen mode which hides the menubar and Dock, resizes to fill the screen, and hides all of its toolbars. As much as possible, both full screen modes should coexist and the user can enter or exit LibreOffice full screen mode while in native full screen mode. So add the following fixes for LibreOffice full screen mode: - Do not add the window's titlebar height to the window's frame as that will cause the titlebar to be pushed offscreen. - The menubar and Dock are both hidden when a window enters LibreOffice full screen mode. However, -[NSWindow setFrame:display:] shrinks the window frame to allow room for the menubar if the window is on the main screen. So, force the return value to match the frame that LibreOffice expects. - Multiple windows can be in LibreOffice full screen mode at the same time so hide or show the menubar and Dock when a LibreOffice full screen window gains or loses focus. - When a window is in LibreOffice full screen mode, LibreOffice hides the menubar. However, when in native full screen mode, hiding the menubar causes the window's titlebar to either fail to display or fail to hide when expected. So allow the menubar to remain visible when a window is in both LibreOffice and native full screen mode and disable all LibreOffice menus (like is done when a modal windowj is displayed) to mimic the effect of hiding the menubar. Change-Id: I94ae24a03d192a681d5500930f7fec70e595ffaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178497 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-12-17sw: silence warning C6011Xisco Fauli
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sw/source/core/fields/reffld.cxx(1419): error C2220: the following warning is treated as an error C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sw\source\core\fields\reffld.cxx(1313) : warning C6011: Dereferencing NULL pointer 'pStart'. : Lines: 1299, 1301, 1302, 1303, 1305, 1307, 1308, 1309, 1312, 1313 make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sw/source/core/fields/reffld.o] Error 2 Change-Id: I7ab3a8906738ed0cd64c890cabdf04234c80afd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178666 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-17tdf#132274 Clarify wording of default Writer zoom behaviourThorsten Behrens
There was apparently some confusion what 'latest setting' was referring to (in fact, it's the latest setting that was stored in the document, for most cases). Change-Id: I30d36567cde602ba18b0b721dec0c9e76b560edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178660 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-17tdf#164124: sc_ucalc: Add unittestXisco Fauli
Change-Id: I002369729f8ced8023412d1a57d91816d44dbb3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178661 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-17crashtesting: unable to import rtf export of forum-mso-en-14843.docCaolán McNamara
user field names have control chars in them and import from rtf hits the code added by: commit a6516c76c01b92f7d35bfb352b63af7de42b5707 CommitDate: Wed Oct 30 14:44:09 2019 +0100 writerfilter: rtftok: filter control characters so control chars are stripped out, which results in a duplicate user field name which throws. Filtering out at doc import time seems to work better, so lets do that as well. Change-Id: I463e30b223bfb5639de23c696d112eda2c27b428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178657 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-15 06:35:51 +0000