summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-23shell/wininet: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I6612d0e45b50f3b02396734b2a20a2c17e18e052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-23sw: handle TabOverflow when replacing compat optionsMiklos Vajna
This was added in commit fd886cdc6a8c047a9fb1bd10a00f901b4adb525e (n#693238: fixed docx import of tabs set after the end margin, 2011-10-31), it's off for old ODF documents, on otherwise. Change-Id: If5b132d9270c5cca888fb1e6e803958858aa76d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99253 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-23tdf#133026: Additions - Thread Execution TerminationYusuf Keten
After press the close button, the search thread will be terminated after this patch. Change-Id: Ic79928bf0604203de9497c34cb18dbd76e3f376c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99250 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-07-23Silence GCC 11 trunk -Werror=nonnull involving dynamic_castStephan Bergmann
...where the compiler now warns that the implicit this pointer argument could be null in a member function call made via a dynamic_cast-converted pointer (and where the code apparently relies on the dynamic_cast not to fail) Change-Id: I79482f4a853b6b47c5f9dd099a4e8377a19f7b0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-22sw: find & replace: fix soft hyphen cleaningMiklos Vajna
If there is a formatted soft hyphen after the search string, then replace skipped the replacement, even if there was a match. Do the same for comments & footnotes, though the primary reported problem was just soft hyphens. (The same happened when manually doing find & replace using the Ctrl-H dialog.) Change-Id: I8437e84dea99ceef98d515beef5893cf954e674f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99236 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-22split SvxFmAbsRecWin up to make a reusable pieceCaolán McNamara
Change-Id: I3c9992d39f7dd45ac354b8e4087bacfd9715b234 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22let up/down increase/decrease record numberCaolán McNamara
Change-Id: I4d77cf71640922db5865586a0d053a46834f4b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22weld form navigator label item windowsCaolán McNamara
Change-Id: I2e49ffda6dc29746819a61db2848b6bcfe5f4a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22tdf#134564 tdf#134578 Improve hierarchy viewing in InspectorShivam Kumar Singh
Significance of this patch - * Added TreeView Lines in the ui file for Inspector for better hierarchy viewing * Properties and there respective values are divided into separate columns. * Grey out disabled properties * bold PS, CS and DF Change-Id: I825a75dd2c5bc54715fe59f3c639024a5e3ab5cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98990 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-22Read contentType from "MediaType" present in the streamMike Kaganski
Change-Id: I7268205529144ab6edc9634cb0310de9886fca08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99198 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-22align label contents to flush leftCaolán McNamara
Change-Id: I75e4887e2b8fbfd94f240af260e0f4eeba53d7ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22merge duplicate GetFocus implementationsCaolán McNamara
Change-Id: Ifc2e3fab6dacb3b0bca74c0584c16170b8b97de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99234 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22move useful parts of ControlBase down hierarchyCaolán McNamara
Change-Id: I4116a3532b21f6066468bd3905efef1020ace101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99233 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22avoid intermediate bitmap causing blurringCaolán McNamara
and use incoming device as background Change-Id: I13eea4148527fa2c3552db12555ca1ca005d7799 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22fix unused ScMatrixRefNoel Grandin
from the surrounding code, these look like they should be returned since these look like bad code checks, add asserts. Change-Id: Idb1a2eb80b3357654e91bf2ad52b547421552003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22dtrans/ftransl: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I7068fd727d57258a21001d24d2f6b14fa51f9870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22tdf#130863: autoredact, disable useless checkboxes for regexJulien Nabet
Change-Id: Ic2bebfb24b8630c6135500a872eb6d6dee7935f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99227 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-22Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4366b556f493d0b2d9f5dd391164948401a4975b - tdf#130733 Fix 'Rename Bookmark' help button Change-Id: Id76665c5ddcdde6500b54d751b95a9ba020b6e2b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99247 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-22make label fill full areaCaolán McNamara
Change-Id: I01cfcb8bbb2fb189220096bdcf917937f5e8fdb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22tdf#132816: update slide "master" option buttons in tabbed uiPierre MARTY
Make AutoUpdate: - SfxBoolItem DisplayMasterBackground - SfxBoolItem DisplayMasterObjects Change-Id: I5f6bbe6cc630d74c5713ae2c0d622a74f22606b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94574 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-07-22ucb/ftp: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ic71294b1fb2afd1726e0c5948d6f088b7cdac964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22embeddedobj/msole: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I11ad7cf96d65332e418f1854803d62a30bacc7e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99163 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22ucb/package: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Id93f1e18d6646e3747443678bf3d56fa75cb46ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22tdf#131288 Chart: fix export of embedded xlsxBalazs Varga
To avoid exporting a broken DOCX, we have to seek the 'embeddingsStream', so we avoid to export an empty (0 Kb) embedded xlsx. Co-authored-by: Balázs Regényi Change-Id: I1723091aab3e2070f3db75ce866897e38021718d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99151 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-07-22tdf#81522 comphelper: just ignore disposed obj on saveJustin Luth
Even if xObj.is(), it might be disposed, and then getCurrentState() will raise an exception, resulting in an ERRCODE_IO_GENERAL, and failing to save the entire document. Although it might not seem good to just ignore an error on save, the general attitude in that function already leans that way. In fact, the other ::StoreChildren() wraps the entire for-loop in a try-catch. Also, in this function a bad xPersist also breaks out of the loop and returns a false. So wrapping the entire xObj in an "ignore if errors" try-catch seems reasonable to me in this instance. The alternative is not to allow the user to save at all, which is much worse, especially since there is nothing he can do to fix the problem. Change-Id: I0372245563735ae7ac7976bf7ce6060e57a5eb87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-07-22ucb/file: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I1650f042a87d7351a126c0701cce8b2e12829461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99221 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22Update git submodulesJoan Montané
* Update dictionaries from branch 'master' to 8cd579e3a67ab36040501138d17c647db24547a0 - tdf#133766 Updated Catalan dictionary to version 3.0.5 Change-Id: I2feda8cfb5fc2f68db2f9a582d4765e35a242f1a Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/95853 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-22ucb/neon: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ia86a4cc06819ce5820ab44d293790f7bd9a03711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22ucb/ext: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Ie2e0958e181db002d747bffd05ead02bebd96956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22[en-US] Added 13 words to autocorrectMarco Pinto
Change-Id: I0e3d18783cf0c97926d10437b4e0de834b6b0f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98463 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-22[en-GB] Added 13 words to autocorrectMarco Pinto
Change-Id: If487f3cf53487d155b8df5d2fd42c4cfb1500aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98462 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-22Fix typoAndrea Gelmini
Change-Id: I8f88c7f055534a8673e89a9bb23a3fe2e85b1dbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99215 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-07-22update svx pchCaolán McNamara
Change-Id: I311f35edbe8c1390fe471883b77c8ce35a1aa0b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22Remove obsolete dynamic exception specifications from SDK example C++ codeStephan Bergmann
GCC 11 trunk g++ defaults to C++17 now, so that CustomTarget_odk/build-examples and CustomTarget_odk/build-examples_java would now fail with "error: ISO C++17 does not allow dynamic exception specifications". 550e0e42d9ccef1244299b2d6cbda18549f8af19 "Remove dynamic exception specifications from cppumaker-generated code" had long since removed the exception specifications from the underlying (C++ classes representing) UNO interface types, so just remove them from the SDK example code, too. An alternative would have been to make sure those CustomTarget use an old C++ compiler standard. However, testing that the examples work against a new standard has probably similar merit to testing that they keep working against some obsolete standard. Change-Id: I8ec9ac2f9ced7bd1b746fb00d9bce94bf6aedda5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99218 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-22Silence GCC 11 trunk -Werror=nonnull in external/boostStephan Bergmann
...like > In file included from workdir/UnpackedTarball/boost/boost/concept/assert.hpp:35, > from workdir/UnpackedTarball/boost/boost/concept_check.hpp:20, > from workdir/UnpackedTarball/boost/boost/range/concepts.hpp:19, > from workdir/UnpackedTarball/boost/boost/range/size_type.hpp:20, > from workdir/UnpackedTarball/boost/boost/range/size.hpp:21, > from workdir/UnpackedTarball/boost/boost/range/functions.hpp:20, > from workdir/UnpackedTarball/boost/boost/range/iterator_range_core.hpp:38, > from workdir/UnpackedTarball/boost/boost/range/iterator_range.hpp:13, > from external/boost/include/boost/range/iterator_range.hpp:29, > from workdir/UnpackedTarball/boost/boost/range/as_literal.hpp:22, > from workdir/UnpackedTarball/boost/boost/algorithm/string/trim.hpp:19, > from workdir/UnpackedTarball/boost/boost/algorithm/string.hpp:19, > from external/boost/include/boost/algorithm/string.hpp:29, > from sal/cppunittester/cppunittester.cxx:61: > workdir/UnpackedTarball/boost/boost/concept/detail/general.hpp: In instantiation of ‘static void boost::concepts::constraint<Model>::failed() [with Model = boost::algorithm::FinderConcept<boost::algorithm::detail::token_finderF<boost::algorithm::detail::is_any_ofF<char> >, const char*>]’: > workdir/UnpackedTarball/boost/boost/algorithm/string/iter_find.hpp:81:13: required from ‘SequenceSequenceT& boost::algorithm::iter_split(SequenceSequenceT&, RangeT&&, FinderT) [with SequenceSequenceT = std::__debug::vector<std::__cxx11::basic_string<char> >; RangeT = const char*&; FinderT = boost::algorithm::detail::token_finderF<boost::algorithm::detail::is_any_ofF<char> >]’ > workdir/UnpackedTarball/boost/boost/algorithm/string/split.hpp:158:50: required from ‘SequenceSequenceT& boost::algorithm::split(SequenceSequenceT&, RangeT&&, PredicateT, boost::algorithm::token_compress_mode_type) [with SequenceSequenceT = std::__debug::vector<std::__cxx11::basic_string<char> >; RangeT = const char*&; PredicateT = boost::algorithm::detail::is_any_ofF<char>]’ > sal/cppunittester/cppunittester.cxx:303:71: required from here > workdir/UnpackedTarball/boost/boost/concept/detail/general.hpp:47:52: error: ‘this’ pointer null [-Werror=nonnull] > 47 | static void failed() { ((Model*)0)->constraints(); } > | ~~~~~~~~~~~~~~~~~~~~~~~~^~ Change-Id: Ia22b5d510ba41bea138dfcc8d8e0b9eb1e9ad41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-22dtrans/clipboard: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: Iba30f1cf6892330495f57343619e234194bc5b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22extensions/prop: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation. Change-Id: I89d2c8d0b2bf960b3de1853c69fa64ff41b484ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-22Removed executable permission on cxx fileAndrea Gelmini
Change-Id: I440d2dc5c2d1e38eaae124cec357f3f5f0acb65c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99181 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-22Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to da688f647b63750ed33e7fe436ac9a086df0c501 - Fix typo Change-Id: Ic8737cf620e6cd1ec64a2fb4234d0982f3724b16
2020-07-22ofz#24317 hash too shortCaolán McNamara
Change-Id: I6b2df62f0d18c6918a82a002f1e9a364c877caf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22move PatternField to toolkit headersCaolán McNamara
Change-Id: Ib75cefc6ca6a289113bac2903eb807f5d43ff3df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22weld PatternControlCaolán McNamara
Change-Id: Ie84778c2f127a6b393edbfa08e61b135ec3bcbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22tdf#134969 Add solid transparence in color gradientRegina Henschel
Converts a 'FillTransparence' percent value to a Gray color and stores it in a TransparenceGradient, so that it can be used by WriteGradientFill(). Use of third parameter rXPropSet is not possible, because it would overwrite a true transparency gradient. Causion, the property 'FillTransparenceGradient' might exist in an XPropSet of a shape with some default values. To detect, whether a gradient is actually used, you have to examine the property 'FillTransparenceGradientName'. Change-Id: Icbef599f02ebae2fcb5825fe64f546295eb78510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99145 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-07-22tdf#132911 sw_redlinehide: fix assert in CopyImplImpl()Michael Stahl
With Ctrl+A, Ctrl+X, Ctrl+V we get the bAfterTable = true case; line 4722 does pCopyPam->GetPoint()->nNode-- and then line 5085 does pCopyPam->GetPoint()->nNode++ but the problem is that nContent still points to the same node as initially while the node after the table end node is now a different one, i.e. nNode and nContent point to different nodes and something in redlining asserts becuase of that with "Assertion `m_pIndexReg == rIndex.m_pIndexReg' failed."; we don't get to step 4 anyway. (reportedly something changed with commit 4532845e22c10f252840887e55002307227b2390 but it's a mystery what that would be) Change-Id: I23744fad543e1e7bfcc11c4b488d4469ba9e509c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99166 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-07-22chart2: clean-up redundant ShapeFactory::createText()Tünde Tóth
It's needless since commit 9eb614f8d2d9cc983c51bcdde211ee0c59c3a96c (tdf#134659 chart2: use centered label alignment at text break). Change-Id: I8607cf1c85e13152bab2543a7970a77f9c72db6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98946 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-22Add explanatory commentTor Lillqvist
Change-Id: I27aeeca56817e369d6d34d3953b2942baaa63ac8
2020-07-22add get/set overwrite modeCaolán McNamara
Change-Id: I9fa9030665702f517fa5fcb22f29e52d0eda8ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-22external: update pdfium to 4203Miklos Vajna
Change-Id: Ib712fa5494e5461ef59252a0e832d43eabccbee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99157 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-22tdf#134832: Also run the BitmapTest from vclTor Lillqvist
Required some fiddling with the SolarMutex. Sadly running BitMapTest did not help finding the root cause for the bug. If you build and run UnitTest in a tree with --enable-dbgutil, you need to manually add DBG_UTIL=1 to the preprocessor macros the UnitTest Xcode project. Change-Id: I92abb6db596868c112996a93d51cc37fb6ab6541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99184 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-22tdf#98000 docx export: blank paragraphs don't affect page breaksJustin Luth
Umm, how could that ever have possibly made sense? And why wasn't it found and fixed earlier? This goes way back to when first/follow page styles were first being handled in tdf#66145, where a blank line skipped calling OutputSectionBreak. Then in LO 4.3, tdf#74566 adjusted that a bit more, and tdf#77890 decided to do the same thing for a previous blank line. These all have unit tests to "prove" it too. But none of that makes any sense, and by reverting all of that garbage, all the unit tests still pass. I also looked at the original bug documents, and they also look fine after the revert. So I think it is safe to kill this nonsense, but I don't plan to backport it, just in case... Change-Id: I4aaca0435fbf030fe9c3113b068ea3370eccd889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99171 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>