summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-27aPoint is never consumed so calculations to derive it are mootCaolán McNamara
Change-Id: I4b00fc1e3bb0f346e688d50d1ea4d1ad4dd56915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-27tdf#42982: Improve UNO API error reportingIan Barkley-Yeung
Improve error repoting in BreakIteratorImpl Change-Id: I0be64a758ed81b7a720c8b26af14de6b51cc5dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92955 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27Extract getting default locale for filters into separate unotools functionMike Kaganski
Change-Id: Ic97b1a4507d5629963f360147ecc20eb10f5d391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27vcl: add tests for GraphicNativeMetadataTomaž Vajngerl
Test the rotation in JPEG metadata is what we expect. Change-Id: I5ee2d646a5257d5695c51f37fb6fe795dcb9af50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92948 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: rename ImplCreateSwapInfo and simplifyTomaž Vajngerl
ImplCreateSwapInfo changed to createSwapInfo. Flatten the code body Change-Id: I5865373d0b7f3cc717a9600bcf6fd198e8320e35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92947 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: move content of swapOutToStream into swapOutTomaž Vajngerl
Change-Id: Iec0227b1e1ceebda961e158315ea5e56c2d33204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92946 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: move filename handling from swapout to ImpSwapFileTomaž Vajngerl
Change-Id: I30930f61385e31e7754d6653ff2eecfea61ce4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92945 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27ImpGraphic: clean-up and simplify swapOut()Tomaž Vajngerl
Change-Id: I3e578c3172fcea341a218798843cd750971a5af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92944 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-27Don't convert OUString to char*Mike Kaganski
Change-Id: I3bfcc6fedb782b12be1fb1d42981756287f29f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92956 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 14064200e02a2280c76e4de3d26d55995332eeb0 - Call it what it is Change-Id: I8ff69aee8063f8997868829291500244e2c1a6a1
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to e8f6152ad369f7cb8152b65ccb1dd7432b77d1f8 - This is an IANA media type; it shouldn’t be translatable Change-Id: I714fd9685c1bf35a2c8b3d05e2a4df07ca8f8cbb
2020-04-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 731ea5215c543caa876b2087c4303970b011d824 - Some more copyediting… Change-Id: I43d4535b5c0ea659fd19177775ad00db71a2d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/91001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-26tdf#132424 don't generate font previews in advance for loolCaolán McNamara
Change-Id: I393db7b019fe16b2b7361bd20ec99dc5671ba1ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26move PanelLayout to sfx2Caolán McNamara
Change-Id: If29ccb67835adba3ff6cf2eb53f348bbe71d6463 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92933 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26vcl: When exporing PDF, write the correct page of embedded PDFTomaž Vajngerl
We can display PDF as an graphic in the document, where the PDF is treated as a vector graphic and rendered with Pdfium. When in that case we export the document as PDF, we can insert the original PDF page as an reference XObject. This workes fine, however the PDF as an graphic also contains the page number, which page should be rendered. This was not taken into account in the PDF export - it was hardcored to first page. This extends the support so it reads the page index from the graphic, and sets the correct PDF page. Change-Id: I15188ee495f9b3fcc3aa7df6f4bad4fa09903c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92924 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26ImpGraphic: encapsulate members of ImpSwapFileTomaž Vajngerl
Change-Id: I882d30f2f27149c865160b3fa68fa974701cea71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to dacce1ab09a52f8eecee9a0651069934eb91054b - Highlight dialog objects in text Change-Id: I9a0a65988a79602bf1e43006f2266bb8ab1471ab Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92778 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-26Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 45df710ed2b840dd15c34f9a24767a50a7454861 - Fix typo Change-Id: I5b1e5f3abbd6543c0c6fc2b2051c5f9922b379e8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-26Test swapping of GraphicTomaž Vajngerl
Change-Id: I895002aa31380d2b5bc2593e66080f3fc94034e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26fix make screenshot breakageCaolán McNamara
Change-Id: Ieb2a4ee7475de2f3f0b6de6c1f3a5c305805131f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26Fix typoAndrea Gelmini
Change-Id: I12743733a35d00b5d99495b584bdb85de0175196 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92928 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-04-26Fix typo in codeAndrea Gelmini
Change-Id: I79939bbaea5730fa0c3d714103e0b1976edd2e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26Fix typoAndrea Gelmini
Change-Id: I0c0c7350b1b8c8630953cdf87146da933de757e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92869 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26Fix typo in codeAndrea Gelmini
Change-Id: I4709f3fd11c8d5800efab65b6f9533cbad3ffe78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92927 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26tdf#124176: Use pragma once instead of include guardsAndrea Gelmini
Started to fixing typo "DEFINITON"->"DEFINITION", eventually #pragma Change-Id: Ie7617b33671614b3ac09907d380f2ffdd9b68bdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92734 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26tdf#124176: Use pragma once instead of include guardsAndrea Gelmini
Started to fix typo DESCRPTION ended with #pragma Change-Id: I0a99e0d1f0696cfbf2cd54e97b8b346bbe8e7e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92925 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26update pchesCaolán McNamara
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26all ItemWindows are now weldedCaolán McNamara
where native widgetery is hostable in a vcl toolbar or a native one Change-Id: I942ada335bb4bd6ced0f3352f632e25787f68597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26Removed executable bitsAndrea Gelmini
Change-Id: I9de3a782cfd2775acfdcee5de576da7c1efe6184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92643 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-26Sifr: Fix for tdf#132404 too large Points iconRizal Muttaqin
Change-Id: I86c4b301a6111e5e8a2a5e043b48bdedfff2ca59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92922 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-26ImpGraphic: put ImpSwapFile destructor into the class bodyTomaž Vajngerl
Change-Id: Ia3f7c29bf7b84dfa8d5cc044269ed51e09c9f1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92919 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26tdf#132385: sql parser: don't drop clauses from window specificationJulien Nabet
bison rule window_specification: '(' window_specification_details ')' { $$ = SQL_NEW_RULE; $$->append(newNode("(", SQLNodeType::Punctuation)); $$->append($2); $$->append(newNode(")", SQLNodeType::Punctuation)); } ; makes it look like rule "window_specification_details" is a single node, but in reality it is a sequence of four nodes: window_specification_details: opt_existing_window_name opt_window_partition_clause opt_order_by_clause opt_window_frame_clause ; The result is that only the "opt_existing_window_name" clause was being put in the parse tree, and the other three were simply discarded. Since that will forever be a trap, and this is the only place where window_specification_details is used, we inline it into window_specification and remove it. Change-Id: I568904355174d2bc36155bde1d4dd09f57759cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92894 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-04-26ImpGraphic: rename maEx to maBitmapEx in the comment tooTomaž Vajngerl
Change-Id: Ida7ecf82d9e54d3a3703b836870534dbf41e51ba
2020-04-26ImpGraphic: rename maEx to maBitmapExTomaž Vajngerl
Change-Id: I49dd552010d008cc486c6aaf51e226cc5bf4a1cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92908 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26ImpGraphic: make magic bits for vector formats as constexprTomaž Vajngerl
Change-Id: If0caaf76feebbdc0fb9b16a3adeecf0e3e9dc295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92907 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26remove Impl from swap method names in ImpGraphicTomaž Vajngerl
Change-Id: Ie235b6d02582d4d5ee3dc3d9d2be7f022bcb13c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92906 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26remove GraphicNative{Metadata,Transform} from clang-f. blacklistTomaž Vajngerl
Change-Id: Ib60485e5d35e9d3ec2b0028d38fb8d5eaa72421c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92905 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-26use pragma onceTomaž Vajngerl
Change-Id: Ia78cc4ee565a5f39835499764b1f2d0a2a72c5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92904 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-25controllayout.hxx can be a toolkit-only headerCaolán McNamara
Change-Id: I4ad08decf432a890cdf7acf475d15210ba813f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename SvtValueSet back to ValueSetCaolán McNamara
Change-Id: I51ab96ffef7acc0d416d13ac8e380e49381f4d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25rename ColorValueSet back to SvxColorValueSetCaolán McNamara
Change-Id: I2036a8986d2d53fc97f1c7724e4e0ab837edc1ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25remove newly unused ValueSetCaolán McNamara
Change-Id: Ia2c587af9846129278caf66ab504d1a1a1ac6256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92897 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25tf#131549 No titlebar on modal dialogs on macOSNoel Grandin
regression from commit e5230535877e30c3b874495e8794faa3a42d8017 Date: Tue Mar 17 21:34:21 2020 +0200 simplify ORefVector code where a half-finished patch of mine snuck into another patch. Change-Id: I01f59a9d451f4535197d3abd7b37bfdbc8461c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-25remove newly unused SvxColorValueSetCaolán McNamara
Change-Id: Iaf7243430e50df4db84f7032eaf52728cc779c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25weld SvxColorDockingWindowCaolán McNamara
Change-Id: Iabefa16f850d3d76017adfd77fb6be30ed467887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25tdf#123292 notebookbar: vertical align for shortcuts toolbarSzymon Kłos
Change-Id: I2f2ccee9d6c01962d5d8609ea55c0c2bca6b5cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92892 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-25Typo: *Comparsion* -> *Comparison* in dbaccess/connectivityJulien Nabet
Change-Id: I9dfe37b290dbb83b1dfb2f92669ae254898ee72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-25Resolves: tdf#132143 make placeholder nodes unselectableCaolán McNamara
Change-Id: I13bcb43122f6b82114f287f13da20a584bf5f349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-25ignore mrucount if the entry was not foundCaolán McNamara
Change-Id: I4b69964fc888b18a5e3baff6a1aeec3bf23c8015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 11:24:07 +0000