summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-29loplugin:virtualdown in svxNoel Grandin
Change-Id: I953780a4b2879266c415a3c4e8992c8be74dced4 Reviewed-on: https://gerrit.libreoffice.org/52001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in vclNoel Grandin
Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f Reviewed-on: https://gerrit.libreoffice.org/51999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29Use for-range loops in include/connectivityJulien Nabet
Change-Id: I4a55fbb06f3e919cc81e3462b23f8d94f6292a9b Reviewed-on: https://gerrit.libreoffice.org/51494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-29Always pass in a TextInsertModeRangeStephan Bergmann
...otherwise testCopyPastePageStyle would have caused the call to xFilter->filter in paste() to fail, throwing an "End of content node doesn't have the proper start node" RuntimeException in SwXBodyText::createTextCursorByRange (sw/source/core/unocore/unotext.cxx) called from the writerfilter::dmapper::DomainMapper_Impl ctor (writerfilter/source/dmapper/DomainMapper_Impl.cxx) (and which would be caught and swallowed in RtfFilter::filter (writerfilter/source/filter/RtfFilter.cxx), causing it to return false). Change-Id: I83b720a365e06edc41c3d9c82614df488ee33d35 Reviewed-on: https://gerrit.libreoffice.org/52013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-29Fix typosAndrea Gelmini
Change-Id: I0f606816871d90173dedaa9fc4eb7e6ccebe0b1a Reviewed-on: https://gerrit.libreoffice.org/51919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-29Colibre icons: finish framework galaxy folderandreas kainz
Change-Id: Ibceac7c35fabc548a82ed9c086ca778608429572 Reviewed-on: https://gerrit.libreoffice.org/52041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-29Colibre icons: finalize extension folderandreas kainz
Change-Id: I2615edfeb9c7bc879bef0db74a3cc82567ac1c88 Reviewed-on: https://gerrit.libreoffice.org/52040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-29ofz#7165 set a recursion limit for svm in svmCaolán McNamara
Change-Id: Id9089986012588690b6d5e33cd71d094ef2357dd Reviewed-on: https://gerrit.libreoffice.org/51982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-29Breeze icons: add chart2 iconsandreas kainz
Change-Id: I40bc25fa6c230d5ee5b9e3af68e01d0d8ad56e72 Reviewed-on: https://gerrit.libreoffice.org/52038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-29Colibre icons: finish chart iconsandreas kainz
Change-Id: I658c1e29a468900297ccbfcfc4b1b7a2c073caee Reviewed-on: https://gerrit.libreoffice.org/52035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-28uitests for bugs tdf#71339 tdf#116215 tdf#116421Zdeněk Crhonek
Change-Id: I4533c4d8cc2742592a0f34b3cdeebee556fd1f67 Reviewed-on: https://gerrit.libreoffice.org/51785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-03-28tdf#116646 Slideshows with transitions page swap rendering issuesNoel Grandin
regression from commit 5b75a1697250d8b2b6003c37067f39270a5ad828 move cairo extract bitmap code from canvas to vcl Change-Id: Ic8d7cd9d54010ae272073877da18a985e931e22a Reviewed-on: https://gerrit.libreoffice.org/52005 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28missing ar_right icon used by starmath edit symbols dialogCaolán McNamara
it used to live at icon-themes/galaxy/res/helpimg/starmath/ar_right.png but got moved by... commit 2f6f851acab5284f516ad6a91c05149ffed575d2 Date: Wed Sep 28 07:30:35 2016 +0200 tdf#100015 (related) Move Math help icons to correct location So that they are actually packaged into the theme zip and then removed by... commit 38ded0332875a3d8ee34ddb4f2eac00d60517263 Date: Mon Dec 12 15:11:13 2016 +0100 Move help-specific images (the actual files) away from core leaving this dialog missing its arrow image Change-Id: I08127a823868d0b32b5f74bd5a7fb3fbfae95b28 Reviewed-on: https://gerrit.libreoffice.org/52023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-28No need to open this test doc read/writeStephan Bergmann
...fail when SRCDIR is a read-only tree Change-Id: I80a372b3eb71faed1215305a55df93390c846eed Reviewed-on: https://gerrit.libreoffice.org/52020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28Copy test doc to temp location before opening read/writeStephan Bergmann
...otherwise fails if SRCDIR is a read-only tree Change-Id: I0b81be5ba055dac133e5ee638f21c3c5f4d5736b Reviewed-on: https://gerrit.libreoffice.org/52015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28tdf#116407 - option "Border" for new table redundantheiko tietze
Function removed Change-Id: I2346a0ba91afb72c7c68a6d50fc103d0409ae374 Reviewed-on: https://gerrit.libreoffice.org/51896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-03-28tdf#90194 - Make Colibre the new default in Windowsheiko tietze
Fallback icon theme changed from Tango to Colibre Change-Id: I525f6d85468e5c300e1fb11ce72ba7d551d5aa4c Reviewed-on: https://gerrit.libreoffice.org/51959 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in svl/style Change-Id: Id6f8f7b09a8ae1768708d9fd5d11003fef1e2e42 Reviewed-on: https://gerrit.libreoffice.org/51798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in table Change-Id: I108136bd79dcc603649c996ecd58c74d67d7dab9 Reviewed-on: https://gerrit.libreoffice.org/51805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German function namesJohnny_M
Akt -> Current in ww8 Change-Id: I3beb046cbce7727c7ff485de9ff956ee087c443c Reviewed-on: https://gerrit.libreoffice.org/51802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in svdraw (Other occurrences will be done separately.) Change-Id: I5dc6b52678b4ce4e875f8c1aaf68e7367bf6e922 Reviewed-on: https://gerrit.libreoffice.org/51799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German variable namesJohnny_M
Akt -> Current in sdiocmpt Change-Id: I39f05bcf7168fe9fbe6cf90b2499037ec5680cc5 Reviewed-on: https://gerrit.libreoffice.org/51806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28Translate German function namesJohnny_M
Akt -> Current in ppt filter Change-Id: Id32efb885e5e1b04c7fd8f3ce0f21537b2e7576c Reviewed-on: https://gerrit.libreoffice.org/51800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-28tdf#108122 HTML export: fix lost images on copyMiklos Vajna
As in the copy part of copy&paste. The problem was that the document has an empty base URL during copy, and this was images were not exported at all. An alternative fix would be to use embedded images, but sadly Word's HTML import doesn't understand that markup, so use tempfiles instead. Change-Id: Iab8c555ac244d943c4958f24f8ac61cba4ec3aba Reviewed-on: https://gerrit.libreoffice.org/52003 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-28fix duplicate strings in notebookbarChristian Lohmaier
and also one in alreadyexistsdialog Change-Id: Ib503f742ca6e99246d1e8fc07a9d2cd418ba2133
2018-03-28Pasted-in document need only be opened for readingStephan Bergmann
Otherwise, if SRCDIR is a read-only tree, CppunitTest_sw_rtfimport would fail with the CPPUNIT_ASSERT_EQUAL(ERRCODE_NONE, pStream->GetError()); from <https://gerrit.libreoffice.org/#/c/51992/> "Check successful stream creation". (And before that, it would have more obscurely failed with the CPPUNIT_ASSERT_EQUAL(2, getParagraphs()); in testTdf90260Par failing with 1 vs. 2.) Change-Id: I55fcc932c66e6a4b84cd391f8821257a0de2abb8 Reviewed-on: https://gerrit.libreoffice.org/51993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28Check successful filter operationStephan Bergmann
Change-Id: I220905486cc2287f2157f57b537c0df0b325bd36 Reviewed-on: https://gerrit.libreoffice.org/51994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28Add mode lines and license blurbTor Lillqvist
Change-Id: Ifc319e6954665b71f8a98d6ec849a71bbf2b7318
2018-03-28Add DeleteNamedRange functionTor Lillqvist
Change-Id: I081614cb34aee704c9162f58c78dbaa6a350d30b
2018-03-28tdf#116570 ww8 export: skip sectionbreak for footnotesJustin Luth
An extra CR was added at the start of each footnote. I'm guessing these documents started life as "end of document" footnotes in Word. SectionBreaksAndFrames is only used by .doc, so this will not affect .docx and .rtf (which are both fine anyway). I forgot that I recently fixed the same problem for endnotes in tdf#108448. Nice to have found example footnote documents also. Change-Id: Ib496e02d9ff46dbc2337a6d3dfe164a625b09a83 Reviewed-on: https://gerrit.libreoffice.org/51771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-28forcepoint: fix null ptr deref.David Tardon
Change-Id: I867a4332d666bf4a0e38e93c0c7918fb106958c6
2018-03-28tdf#116563: floating windows must get input focus at some pointKatarina Behrens
This partially reverts commit bb6a8dce405bd0f and means we need a different solution for tdf#48300 on X11-based Linux frontends. Send _NET_ACTIVE_WINDOW signal only if we want to activate window that has been minimized (ToTopFlags::RestoreWhenMin) or covered by other windows (ToTopFlags::ForegroundTask). Change-Id: I529baf6cc1174728b54bae4c658cf95631da19d6 Reviewed-on: https://gerrit.libreoffice.org/51867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-28Check successful stream creationStephan Bergmann
Change-Id: Iea7dea13684a15ed1960d2c8562253f5a2e64c34 Reviewed-on: https://gerrit.libreoffice.org/51992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-28Colibre icons: add 32px shapesandreas kainz
Change-Id: Id639e80549df9f58b0ef6f9b5be24b3661d54e69 Reviewed-on: https://gerrit.libreoffice.org/51925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-28tdf#116615 WIN process messages using RescheduleJan-Marek Glogowski
Since LO message processing loop is a little more complex then PeekMessageW and DispatchMessageW, use Reschedule( true ) to process all pending events. Processing all event is important, because MsgWaitForMultipleObjects will just trigger for new messages since its call and will ignore already pending messages. Which leaves the IsMTA() call. I know of the COM STA / MTA stuff, but I don't understand how this might be related here. The call to SHBrowseForFolderW definitly block, but we already use multiple threads, so I don't understand, how this has worked before... Change-Id: Id348f26155571b3ddb31233d0bcd2c4fd2003819 Reviewed-on: https://gerrit.libreoffice.org/51940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-28loplugin:virtualdown in swNoel Grandin
Change-Id: Ia4053970a23d62ac7483f18d6caa559ddf43b176 Reviewed-on: https://gerrit.libreoffice.org/51988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28loplugin:virtualdown in xmloff/xmlsecurityNoel Grandin
Change-Id: I884fe180be98fe29ddb7d2daf4c61f733236e8bd Reviewed-on: https://gerrit.libreoffice.org/51987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28loplugin:virtualdown in sc..sdNoel Grandin
Change-Id: If93dc12f484839e6d2b44d6568b506f0c15b4735 Reviewed-on: https://gerrit.libreoffice.org/51989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28new loplugin virtualdownNoel Grandin
Look for virtual methods where we can push their definition "down" i.e. the base virtual method does not need to exist at all, because all the call-sites are calling the more specific overrides. Change-Id: Ib8e82637bfb6bc2a06df45de0e289d27344fb3ab Reviewed-on: https://gerrit.libreoffice.org/51986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Colibre icons: add 32px shape iconsandreas kainz
Change-Id: Ic2f49811506495e6cb22ec3845db11b9b630701d Reviewed-on: https://gerrit.libreoffice.org/51924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-28Add NamedRanges.py to the relevant MakefileTor Lillqvist
Change-Id: Ic2d36182795b2d27aec8fed8665d8bb9f8f12a0f Reviewed-on: https://gerrit.libreoffice.org/51975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-28Fix class name in debug messageTor Lillqvist
Change-Id: I171e74a34273ddf969e49260fec487dd8cf2fb12 Reviewed-on: https://gerrit.libreoffice.org/51981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-28Revert "Temporary hack for iOS: open files read-only if read-write open fails"Stephan Bergmann
This reverts commit bdbb0d1cc13a11c8c857ee2d387771a8c2622488. Assumed to no longer be necessary after 9906c6d2a55b6f8a27903f0ef08aa8949d7a71c2 "rhbz#1559633: Treat EPERM same as EACCES when opening files". Conflicts: sal/osl/unx/file.cxx Change-Id: I9f7ef544da3fec00810cd1d55bb52bf0470d1054 Reviewed-on: https://gerrit.libreoffice.org/51979 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-28drop newly unused HTMLMODE_NO_BR_AT_PARENDCaolán McNamara
Change-Id: I4e1c0355a10e0334439beb04c54bde24dada0dd2 Reviewed-on: https://gerrit.libreoffice.org/51960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-28sw: fix some IWYU warningsMiklos Vajna
Change-Id: I96a6401f0cc7bf9f219717671e41932d7d8570b7 Reviewed-on: https://gerrit.libreoffice.org/51972 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-28tdf#63438 Toggle highlight color to no fill if the same value is activeDaniel
Change-Id: I7553bc7bffeb0a8d1275aadc44bf2813564087b5 Reviewed-on: https://gerrit.libreoffice.org/51794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-28tdf#115005: New option to prevent adding fallback imagesSerge Krot
A new option AddReplacementImages was added to prevent addition of fallback images that could increase the file size of the package in several times. Added unit test. Change-Id: I50eebba51072d3c93bfe6bed59e9f007568810c0 Reviewed-on: https://gerrit.libreoffice.org/51939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-28loplugin:useuniqueptr in ScSortInfoArrayNoel Grandin
ScSortInfo is rather small POD object, so rather than using the heap, and doing lots of pointer chasing, just allocate them in nice big cache- friendly arrays. Change-Id: Ice7b6afc73c7f6e2af51855d38184640ef440e46 Reviewed-on: https://gerrit.libreoffice.org/51914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28use boost::optional in sc and svgioNoel Grandin
instead of using std:unique_ptr to allocate small objects on the heap Change-Id: Ifd309a9bf331910354406b827b89a0363f3b7eda Reviewed-on: https://gerrit.libreoffice.org/51945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28loplugin:useuniqueptr in ScColumnNoel Grandin
Change-Id: Iff6c68a29b9e7660132cbe4e556802b0f63706f0 Reviewed-on: https://gerrit.libreoffice.org/51904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>