summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-19improve and enable loplugin:fragiledestructorNoel Grandin
Where the problem was benign and the class was not extended, I marked the class as final. Where the problem was benign and the class was extended, I marked the relevant callee methods as final. Other cases were excluded in the plugin. Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc Reviewed-on: https://gerrit.libreoffice.org/79089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-19tdf#42949 Fix IWYU warnings in svtools/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifc70900022efcd089c0874bd46e0aacaef0efb72 Reviewed-on: https://gerrit.libreoffice.org/78767 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-19desktop: various small cleanups in lokclipboardMiklos Vajna
1) virtual is redundant when override is used 2) LOKTransferable::initFlavourFromMime() had different parameter names in the function declaration and definition 3) const-qualification on nInCount only had an effect in the function definition, not in the declaration Change-Id: I773f1f3cb5bac137a49c7e3b9ecb9b9bdf606268 Reviewed-on: https://gerrit.libreoffice.org/79111 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-18lok: send message when in place editingSzymon Kłos
Change-Id: I96d22cabeda1eb851116d556a5302394a0dd7f93 Reviewed-on: https://gerrit.libreoffice.org/73162 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 96ca927aca86b077b9914178e6c68ed0d4c0e3d1) Reviewed-on: https://gerrit.libreoffice.org/79092 Tested-by: Jenkins
2019-09-18tdf#39593 use isUnoTunnelId in sdArkadiy Illarionov
Rename SdrModel::getUnoTunnelImplementationId() Change-Id: I364a05efe8ddc04b2b2ca393416c9b974ded43df Reviewed-on: https://gerrit.libreoffice.org/79108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-18-Werror=volatile in OpenCLZoneStephan Bergmann
Recent GCC 10 trunk in C++20 mode reports issues like > include/opencl/OpenCLZone.hxx:27:9: error: ‘++’ expression of ‘volatile’-qualified type is deprecated [-Werror=volatile] > 27 | gnEnterCount++; > | ^~~~~~~~~~~~ But unlike in the case of ec17c8ec5256386b0197a8ffe5d7cad3e7d70f8f "-Werror=volatile in OpenGLZone", * it looks like there are no multi-threading issues here, and the counters are just accessed (via OpenCLZone::isInZone) from the VCLExceptionSignal_impl signal handler in addition to being modified (via OpenCLZone RAII objects) from mainline code; and * from the usage pattern of gnEnterCount and gnLeaveCount it appears that they can be combined into a single counter. (f41eb66302208f384a475fb20c98b6d1b0676cb6 "opencl: OpenCLZone, detect CL device change and disable CL on crash" presumably modelled OpenCLZone naively after OpenGLZone, without simplifying it where possible.) One minor advantage of having two monotonically increasing counters is that when they overflow, the implementation of isInZone (comparing them for equality) still gives ~useful results (assuming that a false "match" of non-overflown gnEnterCount against overflown gnLeaveCount is highly unlikely). But instances of OpenCLZone RAII objects are presumably never nested very deeply (if at all), so that the newly added "TODO: overflow" comment (which would even cause UB if std::sig_atomic_t is signed) is probably of no practical concern. Change-Id: I92e1f2c46ca996a0a86bacabcda2accba5eb6298 Reviewed-on: https://gerrit.libreoffice.org/79106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-18Related: tdf#124600 sw anchored object allow overlap: add doc modelMiklos Vajna
This is initial code to support DOCX's <wp:anchor ... allowOverlap="0"> markup as a full feature in core. Currently anchored objects can unconditionally overlap, the new bool allows opting in to prevent that. Layout is not yet using the new SwFormatWrapInfluenceOnObjPos::GetAllowOverlap(), to be done in a follow-up commit. Change-Id: I2f299571223c039741c81860ea17d42cd63140b3 Reviewed-on: https://gerrit.libreoffice.org/79105 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-18accessibility: fix leak of AccessibleListBoxEntryMichael Stahl
The problem is that AccessibleListBoxEntry from the Stylist in the sidebar are not deleted until the document is closed, which causes slowdowns because it causes an ever-growing list of window listeners. There are several issues here: * AccessibleListBoxEntry::m_aParent appears of dubious merit because SvTreeList::Move may move entries to a different parent; this member may or may not be initialised depending on where the instance is created; there are confusing comments mentioning a "Solution" but not the corresponding problem; just remove it and let it do a dynamic lookup when needed * AccessibleListBox::m_mapEntry already exists but is used in only half the places where AccessibleListBoxEntry are created; use it everywhere (consistently create entry without a parent, see previous point), and let AccessibleListBoxEntry know the AccessibleListBox instance so it can use the m_mapEntry too * When VclEventId::ListboxItemRemoved event is received, the m_mapEntry is cleared but the AccessibleListBoxEntry survive this happily; better dispose them (seeing as this event is regularly sent because there's some timer clearing the Stylist and recreating it from scratch...) Change-Id: I6c3336e019e873fa7cc8fa03cb8949a1ff2fe8fa Reviewed-on: https://gerrit.libreoffice.org/79100 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-18remove unused crc functionality from ZCodecNoel Grandin
Change-Id: I3e57e815b538ad5749b4bab3d4ef8e295cbe116b Reviewed-on: https://gerrit.libreoffice.org/79098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-18not actually using the ZCodec CRC hereNoel Grandin
so don't bother to compute it Change-Id: I62f3b4dda2ac12e2a7bff9fdf0f40b3074e33382 Reviewed-on: https://gerrit.libreoffice.org/79097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-18WIP: tdf#127235 break if object is larger than pagePatrick Jaap
We will always have an overlap if the object is larger than the whole page. Look for the next page style: if it is missing or the same as the current, we simply stop. Change-Id: I699d5146d215f17b4775dbcb32811fa5b6ebf60d Reviewed-on: https://gerrit.libreoffice.org/78696 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-18fix some incorrect column idsCaolán McNamara
Change-Id: I17575fb6b24e5e09791dbd3f15c6cda662fefe65 Reviewed-on: https://gerrit.libreoffice.org/79087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18The menu is called 'Form', not 'Forms'Andras Timar
Change-Id: I216e04bb54319cff5d790c5e223c6e49215d09a3 Reviewed-on: https://gerrit.libreoffice.org/79094 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-18tdf#39593 use getUnoTunnelImplementation in pyunoArkadiy Illarionov
Change-Id: I2cbbaad921b0a3d2ea6def4da2a2527dc4d94549 Reviewed-on: https://gerrit.libreoffice.org/79075 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-18tdf#39593 use isUnoTunnelId in dbaccessArkadiy Illarionov
Change-Id: I796d010c25e5d59f473b2b2f38736aebe16fe114 Reviewed-on: https://gerrit.libreoffice.org/79076 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-18update creditsChristian Lohmaier
Change-Id: I4d6c996cbc25053fed93ce62e261c6ae77119961
2019-09-18cui: infinite loop in SentenceEditWindow_Impl::MarkNextError()Michael Stahl
Looks like previously the aCursor never moved backwards so try to ensure the same for nCursor. (regression from 5261417cbb3051b812164838d19c0f748573df45) Change-Id: I7d2f04bbc6d1274ec4feff57927494f2eb5d665c Reviewed-on: https://gerrit.libreoffice.org/79071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-18fix column sensitivity mapCaolán McNamara
Change-Id: I14a972bef0caf8a9eef12078aadbad4f2f363a64 Reviewed-on: https://gerrit.libreoffice.org/79086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18tdf#103516 Calc: fit columns to page similarly to ExcelLászló Németh
With the page setting "Fit print range(s) to width/height", "Width in pages" > 0, and no "Height in pages" selected, apply slightly smaller zoom (~98% of the selected zoom), when this adjustment results printing fewer pages, ie. no more pages printed, than MSO. Note: a very annoying problem was that Calc printed almost blank extra pages (containing only one or a few table rows) from documents that Excel printed "correctly". Change-Id: I527f7084d22fc2ef60780492fbe24791d6ab30ca Reviewed-on: https://gerrit.libreoffice.org/79063 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-18column should be CairoSurfaceCaolán McNamara
Change-Id: Iaccc60edbb5729121b8258416a17345df2475f50 Reviewed-on: https://gerrit.libreoffice.org/79082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18Removed executable permission on filesAndrea Gelmini
Change-Id: Iea2a937559ac8393c0fb5bf9482115ba162c2a6c Reviewed-on: https://gerrit.libreoffice.org/79079 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-18-Werror=volatile in OpenGLZoneStephan Bergmann
Recent GCC 10 trunk in C++20 mode reports issues like > vcl/inc/opengl/zone.hxx:37:21: error: ‘++’ expression of ‘volatile’-qualified type is deprecated [-Werror=volatile] > 37 | OpenGLZone() { gnEnterCount++; } > | ^~~~~~~~~~~~ so look for a type that is more appropriate here (see the comment added to vcl/inc/opengl/zone.hxx for details). (Though calls like OpenGLZone::isInZone(), comparing gnEnterCount and gnLeaveCount, in OpenGLWatchdogThread::execute are still not done atomically, of course.) Change-Id: Ie5563addc65f629336f89cbccb73f7b9ac5e9870 Reviewed-on: https://gerrit.libreoffice.org/79072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-18tdf#127448 fix unit test for HiDPI displaysBalazs Varga
Change-Id: I76a1d54fb23f53b05a0fc3962a92149fe2d65742 Reviewed-on: https://gerrit.libreoffice.org/79046 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-18tdf#42949 Fix IWYU warnings in toolkit/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib49e2f29daa6d9b2a8195915c4ba10a8cef965ce Reviewed-on: https://gerrit.libreoffice.org/78722 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-18writerfilter: use '= default' to define a trivial destructorMiklos Vajna
Change-Id: I63eb9e64ce1dbacdcdaf77beb1a5a87c3a8d26e8 Reviewed-on: https://gerrit.libreoffice.org/79073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-17weld ScTpUserListsCaolán McNamara
Change-Id: I3686b038aabf0b7fa132a5172cbabb667265fe64 Reviewed-on: https://gerrit.libreoffice.org/79069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17Removed duplicated includeAndrea Gelmini
Change-Id: I2c8f8807e54b3efc5a572644c36861d69a605e0b Reviewed-on: https://gerrit.libreoffice.org/79066 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-17Related: tdf#124600 sw textbox: sync left/right margin of shape to textboxMiklos Vajna
Writer TextFrames have a default left/right margin; sync from shape to textbox is needed to have correct layout when a DOCX shape has 0 left or right margin. The left margin of the shape was already correct. (The shape in the docx file was extended to have text.) Change-Id: I832f1bc460f2553bd7f08252d3e21000b4906538 Reviewed-on: https://gerrit.libreoffice.org/79068 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-17SmartArt: separate data model from diagram.cxxGrzegorz Araminowicz
data model is having more and more code, so separate it from diagram.cxx as this file is getting too big Change-Id: I05193c518c47958d24739d97f7b6afbf821b5361 Reviewed-on: https://gerrit.libreoffice.org/79067 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-09-17WIN make sure bootstrap.ini is openend read-onlyThorsten Behrens
As fstream opens read-write by default, and obviously usually program dir content is not modifiable.. Change-Id: I16ade5a87e50c2e94d3f4df3f59fc298b40ceb7f Reviewed-on: https://gerrit.libreoffice.org/79061 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-17tdf#118544 set correct type for optional parameterTomoyuki Kubota
Change-Id: Id8840431b9dc1f1e97882c675ebfc6456e33d953 Reviewed-on: https://gerrit.libreoffice.org/77684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-17Consolidate places that manipulate OpenGLZone::gnEnter/LeaveCount directlyStephan Bergmann
(keeping the inline'd-ness of what the OpenGLZone ctor/dtor do, in case that might actually be relevant for performance) Change-Id: I411b83d1b99ed46b35857c7cca10f95dbc1c8e27 Reviewed-on: https://gerrit.libreoffice.org/79062 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17No need for explicit OpenGLZone::enter/leave calls from vcldemoStephan Bergmann
(though I have no idea how to actually test the affected code) Change-Id: Ib74d966d021e337bfab94c223812cb51c02c705f Reviewed-on: https://gerrit.libreoffice.org/79059 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17Better handling of non--UTF-8 filesystem pathnames in sal/osl/unx/Stephan Bergmann
The idea is to internally in sal/osl/unx/ use OString instead of OUString to represent pathnames, so that the OString carries the actual bytes that make up the pathname. At the boundary of translating between pathname OStrings and file URL OUStrings, translate sequences of bytes that are valid according to osl_getThreadTextEncoding() into UTF-8 and translate other bytes into individual (percent-encoded) bytes in the file URL. This change required duplicating some of the internal functionality in sal/osl/unx/ for both OString and OUString, and to make part of sal/rtl/uri.cxx accessible from sal/osl/unx/ via new sal/inc/uri_internal.hxx. Change-Id: Id1ebaebe9e7f2d21f350f6b1a07849edee54331f Reviewed-on: https://gerrit.libreoffice.org/78798 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17CppunitTest_sw_uiwriter: no need to execute on the dispatcher using stringsMiklos Vajna
This has the benefit that the dispatch happens explicitly on our frame, not somewhere else. Change-Id: Id633bab46c3dd1c3eae29b7d7a5b8669898beedc Reviewed-on: https://gerrit.libreoffice.org/79058 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-17Use CPPUNIT_ASSERT in test codeStephan Bergmann
Change-Id: I0ac21995315e136ae0035aeaf0f6a6d1e5f5811a Reviewed-on: https://gerrit.libreoffice.org/79055 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17Remove redundant clearsMike Kaganski
Change-Id: Id95a33bd7f2a89791e140bf0cb51b59c06a2c65e Reviewed-on: https://gerrit.libreoffice.org/79054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17drop some unnecessary includesCaolán McNamara
Change-Id: I4a39c393867b58179ca1fb4d3984f5d9a5d9f54c Reviewed-on: https://gerrit.libreoffice.org/79047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17tdf#126852 Bind TEXT mysql type to ClobTamas Bunth
Change-Id: I5a71666f1fafa9507032deffafebf885813a0369 Reviewed-on: https://gerrit.libreoffice.org/78815 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-09-17avoid some copyingNoel Grandin
Change-Id: I2e8da57f0fe048c3cf7288bf688f9411e62a1ffc Reviewed-on: https://gerrit.libreoffice.org/79035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-17Better fixStephan Bergmann
...for 32efe70bbfc6c64df7cf73b6a6c0976ae1e038c8 "Fix linux x86 build" Change-Id: Ic935300777fc43dfb315e1117ca7f96916cc43c6 Reviewed-on: https://gerrit.libreoffice.org/79050 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-17Related: tdf#124600 DOCX import: ignore left wrap on left-aligned shapesMiklos Vajna
The DOC import does the same in SwWW8ImplReader::AdjustLRWrapForWordMargins(). This fixes one sub-problem of the bugdoc, so now the shape anchored in the header has a correct position. This made it necessary to re-visit the tdf#115719 testcases, which are minimal reproducers. The original document had from-left alignment (instead of align-to-left), but this did not matter before. Bring the test documents closer to the original large document, so the tests still pass and don't depend on LO mis-handling the above mentioned left-aligned situation. (The interesting property of tdf115719.docx, where Word 2010 and Word 2013 handles the document differently is preserved after this change.) Change-Id: I973c13df47b0867e2c4756f0c448495257b7c9d5 Reviewed-on: https://gerrit.libreoffice.org/79049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-17sw: Mark uno property ParaChapterNumberingLevel as MAYBEVOIDThomas Viehmann
tdf#127534 TextRange.getPropertyValues runs into RuntimeException when getting all properties form PropertySetinfo We suspect that the property might be completely unused / useless. However, removing it might be BC breaking for "buggy" uses of the property, so this is a lower-risk fix. Björn helped with great advice, thank you! All errors in the patch are my own, though. Change-Id: Ie80b61003de2b8516e458c800531aac951ebc148 Reviewed-on: https://gerrit.libreoffice.org/78865 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-17No need for the string buffer hereMike Kaganski
Change-Id: I196dc9c50169108ca72f7b5e06d0bf2c2bb446d9 Reviewed-on: https://gerrit.libreoffice.org/79044 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-17OUStringBuffer use should be the other way round hereMike Kaganski
Change-Id: I0555f619253268c71187c24fa7336d44b3fe4dd2 Reviewed-on: https://gerrit.libreoffice.org/78928 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-17tdf#64222 sw: better DOCX import/export of paragraph marker formattingMichael Stahl
The problem here is that Word allows formatting the paragraph end marker, and applies the same formatting to the generated numbering string; Writer has no such marker thing. This is currently represented by an empty AUTOFMT hint at the end of the paragraph, which is created almost by accident in SwXText::finishParagraph(), because the paragraph properties are set on a SwPaM that doesn't select the whole paragraph but sits at the end. This is a bit fragile and the hint may have unfortunate accidents such as being merged into a preceding AUTOFMT hint if it happens to have the same items in it. It ought to work better to have an item in SwTextNode's SwAttrSet to store these special items; has the advantage that the items will also be copied when you split the paragraph, like in Word. Add a RES_PARATR_LIST_AUTOFMT and UNO property "ListAutoFormat" (which should be considered a first draft...) and use it in preference (where possible) or in addition to (where necessary due to other missing pieces) the empty hint. Also revert the change in checkApplyParagraphMarkFormatToNumbering() to consider hints that start before the end of the paragraph, as it has unintended side effects as pointed out by Mike Kaganski. Change-Id: Ic1d5dd9db2bab0c5e4594712bb45973aa1442da3 Reviewed-on: https://gerrit.libreoffice.org/78729 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-17disable stringbuffer pluginNoel Grandin
as pointed out by mike kaganski: the 'aCellStr + u"\x0001"' expression gives an OUStringConcat which holds the references to the strings and doesn't allocate any memory; the OUStringBuffer has a dedicated overload of append() for the OUStringConcat, which allocates only once for the combined concat length and then copies everything from the concat, instead of doing the append twice for each element... why the strange warning for a more efficient method? Change-Id: I6492e99c335e2375cfe78547a87b3079a86890f0 Reviewed-on: https://gerrit.libreoffice.org/79036 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-17weld DirectSQLDialogCaolán McNamara
Change-Id: I8f97068bb38a1fb888d60251f8f25506044c8451 Reviewed-on: https://gerrit.libreoffice.org/78970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17tdf#42949 Fix IWYU warnings in xmloff/inc/Gabor Kelemen
Also recheck include/xmloff/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If01cb2844209b119063772d829e4ae21b74fc164 Reviewed-on: https://gerrit.libreoffice.org/78747 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>