summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-14change SvxFrameDirectionItem base to SfxEnumItemJochen Nitschke
Change-Id: I82f01d0e3e4bf15ed6ba435406ae63b7c9110091 Reviewed-on: https://gerrit.libreoffice.org/35160 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14ooxmlimport: move tdf#55381 unit test to ooxmlexportJustin Luth
This test wasn't round-trippable because the page breaks were all lost, and all of the frames ended up on page 1. fixed in 5.3 daily debug bibisect 12a5c2be4d64199c6540969c645118112084a639 best guess: author Tamás Zolnai 2016-10-28 14:10:41 (GMT) best guess: commit b927c1f4b334f80d2c2965e5b7327d6b6a685105 tdf#103544: DOCX exp.: Image loss when have a frame anchored to the same para. This doc still needs some work - the frames are shifted backwards one page, so frame 1 is on page 2 and the last page contains two frames. Change-Id: I512c1d66b742b29f1a9fe8644355f3d9df5ed1f1 Reviewed-on: https://gerrit.libreoffice.org/35127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-03-14add test for tdf#106456Markus Mohrhard
Change-Id: Icf8a52db84536ef540c5dcffceabfbeb5c1deb02 Reviewed-on: https://gerrit.libreoffice.org/35153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-14try to fix webdav buildMarkus Mohrhard
Found by the "Random Condig" tb run #293. Change-Id: I8fa7b66444b9b57f289c963cb1da5e772341dc30 Reviewed-on: https://gerrit.libreoffice.org/35156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-14sc: change nDirection type to enumJochen Nitschke
Change-Id: Icaa71f99de7c97d1a9601ad00d2a6b0dbe8dae14 Reviewed-on: https://gerrit.libreoffice.org/35130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14fix typo: alreay --> already dennisroczek
Change-Id: Iabb8588a2547c925c2c959f3b4831c89935a9529 Reviewed-on: https://gerrit.libreoffice.org/35133 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14sd: fix comparison between different enum typesJochen Nitschke
found while changing base of SvxFrameDirectionItem to SfxEnumItem > warning: comparison between ‘enum SvxFrameDirection’ > and ‘enum com::sun::star::text::WritingMode’ [-Wenum-compare] Change-Id: Ide7c8193fd700f2503b05322f0d4d38f465b12c5 Reviewed-on: https://gerrit.libreoffice.org/35148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14make o3tl::strong_int constructor explicitNoel Grandin
Could have sworn I did this originally, somehow it got lost. Also fix a thinko in tools::ResId I introduced in commit 2b70fb58be039fbd05ea833a40b1b3e9f922e45c "Use o3tl::strong_int on RESOURCE_TYPE" Change-Id: Id3b39962255297010cd1feaaca6d822168311081 Reviewed-on: https://gerrit.libreoffice.org/35108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14sw: Simplify - no need to create a pointer herePranav Kant
Change-Id: I5c7d1d47f347b3ce8de6e2e4995da8724a464941 Reviewed-on: https://gerrit.libreoffice.org/35045 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-03-14starmath: Return SmBracebodyNode from DoBracebody()Takeshi Abe
to skip a push to the stack immediately followed by a pop. Change-Id: I97eb48db2521d640acec4d8080cceb56561eb901 Reviewed-on: https://gerrit.libreoffice.org/35129 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-14tdf#106456, don't try to use invalid ranges in external ref codeMarkus Mohrhard
Change-Id: I38e622df87dd4b5e37dd248c5181978e13890fda Reviewed-on: https://gerrit.libreoffice.org/35132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-13More ToolBox sal_uInt16 -> ImplToolItems::size_type clean-upStephan Bergmann
Change-Id: I6ec50033a452493852729dc8efe78da2708cbd96
2017-03-13ofz#853 oom in svmCaolán McNamara
Change-Id: Ibe41e1edb717b4e740971f4b972abdea769460eb
2017-03-13fix remainingSize for writable modified MemoryStreamCaolán McNamara
Change-Id: If8abbca4701002b7c171c19fc6ec56d3211b0cb4 Reviewed-on: https://gerrit.libreoffice.org/35145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13merge these similar buffer flushes togetherCaolán McNamara
adds an extra SVSTREAM_WRITE_ERROR check to some of them, otherwise they're all the same Change-Id: I2a4c766ff267a246a9f126fa9b7d557cfa2d66b0 Reviewed-on: https://gerrit.libreoffice.org/35144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13tdf#95416 remove ../ in #include headers of sfx2 filesJeevan
Change-Id: I5f3e1a8fe559500aec7ea9e38edaba42dff3f98b Reviewed-on: https://gerrit.libreoffice.org/35028 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-13fix fontconfig build with new glibc and gperfDavid Tardon
Change-Id: Ia89f068d93b810b0c32df5df62a582322f3e5588 Reviewed-on: https://gerrit.libreoffice.org/35142 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2017-03-13Simplify and sanitize some OSL_DEBUG_LEVEL > 2 (!) SAL_INFO codeTor Lillqvist
No point in outputting the enum class name when we know it is a value from that enum that we are outputting. Fix some random whitespace craziness. No point in putting that symbolic representation of an enumeration in double-quotes. It is not a string in any sense. We can pass an OUString directly in SAL_INFO. Be consistent, put a double-quote on both sides of the string (font family name), if at all. This is a way too verbose commit message for such a trivial change. Change-Id: I9e3f96856a634dc16f0e24f789c1898d7ec75fd9
2017-03-13WaE: Operator precedence is difficult to get rightTor Lillqvist
Fix C4806: '&': unsafe operation: no value of type 'bool' promoted to type 'int' can equal the given constant Change-Id: Iedd54379a67373fb3499a0a780f2cbfc83f08e84
2017-03-13Fix bit-rot in OSL_DEBUG_LEVEL>2 (!) codeTor Lillqvist
Change-Id: I376933a033a2dc2b5b7b59006b93d14a65463aed
2017-03-13Bin leftover debugging fprintf with reference to some mysterious 'grLog()'Tor Lillqvist
Change-Id: I6b9423db247583ff1dcbd469db5dfab7f89e7457
2017-03-13Added Test for EditEngine - Copy/Paste using Bold/Italic TextVarun Dhall
Change-Id: Ifd2fd8088590493377749866f37b1e663f97fa76 Reviewed-on: https://gerrit.libreoffice.org/34983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-13Clean up odd non-static member functions with pThis paramterStephan Bergmann
...and get member function const'ness right overall Change-Id: Idb422039108d1dde9f6a8b881f6dff742030f6f0
2017-03-13loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ide32700aab3427a8bf18c806968822cdf3f91bf2
2017-03-13Bin some noise commentsTor Lillqvist
Change-Id: Ia315f446c374ac08d8a4b7247c571b70cbbab5ae
2017-03-13ofz#846 timeout in wmf, can defer clip region if we don't do anythingCaolán McNamara
Change-Id: I8711bb5c676194d9b34df2584a31851dfcc901e6 Reviewed-on: https://gerrit.libreoffice.org/35143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13Unnecessary OUString instancesStephan Bergmann
Change-Id: I81a59c7847e2109198a35cbdb49f5bcf3505c4ba
2017-03-13Minor loplugin:unnecessaryoverride improvementStephan Bergmann
Change-Id: I3afb31b642a47e767dda0614d223b6b7f22e5d54
2017-03-13Werror=maybe-uninitialized on arm toolchainCaolán McNamara
Change-Id: If728a1da99d9146d60d15b5273a7a89764b82d51
2017-03-13mDNSResponder: fix SHA256 checksumMiklos Vajna
I guess you can only see the problem if you not only do a from-scratch build (like Jenkins does) but also empty the tarball cache. Change-Id: I1238e35abe1a6009ce0e0c3406e20aa1879c65bc
2017-03-13Resolves: tdf#105998 distort hairline borders to fall inside the canvasCaolán McNamara
if we are a hairline along the very right/bottom edge of the canvas then distory the polygon inwards one pixel right/bottom so that the hairline falls inside the paintable area and becomes visible Change-Id: Ie5713f6916cf5b47fdf14f86f034e38cda9900fd Reviewed-on: https://gerrit.libreoffice.org/34243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13Resolves: rhbz#1431540 crash in SwDBManager::releaseRevokeListenerCaolán McNamara
Change-Id: I8e61163de7e6192bdf613ab6b58906326499d6c2 Reviewed-on: https://gerrit.libreoffice.org/35137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-13force SvNumberformat::FormatterPrivateAccess for Get/SetLastInsertKeyEike Rathke
... so only SvNumberFormatter can use it, as intended. Change-Id: I91875dfd00d1f83b3ae988bda922782336489f73
2017-03-13Fix loplugin:unnecessaryoverrideStephan Bergmann
(user-provided virtual dtor in class with dependent base) Change-Id: I37b3cc3d32e76a0286ecc91f999920e3dfe706cc
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-13rhbz#1431476 dnd has started copying instead of moving slidesCaolán McNamara
Is suspect something has changed in gtk3, and I think we're not supposed to use gdk_drag_drop_succeeded at this point, but instead we'd get a dragFailed signal on the failure case Change-Id: I6b305db56a29255b468ca9182d1f7e57cb4c10f4
2017-03-13ToolBox::GetItemCommand/GetItemWindow/EnableItem take IDsStephan Bergmann
...not positions in the [0..GetItemCount()) range, so what's probably missing here is to map from positions to IDs. Code was originally introduced with 8a429819aab795e131bb2567f08cc0c2d1784624 "findbar01: enhancements for findbar". Change-Id: Ia95b65e14bb81dac940269b167434f83cefbd4d8 Reviewed-on: https://gerrit.libreoffice.org/35102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-13ToolBox::GetItemCommand/GetItemWindow take IDsStephan Bergmann
...not positions in the [0..GetItemCount()) range, so what's probably missing here is to map from positions to IDs. Code was introduced with f25cdaa78d5e7d200fbaf31cce9895bab7c5ee63 "fdo#74132: Do not interrupt search in Writer." Change-Id: I0049b76c91c8ed5a9f4051f170454fb3d49c46f9 Reviewed-on: https://gerrit.libreoffice.org/35101 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-13tdf#103931 writerfilter breaktype: same for implicit and explicitJustin Luth
MSWord normally does NOT specify "nextPage" for the sectionBreak, since that is the default type. That is imported as BreakType == -1. However, Writer ALWAYS exports the section type name, which of course is imported explicitly. **There is an import hack that treats the very first -1 section as continuous IF there are columns**. Since Writer explicitly defines the section type, these documents import differently. When Writer round-trips these types of files, they get totally messed up in Writer, although they look fine in Word. So, treat both implicit and explicit nextPage identically for bTreatAsContinuous during import. Another unit test demonstrated that headers/footers are lost when treating as continuous, so preventing that situation now also. This fix allows several import-only unit tests to round-trip. Change-Id: I37fa861d82e8da564d28d8e9089fe0f2777650fb Reviewed-on: https://gerrit.libreoffice.org/35013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-13Revert "comphelper: fix MSVC hang in ThreadPool::shutdown()"Miklos Vajna
As it causes "unopkg.bin: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/comphelper/source/misc/threadpool.cxx:96: comphelper::ThreadPool::~ThreadPool(): Assertion `mbTerminate' failed." in <https://ci.libreoffice.org/job/lo_gerrit/8283/Config=linux_clang_dbgutil_64/console> and also locally. Revert till it's clear if that assert() should be a SAL_WARN() or unopkg has to be fixed. This reverts commit 9899ffd244dd367ba69dffe1f21f4f0222064a46. Change-Id: I72902f7da410012340aa8231d84c6871a3f7b976
2017-03-13sw: prefix members of SwTableBoxFormulaMiklos Vajna
Change-Id: If96fbf097e2314303e60fd4f10ae314d12f2c468
2017-03-13fix android buildNoel Grandin
Change-Id: I960768ff98137a50da44348bffeec329295ea95f
2017-03-13ofz#837 divide by zero in metCaolán McNamara
Change-Id: I7acdea720ba29eb9b9fb3ef8e8cbc76a673d17c2
2017-03-13this is a swapCaolán McNamara
Change-Id: Iaf6310055b60da772187fdbeaca74d6eb296cfca
2017-03-13improve scopingCaolán McNamara
Change-Id: Ibb1625ff974cc1a35e5547b6ce88bf13d186d4bb
2017-03-13ofz#836 fix leakCaolán McNamara
Change-Id: Ifd818cdf81516bd449db14bb1e84ed508e4b7d96
2017-03-13templatize SvXMLEnumMapEntryNoel Grandin
in preparation for "scoped UNO enums". This is a little hacky: In order to limit the scope of this change, the templated SvXMLEnumMapEntry struct actually has a fixed size field, and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various places, to avoid carrying the type param around. Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83 Reviewed-on: https://gerrit.libreoffice.org/34987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13convert GraphicDrawMode to scoped enumNoel Grandin
Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f Reviewed-on: https://gerrit.libreoffice.org/35004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Missing NUMBERTEXT_EXTENSION_SHA256SUMStephan Bergmann
...after faef35d8653003786f9a0ea2ae1a2330fd15d632 "Move file download verification from md5sum to sha256sum". ATTENTION: A proper SHA from the source of that b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt is needed. The value substituted for now is just my local sha256sum after download. Change-Id: Id31508f10c6cd936e5c6318731ceed71bdc25f48
2017-03-13Related tdf#54443 List only matching JREsSamuel Mehrbrodt
I.e. show only 64bit JRE for 64bit LO and 32bit JRE for 32bit LO Change-Id: Id5e890637c7e1014bcb4e6fdd9ed9a33765112d5 Reviewed-on: https://gerrit.libreoffice.org/35026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-02-11 23:56:44 +0000