summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-09svx, compile error with !HAVE_FEATURE_DESKTOPjan Iversen
solved unused parameter referer in case of !HAVE_FEATURE_DESKTOP Change-Id: I64e2707ad87822ba784ed40c45801c6d101e6386
2018-03-09tdf#45904 Move _SheetLink Java tests to C++Jens Carl
Change-Id: I33813be65bcb44c11a35bc97d963057418a28d9e Reviewed-on: https://gerrit.libreoffice.org/50984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-09sw XHTML export: handle image as <object>Miklos Vajna
At least in ReqIF mode, where <img> is not part of the allowed subset. (Freeware validator for that subset is at <https://reqif.academy/library/software/consequent-command-line/>.) Change-Id: Iecc2645c5fbd35cc52096a25a797df0594b47d4f Reviewed-on: https://gerrit.libreoffice.org/51009 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09Updated coreOlivier Hallot
Project: help 0ddb36aafd052ca3a10c4a873f6a7b5ccf0f9c82 Drop undefined navigator property Change-Id: I42a37211bfc6d6e3b91061593f252feb6c38a8b6 Reviewed-on: https://gerrit.libreoffice.org/50782 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-09Updated coreOlivier Hallot
Project: help 3f82ba1d59d3bf4aa5e347f8dfb76f79ffd68bb0 tdf#72038 Improve number format recognition help Change-Id: I403d2021114f432d85dd2915ca8722c04acb50a3 Reviewed-on: https://gerrit.libreoffice.org/50976 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-09Use std::arrayStephan Bergmann
...so standard libraries in debug mode can catch out-of-bounds element acces Change-Id: I519795f5fcb51f243312e5d0247998eff6ceb151 Reviewed-on: https://gerrit.libreoffice.org/51008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-09give color picker explicit parentCaolán McNamara
Change-Id: I73e9a29abd5d767b31850e9a6b1f2b8d757ee928 Reviewed-on: https://gerrit.libreoffice.org/51000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09Bin incorrect comments, this is not "org::openoffice" but "ooo::vba"Tor Lillqvist
Change-Id: I044bb3afa1e134dd851dd30f639b475400f4ceea Reviewed-on: https://gerrit.libreoffice.org/51006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-09tdf#116101 Correct position for linespacing > 100%Szymon Kłos
Change-Id: Ia3d90d521e03ed59312d1603b2cf5e5680b00781 Reviewed-on: https://gerrit.libreoffice.org/51005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-09sw XHTML import: PNG <object> is an imageMiklos Vajna
The previous scheme was: <object data="..." type="..."> <object data="..." type="image/png">alternate text</object> </object> Support also the case when the inner <object> is standalone, like: <object data="..." type="image/png">alternate text</object> Change-Id: I2dec2770ee3c1c538bcf26f6ff12c6e8f5969563 Reviewed-on: https://gerrit.libreoffice.org/51003 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09color slider behaviour changedCaolán McNamara
since... commit db42098d99bd8648fcd7b6f669e3e5ad4142670a Date: Fri Feb 9 10:47:48 2018 +0200 use VirtualDevice in ColorFieldControl as part of moving use of BitmapWriteAccess inside of vcl/ Change-Id: Id2edd8a7f0246ff710a19ae65ddde776429dabce Reviewed-on: https://gerrit.libreoffice.org/50994 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09sw XHTML export: fix OutHTML_INetFormat()Miklos Vajna
<a> missed the namespace prefix, </a> did not. Change-Id: I8f50249170c6323d35bbeb856e10a2c93038cdbf Reviewed-on: https://gerrit.libreoffice.org/50993 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09inherit welded dialogs from a common ancestorCaolán McNamara
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42 Reviewed-on: https://gerrit.libreoffice.org/50936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09-Werror,-Wunused-parameter (Android)Stephan Bergmann
Change-Id: Ib15218f1f3bc2867ca0e8daa50a2d4edad4a9d87
2018-03-09completely remove MID_GRAFURL, replace with MID_BITMAPTomaž Vajngerl
Change-Id: I39b055760320abb2575958d525b4db3185a11d4a Reviewed-on: https://gerrit.libreoffice.org/50990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09rename aNewGraphicUrl parameter name to what it actually isTomaž Vajngerl
Change-Id: I054b02bf860fc3062fd6043e7abf30322e07a9ee Reviewed-on: https://gerrit.libreoffice.org/50991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Nitpick: public domain means no copyrightAdolfo Jayme Barrientos
Change-Id: I6c4ea78e8d80b85edc872019c68841705860806c
2018-03-09Make the CoInitializeEx() (non-)error reporting ludicrously verboseTor Lillqvist
Tell in the SAL_WARN what apartment mode the thread is in. It's a bit unclear to me why the code insists on calling this o2u_attachCurrentThread() function even in cases where it perhaps should know that it is in the main thread, which has been initialised as STA by the CoInitialize() in InitSalData(). Change-Id: Ia69e67f8b17ee153d3bcf8ae450d5f413dea2e1a Reviewed-on: https://gerrit.libreoffice.org/50985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-09ofz#6800 Null dereferenceCaolán McNamara
Change-Id: I12a0b386917af64f489706ab960f11559ac6122a Reviewed-on: https://gerrit.libreoffice.org/50988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09tdf#115867: Add colibre icon theme which follow MSO color schemeandreas kainz
Change-Id: Id09932212f348952fe9fb141dec1b5b13d727a54 Reviewed-on: https://gerrit.libreoffice.org/50989 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-09Let sysadmins disable individual file format filtersAndras Timar
It makes sense to disable a filter, as a temporary security measure, when there is a 0-day vulnerability in it. E.g., when 0-day found in AbiWord filter, this config snippet disables it: <item oor:path="/org.openoffice.TypeDetection.Filter"> <node oor:name="Filters"> <node oor:name="AbiWord"> <prop oor:name="Enabled" oor:finalized="true"> <value>false</value> </prop> </node> </node> </item> Change-Id: I8b84250c7e4aac3555877d23f58ed13a2210ebfc Reviewed-on: https://gerrit.libreoffice.org/50961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-03-09-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I0cfa88efe03e8018513e2cce49ab9db63fe976d0
2018-03-09Add eclipse project for qadevOOoSamuel Mehrbrodt
Change-Id: I4b2d6e243d65d83d32452a3720fa3d94a76b1dfe Reviewed-on: https://gerrit.libreoffice.org/50946 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-09forcepoint #21 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I0aac834a60224b33e5d33d08abd7fb056ef9d52a Reviewed-on: https://gerrit.libreoffice.org/50973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09forcepoint #20 pop on empty stackCaolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I3098c5d32d8f97dff4c620e054acde1ba1b6adf3 Reviewed-on: https://gerrit.libreoffice.org/50972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09Add classpath for qadevOOoSamuel Mehrbrodt
Change-Id: Ib900a6ee0f3da6cc5b516ec5f6e2fa57d10e37d0 Reviewed-on: https://gerrit.libreoffice.org/50945 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09chart2: change usage of MID_GRAFURL to MID_BITMAPTomaž Vajngerl
Change-Id: Ifba65af4820f6a24984f6b3f5ca4f8ecb7acaa6a Reviewed-on: https://gerrit.libreoffice.org/50983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09remove MID_GRAPHIC_URL and related mappings, implementationTomaž Vajngerl
Change-Id: I752a2f036791720d12fb04b95f53d4127d605c7e Reviewed-on: https://gerrit.libreoffice.org/50979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09sw XHTML export: handle alt text for OLE objectsMiklos Vajna
The XHTML export is now on par with the import wrt OLE objects. Change-Id: I736c1f03b0e3d8b84b8ebe08eb1b1cfa247cefbd Reviewed-on: https://gerrit.libreoffice.org/50966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-09sw: fix some IWYU warningsMiklos Vajna
Change-Id: Idb8ad6cda75b7112280ae71b4340d0187a602794 Reviewed-on: https://gerrit.libreoffice.org/50974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-09Remove warning "No DrawLayer available"Samuel Mehrbrodt
This warning appears very often in unit tests. We have similiar checks all over the place and don't emit a warning either. Change-Id: Ic1667fa51ce39e72c9a940023cc12a72458bd490 Reviewed-on: https://gerrit.libreoffice.org/50968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-09loplugin:redundantfcast look for unnecessary temporariesNoel Grandin
when calling methods that take a const& Change-Id: Idf45dfd9fea0de6fae0b1f89550f2f7fc302aa15 Reviewed-on: https://gerrit.libreoffice.org/50970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09loplugin:constantparam in vclNoel Grandin
Change-Id: I1618280494ff10d884a3285501303c6a74ef3542 Reviewed-on: https://gerrit.libreoffice.org/50951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09drop getColor() method of ColorNoel Grandin
no longer necessary Change-Id: I9e0fcea1134e8c5e27f9effbb5eb79fe5446e33d Reviewed-on: https://gerrit.libreoffice.org/50925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09tdf#116301: write correct content type for diagramDrawingAron Budea
According to MS-ODRAWXML the correct one is: application/vnd.ms-office.drawingml.diagramDrawing+xml Change-Id: If988ad234742da42634a52bbe176dbb5b763af46 Reviewed-on: https://gerrit.libreoffice.org/50980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-03-09lokdialog: run async for weld dialogsPranav Kant
Change-Id: Ieb06beada435bc47a39295acb5ea2dcef10ca454 Reviewed-on: https://gerrit.libreoffice.org/50874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-09svx: convert "ThumbnailGraphicURL" prop. to "ThumbnailGraphic"Tomaž Vajngerl
Change-Id: Id77768e6ad58c8ed7bd35478a8f0cf78ce4b1feb Reviewed-on: https://gerrit.libreoffice.org/50934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09svx: removing GraphicURL and OWN_ATTR_GRAFURL, fix writerfilterTomaž Vajngerl
Change-Id: I5b84788a324cc68e3c4561e9a7376fcb1cfeeb67 Reviewed-on: https://gerrit.libreoffice.org/50933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08Fix external/gpgmepp Linux RPATHStephan Bergmann
In other external projects using libtool, we fix that by patching configure, resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block that sets the Linux-specific value. But here we run autoreconf in ExternalProject_libassuan, so that patch in configure would be overwritten. The relevant code in configure comes from autoconf boilerplate, so we cannot just do the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec sufficiently late in configure.ac so that things still work as intended. Disable tests that would build executabes linking against libgpgme.so, which in turn links against the libassuan and libgpg-error libs, which would no longer be found by the linker because of the dropped -rpath flags. (Alternatives might be to pass in LD_LIBRARY_PATH or to link with --allow-shlib-undefined.) Change-Id: I7e37abf802d213347bd80383b7980d85cf0762d4 Reviewed-on: https://gerrit.libreoffice.org/50960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08color picker behaviour changedCaolán McNamara
since... commit db42098d99bd8648fcd7b6f669e3e5ad4142670a Date: Fri Feb 9 10:47:48 2018 +0200 use VirtualDevice in ColorFieldControl as part of moving use of BitmapWriteAccess inside of vcl/ changing the radiobutton selected used to change the contents of the color picker widget, after that point it got locked to the original contents. Change-Id: I94c730f1868efc388cba7720364bc04a666d4fbd Reviewed-on: https://gerrit.libreoffice.org/50969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-08Improve gpgmepp -> libassuan/libgpg-error lib dependenciesStephan Bergmann
...so that other executables than svidl would benefit, too Change-Id: I208ebbc04189c2f25eace19ef0875349cf63d3f0 Reviewed-on: https://gerrit.libreoffice.org/50963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08svtools: allow writing characters with HtmlWriterMiklos Vajna
The sw HTML image export already uses HtmlWriter, so need to extend this to support XHTML alternate text, writing the character data directly is not an option. Change-Id: Iac3f2b9a3828175a5f1d0fb14ab505f8de389e52 Reviewed-on: https://gerrit.libreoffice.org/50965 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08sw XHTML export: handle media type for OLE objectsMiklos Vajna
Both native data and replacement graphic. Change-Id: I2f89493e56e9d22a54aa3e4175d8b750c33d98f0 Reviewed-on: https://gerrit.libreoffice.org/50964 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08loplugin:constantparam in svtools..unotoolsNoel Grandin
Change-Id: I6e72fbe44dcb65ee5162448e9a72e6437d56b044 Reviewed-on: https://gerrit.libreoffice.org/50948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08Fix external/libassuan Linux RPATHStephan Bergmann
In other external projects using libtool, we fix that by patching configure, resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block that sets the Linux-specific value. But here we run autoreconf in ExternalProject_libassuan, so that patch in configure would be overwritten. The relevant code in configure comes from autoconf boilerplate, so we cannot just do the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec sufficiently late in configure.ac so that things still work as intended. Change-Id: Ic6c6123bcfe8bc2dac87812f919842519374abaa Reviewed-on: https://gerrit.libreoffice.org/50959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08Remove apparently unused external/libgpg-error/disable-rpath-option.patchStephan Bergmann
...which only patched configure.ac not configure, and the latter does not appear to be regenerated from the former in ExternalProject_libgpg-error Change-Id: Id0132ed8fd8ea3a5012e4a2bc309bd5f3983ad11 Reviewed-on: https://gerrit.libreoffice.org/50954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08sw XHTML export: handle replacement graphic of OLE objectsMiklos Vajna
Replacement image of OLE object in XHTML is <object data="...">, not <img src="...">. Change-Id: I244000099037869590a71bf49dd94fbf34a71e50 Reviewed-on: https://gerrit.libreoffice.org/50955 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08Make ubsan-suppressions a bit more preciseStephan Bergmann
Change-Id: I9a326da5e7c69fc4c7f21e472c1f1e2c8a260c1b
2018-03-08libgpg-error doesn't need RPATH at allStephan Bergmann
...as it doesn't link against any of our libs Change-Id: Iaf0df9d5dc5eefb976d2041f24b2921cb3e3b1ba Reviewed-on: https://gerrit.libreoffice.org/50953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08tdf#116283 oox customXml: Don't write the Relationship to DOCX files twice.Jan Holesovsky
Change-Id: Id3da40138e86c142707e377aa897df372aacb704 Reviewed-on: https://gerrit.libreoffice.org/50947 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>