summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-10-31merge these linesCaolán McNamara
Change-Id: Ic8bcfdd09c0f23e6584daf0e30c26aaccdab6fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175825 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-31cid#1607883 Overflowed constantCaolán McNamara
Change-Id: Ib01a9c72b2e5684552af22e3ef64a33358eacb9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-31Prevent 'Failed to dispatch .uno:None' messageAndras Timar
This was seen when checking grammar checker suggestion. When I click on the top element of the context menu of underlined text (e.g. Grammar error), I get warn:lok:1663798:1663791:desktop/source/lib/init.cxx:283: lok exception 'Failed to dispatch .uno:None' This .uno:None was introduced by Tamas Zolnai especially for LOK: 3616bb68f247735c46c1a4cd9568775e77be6441 His intention was to add an empty command that does nothing. Change-Id: I12a9a1e17dcf65cdd78266f44e6201ed3d5fa01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175102 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit bdb0dd485da24a95b61df6136362ab189803bc27) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175845 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2024-10-31tdf#163486: PVS: The variable was assign the same value.Bogdan Buzea
V1048 The 'bDoIncrement' variable was assigned the same value. Change-Id: Id5fd249b94429c80898e8ab1553ef32066313d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175204 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 962, 979 Change-Id: Ic31a6129828a41bd3450567ca8cb8884d60691cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175220 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 944, 957 Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 579, 584 Change-Id: Ifccc082caa5d8c13c92f3d4098f03fbf3c9782a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175215 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-31tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 981, 984, 1056 Change-Id: I5e1578341075dfb8f6699fca3f5468de1eeef70b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175212 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-31Fix typoAndrea Gelmini
Change-Id: If3d4810cb2a5770b5432c398a3785d8bdcf19ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175829 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-31Remove duplicated includeAndrea Gelmini
Change-Id: Ie69536fca492f0e8fcd8da5c167429d0f3de42ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175830 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-30sw: redline changes may try to set broadcast on non PostIt fieldsPranam Lashkari
broadcast was set from sw::UpdateFramesForRemoveDeleteRedline which triggered SwPostItMgr::Notify in that case SwFormatFieldHintWhich::INSERTED may have pField which maybe different from SwPostIt fixed regression from 0b7a9c231f66b5c2659ab3aa6a0f3c7991b9e721 problem:(in LOK) with tracked changed on delete a merge field then reject the changes LOK will crash Change-Id: Ic1fafa1408d7a238133f5b3d18bf948d539aa991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175808 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175833 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2024-10-30tdf#85976 Change label from "Handle Duplicate Records" to "Duplicates"Sahil Gautam
This is because the original label was taking a lot of space on the notebookbar. Other suggestion was 'Manage Duplicates', which didn't seem any better than 'Handle Duplicate Records' as when an icon for the command is added, it will end up taking a good amount of space. Change-Id: I852bd897d68648208102861de3d8131e103f4f14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175826 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-30Resolves tdf#74386 - Make Text Boundaries independent from non-printable charsHeiko Tietze
New option introduced under Formatting Aids to switch between full and crop marks, which was done before via NPC Change-Id: I920f68b571da740e47ae367ba1e8d28e03a131e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-30tdf#163582: Fix scrolling distance increasing geometrically.Marc Mondesir
New scroll distance was previous distance multiplied by speed factor, but distance was not reset to base values when mouse not moved (or outside app window on some platforms), resulting in continuous multiply amplification. Break out base scroll values to separate variables to prevent multiply feedback. Add comments to help future code maintenance. Change-Id: If11baff3b25521abce7436b44aaf8e6a19e54f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175657 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-10-30Don't call std::string::erase with end()Caolán McNamara
Change-Id: I64afcbe7138de7c7655a8107fd25e3ac8393a55d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175824 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-30tdf#163684 gtk3 a11y: Don't use combobox role twice for non-editable oneMichael Weghorn
Since commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue May 7 10:04:16 2024 +0200 tdf#160971 gtk3 a11y: Set role for custom editable combobox Set the combobox a11y role for the box in the .ui file used for the custom gtk3 combobox implementation. With this in place, moving focus to the "Font Name" or another editable combobox in the Writer toolbar now makes Orca announce that one as "editable combobox" rather than just "text". , the combobox a11y role is set for the GtkBox of the custom combobox implementation used for gtk3. That box contains the edit (for editable comboboxes) and the button. While this is needed for editable comboboxes for AT to identify this as a combobox when the edit receives focus (by the fact that the edit's parent has a combobox role), this resulted in Orca no longer announcing the combobox role when the button receives focus for non-editable comboboxes. While the button also has the combobox role, Orca has logic to not announce the role of combobox children. (`SpeechGenerator._should_speak_role` returns `false` for that case [1].) To avoid this problem and make announcement for both, editable and non-editable comboboxes work as expected, no longer set a combobox role for the box in the .ui file, but set it only for the editable combobox in the C++ code. [1] https://gitlab.gnome.org/GNOME/orca/-/blob/78e44c625ef5fb082907ca484230458624d24ee8/src/orca/speech_generator.py#L365-366 Change-Id: Ia3ff00688f47e61d5a98c79f1a256061b2fb18a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175823 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30Adapt to generation of .worker.js files gone from 3.1.68Stephan Bergmann
...and just unused dummies since 3.1.58, so don't install them for >= 3.1.58, even if the dummies would still be available for < 3.1.68 Change-Id: Ida55be2fa3b75982bfd764b7b2676e63c092fe79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175822 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-30Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to 8493c54bdde03bdc793b83402b9c341a5a97efac - tdf#143846 split DECIMAL() + DOLLAR() Change-Id: Iba787b44ad846fd2e7ec129fbb72bf916b23e2e9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175756 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-10-30We're not interested in using an empty replyCaolán McNamara
Change-Id: I6925879c83e188e892a375df5b295a48fb0f464d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 18e1f0e92aa20ba9c08ce553523f8a2cdec2e23d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175759 Tested-by: Jenkins
2024-10-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f833371fbfb54ba9414f127c96cd2bcb2b985a0c - Mute L10n of embedded contents. + fix bad string Change-Id: Ie84c289310923c286cc843d42ffc2c361dcd9154 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175758 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-10-30Missing test dependencyStephan Bergmann
Change-Id: I574ae3404ce4a9ad75176f2e2066563da60136ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175809 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-10-30tdf#130857 qt weld: Implement QtInstanceComboBox::set_entry_completionMichael Weghorn
Set a corresponding QCompleter [1] using QComboBox::setCompleter [2]. [1] https://doc.qt.io/qt-6/qcompleter.html [2] https://doc.qt.io/qt-6/qcombobox.html#setCompleter Change-Id: I89cdd8bee676c8a208ffe944ca84225210e842a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175819 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 qt weld: Declare support for print progress dialogMichael Weghorn
Add .ui file for the print progress dialog that gets shown when starting a print job from the print dialog (Ctrl+P) to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: I4bfdd34fcdb6d5844e04d99235fbf3ad5ef9f66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175817 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 qt weld: Add a QtInstanceProgressBarMichael Weghorn
Add a new QtInstanceProgressBar class that is the weld::ProgressBar implementation using a native Qt widget. The widget used is a QProgressBar. This will be used e.g. by the print progress dialog, for which support will be declared in an upcoming commit. Change-Id: Ic4b162014cd3a09801096cebd38dbdc923f5dbfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175816 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 securityoptionsdialog.ui Define grid children in orderMichael Weghorn
Switch the order in which the children of the "grid3" grid in the .ui file are defined so that the order matches the visual appearance, which makes sure that tab focus order with the Qt-based VCL plugins is correct as well in the "Tools" -> "Options" -> "LibreOfficeDev" -> "Security" -> "Options..." dialog. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. Change-Id: Iffba59ba04ecfd3fcb900e09ad013e6f498beff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30no need to use std::unique_ptr in GetPartialTextArrayNoel Grandin
Change-Id: I3c60f69d1693721a620faef4e1cda2f479c1bfda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175801 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-30tdf#130857 qt weld: Declare support for "Enter Safe Mode" dialogMichael Weghorn
Add .ui file for the "Help" -> "Restart In Safe Mode" dialog that asks whether to really restart in safe mode to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: Idec1c2dedd057aa2322453471c55022442941f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175807 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 qt weld: Support hiding plain text in entryMichael Weghorn
Evaluate the "visibility" GtkEntry property [1] [2] and set the QLineEdit's echoMode [3] to QLineEdit::Password if the visibility is set to false, so that replacement characters are shown instead of the actual text as expected. This is used e.g. in password dialogs, e.g. in Writer: "File" -> "Properties" -> "Security", press "Protect..." button. (But this dialog is not using native Qt widgets yet, more needs to be implemented first.) [1] https://docs.gtk.org/gtk3/property.Entry.visibility.html [2] https://docs.gtk.org/gtk3/method.Entry.set_visibility.html [3] https://doc.qt.io/qt-6/qlineedit.html#echoMode-prop Change-Id: I218e4721bbc21f3d6a3553647e92c1ea7cdc4a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175806 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 qt weld: Add a QtInstanceLevelBarMichael Weghorn
Add a new QtInstanceLevelBar class that is the weld::LevelBar implementation using a native Qt widget. The widget used is a QProgressBar. This is used e.g. in password dialogs where the level bar is used as an indicator for the password strength, e.g. in Writer: "File" -> "Properties" -> "Security", press "Protect..." button. (But this is not using native Qt widgets yet, more needs to be implemented first.) Change-Id: I4400b8d1a03e8978bc96152166dec87f8134f48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175805 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-30tdf#130857 qt weld: Declare support for Calc "Select Source" dialogMichael Weghorn
Add .ui file for Calc's "Select Source" dialog to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. This dialog is e.g. used for "Insert" -> "Pivot Table" in Calc. Change-Id: I4e9397f665f83cff099a7fb91d5e310b249be933 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175800 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#130857 qt weld: Signal when radio button gets toggledMichael Weghorn
Call weld::RadioButton::signal_toggle when the QRadioButton::toggled signal gets emitted. Change-Id: Ib9713c452fef94448a4f101a7ef6b1dc1d93966c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175799 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-30tdf#130857 qt weld: Declare support for "Security Options" dialogMichael Weghorn
Add .ui file of the "Security Options and Warnings" dialog that can be triggered via "Tools" -> "Options" -> "LibreOfficeDev" -> "Security", then pressing the "Options..." button there to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: Ife7422cb82358d91e3b2092037768231669fcab3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175798 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-30fix bug in XclExpXF::Init (tdf#163667 related)Noel Grandin
looks like a copy/paste error from commit d0f8daa0980ba8e403b32006831657c5a0a4ea17 Author: Eike Rathke <erack@redhat.com> Date: Wed Aug 22 13:16:19 2018 +0200 Resolves: tdf#73063 preserve and roundtrip LCID from/to Excel number formats Found while debugging the file in the associated bug. Change-Id: I6816290c90d6271f43416a7417cb2a0341da928c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-30win a11y: Move (Impl)InitAccessBridge logic to only callerMichael Weghorn
Now, with previous commit Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 29 15:08:37 2024 +0100 win a11y: Stop using setting to indicate AT support in place, InitAccessBridge only gets called from the Windows- specific ImplHandleGetObject. Therefore, move the logic from ImplInitAccessBridge there and drop the InitAccessBridge and ImplInitAccessBridge functions. Change-Id: Id0d08478b84434b4ec03ab72b8af40e8ad51bd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175796 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30win a11y: Stop using setting to indicate AT supportMichael Weghorn
No longer use a "Accessibility"/"EnableATToolSupport" VCL setting to control/report whether support for assistive technology is (or should be) enabled, which was primarily used on Windows. As described in previous commit Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 28 21:12:48 2024 +0100 win a11y: Drop "Enable AT Tool support" from options UI , that setting got automatically enabled when an assistive technology was active on Windows, and never got reset to "false" automatically, so AT support would be enabled next time LO starts as well. Instead of persisting this via a setting, enable the Windows a11y bridge if and when a WM_GETOBJECT message is received only, see `ImplHandleGetObject` (where this was already done earlier) and no longer alternatively start the a11y bridge in Desktop::Main when the mentioned setting is enabled. Drop MiscSettings::SetEnableATToolSupport altogether. Adjust MiscSettings::GetEnableATToolSupport to no longer read a setting, but return `true` if the AT bridge has been activated (or a SAL_ACCESSIBILITY_ENABLED environment variable is set, as was already checked before). This already returns `true` when called from MenuBarManager::FillMenuManager when starting LO while the NVDA screen reader is running. With this in place, the a11y bridge on Windows should now become active whenever an AT requests information (by sending a WM_GETOBJECT message), but not otherwise, and restarting LO will result in the a11y bridge no longer being active unless AT requests information again. Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175795 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30win a11y: Drop "Enable AT Tool support" from options UIMichael Weghorn
Drop the "Support assistive technology tools (program restart required)" checkbox from the "Accessibility" options page. It was only shown on Windows. While having this in the UI seems to suggest that this is a setting that users explicitly toggle on and off, the setting is automatically switched on when an AT is active anyway, see `ImplHandleGetObject` in vcl/win/window/salframe.cxx. Therefore, only switching explicitly off after using an AT, but no longer planning to do so any more is the only case I can think of where changing this option via the UI might have been a use case. The plan is to rework the handling in an upcoming commit instead: to enable AT support when an AT is active, i.e. in `ImplHandleGetObject`, and not persist that setting any more across LO runs. Related change for the Windows registry: commit 77e1c0bfa2e643f017b829cd775d08c5a40d9b6b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 23 12:17:02 2024 +0100 win a11y: No longer read/write registry key Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175787 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 872, 875 Change-Id: Icb311dd2ae1ab6b62bcdf141a2139e2cc6dd0564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175265 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 876, 881 Change-Id: I03f7b39a9f1d2226bf85904ffa2c4165b84b0aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175264 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 836, 890 Change-Id: If6036da666ea46a4e5c2bc0f4547c78aa43a26a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175270 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 614, 624 Change-Id: I0171d19f151719bc6faf8909d14327b63b4ac2ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175354 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 685, 689 Change-Id: I3c35e7d89699e64693c04da554136f8747fd0dde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175347 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 718, 724 Change-Id: Id39e264626634ab4288e41bd6d72303a3820a10d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175319 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-30sw/qa: use more getSwDocShell()Xisco Fauli
Change-Id: I4df04a94bb63709e43fb887972fcab9756f6233b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175797 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-30SwModelTestBase: add getSwTextDoc and use it everywhereXisco Fauli
Change-Id: I09f132a9c79f0aa4c3f4d3ca5f2fed233d0dcb06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175641 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-29cid#1607551 silence Overflowed constantCaolán McNamara
Change-Id: Id632cf7933059e54b3cae9daabd981781e944313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175803 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-29cid#1607341 silence Data race conditionCaolán McNamara
clarify that the same mutex is held for writing and reading to maUsedLines Change-Id: Ifabe8006cc1eac3cf05e9d5c4e907e79f22c3de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175802 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-29sd: lokit: add notes to presentation infoHenry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I1293a392749b6cff75be02236fb570f8faeb2446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174613 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175757 Tested-by: Jenkins
2024-10-29Related tdf#162262 - Move "Summary below data" UI tests toBalazs Varga
separate file. Follow up commit: 26c08356d1b2a963efdca570979cb04388371400 (tdf#162262 sc add "Summary below data" option for Subtotal dialog) Change-Id: I8e76fe2585993e79454f6079485f191e970e8f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175786 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-10-29tdf#130857 qt weld: Declare support for "Switch to override" dialogMichael Weghorn
Add .ui file of the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: Ib4f83af6d83e46a5bf1a816ffe7d1d494bc0b9d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175792 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#130857 cui: Move checkbox out of button boxMichael Weghorn
In the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer, move the "Do not show again" checkbox above the button box with the "No" and "Yes" buttons instead of having it inside of the button box. This aligns this with how it's done elsewhere, e.g. in the "LibreOfficeDev Help Not Installed" dialog (sfx2/uiconfig/ui/helpmanual.ui) that gets shown when pressing F1 without local help installed. It also prevents an issue with this case of a checkbox with quite some text inside a button box resulting in overlapping UI elements for the native Qt version of the dialog (once this gets enabled in QtInstanceBuilder::IsUIFileSupported). Change-Id: I005da330cca5a8d6ee468477472e0382c288b022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175791 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-02-15 10:17:59 +0000