summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-09compact namespace in i18npool..ooxNoel Grandin
Change-Id: I1de87468b56b86a1eeee09a612551ab119a1be8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09remove dead codeNoel Grandin
Change-Id: I095e9a6137ea835f6182819b55e911079925f740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09this should be Indet to indicate neither radio or check buttonCaolán McNamara
Change-Id: I360bf6b6d8fd491fc01c7f413df92d1fd916c67d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-09CppUnittest: ooxmlexport5: assert pages where possibleXisco Fauli
Change-Id: I72e222b7fb64b3262afd5b733a300bb94280ee03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93738 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09CppUnittest: ooxmlexport8: assert pages where possibleXisco Fauli
Change-Id: I7057226d46c78fb134f2eb9d439ae4e240325fa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93740 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09lok: MSForms: test & fix two corner cases of drop-down field.Tamás Zolnai
Change-Id: I2c54e2e2a94d15d42b23e04a896211936e9e1852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93845 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-09Avoid ODBC warning when testing connectionJulien Nabet
When clicking test connection for ODBC, there's this warning on console warn:legacy.osl:11208:1336:connectivity/source/drivers/odbc/OConnection.cxx:68: Failure from SQLDisconnect Some debug by adding a call to OTools::ThrowException indicates that SQLGetDiagRec returns 08003 08003 Connection not open (DM) The connection specified in the argument ConnectionHandle was not open. (see https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/sqldisconnect-function?view=sql-server-ver15) It's due to the fact that "N3SQLDisconnect( m_aConnectionHandle )" has already been called during void OConnection::disposing() Avoid the warning by testing m_bClosed Change-Id: Ie992da3582ab4d61cde35ada3f10f6a3d51d8be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09Wrong copypaste for SCHEMA in DatabaseObjectContainer.idlJulien Nabet
Change-Id: I9ce3531e240351e39fb97a390d1dc95b62955554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93840 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-09lok: replace locale name "en_US" -> "en-US"Henry Castro
Change-Id: Ic4792e35d14e2865f8bd9998b61c9024f822d454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93584 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-05-09lok: fix the window type of the metric field controlHenry Castro
Change-Id: I286be638a562e3042c1c91e40cb60a9c98938360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92796 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93071 Tested-by: Jenkins
2020-05-09Fix mapping CompositionType->EComposeRule (dbaccess/tablename)Julien Nabet
Digging in git history, I got this: commit bf7690bc1b444278bef1e355c7463d27381a8700 Author: Noel Grandin <noel@peralex.com> Date: Thu Feb 25 09:38:09 2016 +0200 convert EComposeRule to scoped enum Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9 but the bug was there from the beginning: commit ce7d8915eadfa24c27e7ae261fa222344a3f2e22 Author: Oliver Bolte <obo@openoffice.org> Date: Mon Jul 10 14:20:25 2006 +0000 INTEGRATION: CWS qiq (1.1.2); FILE ADDED 2006/05/24 06:54:32 fs 1.1.2.1: XTableName implementation Change-Id: I3f253f0fc6659d8853798ade3ad2bf2e72a8be82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93841 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-05-09lok: fix wrong metric conversion of the metric input controlHenry Castro
The client side does not work well if the browser has different locale, and the input element conversion fails or change to a different value, so the value is converted to a neutral locale. Change-Id: I89f96844603a8552609d486590c7de752cb5a95c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92395 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93069 Tested-by: Jenkins
2020-05-09CppUnittest: ooxmlexport14: Assert pages where possibleXisco Fauli
Change-Id: Ia8c9484420401dc3607c84ada375dfe063bc15cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93736 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09fix leak in svl unit testNoel Grandin
Change-Id: I8dc11da4e1de5c2e2831ac85dff0daeac0e0ce95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09CppUnittest: ooxmlexport6: assert pages where possibleXisco Fauli
Change-Id: I18d1379fc340ba16616a47501e2d6936621babe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93739 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09tdf#132783: sc: Add UItestXisco Fauli
Change-Id: I51745010d2be39ca0510213cda54031f8a0c6a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93815 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09Re-indent sanelyTor Lillqvist
Change-Id: I68e2ae23bdba5c47a9156d1fa8d2078b364c1061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93750 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-09xmloff: ODF export: adapt all checks of ODFSVER_012 etc.Michael Stahl
Most of these actually want to check ODFSVER_EXTENDED because the extension didn't get into ODF 1.3. Change-Id: I1b625a329f7a3d146c616c62c15b56e2c314c2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92872 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-09sc,xmloff: ODF 1.3: adapt XMLPropertyMapEntryMichael Stahl
Map the following property attributes to ODFSVER_013: * OFFICE-2173 table:tab-color * OFFICE-3767 text:contextual-spacing * OFFICE-3857 table:scale-to-X/table:scale-to-Y Change-Id: I3585560a3654c71353bbcaf66da20eacba8ebd1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92861 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-09lok: MSForms: add a test case about editing drop down form field.Tamás Zolnai
Change-Id: I926b322d3af3047fc72c6ee9b923bc4435111328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93661 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-09Just use initializer list for Sequence<OUString>Michael Weghorn
Change-Id: I4732e238053b8c9e6813f1bbecd6f613922cb521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93748 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-09toolkit: Use lambda instead of FindControlModel functorMichael Weghorn
Change-Id: I04cbd84196b5bf31caa4da3140dc65b1dfa20127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93746 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-09tdf#118418 implement scrollSubstringTo() for Qt & windowsSamuel Thibault
Use new accessibility scroll type compatible with IAccessible2. Change-Id: I0967d1c56425e1e860db34f4b9c17427e531fe02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93636 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-09tdf#94628: sw: allow setting for bullet for outline paragraphsVasily Melenchuk
Paragraphs in outline (having style "Header XXX") can also be a part of list and have custom bullets. Simplified code of SwXNumberingRules::SetPropertiesToNumFormat(): do not check for properties special for outline/chapters and removed redundant data shuffle with local maps. Change-Id: I1fa7f8f5359acee1d5aa62d9700641490bb91b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93672 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-08lok: MSForms: send button message also when paint area is not changing.Tamás Zolnai
We can filter out duplicated messages with storing the last message. Ignoring messages with the same paint area is a problem, if we change the drop down field content to a new item with the same size. Change-Id: Ie2e0bab445eb0e6e5b9b25846adbd79af55e7816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93732 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08lok: MSForms: fix field activation for multiple fields.Tamás Zolnai
First hide hide the button of the previously active field and show the new button afterwards. Change-Id: I6de668f25a18f8c1d3dbf66beb357f089b51ae0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93664 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08lok: MSForms: fix editing of drop-down field.Tamás Zolnai
When cursor is on the left side of the form field. Change-Id: I8587c477b6177e9309349afbbfc70979b4338275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93663 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08lok: MSForms: disable form field messages on mobile.Tamás Zolnai
Change-Id: I466c457fb0a2cbca3e7480fe8fde9833d9c35b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93662 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08lok: MSForms: dont send form field button data with empty text area.Tamás Zolnai
Change-Id: I88d793765b58a3c483aad51d1a0e2e9f0159d5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93660 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08lok: MSForms: Handle event about item selection of a drop-down field.Tamás Zolnai
Change-Id: I095013097348c98361b6614e4ddf1e9029923c7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93659 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08Revert "lok: remove sum and equal buttons from the formula bar"Andras Timar
This reverts commit c35aef260feda34eae5e4b8a39f1baaa716b717d. Reason for revert: patch applied in the wrong order, pre-requsite was not merged Change-Id: Id3ce6dbac6d9b7589b8d4dd21932b8dee8356c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93790 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-08xmloff: ODF export: rework version checks in SvXMLExportPropertyMapperMichael Stahl
There's some issues with the version checks here: * The requirement is to retain support for ODF 1.2 extended, but some attributes are in ODF 1.3, while others require ODF 1.3 extended, so a single version number can't be used to compare * A recurring problem is that new extension attributes are erroneously exported to standard namespaces; there is the pre-existing buggy case of style:hyperlink to consider... * Currently it's possible to distinguish multiple extended version but the only minimum version that's actually used is the minimum one ODFSVER_012_EXT_COMPAT Rework this to use a different check, by: * distinguishing extension attributes from standard attributes via their namespace, to avoid such bugs by construction * interpreting the version number always as a standard ODF version number: if the attribute is in extension namespace: if the minimum standard version is met, ignore else: if the minimum standard version is met, export * adapting all XMLPropertyMapEntry to use ODFSVER_FUTURE_EXTENDED for extension attributes (TODO: check which of these should be ODFSVER_013) This should have an effect on the drawext:fontwork* attributes, which need ODFSVER_FUTURE_EXTENDED to be exported now. Change-Id: I986c8064e578a61d69ed5fdb261f23e7582a7d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92856 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08sc: ODF export: table:name extension element, step 1Michael Stahl
3119de050ef5e3561e01badeb6307ae2538d215a introduced an attribute table:name on table:source-cell-range, but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to TABLE for now because existing LO releases expect that. Change-Id: Ic0e8737218473338d18b00150209bcc16678fee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92863 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08compact namespace in editeng..extensionsNoel Grandin
Change-Id: Ie93ac69592c3625b8e2e5db3619ce24597a07a7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in filter..frameworkNoel Grandin
Change-Id: Id3c2d9b1fdf9d617adea0fa1ab2fa9a2de12ef50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93727 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08tdf#114400 Export drawoo:fontwork-xyz attributesIlhan Yesil
The attributes can be read in the old and the new namespace, but will be exported only in the new namespace. Change-Id: Ia79aad425105d94d460a819eaa3e4a35ac4c73e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/59411 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08sc: ODF export: style:hyperlink extension element, step 1Michael Stahl
Commit 066bdb31f7ff801b7a36c79c43ecbd527ffb2a88 introduced style:hyperlink element but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to STYLE for now because existing LO releases expect that. Thanks to vmiklos for discovering that such link can be inserted via: ThisComponent.Sheets(0).getCellByPosition(0, 0).Hyperlink = "http://libreoffice.org/" Change-Id: Id951f4a657fefe1e4af5e1635acca7a96f90ce28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92800 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08Related: tdf#129916 svx: improve shadow size of custom shapesMiklos Vajna
There are multiple problems with this bug document, the first is that the shadow primitive got the default position (0) of the owning shape. Do it the same way as commit 6454b6336b8de9a4c5899adeab552af6f794cdc4 (tdf#130058 Import shadow size., 2020-04-14) did for graphic objects. This requires constructing a transform matrix in ViewContactOfSdrObjCustomShape::createViewIndependentPrimitive2DSequence(), include position and size in that as a start. Change-Id: Ia51df555c1984971afe7c52ba3f2658099a4e7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93771 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-08lok: remove sum and equal buttons from the formula barMarco Cecchetti
This patch removes sum and equal buttons from the formula bar in the lok case. A tentative to limit that to the mobile case has been done however the formula input bar is created before than the client view so we are not able to use the LibreOfficeKit::isMobile check. Change-Id: Icb820a0d77eb9295046997d2f3690d7f8b39680d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89453 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93342 Tested-by: Jenkins
2020-05-08CppUnittest: ooxmlexport13: assert pages where possibleXisco Fauli
Change-Id: I793d63d549ecd51a301abe064a6d7c84aa1a9d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93735 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08CppUnittest: ooxmlencryption: assert pages where possibleXisco Fauli
Change-Id: Id4a7ed5ecab048a6249444e30a38c1ffa310f96e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93733 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08xmloff: ODF export: fix style:hidden nonsense, step 1Michael Stahl
a0dcf961879ab644a52f801f65466756cb144b72 introduced style:hidden attribute, fix the obvious problems with this: * as a non-ODF attribute it should use LO_EXT namespace * import LO_EXT namespace too * comparing == ODFVER_LATEST is wrong; it already prevents exporting in ODFVER_012_EXT_COMPAT case. Don't remove export to STYLE namespace yet even though it's invalid, because existing LO releases expect that. Change-Id: I258202cc572a7c50f3b2620da3b9970d34fbf80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92730 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08xmloff: GetEarliestODFVersionForExport(-1) is impossibleMichael Stahl
Remove defensive programming nonsense to deal with situation that has apparently never been possible in git history. Change-Id: I3788cdcec5e1b4afa27e294ed91825bb33e8e633 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92729 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08replace ODFDefaultVersion usage with ODFSaneDefaultVersion...Michael Stahl
... in SvXMLExportPropertyMapper. The condition nCurrentVersion == SvtSaveOptions::ODFVER_UNKNOWN is impossible since d571a509aa324db9a425110a67ea142d157256b2. ODFVER_UNKNOWN isn't a value of ODFSaneDefaultVersion so use std::optional to handle the remaining usage. Change-Id: I1e33cb707c289224664a385b4e4425e6788b2943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92728 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08improve loplugin:referencecastingNoel Grandin
to catch a few more cases Change-Id: I0323fba51bb2b4ba255e1db5aa0d890c5c6a2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08read properly OOXML 'strips' slide transition as our SLIDEWIPELuboš Luňák
Change-Id: I584c66008e40d692021be5298cb9cdcc492eea05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93716 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-05-08implement PowerPoint 'flash' slide transition (API CHANGE)Luboš Luňák
It's like 'fade', but using white instead of black. It's a separate type in the pptx file (although I actually cannot find it in the spec OOXML, but PowerPoint 2013 generates it). The API change in XTransitionFactory should be fine, I doubt there's anything external using it. Change-Id: I3479840f265ed8227b3b8301ecff56a63d57f493 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93668 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-08lok: MSForms: Send also the drop down field params to the client code.Tamás Zolnai
Change-Id: Id42f428b7944d97d1b61a5b60d6e0807cb51cc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93658 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08tdf#132270: sw: restore unittestXisco Fauli
Removed in f9fc420dceb1ece2c98767da16a21aaff771f140 Change-Id: Ib2cc294f5efa3c1f10c43c481c9be4d1738f6fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93720 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-08Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to bb703eb529ae5b825215fd15b0be83a1c0f6409e - Add info on 'hide whitespace'. Change-Id: I2bf875c5f9705f712af5d1c150ec791798275930 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93545 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-01 13:28:18 +0000