summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-08osl::Mutex->std::mutex in UpdateRequiredDialogNoel Grandin
Change-Id: Ic4161d946190f74d016dd81aca44a7623a4e2dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-08osl::Mutex->std::mutex in SQLEditViewNoel Grandin
Change-Id: I5110342b54a3674a521d3f9b8452711650b70d0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148438 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-08BaseMutex->std::mutex in BibDataManagerNoel Grandin
Change-Id: Ieb341b37e9643474cfcbed0c0fb0d44e9f079157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-08Fix no-PCH buildMike Kaganski
Change-Id: Ie3a60558c9a459d2809883590649bee75244a8df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148453 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-08tdf#153918 svx a11y: Drop old items when switching FontCharMapMichael Weghorn
Calling `rRenderContext.GetFontCharMap(mxFontCharMap)` in `SvxShowCharSet::RecalculateFont` means that a new `FontCharMapRef` gets assigned to `mxFontCharMap`. Therefore, clear the old items based on the previous one from the map, so that new ones will be created based on the new font char map in `SvxShowCharSet::ImplGetItem` as needed instead of still returning the old ones. Adapt the a11y UI test to check again that the "!" character now has the proper accessible name. The incorrect accessible name in the special characters dialog had actually been uncovered by the initial version of the test that failed on Windows due to this, and the test was adapted to workaround that, s. tdf#153918 and the discussion in the Gerrit change adding the test [1] for more details. [1] https://gerrit.libreoffice.org/c/core/+/142260/24..26/sw/qa/extras/accessibility/dialogs.cxx#b85 Change-Id: I0ac578750b1fa0a7e63e62a6937a125c7ceab510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148423 Reviewed-by: Colomban Wendling <cwendling@hypra.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-08svx: Stop manually counting map entriesMichael Weghorn
The `nCount` member counts the number of elements in `m_aItemList`, but `std::unordered_map::size()` also returns that, so just use that instead. Use `SvxSearchCharSet::getMaxCharCount` in most places and simplify to use `std::min` in `SvxSearchCharSet::LastInView`. Change-Id: I8b66b1d83c0327026b13147f201995c7d1df1238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148422 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-08tdf#153538: blacklist GeForce GTX 1070 Ti for Skia hardware renderingJulien Nabet
Change-Id: I4ec53d9bcde229f3df3f19e952536ba64e1dc3d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148447 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-08Simplify usage of BinaryDataContainerMike Kaganski
It is always used to store data read from streams Change-Id: I613bc446eaadf98d2b1c012002d38f23d79a40ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-08Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 82b298d6f35e25961a026d848238d29d6b373709 - tdf#154034 remove xml-lang and use lc_ for icon Change-Id: I368077b40ed9924ed715a43072d064385b7ae5c5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148408 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-03-08tdf#153560 "up to level" also selects field contentsSeth Chaiklin
revise tooltip and extended tip for "level" spinbox to indicate that the "level" setting applies both to numbers and contents Change-Id: Ib54e4d6db59de346ed678f1fa7a5174f8e7d84ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148407 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-07Update Sifr Mimetype IconsGaldam
Updated Sifr mimetype icons to match new app/mimetype icons Change-Id: I4dda9bd4f342ed068bf1a10f9ffb23246685cc94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148429 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-07tdf#104315: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: Id789db24b570242928a650f6e9dedd5691f0625c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148420 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-07tdf#114773: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: Idb5edf4c3d7179eca0d1e66801aedd07712c2da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148419 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-07tdf#154042 Use an initial height of one row for toolbar layoutCaolán McNamara
so the Toolbar positions this in the same place regardless of how many rows it eventually shows Change-Id: I7ec31e50557a099962fb051a1948781ef9abdfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07tdf#153423: sw_uiwriter6: Add unittestXisco Fauli
Change-Id: I585d5ea5ac4d704ef1b303a1bf304c29023c2fba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148416 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-07lok: form controls: rendering and mouse event forwardingMarco Cecchetti
What we got - Most controls rendered on Writer and Impress (on Calc already implemented by Tomaž Vajngerl) - Text labels rendered correctly - Mouse events forwarded to controls - Control state changed on click for Writer and Calc - Control invalidation for all apps - Fixed broken LOK_CALLBACK_MOUSE_POINTER msg - Correct pointer style when mouse is hovering over a control Need to be improved - in impress click method for a control is not executed even if the mouse event is forwarded correctly - avoid not needed control invalidations (as the one occurring on document autosaving) Change-Id: I4d5012af7f90a2c726b6b6b5b068e2be1ed5568a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146569 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147320 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I86611e14a32dda3ae2226bbfa775ad0234513888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07Depend on ExternalPackage_fontconfig, not just ExternalProject_fontconfigStephan Bergmann
...so that e.g. a from-scratch `make CppunitTest_sw_core_layout` doesn't fail with > warn:sal.osl:3973661:3973661:sal/osl/unx/module.cxx:103: dlopen(workdir/LinkTarget/Library/libvclbootstrapprotector.so, 257): libfontconfig-lo.so.1.12.0: cannot open shared object file: No such file or directory > Failure instantiating protector "workdir/LinkTarget/Library/libvclbootstrapprotector.so", "vclbootstrapprotector" (This is LINUX-only, as ExternalPackage_fontconfig has been introduced as LINUX-only by d552b4a549d614a03aa9328e017dec27bd3ff41e "Enable opening of downloaded fonts only in ForKit in Online": "All this is relevant for Linux only, as Collabora Online runs on Linux.") Change-Id: I8976726ee8080f91a0fa97d60b8f345c48cae686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148381 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-07tdf#94079 sc_ucalc: Add unit testSupriyo Paul
Change-Id: I2254d924acd05d2322068b7b8df229328dcf21f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148385 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-07improve variable nameNoel Grandin
until commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value it served two purposes, now it serves only one, so rename it to reflect that. Change-Id: Ifc4f9361fd562cc6c572cdc3ad90151d87f41501 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07sw: fix crash in GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid()Miklos Vajna
Crashreport signature: program/libswlo.so SwFlowFrame::GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid() const sw/source/core/layout/flowfrm.cxx:1741 program/libswlo.so objectpositioning::SwAnchoredObjectPosition::GetTopForObjPos(SwFrame const&, SwRectFnCollection* const&, bool) const include/svl/itemset.hxx:101 program/libswlo.so objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition() sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx:1020 program/libswlo.so SwAnchoredDrawObject::MakeObjPosAnchoredAtPara() sw/source/core/layout/anchoreddrawobject.cxx:424 Change-Id: If162602f6a1cc2108c0de385652e93e23be920be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148391 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-07tdf#152278 a YoavKtav Black font reported as claiming its name is in 0x4800 ↵Caolán McNamara
encoding Change-Id: Ie1f190cd4e550a21b5614d565b03422332594ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148417 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I56f00947c92c7b092dee534a6eecf6caedbafa2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07tdf#153699 workaround cairo 1.17.8 problemCaolán McNamara
Change-Id: I5290dd93d06a6812acf97fe0eeec581a233a898c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07tdf#154039 wina11y: Increase refcount for returned COM interfaceMichael Weghorn
The reference counter for the IUnknown interface of the COM object needs to be increased in `CMAccessible::get_accSelection` as well, not just in the called `CEnumVariant::Next`, because calling VariantClear` on the temporary variant afterwards decreases the ref count again. Regression from commit 00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Jan 31 07:41:14 2022 +0000 tdf#147083 wina11y: Return a11y object instead of child ID Change-Id: Id968c3d80b38961b836fbb1a9bd6dfeefdff813f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148393 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-07Drop the LibreOfficeKit paintThumbnail() APITor Lillqvist
It turns out that Mert's original idea is actually the simplest and it is known to work. And in that, the separate paintThumbnail() is rather pointless, as all paintThumbnail() did was to call paintTile(). The caller (in Collabora Online) knows when a file is opened specifically for thumbnailing, and can call paintTile() itself with the appropriate parameters. My misguided idea would have had paintThumbnail() somehow figure out the physical Twip coordinates of the current location (for text documents, the insertion caret location) in the document. (Or, as LibreOfficeKit for some reason calls them, "logical" coordinates, even if a Twip is a very physical length unit.) Then it would have called paintTile() with those coordinates. But it turned out to be rather hard to figure out the Twip coordinates of the current location in the document. Mert's idea was that when a document is opened for thumbnailing, only Online actually needs to know that. From LibreOfficeKit's and core's point of view it is a normal document load operation. Then Online performs the .uno:OpenHyperlink magic, which makes core move the current position to the requested "target" or "mark" (the terminology varies) location. And then a "cursor" callback is used by Online to get the Twip coordinates of the target. It is a bit unclear to me whether .uno:HyperLink causes the document to be opened an extra time, but whatever, this way is said to work. So let's do it like that. This reverts the paintThumbnail part of 1aa37ca99112c0760552600d7774ba7224581c5b. Change-Id: I8f3d9917ee362c1518834fc10a57c57ebc4a6edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148390 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-03-07tdf#154034 correction to tooltips "outline" -> "index"Seth Chaiklin
Change-Id: Ic8024be1615103c2b367ff0b90cae42e38c4654f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148328 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-07Resolves tdf#153344 - Resize Save icon in statusbar to 16pxHeiko Tietze
16px instead 18px to comply with the other icons Change-Id: Ic7e3531c30f1af75b38416a94acc2e7ea16c3ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148350 Tested-by: Jenkins Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-07Improve flow of logic in SwAnnotationWin::ToggleHdlNoel Grandin
and rename the IsProtected method to more accurately reflect what it returns. Certainly the initial flow of logic in this method was very confusing. Change-Id: I4a01c00160a896961fcce97831605d3a6e15cd1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07clang-tidy dead-storeNoel Grandin
Change-Id: Iad8dd9081966193090b0929169da199b47f949a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07Typo in commentHeiko Tietze
Change-Id: Iadf080cfae051116add064f8ac3e7d13079effb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148351 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I44d60e9fca03ce6709551a660661dd2a6778fd7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07Fix Doxygen comment thinko: dumpState() is in lok::Office, not in lok::DocumentTor Lillqvist
Change-Id: I87626370fdd8cbe906ed31d1b8c92234696e9708 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148414 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: Ibfa1bc474a2dfc9bf117f8963b52ffbd74b91dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148379 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: Iebbe17f114b098337305d4f8f5c3835be4744c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07jsdialog: don't close dialog on tab page destroySzymon Kłos
was closing the whole dialog on tab switch in Format -> Characters -> Highlight when switching to "None" also avoid sending multiple "full updates" by using the same builder for sending message Change-Id: I4540c9c857acf2b9f40482678a30335edc24e7cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148314 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-07tdf#153243 amend labels for Heading Numbering; polish tooltips/extended tipsSeth Chaiklin
also, change "chapter" -> "heading" in tooltip for Separator in AutoCaption, and add tooltip for Separator in Caption Options Change-Id: I45bdc5381d6a5459ba64565b3064a7642bdbc0cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147594 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-07jsdialog: enabled format Character dialog (calc)Pranam Lashkari
can be found from: Tabbed view > Format > Character Compact view > Format > Character Change-Id: I80c15237a29ef19303c71101965df9a18791cb4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148243 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-07Fix a bug parsing pdf arraysJaume Pujantell
The parser ignored number elements in some situations, like before a reference element. This manifested in creating an invalid pdf file when exporting as pdf a document that contains a pdf. Change-Id: I98625c8da8631056079814f7e824f36177cf41c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148198 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-03-07Avoid running graphics tests when in lok mode.Michael Meeks
Best to avoid allocating and freeing 64Mb of RAM, and burning lots of CPU doing CPU rendering on an invisible for each document loaded through lok API. Change-Id: I656b400159b9d6a7a9f2c79d188e3aec9b3dd0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148258 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2023-03-07Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f205cf12787f7a601a75a8acd4ddd13b064f686e - tdf#154034 add icons and update procedure refactor to <h1>,<h2> Change-Id: I89df34df481a5438bcc90e12534790f2ef78f3ab Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148329 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-07Drop VectorGraphicDataArrayMike Kaganski
Change-Id: If444317edf35d0627c6bc3a8c36ba973a8a0af8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148371 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-03-07Resolves tdf#153933 - Minor adjustments to EntryMessageTypeHeiko Tietze
Red adjusted to follow the standard palette and yellow to have the same saturation Change-Id: Ic40a37c77862471066a8575d4b22cc18dc6edac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148348 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-07sw floattable: grow the print area as well in SwFlyFrame::Grow_()Miklos Vajna
The bugdoc should be of 3 pages, but the last for of the floating table went to the 3rd page. The reason for this was that SwTabFrame::MakeAll() calculated nDistanceToUpperPrtBottom, then determined that the upper has to grow, and called GetUpper()->Grow(LONG_MAX, /*bTest=*/true). Now this growth was less than what would be possible, because a previous invocation of SwFlyFrame::Grow_() increased the frame area (with margins) but not the print area (with margins). This meant that the frame can't grow too much because its frame height is already 7044 twips but its print height is only 548. This combination of "not enough inner space" and "can't grow too much, either" resulted in moving the last row to an unwanted 3rd page. Fix the problem by not only increasing the frame height but also the print height in SwFlyFrame::Grow_(), this keeps the last row on the 2nd page, like Word does. Change-Id: I7850b54b030c42034e0a117d52d2148fa6ba2f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148373 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-07Remove mention of apr and apr-util from NOTICE cause we don't use them...Andras Timar
since commit f45b7871e7d31dfc6ed31d1b79928990bba0d0dd Author: Michael Stahl <michael.stahl@allotropia.de> Date: Tue Dec 14 16:03:46 2021 +0100 ucb: remove --with-webdav=serf Remove code in ucb/source/ucp/webdav, and now unused externals apr, apr-util, serf. Change-Id: Idfb1f921c0d048f18f23263c04ac718ca1c95ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147886 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-03-07sw: document SwFrame::MakePos()Miklos Vajna
I.e. the simplest SwLayoutFrame::MakeAll() mostly just calls MakePos() and Format(). Change-Id: I13d37c2bddfdd57503c1de974e34acd004e57195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148360 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-07tdf#153396 - Bibliography marks improvementsVojtěch Doležal
Adds option to separate function of "URL" into (listed) "URL" and "Target URL" to allow for more flexibility (in that case if target URL is empty, bibliography mark hyperlink leads to bibliography table row if possible) When writing tests also found and fixed bug where exporting new file with anchor link bibliography mark crashes LO. Change-Id: Ic1b5c8c9590c0338dcfc4fa3a981142bddae0113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147868 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-07eFormat modified inside GetDateArea, but change not propogated to the callerCaolán McNamara
regression from: commit 6e7e19d9c300dbdd279789b09f94781e946fad52 Date: Wed Jul 15 12:10:32 2020 +0100 weld DateControl Change-Id: I74bc01383f04fd4e54a45058fbbc3bc082eef0e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07remove dead code in X11SalFrame::SetIconNoel Grandin
ever since commit a11cabb47249257d8b6510fe91063ade03d0c636 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jan 11 12:22:17 2023 +0000 rely on support for NET_WM_ICON found by clang-tidy dead-code Change-Id: I4b762361a7937d087dab8c5cb0f57131ce3650d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07clang-tidy dead-storeNoel Grandin
Change-Id: Id7c48e995b4f92f081fbd4d1af257e1b81e6a421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>