summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-22tdf#119360 - Inconsistent labels protect/protectedheiko tietze
Insert/Edit section dialogs use now the same label Change-Id: I9726c5e90d25d7b1285be53f6a365ae0eb017bdc Reviewed-on: https://gerrit.libreoffice.org/59460 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-08-22Resolves: tdf#98558 oom under windows with certain chartsCaolán McNamara
keep the performance fix of i#66963 but clip it to a value larger than appears in that document, but massively smaller than what is necessary for this document Change-Id: I162c03a13ce11e348db8168fed212dfea216c7a4 Reviewed-on: https://gerrit.libreoffice.org/59458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22loplugin:useuniqueptr in SwSdrUndoNoel Grandin
Change-Id: I848f889f34dd7d3ffd83ff0cf209de8e69bbfeae Reviewed-on: https://gerrit.libreoffice.org/59447 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in SwTextLineNoel Grandin
Change-Id: I3c3cdf14d8d86028c452e190dea5fa1bb3da0cbb Reviewed-on: https://gerrit.libreoffice.org/59443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Resolves: tdf#73063 preserve and roundtrip LCID from/to Excel number formatsEike Rathke
Change-Id: I8e3e5ef5873af108596b387e8900d038e3942981 Reviewed-on: https://gerrit.libreoffice.org/59441 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-22Resolves: tdf#118799 use spelling/search dialog as message dialog parentCaolán McNamara
when visible Change-Id: Id4d6df2a85aebd6887949f285e1a5ec1046dbf64 Reviewed-on: https://gerrit.libreoffice.org/59456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22Resolves: tdf#119259 reused in-use SdStyleSheet removed by undoCaolán McNamara
since... commit a4cd841541a729d7b8126d27d91fa28e30b01403 Date: Thu Feb 13 16:10:47 2014 +0530 n#757432: Styles (rename &) copy to different decks. While copying slides to different slide decks, styles were not being copied if there is already one with the same name. This patch renames and copies those to keep the formatting intact. if a SdStyleSheet is not freshly created, but reused, it ends up in the rCreatedSheets list, and so when the copy is undone (via SdMoveStyleSheetsUndoAction), the SdStyleSheet is unconditionally remove from the StylePool and so its ref count hits 0 and is removed, even though there are still objects depending on it. the problem becames more common since... bash-4.4$ git show 57db6e24b5ad43d447c30e44a112c74c7e75b46b commit 57db6e24b5ad43d447c30e44a112c74c7e75b46b Date: Tue Aug 15 02:51:07 2017 +0530 Removing old SfxItemSet::getHash usage improves the SfxItemSet comparison. Assuming that its correct to leave SdStyleSheetPool::CopySheets with those reused SdStyleSheets in the list, change things so that a flag is passed around to indicate if the SdStyleSheet should be removed or not by undo Change-Id: I82b5bd93183fd1ff9e67957ccfb5babef81fd36d Reviewed-on: https://gerrit.libreoffice.org/59432 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22gbuild: Unconditionally compile as C++17 with MSVC 2017David Ostrovsky
Change-Id: Icb7161bb140cb2ffbf36f56839a2889d9eb2660c Reviewed-on: https://gerrit.libreoffice.org/59445 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-08-22fix oss-fuzz buildCaolán McNamara
Change-Id: Idec87abc7c7ec030e299a5dd582d6c1c44ae1a32 Reviewed-on: https://gerrit.libreoffice.org/59440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22pt_PT autocorrect - added 21 new words.Marco A.G.Pinto
Change-Id: I59793df3b2424661c92c0015444b12b7b4abeb94 Reviewed-on: https://gerrit.libreoffice.org/59378 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-08-22vcl: README claims VCL expands like Borland's VCL, not StarOffice'sMichael Stahl
Change-Id: I41b013dc3666dc990b63f1de34fe80fcc129ecc8 Reviewed-on: https://gerrit.libreoffice.org/59455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-22loplugin:useuniqueptr in ScChartListenerNoel Grandin
Change-Id: I0504bcd57a85b91ae2f4a5fa931f90f776f0fd46 Reviewed-on: https://gerrit.libreoffice.org/59446 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in ScLookupCacheMapImplNoel Grandin
and simplify Change-Id: Ic5ec97680349a1ea837891b2300dff05cd00026f Reviewed-on: https://gerrit.libreoffice.org/59431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Fixed LongDateYearSeparatorMatthias Seidel
(cherry picked from commit ba13ae2c5b626b6e5ccd27c9f88e8e4dcc79729c) Change-Id: I408e1294a3c25d8b8fc036f40f754c20cfbe1653 Reviewed-on: https://gerrit.libreoffice.org/59426 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-22loplugin:useuniqueptr in SwContourCacheNoel Grandin
and simplify, std::vector is easier than keeping an array and our own count Change-Id: I8662063e7914a2f7dacd40f7c20dd1f924ea70dd Reviewed-on: https://gerrit.libreoffice.org/59433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in sd::Outline::IteratorNoel Grandin
Change-Id: I5f8281efb09c1da7c12e80d2522b89bbd400c3f7 Reviewed-on: https://gerrit.libreoffice.org/59435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22new loplugin:conststringfieldNoel Grandin
Look for const string fields which can be static, and mostly convert them to OUStringLiteral And add a getLength() method to OUStringLiteral to make the transition easier. Remove dead code in XclExpRoot::GenerateDefaultEncryptionData, default password is never empty. Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091 Reviewed-on: https://gerrit.libreoffice.org/59204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in StringResourceImplNoel Grandin
Change-Id: I399836e9177038dde03ec7435e549094e4d3dd04 Reviewed-on: https://gerrit.libreoffice.org/59437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in chelp::DynamicResultSetNoel Grandin
Change-Id: If9ffa025ba0ce9a1c97c89ec50e71e7f90c5435b Reviewed-on: https://gerrit.libreoffice.org/59436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Related: tdf#73063 strip a plain locale identifier if locale data is availableEike Rathke
Change-Id: Ie34f6c34fe4415489026203fe7d7b1f32a2bb5dc Reviewed-on: https://gerrit.libreoffice.org/59398 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-22tdf#119118 convert tmAbs value to second.Mark Hung
setInterval() of IterateContainer actually need second instead of percentage of the duration, we just need to convert tmAbs in millisecond to second to make iterate interval correct. Change-Id: I1dfc3c64187eb5b7fd8f0b6a91f41dc55466b58b Reviewed-on: https://gerrit.libreoffice.org/59412 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-22Deleted whitespace, fixed typos and spelling errorsMatthias Seidel
(cherry picked from commit 16c6c9fbce5112869d554ca1f346f7c8f1bcc024) Change-Id: I61f469100dc49fe9c00171b59c3390834bb3af78 Reviewed-on: https://gerrit.libreoffice.org/59425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22arg is never nullCaolán McNamara
Change-Id: Ifde85786e9e0b0d9c1bdb1163b7c4a0889005323 Reviewed-on: https://gerrit.libreoffice.org/59386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22pass X11SalGraphics around by std::unique_ptrNoel Grandin
Change-Id: Id2fcf829e3ca0edcfcdd3d4daf31188ae5317b27 Reviewed-on: https://gerrit.libreoffice.org/59427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Adapt Library_vclplug_kde5 to f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044Stephan Bergmann
..."loplugin:useuniqueptr in SvpSalInstance" Change-Id: I6f3f7c102fcf07f552d3256553dd39e9cd54005f
2018-08-22Update git submodulesAndras Timar
* Update helpcontent2 from branch 'master' - Add 'Indonesian' to language dropdown list Change-Id: I8c2fe09b6c774363252e69117c13ee29470528e7 Reviewed-on: https://gerrit.libreoffice.org/59429 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-08-22loplugin:useuniqueptr in ScDBQueryDataIteratorNoel Grandin
Change-Id: I53b458c39ec6fd8b64110d9cdd1ccbd9f850dc08 Reviewed-on: https://gerrit.libreoffice.org/59361 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Fix typosAndrea Gelmini
Change-Id: I8a25a3d7928cca12b0f5c86701fe86b76b85249f Reviewed-on: https://gerrit.libreoffice.org/59414 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-22Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - minor corrections to Edit Fields page Change-Id: I04e54d3edd10540e730f9049ffd8b9361c7775a5 Reviewed-on: https://gerrit.libreoffice.org/59419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22offapi: correct description of IterateInterval.Mark Hung
Correct the description in com/sun/star/animation/XIterateContainer. Both sd and xmloff take the value of the interval as second when invoking setIterateInterval() and getIterateInterval(), so does the slideshow. Referring to the duration of the container is only implmented in UI level and is not related to API. Change-Id: Ieb86c5b2b99c7a58314241ed62f273ba424e9962 Reviewed-on: https://gerrit.libreoffice.org/59409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22fix android buildNoel Grandin
after commit f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044 Date: Sun Aug 19 08:53:29 2018 +0200 loplugin:useuniqueptr in SvpSalInstance Change-Id: I0479139c28b88c049a4584c825a28217fa20b7c0
2018-08-22tdf#118261 package libnumbertext data files into installation setsChristian Lohmaier
Change-Id: I1d4bfc9de274df2b467614fba7639e7f5a653377 Reviewed-on: https://gerrit.libreoffice.org/59421 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-08-22lokdialog: Convert the SideBar->Animation->Effect Options to async exec.Noel Grandin
and move the ownership of the propertyset, so it lives as long as the dialog (which appears to fix a double delete here as a bonus) Change-Id: Iaff931a048211ae8453cc8955344453abdd3f4ab Reviewed-on: https://gerrit.libreoffice.org/59399 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in SwFieldPortionNoel Grandin
Change-Id: I7b87652c86ff682760120f3992b33e27f4eaeaed Reviewed-on: https://gerrit.libreoffice.org/59365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in SwTextAPIObjectNoel Grandin
Change-Id: I697a8a119fa4ad0a6c50bc6e4a3bc8944435928a Reviewed-on: https://gerrit.libreoffice.org/59364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in ModuleDataNoel Grandin
Change-Id: I90b4f18028fe269f44973fbb3b8ed002335f11ef Reviewed-on: https://gerrit.libreoffice.org/59363 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in DynamicResultSetNoel Grandin
Change-Id: I1c34dbe81a6909bfbc4d62f5f9f73e7b9114e58c Reviewed-on: https://gerrit.libreoffice.org/59362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22loplugin:useuniqueptr in SbiExprNodeNoel Grandin
Change-Id: I2025251e35a48f47a51f11d790c3a22e118f3c05 Reviewed-on: https://gerrit.libreoffice.org/59348 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22improvements to loplugin:useuniqueptrNoel Grandin
find more patterns of deleting member data Change-Id: I8913e364200dad8405bac30dd8cab2a68c8bee8f Reviewed-on: https://gerrit.libreoffice.org/59233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22tdf#106174 ww8import: bidi - prev adjust? prev bidi?Justin Luth
Read_RTLJustify knows that it needs to swap in BiDi situations, but sometimes it is read before BiDi status is known. So Read_ParaBiDi needs to watch for this and do the swap afterwards. Three situations to handle: 1.) bidi same as previous setting: no adjust change 2.) no previous adjust: set appropriate default for this bidi 3.) previous adjust and bidi different from previous: swap adjusts (4. Unknown bidi treated like prev=LTR - one difference from DOCX) Unit tests cover both situations - where BiDi is already known, and where it is unknown. Change-Id: I0b4e2383a4909fe79317dd9772d0be63f749da68 Reviewed-on: https://gerrit.libreoffice.org/57294 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-22rename FontSelectPatternAttributes to FontSelectPatternCaolán McNamara
Change-Id: I2c018e2e61707c0d89178b0cb38a0918906e23cb Reviewed-on: https://gerrit.libreoffice.org/59390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22drop now unused FontSelectPatternCaolán McNamara
Change-Id: Ie236f1dd88f21cf85130ab324787d7b9bd2ff81e Reviewed-on: https://gerrit.libreoffice.org/59389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22turn the cache around to work on LogicalFontInstanceCaolán McNamara
instead of a FontSelectPattern with an associated LogicalFontInstance use a LogicalFontInstance with owned FontSelectPatternAttributes Change-Id: I939f84731fcb8db5ff6484dcfbd2f9199bb50d23 Reviewed-on: https://gerrit.libreoffice.org/59388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21Fix typosAndrea Gelmini
Change-Id: If515966300c5d3835e4d4a9004fb8cd472f4d3ae Reviewed-on: https://gerrit.libreoffice.org/59308 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-21split into FontSelectPatternAttributes and LogicalFontInstance argsCaolán McNamara
Change-Id: I099d9de60e6ca85f6cf048fe935cdfe5a804e78b Reviewed-on: https://gerrit.libreoffice.org/59374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21change FindFontSubstitute to operate on FontSelectPatternAttributesCaolán McNamara
it remains to be seen if we need the the returned mpFontInstance of the coretext impl Change-Id: I48f73188250c3eb014f16ffe0a735191da5cb25b Reviewed-on: https://gerrit.libreoffice.org/59322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21CreateFont from LogicalFontInstance instead of FontSelectPatternCaolán McNamara
Change-Id: I75e5dc2934a208c30be18b3ce3b033059fdf1164 Reviewed-on: https://gerrit.libreoffice.org/59373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21can now use just FontSelectPatternAttributesCaolán McNamara
Change-Id: I1857afa0a9aff39118ba3c242134985f865e37c1 Reviewed-on: https://gerrit.libreoffice.org/59387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21pass GetFontFace at call siteCaolán McNamara
Change-Id: Id2677cdc386e51ae1549c548c06d095ad0f43b40 Reviewed-on: https://gerrit.libreoffice.org/59385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21Resolves: rhbz#115937 virtual device leakCaolán McNamara
windows runs out much sooner than the other platforms Change-Id: I8ffbe32babf8854580150edfe741b03fd43e4326 Reviewed-on: https://gerrit.libreoffice.org/59404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>