summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-19tdf#156336 - sc ods: fix can't remove Calc comment metadataBalazs Varga
Remove Calc comment metadata (author, date) during ods export if the Remove personal information option is enable. Change-Id: I814aabb734cff4160dccf1913a33aa270c2edbf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158116 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-10-19tdf#157484 UI: Add UI controls for personal information to be keptBalazs Varga
or removed upon save. With the new options button we can keep the security infos upon save such as (even if we set the remove personal infos): - RedLine Info - Document User Info - Author and date of notes - Document version infos Also on the infobar, if we have a warning, clicking on the infobar button the security option dialog will open where we can set/modify these options. follow-up of: 1f440348eb0892fd2c9597806d87b5fe9d60d49a (tdf#157482 UI: Turn Security Warnings popup windows into infobars) Change-Id: I8d5d944d76dbdd31653401246113de097ca6d57b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158112 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2Stephan Bergmann
Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19sc: return earlier if there is no pActiveViewShXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/158123 Change-Id: Id9a27ca657377ba0a81009cdd2d27ce6aa4e2aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158140 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: configmgrStephan Bergmann
Change-Id: Id95245a309b3baa80d7cca63d980aa0657fb9eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158148 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: basegfxStephan Bergmann
Change-Id: If228639806c49d77d1c1a36a8d536992e1402896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: comphelperStephan Bergmann
Change-Id: I2a422f921739adf81131082d57ab7601dfb46d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158147 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19tdf#42982: Improve UNO API error reportingkhushishikhu
Change-Id: I16bd4bb935d02ff03422cb48d21a63e3d994d0b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157993 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: avmediaStephan Bergmann
Change-Id: Ib56a05e171f485ad01cb54ed87e01c3536ea733d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: UnoControlsStephan Bergmann
Change-Id: Ib8b380be99ae23f314f226be6c81bc62a08c13b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158141 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Use std::span instead of sentinel elementsMike Kaganski
Change-Id: Idcde4728f4db5b878c126c29c1953dff7c47f05a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158139 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-19tdf#157696 wina11y: Switch from custom to IA2 text attributesMichael Weghorn
So far, reporting text attributes on the a11y layer on Windows did not follow any standard/specification, but LibreOffice's custom attribute values were mostly reported as is (i.e. using the LibreOffice-internal attribute names and values), and assistive tooling had to interpret those in order to support reporting them to the user in a useful way. For example, NVDA has custom code in the LibreOffice-specific app module to do so. [1] Stop using our custom attributes and switch to the use of attributes according to the IAccessible2 text attributes specification [2] instead, which is the applicable specification for `IAccessibleText::get_attributes` that is implemented here. This implies that by reporting more IAccessible2 text attributes, those should "automatically" work if assistive tooling handles those, as is e.g. the case for NVDA and the the "invalid:spelling;" attribute for spelling errors, for which bridging to IA2 has been iplemented in Change-Id I54e5bcbb4bef4c73068243f91a3ee69c10326460 tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attr (See also the other tdf#135922 commits preparing for this change.) A change in NVDA is still needed in addition to switch from only handling the custom values for LO to use the existing code path for handling IA2 text attrs instead. Pending pull request that implents this: [3] [1] https://github.com/nvaccess/nvda/blob/9878248c217156de4defe244d2df797d6b3bd0ca/source/appModules/soffice.py#L35-L137 [2] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes [3] https://github.com/nvaccess/nvda/pull/15649 Change-Id: I11492bb5d09d64fd153db1b73d97a331a98ee535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158090 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-19Use OUString instead of OUStringLiteralStephan Bergmann
Change-Id: I0d49fa6c70c41b39b85f860ad648889be3613295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158136 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Presumed loplugin:cppunitassertequalsStephan Bergmann
Change-Id: I8acd32ff2cf3bd1b72136fd40e93ce047909f677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Suppress some upcoming loplugin:ostr OUStringLiteral -> OUString rewritesStephan Bergmann
...which would not work, as calling constexpr SbxVariable::MakeHashCode on those vars would no longer be constant expressions Change-Id: Ib848a6405dc270a1a5b9a92084fa2d063ea37892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158134 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19use more SdrObjList::begin/end in variousNoel Grandin
Change-Id: If054626a10d3cbd3b168dd4e66ec7f08344d2c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158131 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-19use more SdrObjList::begin/end in scNoel Grandin
Change-Id: I6b8614e4e8917f71308cda4caaeb714ae18885f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-19Use std::u16string_view instead of OUStringLiteralStephan Bergmann
Change-Id: I0a0a7badb25eea99632f734aa52231a9f3df67e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158137 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19uitest oneprocess mode: explicitly avoid this in the remaining testsMiklos Vajna
These 11 suites depended on the UITest default to not use oneprocess mode. Explicitly avoid that mode in these suites, because they currently fail that way. This allows changing the default in the future, so new suites automatically benefit from the oneprocess mode (it runs faster, somewhat similar to cppunit). Change-Id: I8c493ca63310815c1364bb6182c3285a9c7fbd63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158128 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-19use more SdrObjList::begin/end in sdNoel Grandin
Change-Id: If39b6c561525bbf66d34edfbff0f1a3ef4531f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-19Related tdf#144256: remove m_pSharedConnectionManagerJulien Nabet
to only use "m_xSharedConnectionManager". For this, it required some refactoring but except the removing, logic hasn't been changed. Change-Id: Iccfe5c45381f31019a0751a61cea6661c88188f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158107 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-19tdf#143148 Use pragma once instead of include guardsAml-Hassan-Abd-El-hamid
Change-Id: I6f6f69cc97fada3ca3bbdead24c10f9099ff28b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158068 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-18LOK: send state of protected cellsPranam Lashkari
Change-Id: I432a3af50b6089faa80a28804d95d816af6cd278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> (cherry picked from commit 5f13751cefd725cb2a38e66c9484046e6141c6c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158150 Tested-by: Jenkins
2023-10-18crashreporting: svx::SentenceEditWindow_Impl::CreateSpellPortions()Caolán McNamara
cui/source/dialogs/SpellDialog.cxx:2005 aRet[ aRet.size() - 1 ].sText += aLeftOverText; presumably aRet is empty() here a) don't bother appending if aLeftOverText is empty() b) don't crah if aRet is empty() and aLeftOverText is not Change-Id: Ie9a9585f572d8afb17183b479fb6f2cce5952aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-18Fix typoAndrea Gelmini
Change-Id: Ie54bc5f012d2de46363da9d19278736a732a1a25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158125 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-18sw: fix stack overflow on kde45196-1.htmlMichael Stahl
Previously, the shell cursor was put onto a SwGrfNode in the top left corner, which is invalid, but didn't crash immediately. With commit b20ca8d951e8205c8b963c6b7407f984053b4094 the cursor is instead put onto the first SwTextNode in the body, which happens to be in a table, and the entire table is hidden; this causes an infinite recursion in SwCursorShell::UpdateCursorPos() because GetModelPositionForViewPoint() no longer moves it to SwGrfNode. So try to move the cursor out of a hidden node, which requires an additional change in SwCursor::IsSelOvr() to allow moving from a node without a frame to another node without a frame. Change-Id: Ia33c7b558755f7e8b65ea3ff2c46aea20be577dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158119 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-18fix crash in ScInputHandler::ImplCreateEditEngine()Xisco Fauli
See https://crashreport.libreoffice.org/stats/crash_details/1b2c45b0-6053-4628-94cc-f639899ceb39 Regression from 5484657d2b1677b7e385ab6ef87ad64dcb9934e4 "tdf#156209 Font size increases when copying from cell in edit mode" Change-Id: I84cac26087b0c8908c22bbb45056e309cd66a016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18use more SdrObjList::begin/end in swNoel Grandin
Change-Id: If882c1c7863618a313b2e06abacdbfa756dfff3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18use more SdrObjList::begin/end in svxNoel Grandin
Change-Id: I362a2e12492391338b63708e4b329fc77ac363c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18Extend /clr /std:c++20 char8_t workaround to old versions of VS 2022Stephan Bergmann
On IRC, pppregin now reported that she ran into the issue addressed by 3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022 17.7.5" when using (a presumably old version of) VS 2022. And <https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering> suggests that older versions of VS 2022 used _MSV_VER values 1930...1936, so cover those too here. Change-Id: Ifee80114c5cd39aeabc31907adafb03eb2f388e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158122 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18loplugin:stringstaticStephan Bergmann
Change-Id: I008c48a315841a2fb642410f210d770bd14bfef5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18cool#6893 cache the EditEngine for renderingNoel Grandin
to avoid re-allocating one constantly Change-Id: I7d6c97a7f68126979bd8a5c12cfd6e680a789d3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18loplugin:indentationStephan Bergmann
Change-Id: If81844107209c3fb04d39c9f2b826b623068fc30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158120 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18Remove obsolete comments in basctlHossein
First comment was last updated with USHORT -> sal_uInt16 in a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit 68ec95b3f80408ae50897b043eed69a07d084df9 there is no remaining sal_uInt16 left, and thus the comment is no longer relevant. Second comment was added in 1fac87f84723a3d6e7e13c091e39b09e0dea1aa5, but with changes in 444c242c51e6b049598359ea6cf98e34f611838b it is no longer relevant. Third comment was also last updated with USHORT -> sal_uInt16 in a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit 444c242c51e6b049598359ea6cf98e34f611838b it is no longer relevant. Change-Id: I9ed383f15a5b403740c0b8bcdd153d04bb1a2b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158111 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-18Replace $baz by %foo for sanity checksLaurent Balland
Tools for sanity-checks like https://docs.weblate.org/en/latest/user/checks.html#percent-placeholders looks for percent instead of dollar Try to align with %1 as suggested by Chistian Lohmaier Change-Id: I97d353f452316b939f2eaf7d30e68b9aab9f83e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147493 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-10-18tdf#157517 vcl: PDF/UA export: add PDF/A extension schema to XMPMichael Stahl
... if PDF/A is also enabled. Thanks to Peter Wyatt for the example document. Change-Id: I2a5951e102ae28a4c998adafe8ab51caa2788e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158118 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-18tdf#132605 Negative skew values in connector dialogRegina Henschel
The skew values of a standard connector can have negative values. Those are possible in ODF, rendered in LO and produced by dragging the handles. Only the dialog restricts the metric field to non negative values. The patch allows negative values now. Change-Id: I5174dccc1ed0ed8644e0f62a5d599eea4d5cdbaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157700 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-18tdf#157573 sw floattable: fix incorrect lack of left margin after tableMiklos Vajna
Regression from d477fa8ac1b0d3ee81427217bbb5950278ab16db (sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplit, 2023-03-17), the paragraph after the anchor of the floating table in the document lost its left paragraph margin at a layout level. Turns out the problem was there earlier, but it was hidden for this specific document, because we used to map DOCX floating tables to Writer inline tables in some cases before. The real problem was introduced earlier, in my 50a1df360c907d8419ce49f098b6bc87a37a9956 (n#775899 sw: add FloattableNomargins compat flag, 2012-08-23), even a TODO was added to point out this will be problematic. The old bugdoc wants to get rid of margins, because the floating table is already shifting text towards the right, the new bugdoc wants to keep the original margin as the paragraph after the anchor is not wrapping. Fix the problem by reverting the older fix and re-fix the old document differently. Don't do changes to the paragraph margin: that's not a good idea. If there is enough anchor text, it'll lead to a visibly bad paragraph margin anyway. Instead of reducing the paragraph margin, reduce the width of the fly portion in the paragraphs that intersect with the floating table. That's reasonly straightforward to do, because SwTextFormatter::CalcFlyWidth() already has a case when we know we're intersecting with a floating table and we also know that the floating table is aligned to the left. In this case we can simply reduce the fly portion width with the paragraph margin. This keeps the old bugdoc fixed and fixes the new bugdoc. It also means that DocumentSettingId::FLOATTABLE_NOMARGINS is now effectively unused, but that's not yet removed in this change. Change-Id: Ibaccc4807fd8c11bd45955b76e96cd4a5e55976f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158103 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-18Drop duplicated forward declarationsMike Kaganski
Change-Id: I0804518ce97e3f5f8098c4a4416675409746aaea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158044 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-18tdf#156033 sw: Don't capture mouse when executing file dlgMichael Weghorn
When the mouse is captured in `SwView::InsertGraphicDlg`, temporarily release it while executing the file dialog, so the user can use the mouse to interact with the file dialog. At least with qt5/qt6/kf5, this would otherwise not work in the file dialog shown after clicking on a previously inserted Picture Content Control, because `QWidget::grabMouse()`'s "other widgets get no mouse events at all" [1] apparently applies for the file dialog and other running applications as well. [1] https://doc.qt.io/qt-6/qwidget.html#grabMouse Change-Id: I80a81c57c80debc716a1b111a9c07eef0c005c65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158109 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#157792 followupNoel Grandin
avoid doing some extra Invert() operations by creating an AlphaMask instead of a Bitmap to pass to the BitmapEx constructor. Change-Id: I1af3a5e65010b346fa0d0c56836d567e51c9b58b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attrMichael Weghorn
Let `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes` also report spelling errors as a text attribute, since the "invalid:" text attribute with a value of "spelling" is specified for that in the IAccessible2 tex attributes specification [1]. In order to adapt the start/end index for the attribute run, iterate over all of the text markups that can be retrieved from the `XAccessibleTextMarkup` interface instead of just deterining whether the offset itself lies within a range of misspelled text via `XAccessibleTextMarkup::getTextMarkupAtIndex`. (This is strongly inspired by how the gtk3 a11y implementation does it, s. `handle_text_markup_as_run_attribute` in vcl/unx/gtk3/a11y/atktext.cxx.) When using the qt6 VCL plugin on Linux, the attribute shows up as expected in Accerciser and the Orca screen reader announces "misspelled" when moving the cursor in front of a misspelled word using the Arrow_Right key. Announcement by NVDA works once winaccessibility and NVDA have been switched over to use IAccessible2 text attributes instead of custom LibreOffice ones. [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes Change-Id: I54e5bcbb4bef4c73068243f91a3ee69c10326460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158089 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#157696 qt a11y: Move handling for text attr offsets to helperMichael Weghorn
Add a new method `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes` and move some more of the logic from `QtAccessibleWidget::attributes` there to prepare adding handling for spelling errors via the "invalid:spelling" IAccessible2 text attribute and for reuse in winaccessibility. Change-Id: I3b4a89ee680437fa2c35c429639b372a55f5a4b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158088 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#155410 shave 1% cost off SdrGroup::GetLayerNoel Grandin
by avoiding repeated indexed lookup into the std::deque inside SdrObjList Change-Id: Ifcf736d0ecef1239b8a236fe1937f347a3d49e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18Replace useless typedef OSharedConnection_BASE2 and replace it by its valueJulien Nabet
Change-Id: I660813058077a36bcf80a3128b53767c851c2672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158105 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-18Clean up the remaining uses of OUStringConstExpr, and drop itStephan Bergmann
Change-Id: I30b2ac77b58e2ae1d1e997a0c830c513542b973d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158101 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18qt: Drop now obsolete workaround for Qt < 5.12Michael Weghorn
This workaround was only applied for Qt < 5.12 and is no longer needed now that support for Qt < 5.15 has been dropped in commit afb4c96d271958ced3175dfc2cf8bb9e8b0a9d3b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Aug 3 21:30:22 2023 +0200 qt: Drop code for Qt < 5.15 Commit originally adding the workaround: commit fe2baf9e84e0ca9aeaa683e37076f57fa3f38dca Author: Jan-Marek Glogowski <jan-marek.glogowski@extern.cib.de> Date: Tue Dec 3 08:32:58 2019 +0100 Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUP This is the application level equivalent of the Qt5 fix for bug QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden by other windows"), which was broken since Qt 5.4 and is just fixed since Qt 5.12. It is needed for some window managers, which don't know about the WM_CLIENT_LEADER property. Both settings are the same, but just the latter is set by older Qt5 releases. This probably isn't a real problem, as GNOME or XFCE would use the gtk VCL plugin, but since I already wrote the code when debugging tdf#129071, there is also no reason to drop it (except: more code, more bugs...). This fix is optional and needs development headers for xcb-icccm, which can actually be compiled into Qt5. If missing configure will just print a warning, since it's a runtime requirement and we explicitly drop the linked Qt version symbol, so the potential build Qt version won't matter. Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b Reviewed-on: https://gerrit.libreoffice.org/84299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: I56b708449cf686f787f55256c76673be604d31e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158102 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18Related tdf#144256: fix order of disposing in OSharedConnectionJulien Nabet
In dbaccess/source/core/dataaccess/SharedConnection.hxx, we got: 35 typedef ::cppu::WeakComponentImplHelper< css::sdbc::XConnection 36 > OSharedConnection_BASE; 37 typedef ::connectivity::OConnectionWrapper OSharedConnection_BASE2; 38 39 class OSharedConnection : public ::cppu::BaseMutex 40 , public OSharedConnection_BASE 41 , public OSharedConnection_BASE2 so first OSharedConnection_BASE ctr is called before OConnectionWrapper ctr therefore OConnectionWrapper dtr should be called before OSharedConnection_BASE dtr It doesn't fix the bug but investigating in all this mess, I'd like to fix these things since it may help. Change-Id: I47255357b4ca02261f31ebf500f3f1ff55642e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158096 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-18Simplify a bitMike Kaganski
Change-Id: I594b3317f8298966d59f8674b71bddd89998b9f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158092 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-18CppunitTest_sw_ooxmlexport8: clean up not needed preTest()Miklos Vajna
This would set (and unset) custom configuration based on filenames, but the suite has no such files anymore, so this can be removed. Change-Id: I8f1dd40b62adcd71a0e4ae303c5d317943ef438b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158094 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-21 04:24:14 +0000