summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-27loplugin:expandablemethods in svxNoel Grandin
Change-Id: I0d193ddf07cc0ddc89b6ce2df6eb71d44e49b631 Reviewed-on: https://gerrit.libreoffice.org/30295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27loplugin:expandablemethods in swNoel Grandin
Change-Id: Ibc9edc28f4041235ab30c026bd3774bd74b7e960 Reviewed-on: https://gerrit.libreoffice.org/30287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26for now, use a limited subset for testing on windows as it is so slowBjoern Michaelsen
Change-Id: I06f77d8aa0a82bd3bb065095a64849d07d11c6a3 Reviewed-on: https://gerrit.libreoffice.org/30311 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-26add test for running gbuildtoide on non-build modulesBjoern Michaelsen
- do concat for json in C++, everything else seems fragile on Windows - have APPEND vars separately - check that gbuildtoide work on modules without a full build (modulo some blacklisted "creative" ones) Change-Id: I6fe267fee7d1b77d758072303729387dfeb8e6c8 Reviewed-on: https://gerrit.libreoffice.org/30293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-27trust the size ... tdf#79442 follow-upEike Rathke
... and don't unnecessarily loop over the whole range. Actually a max/min typo. Change-Id: I3dbda3a7388baa337c3922ad992fd3946074c3b7
2016-10-26Java 7 DISPLAY and FORMAT locale and script fieldEike Rathke
Change-Id: Ie62105c60a327f6e5cbcf1a801b341e988471d73 Reviewed-on: https://gerrit.libreoffice.org/30308 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-26sal::detail::logFormat is no longer neededStephan Bergmann
...since 97354578d7195bce927f0c00c4e2ae9cd7344776 "Remove the obsolete functionality originally underlying osl/diagnose.h" Change-Id: I7c920bca9cdddb37fcbbc15d8629d01c21eb0787
2016-10-26rework to avoid coverity#1371205 Missing move assignment operatorCaolán McNamara
Change-Id: I117fa0891e8cd1bf339bded93a7ee19d799caf9f
2016-10-26we don't need ree after the loop hereCaolán McNamara
Change-Id: Ib288ab3a7abf8f45c1175c36dcd4349dc4ad019f
2016-10-26normalize existing emacs/vim mode-lines in python filesMichael Stahl
Bunch of these were setting C++ or Make modes and icky tabs... Also, reportedly Emacs can figure out to enable python-mode automatically. Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
2016-10-26gbuild: missing emacs mode-linesMichael Stahl
Change-Id: Id767a98be85a7f3f4abb28891d0a5cac2057b0e0
2016-10-26fix leak in HeaderFooterTabPage seen examining coverity#1371205Caolán McNamara
In the case that the field data is not a SvxDateTimeField or SvxDateField then the old "aFieldInfo.pFieldItem = nullptr" call will mean that the pFieldItem is leaked for that element. The only thing needed later is the existance of a date field, and the field's position, so encode those two facts as a bool and EPosition and stop abusing aFieldInfo.pFieldItem to serve as a flag Change-Id: I6a1c46d32406dbd6865cfcf6d23a3863bada6810
2016-10-26fix "TabError: inconsistent use of tabs and spaces in indentation"Michael Stahl
Change-Id: Iff27ff4a01dc8c20b01a6247554b6cc7195a2306
2016-10-26solenv: fix Windows buildMiklos Vajna
Traceback (most recent call last): File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32solenvqapythongbuildtoide.py", line 32, in test_gbuildtoide del(os.environ['LD_LIBRARY_PATH']) # built with ASAN; prevent that File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32instdirprogram\python-core-3.3.0libos.py", line 692, in __delitem__ raise KeyError(key) from None KeyError: 'LD_LIBRARY_PATH' Change-Id: I1575caf90cafffd71dd28fedc46b5e3570848be8 Reviewed-on: https://gerrit.libreoffice.org/30304 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-10-26xmlsecurity PDF verify: support SHA-256Miklos Vajna
And various other minor fixes. Change-Id: Ifcccebf48aac8ad526406f2d7a402a840d3c91cd
2016-10-26xmlsecurity PDF verify: fix handling of non-imported certsMiklos Vajna
Previously we only managed to verify a signature in case the certificate was already imported in the local NSS db. Don't depend on that by (temporarily) importing certificates from the PDF signature. Also adjust a test file that failed previously (the test DB has only an "Alice" cert imported, intentionally sign the file as "Bob" as well). Change-Id: Id8440acc31915f5a1718ea48129b950bb67e7486
2016-10-26xmlsecurity PDF sign: fix removing non-last signaturesMiklos Vajna
PDF signatures are always chained, so when removing a signature not only the item at a given position should be removed on the UI, but the whole position-last range. Change-Id: I76b14308885267cdac994fa957218a8b7df6b3cf
2016-10-26xmlsecurity PDF signing: fix byte range check for multiple signaturesMiklos Vajna
We can mandate that the byte range end is the end of the file for the last signature only. With this, signing a previously unsigned file multiple times works, so add a matching testcase for that as well. Change-Id: I8fe5482890fca4dab8da6305aa7fc7f60df612d8
2016-10-26Revert "clang plugin for push_back after using sized constructor"Stephan Bergmann
This reverts commit e2fa592c770222344fccb0e39db3d500fc7690b5, sould no longer be necessary after 3be8c4c2bb919d69a2812c76edbaeaa41d149edb "The badvectorinit plug-in probably can be retired". Change-Id: I26fadaf002e8e21144a7e888a80bb40eb017a64b Reviewed-on: https://gerrit.libreoffice.org/30296 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-26init ScUndoRemoveMerge with range, tdf#92117 follow-upEike Rathke
So the original selection is restored after Undo. Change-Id: Ie549a0b62da469ee38270ae089ea5abf9a6868e3
2016-10-26solenv: don't run make with LD_LIBRARY_PATH setMichael Stahl
In a build with -fsanitize=address, this fails with: Change-Id: Ida0d4445d7f829545b493e9dd4c2c4ef33960850 make: symbol lookup error: instdir/program/libfreebl3.so: undefined symbol: __asan_option_detect_stack_use_after_return
2016-10-26i18nlangtag must presumably be dropped from Library_merged.mkStephan Bergmann
...after 475e4b477c6d7ae114c3ae51ba4872882af67a68 "Move i18nlangtag lib to URELIB"? Change-Id: I45c5d997ed30757157109c67f30b91c4073c6b0a
2016-10-26Resolves: tdf#92117 create only one Undo for all UnmergeCells() callsEike Rathke
... during DeleteCells() and InsertCells(), instead of one Undo per UnmergeCells() call. And actually create Undo only if bRecord requested. Change-Id: I4f1747c3f42f36e16be81f989f0af5d048ba9d9f
2016-10-26SfxSlotInfo is unusedCaolán McNamara
Change-Id: I8d5438ca338868c77dcf489609a4e007cfe925fd Reviewed-on: https://gerrit.libreoffice.org/30290 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-26xmlsecurity PDF signing: only write incremental xref in an incremental updateMiklos Vajna
We used to just dump all the object offsets in the xref of the incremental update, but Adobe Acrobat doesn't like that, and considers that a second signature invalidates the first. If we properly only mention new and changed objects in the xref, then this doesn't happen. This requires actually parsing incremental updates, the previous code depended on LO writing not-really-incremental xrefs at the end of incremental updates. Change-Id: Icdd73fe0a3eab16f8c5a62f1355edbb49f6e73de Reviewed-on: https://gerrit.libreoffice.org/30288 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26Linux: Build NSS in debug mode only in '--enable-dbgutil' mode.Giuseppe Castagno
With this commit, NSS debug mode is enabled only if you compile with --enable-dbgutil using ./autogen.sh command. Only for the Linux platform builds. Change-Id: Ia8626f36692fd38e8b1dbd774e4bc0ccedc59072 Reviewed-on: https://gerrit.libreoffice.org/29781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-26const-ness fixesStephan Bergmann
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26svl: the compiler can generate the same SfxGrabBagItem copy ctor itselfMiklos Vajna
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec Reviewed-on: https://gerrit.libreoffice.org/30283 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26tdf#103088, improve interoperability with Excel for LOGNORMDIST().Winfried Donkers
Change-Id: I5f4ccbb54b212247a3ff8b13ff012c930d18a86c Reviewed-on: https://gerrit.libreoffice.org/30020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-10-26Better way to silence loplugin:staticmethodsStephan Bergmann
...in this !ENABLE_FORMULA_LOGGER dummy implementation Change-Id: Ifaf3356ada68d70164644f89fc6dc6d66f22024b
2016-10-26drop now unused SfxStyleItem, etc.Caolán McNamara
Change-Id: I61227079c376299d17250970b19acb0c415034fb
2016-10-26assemble SfxStyleFamilies from more generic resource componentsCaolán McNamara
Change-Id: I25aa0d8bca1f16f5fc27d3b299709479a1635ea3
2016-10-26expand SvMetaType::ReadNamesSvIdlNoel Grandin
it just forwards to ReadNameSvIdl Change-Id: I803edb7a5977cf309e2cedaa3b4764bcbd933597
2016-10-26tdf#96948 Change color of the area behind Impress slide immediatelyTakeshi Abe
after saving Options > Application colours > Application background. This fixes a regression from 1c481fe6522f4c7d883e77a4ac32f855b9bcb323. Change-Id: I8dc0caf9e351c0b1bf2a10e9097d8f3e895f1471 Reviewed-on: https://gerrit.libreoffice.org/29957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-26try and silence coverity#1374267 Out-of-bounds accessCaolán McNamara
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-26coverity#1374287 Uncaught exceptionCaolán McNamara
Change-Id: Ieed911b33fe4a5358855b3960b9d4c77c66ceff9
2016-10-26coverity#1374286 Uncaught exceptionCaolán McNamara
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26coverity#1374285 Uncaught exceptionCaolán McNamara
Change-Id: I0a3790607fe7db6a8b8093a67e4dbf3548c800bb
2016-10-26coverity#1374284 Uncaught exceptionCaolán McNamara
Change-Id: Ie43165d3f6abd420b951a80e0101d8e77946d4a3
2016-10-26coverity#1374283 Uncaught exceptionCaolán McNamara
Change-Id: I658a12da4d30f360f207ca06dcf3650ba18cc7a2
2016-10-26coverity#1374282 Uncaught exceptionCaolán McNamara
Change-Id: I1b31825ec27d2395ca030ca79b6c932b7814d901
2016-10-26coverity#1374281 Uncaught exceptionCaolán McNamara
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26coverity#1374280 Uncaught exceptionCaolán McNamara
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26coverity#1374279 Uncaught exceptionCaolán McNamara
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26coverity#1374278 Uncaught exceptionCaolán McNamara
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26coverity#1374277 Uncaught exceptionCaolán McNamara
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26coverity#1374276 Uncaught exceptionCaolán McNamara
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26coverity#1374275 Uncaught exceptionCaolán McNamara
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26coverity#1374274 Uncaught exceptionCaolán McNamara
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7