summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-18undo changes to TextAlignCaolán McNamara
revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 29 20:49:29 2021 +0100 convert TextAlign to scoped enum lets leave this as it always was Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18ofz#37315: Invalid-enum-valueCaolán McNamara
Change-Id: I573ecf0cd1bd7b71ebf77a503d9937ee9f9d867c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18specialise std::optional for OutlineParaObjectNoel Grandin
we can re-use the o3tl::wrapper pointer to indicate empty Change-Id: I26e502a7dacfb2bd3d465e71c8fdd89a6a80969b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18ofz#35787 skip expensive ResetAttr if the document is in dtorCaolán McNamara
lets try it initially just for fuzzing builds Change-Id: I4ae08348c53756a8f3693ba7cd5c6c3e255d91bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18tdf#143736 Fix loading hyperlink from various shapesSamuel Mehrbrodt
Change-Id: I86de90ee605fab8f11e7c01892fbbff6acf790a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120609 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-18improve SvxShapeCollection::getByIndexNoel Grandin
Change-Id: I4cca7c0b6344241256d038902069a20ece314358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18jsdialog: dump selected state for toolitemsSzymon Kłos
Change-Id: I8c2c017168e4feae6e24118153906ee24ed90a5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118893 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120615 Tested-by: Jenkins
2021-08-18jsdialog: dont use popular id for glow colorSzymon Kłos
to avoid confusing it on updates Change-Id: I2b19dc41a17e070ac1c8869d478c3b0b09a54223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120614 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18jsdialog: send type for popup messagesSzymon Kłos
Change-Id: Ic0f189645dc9a1164cbbc528b3a5d30d72ee3333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118552 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120613 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18gtk3: fix warning about GtkBin already containing a widgetCaolán McNamara
Change-Id: I9df18e9cc865a8600f26605530eb99b9ba8f0d36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18tdf#114441 :Convert use of sal_uLong to better integer typesYildiray
Change-Id: Ifc7c1ce21f9dbaf77a0ae2ffa598e219809a250d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120541 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-18tdf#59820 - Adjust column width of imported ASCII filesAndreas Heinisch
Don't adjust the optimal column width of imported ASCII files in Calc by using the simple text mode. In the simple text mode, the length of a column is determined solely by the length of a text and not by the actually needed size. Change-Id: I02a1e0fbfad88a31bd474124c2f4367b660bdfdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120514 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-18ofz#37305: load of value 131 which is not a valid value for type 'bool'Caolán McNamara
Change-Id: Icd535272bfc2ef62399fa889f73acd705b566973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120622 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18avoid constructing OUString on hot path (tdf#105575)Noel Grandin
Change-Id: I7c9925fc7f68cdc9bd1a9c1834daabff09c8cf6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18remove dead codeNoel Grandin
ever since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I1fd724f2e4f31353da60d2615e6c840bbb88dfcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18loplugin:sequenceloop also check for B2DPolyPolygonNoel Grandin
which has the same problem Change-Id: I98f9924626f26739e91d6a9d21e4276473ea314d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18Simplify SdrTextObj::RecalcSnapRectMike Kaganski
Change-Id: Ieab3f3143e96af56c87720451de4194138f0463b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120590 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18Simplify Rect2PolyMike Kaganski
Change-Id: Ie20662c6040da8a77db8168a7aa32e001a01ae6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120589 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#134569 writerfilter: move tableParaProps on table endLevelJustin Luth
The end-level of a table only comes at the ::finishParagraph of the FOLLOWING paragraph. So for table-in-table, it is necessary to move the paragraph properties captured during the paragraph to the correct table level's collection. This fixes 7.0 regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c and depends on prior commit related tdf#134569 writerfilter: negative means table end Change-Id: I83183f38e1cf68b7db09813ca1b4a2491e7b54e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120526 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-18Update git submodulesMing Hua
* Update helpcontent2 from branch 'master' to e4f55790b32ad295322c712ed49d0349f4eea66d - ScriptForge Basic: fix example MB_* are properties of the service, so the service variable needs to be properly specified. Change-Id: I033f3e54ca69707c25030723fb5dc426a3ad6691 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120586 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-17Removed duplicated includeAndrea Gelmini
Change-Id: I4103d44e0535b39555f2f62e36ce6109e39cabfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120595 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-08-17rtl::Static -> thread-safe static localNoel Grandin
Change-Id: I9f8fe250813f4f376dc46c6f3d7e25e90fdbb50e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17reduce alloc costs for some basegfx objects (tdf#105575)Noel Grandin
we can use a default object for the default constructo case, and remove one malloc for each default constructed object Change-Id: I0bec37ef9161a210973abb25669a9f16a5e0ea75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17Resolves: tdf#139220 with ~1000 selected shapes a11y UpdateSelection crawlsCaolán McNamara
so fetch the selected shapes once and sort them for quick lookup in the loop over maVisibleChildren. As an aside, not changed here, SvxShapeCollection::getByIndex looks suboptimal with a body of std::vector<Reference<uno::XInterface>> aElements(maShapeContainer.getElements()); return uno::makeAny(Reference<drawing::XShape>(aElements[Index].get())); Change-Id: Idec7c003e7c5ee02000d4642d4fdb0d940548d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120610 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Fix o3tl::convert for Rectangle, to operate on right/bottom valuesMike Kaganski
... instead of using confusing/ambiguous size having two interpretations. This reverts some of the unit test changes made in commit fa339b3adb53300ae68913bed87e18caf9f2e262. Change-Id: Ic56417703e32c1d92bcee76ad8ff494824bd4a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120564 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17ofz: Indirect-leakCaolán McNamara
Change-Id: Ia29c771d6dbdf37b55ce0e63cc73564bcea6f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Fix typoAndrea Gelmini
Change-Id: Ib67f29eec54557811eb1136673030249b296289e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120599 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I8cf2ea25ee343b747497a8a83edb48c2421863bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Improvement to ml element exporterdante
Change-Id: I12303add11406c0ab65ca02084945989f41380d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I93062ed58f820a0f88a236c4134ff9adce06006c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120601 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I28ef5ac72fb06406d049e1076f48dcd2d06a42af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120600 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I05739d1b82ec872cd8c7d68d3945893c9e6c3648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120597 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17jsdialog: don't send unnecessary close messageSzymon Kłos
Change-Id: I4077c0871c7e6faf4917ad22a1a3aae8eb972961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118549 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120569 Tested-by: Jenkins
2021-08-17jsdialog: sidebar: send message on sidebar closeSzymon Kłos
Revert needed code removed in 64bd4dd Change-Id: If45facbd68ea8f3af433b78e127fbb0745e62c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118483 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120565 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-17jsdialog: dump image for toolitemsSzymon Kłos
Change-Id: If47eb57cc18c6f04e5b2e3a14a6bcea657e03df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118472 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120543 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-17tdf#143858: sw: default value for nInclUpperLevels is 1Vasily Melenchuk
SvxNumberFormat::nInclUpperLevels (matches text:display-levels in ODF) bit incorrect in its name: is counts total amount of levels to display, including current level. So value "0" seems have no sense: display 0 levels in total? In UI you can't select less than 1 level and ODF standard (19.797) using 1 as a default. This looks plausable. Change-Id: I596386c7b3cc4370910cd0ff6e927e501179fbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120458 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-08-17tdf#143911 DOCX: export character formatting changesLászló Németh
of text portions (instead of losing them completely, resulting missing rejection of tracked formatting changes later). Follow-up to commit 0115a77eb84afb0d820d8e23f45e49b30b82a8d3 "tdf#50447 sw: track changes of character formatting" and commit 5322663f8234836a6a4aaaed025c158fd7e8b67a%5E%21 "tdf#126206 DOCX: add rejection of character formatting changes". Change-Id: I7f00774875fe06d21865d9468fc1a63bd11d91ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120568 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8c962ef5c3feb4f0ed970ab4c90efcace00f6e06 - Update intro video for online Help pages The patch does not require translation. The videos is not loaded in offline Help Change-Id: Ia8f966d7dc48b3fe1547461a64d4430dfddf75fe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120594 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-17Related: tdf#142003 add a test for this caseCaolán McNamara
Change-Id: I32ca1ccdcf221c0ef6933fa1018b5f2eb753fa7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120571 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Enable sd pdf import tests on WindowsMike Kaganski
Change-Id: I101e59a6ce1a3467a1f743bdcc288b16307eb5a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120579 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17Use new json_writer class for json objects.Gökay ŞATIR
Change-Id: I68b43829250201a716e2ec10968b90eadcba7fca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120567 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins
2021-08-17Rename SaturatingSet[XY] to SaturatingSetPos[XY]Mike Kaganski
... to align with commit 4639ca2f878b04ffc50d9c20d92e90464d2d67a7 Change-Id: Ibec7a451a61ca7f2d141a9624369a6f9656ed468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120562 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17Resolves: tdf#142003 tracked changes in footnotes offset in .doc importCaolán McNamara
Reverts: commit e71d05eaa9a8c9e628b256f3e889b85ac11ed474 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 27 15:42:26 2018 +0100 ofz#8038 defer subdocument redlining to end of parse like main document Change-Id: Ie8d7a98c7927dcba53228ebcd991d715d8faabe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Simplify and inline tools::Rectangle::JustifyMike Kaganski
Change-Id: I535fb70fa532d98542ac30e0b2053bdaa6b94383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120494 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17jsdialog: image for radiobuttonsSzymon Kłos
Change-Id: Ic6027223c5771ffb659a4503cfd305d0decc2433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118465 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119244 Tested-by: Jenkins
2021-08-17Make IdleFormatAndUpdate privateMike Kaganski
Change-Id: Ifecc0653de27bbc0cf483147c87a11d5cd307090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17rename SetRectsDirty->SetBoundAndSnapRectsDirtyNoel Grandin
because there are lots of things being marked dirty, and I like to be sure I know what the code is doing Change-Id: Ifd0380c5560adc4a054495551885fe33af4f3e5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17tdf#143778 these async callbacks expect to have SdrModel::IsChanged of falseCaolán McNamara
when they are entered. They are adapted from the original non-async SwDrawShell::ExecDrawDlg where the start of SwDrawShell::ExecDrawDlg has... bool bChanged = pDoc->IsChanged(); pDoc->SetChanged(false); and the end has if (pDoc->IsChanged()) GetShell().SetModified(); else if (bChanged) pDoc->SetChanged(); and before async dialogs the start and end happened before and after the dialog appeared and disappeared. The intent seems to be unset the sdrmodel-changed and restore its original state if the dialogs caused nothing to happen and to explicitly set SetModified on the document if something did. Now the async dialogs callback happens after SwDrawShell::ExecDrawDlg has ended and so the callbacks start with SdrModel::IsChanged at its original value (restored by the end of ExecDrawDlg), not the "false" they were originally written to expect. For simplicity set the SdrModel IsChanged to false at the start of the callbacks and continue to restore to the passed in bChanged state if there was no changes by the callback. Change-Id: I671b35acab6d1b391fa7e6590c09f8be135449b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 3a58cb35bdb6e11e7a80759b59d4c68fcd3c6be7 - Improve VALUE function help page The help page for the VALUE function is created as a separate help page func_value.xhp. This patch also refactors related help pages NUMBERVALUE, DATEVALUE and TIMEVALUE. Their main header was <h2> instead of <h1>. Change-Id: Ic67893f0c35a58a19f13af1d34d68956e901a4a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120361 Tested-by: Jenkins Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-17Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to 70819b10363aba5cce4c1655dae622b5e3776d51 - tdf#132643 Translate German section IDs Change-Id: Ia985134bc5f4176d268789cb2d47c5aae3173c4c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120507 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-12-28 10:14:14 +0000