summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-14elide some temporary OStringsNoel Grandin
where we can pass a string_view into OStringToOUString Change-Id: If7803ba49aa15f6e9c7bd386d32fb84003155390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14Related tdf#129547 and tdf#154136: add COLON keyJulien Nabet
Change-Id: I17978dbb100fbfa6f6ddbbbdf96872076bc2a289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86713 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-14tdf#154129 writerfilter framePr: check whole style inheritance: W/HJustin Luth
This patch depends on HAnchor, which created vProps. This patch changes the logic a little bit from the previous code. Before, the paragraph has to specify something other than 0 (auto) in order to be acceptable. Well, I don't see any reason why direct formatting shouldn't be able to override a non-auto style value, so we'll make the change and see how it plays out. Errata says: "The standard states that 0 is a valid value of the h attribute. HOWEVER Word treats a value of 0 on this attribute as a value of auto." and: "The standard states that the values of the h attribute are defined by the ST_TwipsMeasure simple type. HOWEVER Word restricts the value of this attribute to be at least 1 and at most 31680." There were no existing ooxmlexport unit tests where the old and new method produced different values. Change-Id: I48934598c1bca8ffc99b97b114d77505f3341105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148715 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-03-14CppunitTest_sot_test_sot: remove duplicated assertMiklos Vajna
This was added in commit 29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb (tdf#115574 sot: fix Excel -> Writer paste, 2018-03-29), where it was hard to consider 4 bugreports at the same time, so I wrote asserts for each bugreport. But at the end 1 bugreport is a superset of an other one, so just moving the 2 comments next to each other having 2 asserts instead of 3 leads to a simple removal of the duplication. Change-Id: Iaedccf5ac498dd6842c25b60b507e63332daddf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148847 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-14Fix typoAndrea Gelmini
Change-Id: Ie7b0692c5f79eb4e8022ac1bcedfe01b3f7b75f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148878 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-14Remove debug commandAndreas Heinisch
Change-Id: I6cd82e83288724896987c591f308fb7ab0eb880a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148863 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-14tdf#154179: fix pre-selection of the current outline levelMike Kaganski
This seems to always be the intention, and never worked. The pre-selection made in SwOutlineSettingsTabPage::SetWrtShell was overridden later in the SwOutlineSettingsTabPage::ActivatePage, because SwOutlineTabDialog::s_nNumLevel wasn't updated to the wanted value. Additionally, it only could potentially work when the dialog opened the SwOutlineSettingsTabPage, not the other page (which would happen when it was active the last time when the dialog closed). And the active document level value must be sanitized. Change-Id: Iefefcdcde9da0e54e3acaffb981e057367a27197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148837 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-14move "align right" checkbox to the leftSeth Chaiklin
Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Change-Id: I4a3c42a6ea098f73c8467e003275e759c0f98882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148756 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 36f71cb8d29fde0c8b42238ba59bc1d73b042cc6 - Related tdf#145332 Fix sentence about TRUNC function As discussed in the original commit [1] the wording about the TRUNC function was incorrect. This patch fixes the sentence. [1] 6b1075e1e032be5bb6cba1dbdcc11de2a1824add Change-Id: Iec86eb4c881dbfbbb3e2020a7aedd6ff59bf0e61 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148767 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 87d52df5836c4fe06e186b289c937be47d9ded53 - Improvement in refactoring XSLT Change-Id: I91f3dce118e4a66d697f844f7f78897748c17a95 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148880 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-14Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to 5e8ed765cc8c502f1272c191c0a1a4f82d505e57 - Related: tdf#154167 ERROR.TYPE() list both alias name and Err:... value Change-Id: Ice9252d0aba19719737d47090f426ee52a0eabc7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148882 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-14tdf#139065: vcl_pdfexport: Add unittestXisco Fauli
Change-Id: Ic185f4e9bd26844b01cf3df61c9b4bcf3b637e6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148798 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-14language list in SwTranslateLangSelectDlg can be staticNoel Grandin
Change-Id: Ica911ec651e536e399491c0c28765aeb9e021548 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14Fix typoAndrea Gelmini
Change-Id: I3c7b644de7b6e6bf46161a33f56eb89df662777c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148876 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-14Fix typoAndrea Gelmini
Change-Id: I9a46298fe53880cd84aa1cb9713e576eece3d2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148877 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-14Fix typoAndrea Gelmini
Change-Id: Ie08c4c4b6997b13eea7b29f987f994d8a894a331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148875 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-14Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' to c3a560d632327fea245b60b7a40e7950974f3cd7 - Related: tdf#154167 ERROR.TYPE(#NULL) is for Err:521 Change-Id: Id30b59e13feac935fb5307f67bd5a5423b1e9fb0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148881 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-14Resolves: tdf#154167 ERROR.TYPE(#NULL!) must return 1Eike Rathke
Error #NULL! is an alias of FormularError::NoCode Err:521 that is also mapped to import/export Excel docs. ParameterExpected Err:511 was wrong. Change-Id: I08dc4e5747cb6c6ab7c2b309b02b942340ed4484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148820 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-14tdf#154129 writerfilter framePr: check whole style inheritance: X/XAlignJustin Luth
This patch depends on HAnchor, which created vProps. XAlign is not like YAlign - which is invalid with a text anchor. XAlign is still valid with a text anchor, and so doesn't need to copy YAlign's special vAnchor default. A unit test was added just to pre-emptively assert that. There were no existing unit tests where the old and new method produced different values. Change-Id: Ib3066f3d67c01a1bca972c6a114bb726bccac5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148714 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-03-14tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor defaultJustin Luth
This patch depends on previous patches for tdf#154129. yAlign takes precedence over w:y. HOWEVER, there is a clause in the documentation that complicates everything. "If [yAlign is] specified, the position for this attribute supersedes any value which is specified in the y attribute, and that value is ignored, UNLESS the vAnchor is set to 'text', in which case any relative positioning is not allowed, and [yAlign] is itself ignored" So if vAnchor is not defined, it defaults to text (FRAME), but if yAlign is defined then it should mean margin (or else yAlign has no meaning), unless of course w:y is also defined, in which case "text" anchor has meaning again and this unit test shows that w:y wins out in this case. The anchor is not affected by wrapping. [P.S. This was already set correctly in the code, but worth noting: "The standard states that the default value for the vAnchor attribute is page. Word uses a default value of 'text' for this attribute."] make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287 make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287B Change-Id: I953afa89e3c0974a16d43500ce590e1a481c2251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148691 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-03-14tdf#154129 writerfilter framePr: check whole style inheritance: Y/YAlignJustin Luth
This patch depends on HAnchor, which created vProps. There were no existing unit tests where the old and new method produced different values. Change-Id: I1bf7dd6ee7a8c8d00f7c743657a32a86986e7a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148690 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-03-14ScriptForge (SFDialogs) make On properties editableJean-Pierre Ledure
A dialog box and its controls may be associated with scripts triggered by events (mouse moved, key pressed, ...). The link is usually preset in the Basic IDE when the dialog is designed. So far, ScriptForge did not offer the setting of a link event-script by code. The actual commit removes this limitation: every On-property related to either a dialog or a dialog control is now editbale. With the important precision that such a property may be updated ONLY IF it was NOT PRESET in the Basic IDE. Static (IDE) and dynamic (by code) definition of a specific On property on a specific dialog or on a specific dialog control are mutually exclusive. The new capacity may be used both in Basic and Python scripts. A short update of the help texts (dialog and dialogcontrol) is needed with mention of above restriction. Change-Id: Ia078aaab317ced7ade7ce69694504013f8e768a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148800 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-03-14remove support for TBL_BOXNAME TBL_RELBOXNAME in ChangeStateBjoern Michaelsen
* PtrToBoxNm and ToRelBoxNm are both public -- use just them directly instead. Change-Id: I7b0e377a13f00a3e0ab90e1cd12325672a83d16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148213 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-14sd: fix crash in ViewTabBar::dispose()Miklos Vajna
Crashreport signature: program/libsdlo.so sd::ViewTabBar::disposing() sd/source/ui/view/ViewTabBar.cxx:113 (discriminator 1) program/libuno_cppuhelpergcc3.so.3 cppu::WeakComponentImplHelperBase::dispose() cppuhelper/source/implbase.cxx:104 program/libuno_cppuhelpergcc3.so.3 cppu::WeakComponentImplHelperBase::release() cppuhelper/source/implbase.cxx:84 program/libsdlo.so sd::ViewTabBar::ViewTabBar(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) [clone .cold] include/cppuhelper/compbase.hxx:65 program/libsdlo.so sd::framework::BasicToolBarFactory::createResource(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&) sd/source/ui/framework/factories/BasicToolBarFactory.cxx:129 (discriminator 2) I.e. the ViewTabBar got deleted by a smart pointer before its ctor finished, guard against this. Change-Id: I3d6ccc21167355047e3752316c8d0b9b02470f57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148838 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-14use more string_view in vcl::PDFObjectContainerNoel Grandin
which makes the call sites much less verbose Change-Id: I94eef7569e419f134ce574ecd9fb2ce8f50184b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14filter: PDF export dialog: always enable Outlines for PDF/UAMichael Stahl
This is not a hard requirement, but why not prevent this pitfall at least in the dialog: 7.17 Navigation A document should include a document outline that matches the reading order and level of navigational targets (ISO 32000-1:2008, 12.3.3). Change-Id: I06533123cdfe5fe1c79180d6ebd4e961b25a63b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148818 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-14filter: PDF export/PDF dialog: PDF/UA requires P bit 10 enabledMichael Stahl
Adapt dialog and export filter to ensure the bit is set: 7.16 Security An encrypted conforming file shall contain a P key in its encryption dictionary (ISO 32000-1:2008, 7.6.3.2, Table 21). The 10th bit position of the P key shall be true. Change-Id: I2e8e4f5b0ef44efeabf3017f2e12b58914e93520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148802 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-14tdf#154171 filter: PDF export dialog: don't show spurious error if PDF/UA ↵Michael Stahl
toggled 1. Security tab, set permission password 2. General tab, disable PDF/UA 3. General tab, enable PDF/UA 4. spurious error dialog mentioning PDF/A, which is unrelated to PDF/UA (regression from commit 5a7cfe98e96489b7fa19d286ddd1e8c8e591d7dd) Change-Id: I742da1cd459919faeae53fc21e5f97ee6a7c6ffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148801 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-14sw floattable: reject small(er than min height) row master at page bottomMiklos Vajna
The problem was that the second row in the doc model was split between page 1 & page 2, but it was expected that row 2 is entirely on page 2. The underlying reason seems to be similar to what commit 913b71dbe06c33773c4d779e00c6ec4b6a4af59f (sw floattable: ignore height of masters in lcl_CalcMinRowHeight(), 2023-03-10) fixed: again the minimum row height is meant to be enforced for each row frame of the row, so in case the remainings size on the page is 566 twips and the minimum row height is 1134, then we should not split the row, instead we should move the entire row to the next page. Fix the problem by checking for this (relatively) at the start of SwTabFrame::Split(), so we don't even try to split the row in this case. I assume that this would be correct to do in general, but have no such sample to confirm this in Word, so keep this specific to tables in split flys for now. Change-Id: Ic9171683ef7e14a70f7f8d5305198bbc16277d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148834 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-14tdf#139618 Add WordArt fill types in pptx importRegina Henschel
This fix uses a similar approach as in WpsContext::onEndElement, only that here moTextOutlineProperties and maFillProperties are still available whereas in WpsContext the properties need to be collected from CharInteropGrabBag. I have adapted unit test testTdf125573_FontworkScaleX because now the gradient is imported, see comment in former version of the test. Change-Id: I989ee475867c97b9f93c7e65cd25483611eec7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148687 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-14svl: fix CppunitTest_desktop_lib's DesktopLOKTest::testSignDocument_PEM_PDFMiklos Vajna
The problem was that this test passed when the entire suite was running, but not as an individual test. Digging deeper, this didn't pass in isolation because the test loads a private key into memory (which is not in the NSS DB) and since commit 5592ee094ca9f09bfcc16537d931518d4e6b2231 (svl: fix testSignDocument_PEM_PDF with "dbm:" NSS DB, 2022-04-28) we delete that in-memory key as a workaround for the NSS dbm -> sqlite transition. Fix the problem by not deleting the in-memory private key in the LOK case: this makes the test (operating in a stateless mode, with in-memory keys) pass again and keeps the desktop signing (working with the NSS DB) working. I noticed this test failure as a local test update of libxmlsec to 1.3 RC started to fail here even when the whole suite was running, but looks like this was working by accident before anyway, and the fix doesn't hurt for libxmlsec 1.2, either. Change-Id: Id365ddc5c5d04d538609f444c0e3c4ab4b32a6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148817 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-14tdf#150135: Fix OTextInputStream to throw runtime exception when uninitializedBaole Fang
New method checkNull is added to the class to throw a runtime error if mxStream is uninitialized. It is run in the beginning of all methods that require an initialized mxStream. Change-Id: Ia1f15d90c79c71b2a2350d9b60ef1bf68fb9009c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-14Colibre & Sukapura: tdf#153772 Revise Navigator's Headings > Outline Lvl iconsRizal Muttaqin
Change-Id: Ice9eeb2d2d9a5ef4bda2d373d007ba8850b0f052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148799 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-14tdf#154005 sc ods fileopen: fix dropdown form control sizeBalazs Varga
Dropdown form control size was increased by the size of hidden rows or columns. Regression from commit: 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca (Improve 'resize with cell' handling) Change-Id: Ic903a488cab22286f95cfdf4ee559013fd7bfa02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148738 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-03-14tdf#154129 writerfilter framePr: check whole style inheritance: VAnchorJustin Luth
This patch depends on HAnchor, which created vProps. A style can inherit its properties from another style, but the code was naively just checking the first paragraph style, and not any of the parents. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154129_framePr1 Change-Id: I72159321485aca18bc4bb8384221ff59cb685fe0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148689 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-03-13Always update fields when loading documentSamuel Mehrbrodt
to make sure that table formulas are re-evaluated after loading. When a document has a wrong sum saved (which seems to happen sometimes), this sum is used until user clicks into the table or otherwise refreshes the formula. Change-Id: I5cc3f983524b395089c17aa35d8641847a388bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148355 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-03-13Use a more reasonable type for XDataPilotDescriptor::checkName nIndex parameterStephan Bergmann
Change-Id: If9e6760a6b23c63d03d337d6b111493684d67c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-13tdf#153935 sw: PDF/UA export: guess table headers based on autoformatMichael Stahl
This is a bit of a disaster area because in contrast to SdrTableObj (see commit 0bc96b8805f2cfa2278729a9f3e56a350ddd69ad) the SwTableAutoFormat application doesn't have flags which "special" formattings like "first-row" etc. should be applied to the table. So add a horrible heuristic to guess depending on the content of its formatting attributes. Change-Id: Ie09538d37de6118409b04a4cec6ab46b74c4194d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148793 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-13Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to f3a16adcb0187df5cf9c01ae6b4550785c03375b - tdf#141474 Incorrect parameter names for Basic functions in help Skipped items: Mid, MIRR, NPV, Shell: - MID statement is bugged, TDF#154166 refers, no need to change it yet. MID function operates fine - MIRR and NPV do not support named arguments in VBA despite MS documentation. No need to update those pages - Shell keyword arguments are correct Change-Id: I09dcc280edeec158eafaf87286966c36447ff71b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148316 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-03-13tdf#126689 elementary: Jump Up & Jump Down This Level iconsRizal Muttaqin
Change-Id: Ia7726678521faa9cf90c3fcb06799c1eb420e399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148748 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-13make more use of OUStringBuffer::append(OUStringConcat)Noel Grandin
where we can avoid constructing temporary OUStrings Change-Id: I0eacd68a8d1b450894c2ea769055f16886b78ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-13tdf#154125: sc_uicalc: Add unittestXisco Fauli
Change-Id: I85a87d9c7f23f6e2c914542a328174cca02d3491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148790 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-13tdf#154106 Add Sukapura TipOfTheDayGaldam
Added Sukapura Totd images Change-Id: I4093f53a338cc4ed08e30a07f713aa741635a31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148785 Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-13Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b119b55661646266f6432addfa59f3de24925315 - tdf#153560 (tdf#153748) update "up to level" need to indicate that the option selects the header. correction to left/right arrow icons for tdf#153748 Problem arose because commit 59b602dcdb445116dde3e50dce45974eec0e043b removed the relevant information from links.txt refactor <relatedtopics>, remove <xml-lang> Change-Id: I0462c55ff54777b4b4b3af9a0c6de53634aabc2d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148762 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-13tdf#150281: Fix CentimetersToPoints in CalcBaole Fang
Originally, CentimetersToPoints was implemented as a base method for Writer and Calc. They are both using the same implementation, which is correct for Writer, but wrong for Calc. Since their behavior should be different, I remove the base method and implement a correct one for Calc. Change-Id: If957accdd9be86a96ca6fb711502e49a79bf3223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148745 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-13Fix buildMike Kaganski
... after commit 470a2c0692533f42d333b9416daf3f0871cd951a and commit 544d6d781b3c8aa108ced362d708693b5127f3d7 landed, tested on CI independently. Change-Id: Ibc2ee083e9afde47c37af3c20a8fcb895b635861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148765 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-03-13tdf#115321, tdf#139065 render emphasismark for pdf export.Mark Hung
Fix the logical mistake: it rendered emphasis mark only for spaces - that is excatly opposite to what we want. Change-Id: Id478af269c6cf8ab9a9e1413d19f9b3a3451d59d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147916 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2023-03-13Introduce OUStringBuffer::insert taking OUStringConcatMike Kaganski
Avoids some (re)allocations, and aligns with already existing append Change-Id: I536ba50f56fc560c0f6e8c0a8b65bd4248896a8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-13Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 8d23e853b52eab08b7f76ef92d875ffc5720f8e6 - tdf#153551 correction to "caption" and "category" + indicate that category is also mentioned before "caption" + indicate that "category" position depends on Caption Option * clarification about paragraph style applied to the caption Change-Id: I85dcccf3dd454ec33480f71cf2a5bd6f9be425b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148766 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-03-13tdf#154129 writerfilter framePr: address nit about nSafetyLimitJustin Luth
I was going to change --nSafetyLimit to nSafetyLimit-- anyway, since that better matches "getting 16 tries" like a code-reader would first expect (instead of only 15). I had thought about putting an assert here, but that isn't logically impossible to have 16 inheritances, so an assert seemed a bit too strict. But as the reviewer noted, a SAL_WARN at least ought to be here. I thought perhaps using an unordered_set might let me automatically eliminate loops, but then according to the documentation it uses "random" sorting and isn't treated like an array, which is definitely needed here. Of course, I could add the logic to simply check if the new value already exists in the vector. However, I believe that a loop would be considered an "invalid document" and thus should never exist, so clean-reading code and a safety valve against a malicious document seems appropriate enough to me. Change-Id: Ie6132c1beb483a6bee9c9794934ba8de7cfd82bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148784 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
generated by cgit (git 2.34.1) at 2025-03-24 14:38:53 +0000