summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-18Use getXWeak in packageMike Kaganski
Change-Id: I838b7c0e45a2a701d400fb7189c5396ed4525a70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150860 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-18Use getXWeak in editengMike Kaganski
Change-Id: If68b80bae13b2e507f8286f6e316d86c0d0255f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150845 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-18Use getXWeak in configmgrMike Kaganski
Change-Id: Ia7d9475cecd2208ccf672f2b35c0c841fed7f4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-18sc drawstyles: Restore text selection after applying a styleMaxim Monastirsky
Change-Id: I0a9bb39d8a7a9e770b3593eaa0a97867cbe86913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153171 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-17Fix typo in codeAndrea Gelmini
Change-Id: I8f7e3b11b952b1882ca8e67619145c0dca71820a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153205 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-17Fix typoAndrea Gelmini
Change-Id: I1d7b271eed63dd0272bd92431eaac3e2dfbfe2b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153206 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-17Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)timeEike Rathke
Change-Id: I18567fdac512ee786ce4b0785b01b2ae6da7450e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153203 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-17tdf#155402 - sc improving CELL() function return value in case of OOXMLBalazs Varga
In case of Excel/OOXML formula syntax: Before the patch =CELL("FILENAME";D2) returns 'file:///X:/dr/own.ods'#$Sheet1 After the patch =CELL("FILENAME";D2) returns file:///X:/dr/[own.ods]Sheet1 Change-Id: I34c805aef813632c45ac3fe930d690ae3c1d5d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153098 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-06-17Related: tdf#153517 Introduce class tools::DurationEike Rathke
Change-Id: I73ea6e162c73382ba470a306ce2852dbff3d1314 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153202 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to fe8a94e99b738bcfe5f36ac999349f9436ef769d - tdf#155875 Tabbed UI commands Writer in Help pages + refactoring + Writer View menu (part 6) Change-Id: I422906f06158e5dcc49b81cf1ef5f108d24dbf95 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153201 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-06-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 77b1451f125ef99c9fb1a017e27f75120d6f1842 - tdf#155875 Tabbed UI commands Writer in Help pages + refactoring + Writer View menu (part 5) Change-Id: I23f49b7a283f53c97725da23f27fab8e6d944fef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153195 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-06-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to ea5863372e39437174ea1403ef30092013248df0 - tdf#155875 Tabbed UI commands Writer in Help pages + refactoring + Writer View menu (part 4) Change-Id: Id3282f560d57a7934a7e54a7c6afe378b6e55b4c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153194 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-06-17oox, writerfilter, xmloff: use frozen data structures for static dataTomaž Vajngerl
Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153175 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17svgio: use "frozen" for mapping between token strings and enumsTomaž Vajngerl
Change-Id: I2061606146cfcb34169dccf69b6f720727839d04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153174 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17Add frozen library support - for compile-time dict, set supportTomaž Vajngerl
Change-Id: I8fa02569ba02048cc3ef02b349aafba1c0cbebb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153173 Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-17sc: perf: speedup sheets with lots of repetitive...Dennis Francis
row styles using a small cache of already allocated patterns that are tied to extended format id and number format id. Change-Id: I3136aef9a034635924f7b7b6d2432f9ae5c2bd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 92b13ad1f1a87393cf66a35694f3e542db57f150) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-17improve exception messageNoel Grandin
the colon here made me think a piece had been chopped off. Change-Id: I1e0f0ef9c16e0fd8f7619a3d8e58e8e0886fda9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-17SAL_WARN->SAL_INFO in SdXMLStylesContext::CreateStyleChildContextNoel Grandin
This is not an error - this method handles elements if it knows about them, and otherwise leaves the elements for other code to handle Change-Id: I531a2d9aff84ef4a2762923737a6b827e88cd920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-17sc: filter: oox: only insert conditional format if has itemsHenry Castro
Otherwise, the empty conditional format will exists. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I99d83bd50ce4c12ef9be6924cba31b8847c0ad07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149720 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151978 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153200 Tested-by: Jenkins
2023-06-17tdf#118335 notebookbar: set visible false for PrintPreview in MenuFileJustin Luth
The label for "Print Preview" comes from ContextLabel in these menus - and it displays "Close Preview" even if the print preview is not active. The PrintPreview buttons in the notebookbar ribbon itself work fine. So just hide the menu ones for now. Perhaps that is not good for accessibility, but I would imagine accessibility people would stick with the traditional menu anyway, since the notebookbar is also horrendous in many other ways for accessiblity. The user can turn this back on again if they want. Customize - Notebookbar - File Tab | File | Menu File Change-Id: I807941650295132c9e15f04094cece26246318d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153199 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-16sc: filter: oxx: insert more rules same rangeHenry Castro
If there are rules with the same range to preserve priority order. <conditionalFormatting sqref="I4:I5"> <cfRule type="cellIs" dxfId="5587" priority="1500" operator="equal"> <formula>"GO"</formula> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="E11:I12 E15:I16"> <cfRule type="containsText" dxfId="5586" priority="1457" operator="containsText" text="R"> <formula>NOT(ISERROR(SEARCH("R",E11)))</formula> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="I4:I5"> <cfRule type="containsText" dxfId="5585" priority="1501" operator="containsText" text="R"> <formula>NOT(ISERROR(SEARCH("R",E11)))</formula> </cfRule> </conditionalFormatting> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ibb98953f0a50140dbde4d52a79fde968095881d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150436 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153198 Tested-by: Jenkins
2023-06-16sc: filter: oox: fix conditional color scale same rangeHenry Castro
Otherwise, the condition color scale the priority order will be lost. <conditionalFormatting sqref="G1:G5"> <cfRule type="colorScale" priority="5"> <colorScale> <cfvo type="min" val=""""/> <cfvo type="max" val=""""/> <color theme="5" tint="-0.249977111117893"/> <color rgb="FF92D050"/> </colorScale> </cfRule> </conditionalFormatting> <conditionalFormatting sqref="G1:G5"> <cfRule type="colorScale" priority="1"> <colorScale> <cfvo type="min" val=""""/> <cfvo type="max" val=""""/> <color theme="0" tint="0"/> <color theme="0" tint="0"/> </colorScale> </cfRule> </conditionalFormatting> Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I33fa73bfe8f0bada1cf79bc07be2e43495a4290c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149721 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151979 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153182 Tested-by: Jenkins
2023-06-16tdf#132061: disable uno:PageColumnType when read-onlyJustin Luth
When the document is read-only, it should not be able to be have the column information changed, so disable that toolboxControl, just like everything else. It was set to be active in READ-ONLY mode since initial import, but no indication why it should be different from the two other page actions added at the same time. It was added as part of adding the sidebar. However, I don't see where it would be found in the sidebar. It is not in the normal menus - just in the notebookbar. Change-Id: Icf342d5ee51cf8bba296049833e0e520813efb03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153193 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-16tdf#155735: unify unittestXisco Fauli
Change-Id: I8de80f869715d4476e62f526e0bb161de8274977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153181 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-16sw uiconfig: add README to explain the different menusJustin Luth
Inspired by tdf#126379, where a Master Document does not use the notebookbar UI - even though it is clearly Writer. So now I finally know what sglobal is for. I had been wanting this information for some time now. So I did a bit of experimenting and verified my information. (I'm not compiling with database support, so I couldn't prove those two, but what else could they be?) Change-Id: Ie1e7615a401c0c07168219dab3e9f02f9e33e996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153188 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-16tdf#155720 remove old skip notebookbar init workaroundSzymon Kłos
This was introduced due to not working Paste Special dialog in LOK case. Now everything seems to be ok. Single initialization should make loading process faster. Change-Id: Ic464908ef044cc446626fff0fb9b4f57e061aea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-16tdf#155871: don't forget to close li before starting nextMike Kaganski
When closing a nested list, the previous condition failed to close the last li in case when the next item is numbered (i.e., will need another li). Indeed, if the next item is unnumbered, current last li should stay open. Change-Id: Iad7d83d50d2f02d6bd1d046804b7e23b59f9ce8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I914d0d62b1807daddea042ced173195d115f31e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153186 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16tdf#146626 catch IndexOutOfBoundsException when fetching accessible childrenPatrick Luby
com::sun::star::accessibility::XAccessibleContext::getAccessibleChild() can throw an IndexOutOfBoundsException exception even when fetching with an index that is positive and less than the value returned by a call to the accessible context's getAccessibleChildCount() method so put every getAccessibleChild() call in a try/catch block. Note: this is actually expected behavior even though it is rare. For example, accessibility::AccessibleTextHelper_Impl::getAccessibleChild() uses the following code snippet to throw such an exception: if( 0 > i || i >= getAccessibleChildCount() || GetTextForwarder().GetParagraphCount() <= i ) In the case of tdf#146626, getAccessibleChildCount() returns 22 but getAccessibleChild(1) throws such an exception due to the last condition in the above code snippet. Change-Id: If974afb7b9178faa99b91dcd79eb5f169bbfe13e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153160 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I05a77aedfed9ea8dffed134d6748151c88dc4c7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153184 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16tdf#143148: Use pragma once instead of include guardsVenetia Furtado
Change-Id: I83c7405c61edd2c92ad624064326ba9c9e971313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153164 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-06-16ofz#59859 TimeoutCaolán McNamara
an interesting finding, but we still want this fuzzer to generate documents that don't need tweaking to load in the normal office so enfore the xml detection rule Change-Id: Ie21f8f5d985b97068935fab6a6abfee8901b1b5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-16tdf#146547 sfx2: allow read-only documents to be modifiedMichael Stahl
This is particularly useful for a Writer document that contains a section that is set to be editable in a read-only document, so that the user is warned when closing such a document without saving it. Originally this check was added in commit 27db57efc51487b3976fbf73df1868b8fb78d201 "CWS fwkbugfix05" "#i39869#: readonly docs should never become modified" but the actual problem there was that the read-only document was displayed in a wizard dialog, not in a document view, so let's instead check that the document is some kind of "internal" document. Also the dialog's Save button should do something, and since the document is read-only, a Save As dialog appears appropriate. Change-Id: I339cbe92a2c9eb74a1f5061246f921037a47f79c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153180 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-16tdf#155736 replaced m_bStartTOC condition with a method IsInTOC()Satya
Modified IsInTOC() method and refactored usage of m_bStartTOC with IsInTOC() in the previous commit,but m_bStartTOC is still used at one place and now which is replacing with IsInTOC() to maintain consistency. Change-Id: I7fe50770741d68d9db35d74e138417728c2e3dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153165 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Justin Luth <jluth@mail.com>
2023-06-16tdf#125154 i18npool,sw: fix group separators in numbers in formulasMichael Stahl
Commit 776f7e7463de3e97f3056712ee567f49a314829d changed cclass_Unicode to reject group separators in numbers by default, but users are complaining that the neat "5.000" numbers in their existing documents are now considered invalid. * in SwCalc, use GROUP_SEPARATOR_IN_NUMBER * in cclass_Unicode::parseText(), reject a group separator if it is not followed by at least 3 digits With this, a number from tdf#42518 "0.19" is still considered invalid, while "5.000" is now valid again. Change-Id: If86f2ed4c27be16f866d7f4cee00789344e9ee2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153047 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-16sc: filter: oox: fix conditional color scale empty value \"\"Henry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I115c3731db85267d115efd24739470bffaeace40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149718 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151976 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153178 Tested-by: Jenkins
2023-06-16remove dead codeNoel Grandin
Change-Id: Ia8523e992b30ba8674ca88374906cb3c671df5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: Idd27071c1200d6ced2c4f43e10310df786fbc8fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16tdf#155847 sw tracked table column: manage multiple changesLászló Németh
In Manage Changes dialog window, group also redlines of multiple different column changes. Follow-up to commit cc52d895314dd7b67de916bd90ccbfa098e77419 "tdf#155342 sw tracked table column: manage changes". Change-Id: I3c9e69bf554bc5b4ce9473f95fff5954228758bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153172 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-16tdf#154521 sw navigator: allow to query selected bookmark via UNOLászló Németh
If the hidden title of SwNavigatorPanel was emptied via UNO XPanel interface, store the name of the selected bookmark there. This allows to query the selected bookmark using UNO e.g. in add-ons, i.e. to disambiguate when multiple bookmarks are there on the selected text range. Note: this is a workaround because getDialog() of XPanel is not implemented for SwNavigatorPanel. Follow-up to commit c4a58634753a84b09f20f7271d6525a6656522d3 "tdf#154545 sw Navigator: select & track nested bookmarks" and commit 6eb1d540a1e599aa4fe0a321eddb9cc22e0546d3 "tdf#154521 sw Navigator: fix selection change event of bookmark". Change-Id: I94f79daf59516331155e0b36502821c769771207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153162 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-16tdf#155852 same method for StepCount in OOXML as in renderingRegina Henschel
Rendering of stepped gradients uses a method that doesn't take the color from a cut point, but before or after respectively. For example, for StepCount 4, the colors at relative positions 0, 1/3, 2/3 and 1 are used. So sections are 'start color', '1/3 color', '2/3 color' and 'end color'. The output to OOXML now uses the same method. That way rendering in a produced pptx-file is the same as in the original odp-file. Since OOXML has nothing similar to StepCount, it is an export only problem. A second problem comes from the cuddle with StepCount in Gradient struct in API and FillStepCount in shape property set. The draw:gradient-stop-count attribute in ODF belongs to the graphic style of the shape. The gradient definition itself in the <draw:gradient> element has nothing about step count. When a file is opened, it can be that the StepCount component in the Gradient struct still has the default value 0, but the FillStepCount property has the correct value of the shape. The Gradient struct in the API should not have a component StepCount to be compatible with ODF. But the API is published and changing that struct is far-reaching in the code. So the fix here is not a general solution but solves the problem for export to OOXML by reading the FillStepCount property while exporting. Change-Id: Ie1cafe6bdda7c4d74b05f279f0d8212ff67ecc92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153154 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-16tdf#103064 Improve comment style usage detectionMaxim Monastirsky
With this patch the "Applied Styles" filter should list also styles used in comments. Change-Id: Ifcb716cb66a0d271ca3d7ce477e6299015310ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153163 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw: enable the UI commandsMaxim Monastirsky
Change-Id: Ic3e5ab9df5386a1cad0801f7044e6148620aa3b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152643 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16ofz#59854 Null-dereference WRITECaolán McNamara
Change-Id: Iedbf21248b7d75474ea325905569d192360380f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-16Fix typoAndrea Gelmini
Change-Id: I774554c7945d5560e229d6c94e9efbafd77deeca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153106 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-16speed up startup timeNoel Grandin
by avoid conversion of static locale data from sal_Unicode to OUString data - we can declare the data as OUStringConstExpr arrays and then no conversion is necessary. Change-Id: I652f02f6f1f354e2dab4f0ca866e8499cd3c50f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-16sw layout xml dump: extract SwTextFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about text frames. Change-Id: I2734e76ced3001de1fc1176d6315f8c69c02d8b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153152 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-06-16tdf#103064 sw: use the comment style by default instead of DFMaxim Monastirsky
As part of that, language changes in the document's body are no longer applied to comments, as that would be a DF. Instead, the default language of comments is controlled via the style (see tdf#153805 for the use case). Change-Id: Icfa9a7334b52fe74292e82fa8daa01a15197e384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153158 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw,editeng: enable UNO API and ODF import/exportMaxim Monastirsky
Change-Id: Icf30e1f30fe6bf6a7d96d14b975954613cd68b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153157 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-06-16tdf#103064 sw,editeng: make para styles work inside commentsMaxim Monastirsky
- Style objects for comments are stored in a dedicated stylesheet pool, and constantly updated from the "real" styles using modification broadcasts. In theory, it should be possible to use same objects for both Writer core and EditEngine, as they use separate item ranges. But unfortunately SwDocStyleSheetPool isn't really a styles container, but just a wrapper around Writer's core styles, with a single mxStyleSheet member that is filled each time with data from different styles (while EditEngine expects different styles to be represented by different objects). - EditEngine switched to allow duplicate listeners for styles - one per paragraph. The use case is 2 paragraphs of the same style, and then one of them is switched to another style. In that case we still need to keep listening to the former style for the other paragraph. There is probably some opportunity for optimization, but it should be good enough for now. - Copying formatted text from document's body doesn't preserve style assignment for now. The editeng RTF import should be tweaked to not insert styles into our "special" stylesheet pool (or somehow forward them to Writer's core style handling) before we can enable this part. Change-Id: Ib67c5388f9cd078c73ec0d453017f815843161ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153156 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>