summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-15editeng: lok: send cursor visibility event when restoring update modeAshod Nakashian
When the default text is removed from a TextBox within a slide, the cursor visibility is inadvertendly set to false and never restored (because the LOK notification is disabled due to treating the ShowCursor during SetUpdateMode as an activation of the TextBox, and that is supressed to avoid messing up the cursor when creating a new view). We add a new flag to SetUpdateMode to flag whether this is an activation or we are restoring a previously active window (TextBox) due to a temporary disabling (to clear the default text). Four unit-tests added not just to check and validate the fix, but to also simulate two different ways of entering edit mode, first by single-clicking on the text and then double-clicking outside the text, but within the TextBox. Change-Id: Icaaabc2a897f614f5ce162b71fadccff22ecda02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90301 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 6b84dfabbb5f6930f9ac582f8c1dd9f467fd068c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90298 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-15Check for some more expected calendar elementsEike Rathke
Change-Id: I615ffc60fcc235fcc84848a22fd7bd3b0d8179d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90441 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-15cid#1460666 Unchecked return valueCaolán McNamara
Change-Id: I47298fdb780ac546ad1c795ba5aea54b6a71758c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-15Fix typoAndrea Gelmini
Change-Id: I434c33cac9e8988d0069e8a15a717ef34e6af482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90527 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-15Revert "loplugin:constfields in ucb"Noel Grandin
This reverts commit d8f8b4375998b62431c8605004e7c7d5c921ccc9. Change-Id: Iece88b16cfb2e4ff18dd82bbf6624dc64a33cebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90519 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Revert "loplugin:constfields in unoidl"Noel Grandin
This reverts commit c04a8576f07cb837439959b8bdbb8b620684d508. Change-Id: Iefede980495d9d59ab3fa26e1ccfa85a58a5c206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Revert "loplugin:constfields in toolkit"Noel Grandin
This reverts commit 175834ce6a3ba707a6d34aa8de7351574381f481. Change-Id: I4b524ca1aa9aed2273b5d891a02fc0b360abc94c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Revert "loplugin:constfields in ucbhelper"Noel Grandin
This reverts commit 64035391ebe8810520a214a3ae0aeb4c1b039819. Change-Id: Icfde3e984f9ebf93a423d101aee385182f65dea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Revert "loplugin:constfields in tools"Noel Grandin
This reverts commit 833c4965fc0941ea997852e3d99dcd7688e58c14. Change-Id: I130a91538627f9e83d94615e2ddd48da5a075d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15expfld.cxx: SwIterator no more ...Bjoern Michaelsen
Change-Id: Ibf84841f5a74c0420c8fdb544e674d883af9b667 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90522 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15tdf#124424 Fix WrapModeTileFlipY option for LinearGradientBartosz Kosiorek
Change-Id: I61a533d2fab085992c1507331699b78aca2c8d29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90515 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2020-03-15SwDbField::PutValue: SwIterator no more ...Bjoern Michaelsen
Change-Id: I5919cf91f342bbd29bad994e4094a3e5490aab21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90509 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15edfldexp.cxx: SwIterator no more ...Bjoern Michaelsen
Change-Id: I3b7aba9c9020e253116940dbe5cd75a047b2e2e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90508 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15tdf#124424 Fix orientation of the LinearGradientBartosz Kosiorek
Change-Id: Id0547fcea95306997f8f04d400f3073abb6d6c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90514 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2020-03-15Resolves: tdf#130371 Undo of sheet-local named expressionsEike Rathke
... created during paste (and maybe other operations). Change-Id: I75d668f717b7336a1a65a9e02c75bf2aefe860b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15tdf#131273: fix crash when pasting quotes with fixed widthJulien Nabet
See bt https://bugs.documentfoundation.org/show_bug.cgi?id=131273#c2 Change-Id: I78f592bb2ee59b50e7301fe4e6f282e53c4eeb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90438 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-15SwTOXBaseSection::UpdateSequence(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I3b52e980d75a27d9ef9f66b4672cf4e52e7d297d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90507 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15DocumentFieldManager::GetFixFieldsAtPos(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I8a820fc89ba7a127162bf942b076956403e4721f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90506 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15DocumentFieldManager::SetFixFields(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I8fe9879eda45a6fe2a013fd8e0b3e2c315cb0b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90505 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15DocumentFieldManager::UpdateTableFields(): SwIterator no more ...Bjoern Michaelsen
Change-Id: Ic2d4fa7fe191f60837feab578e3573e21dab3d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90504 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15crstrvl.cxx: SwIterator no more ...Bjoern Michaelsen
Change-Id: Id92053b2d4310dc684ab1e51f8fdf6c2a0e2c62e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90502 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15SwDoc::ConvertFieldsToText(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I68ef8fa411c6da21e99b0e5435481a03e0d32db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90501 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15SwDoc::HasInvisibleContent(): SwIterator no more ...Bjoern Michaelsen
Change-Id: Iff639ea1400f38079cc891f52e583476fb484dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90500 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15SwDoc::RemoveInvisibleContent(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I62400059950bbd0cd110a4d1144d8e9a7163b744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90499 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15docufld.cxx: SwIterator no more ...Bjoern Michaelsen
Change-Id: Ieb0c9f8aea3fa70260cb74e6b7850fd84108aacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90498 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-15tdf#105600 rework section selection from NavigatorJim Raykowski
Corrects selection behavior when the section is empty or has a single empty line before a table. Also, doesn't suffer the SelAll function use selection misbehaviors when a table is at the start of the document, other than for the case of a section containing a table at the start of document, in which case, neither this rework nor SelAll function selects the section. Change-Id: Ibdefa0af417fc3c3262acaa1977fec811c8f24e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90181 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-14Firebird: fix TODO use xClob instead of xBlob for REMARKSJulien Nabet
TODO added with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a author Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-10 12:58:32 +0100 committer Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-11 16:05:11 +0100 commit e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a (patch) tree b61ed29963dea3d6fd1c276ab6cc05a143e2058b parent d12ddee812480595745b656113475468bddc4b1a (diff) Reduce verbosity of getTables. (firebird-sdbc) Change-Id: I14c46ab9d36bf40791004941684308011af81b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90494 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14tdf#131337: fix range for "Surface angle" (tab "Shading" in "3D Effects")Julien Nabet
Should be to 90° max instead of 1000° Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=11d0c28601dc89c48e67a7b39ba82dd52e660334 author Caolán McNamara <caolanm@redhat.com> 2014-12-28 16:30:18 +0000 committer Caolán McNamara <caolanm@redhat.com> 2014-12-30 15:43:39 +0000 commit 11d0c28601dc89c48e67a7b39ba82dd52e660334 (patch) tree 75e0e9d83694637de1e3b95a25c66de911d381bc parent 04299dba24d04b08d54f4f5945d340d7abfa73e4 (diff) convert RID_SVXFLOAT_3D docking window to .ui This is an epic dialog with lots of moving parts Change-Id: I867723f65273bf46b0693910d88e11a9197384c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90493 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14sw_GetPostIts(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I4a8465e2109b3703d0491aaf0578b61e8c00eb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90490 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-14SwDBFieldType::PutValue(): SwIterator no more ...Bjoern Michaelsen
Change-Id: I4507ee036611f52a7685077cc880163cd7b83881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90492 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b380314caa37246d51a7ac2b00a2907e1b824112 - more cleanup in help page for field variables - move some <embedvar> into a <note> for "Numbering by Chapter" "Level" and "Separator" Change-Id: I2e72c4e711c1e7d1e85c78fd344f6b471ee5947f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90392 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-14Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 4ef0e0f1ea2f77d7b5606da6ed94569c166f6c0c - Slide Design command and dialog was renamed Change-Id: Icc7379d1c1204f203f011bea512614d72836fe0a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90130 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d68296397cbf9913c577c02ea6c95f74e7ce594e - Fix error reported by translators. Change-Id: I475d2f5dea0cdbabbbac9cf31613c29f3c9f015a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90483 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-14tdf#130460: clarify the option some moreMike Kaganski
Change-Id: I4f1de2d3b112c5a4d3ba795bd944aa21add037a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90396 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14Revert "Resolves tdf#99675: Add BPMN images to the gallery"Heiko Tietze
This reverts commit 2e74fdc559eb1b7bab1a6661203400017f93b234. Reason for revert: Does not work Change-Id: I8014d2d046385a795777208330e2a6af1b9f5222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90395 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14Revert "loplugin:constfields in stoc..svgio"Noel Grandin
This reverts commit 0ddf3e0a628599d01356cb5262b93faca073ee9f. Change-Id: I3e476399a465950defc15ac4d6199a638c4a4baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Sukapura: Add tiny blurred shadow to more iconsrizmut
- Update User Interface, (Calc) Group & Ungroup, Footnote & End Note icons - Add Status Bar icons Change-Id: I40b0700d024af216b62028524cb73b45b8901492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90477 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-13tdf#129471 alphabetize Navigate By option in writerShivam Kumar Singh
The "Navigate By" option in find does not have a particular order. In this patch all the options are sorted alphabetically . Change-Id: I52fdce37ac86ed12b7ea123f7238bf2b788f8a2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87670 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-13android: Pass Intent's action in ctor alreadyMichael Weghorn
This also prevents some static analysis tool from issuing a false positive that "The application uses implicit intent that may be insecure under certain conditions". Change-Id: I1d4198b1c26c764c927d99c9a9e144da96ebc109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90457 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-13compare using GtkTreePath instead of GtkTreeIterCaolán McNamara
Change-Id: I53d8f686fd924c82fc00285f28dbdc7c73577f7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-13uitest: select child instead of moving downXisco Fauli
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13Revert "loplugin:constfields in svx"Noel Grandin
This reverts commit 1a6397030381a45f27ab7a2a02e6e6d0f9987c84. Change-Id: Iaa706bb4ea3144ef57ab359b982400abc589b97e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svl"Noel Grandin
This reverts commit 5181253946ca1877cc42050452aa6d733d6da3f1. Change-Id: I30e30aae45c33824c0df823a9fad710faa81ea3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13uitest: import missing LocaleXisco Fauli
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13vcl: warn about unused GraphicConversionParameters instancesMiklos Vajna
I just made the mistake of creating one but then forgetting to use it, warn about that. Change-Id: Ie7e6e34eb234468d4a255e438b9551c81a9d2fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90459 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>