summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-04fix some DocShell leaks in unit testsNoel Grandin
need to call DoClose() to unwind the internal ref-counting Change-Id: Ibfd13e2300f3542e5e86363facd5b41dbfafdf6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03Revert "Adapt to changed clang::ASTContext::getParents behavior on Clang 11 ↵Stephan Bergmann
trunk" This reverts commit 09aa5a9be8b9b3c88cf25b85e0eda28c5ef19aa4, now that <https://github.com/llvm/llvm-project/commit/ 551092bc3dfb86f1e11a55f3bee0c8ee1be6fdd6> "Revert AST Matchers default to AsIs mode" reverted the Clang commit that prompted this compilerplugins change. Change-Id: I75c8b4cb2894cd67a791db460f2886a783856c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100026 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03tdf#133687 Fix the placeholders priority order.Gülşah Köse
When we don't have type attribute on slide but have on slidelayout we have to use it instead of default type. Change-Id: Ibb874b5ee39c48641484fe1a8686f66c31695f76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99904 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-08-03Fix typoAndrea Gelmini
Change-Id: Ia2ab8c92bf28bae5a70f1e768e91093695dd3dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-03tdf#133747 add missing character to make the sort feature work correctlyTomoyuki Kubota
Change-Id: Icea2dac6e4ef6493c2a7fe5f7def0f1708caf6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95684 Tested-by: Jenkins Reviewed-by: Tomoyuki Kubota <himajin100000@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2020-08-03loplugin:flatten in ucbNoel Grandin
Change-Id: Ica7e5d3b5a5cec065f35f99d62b3b6604323601a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03loplugin:flatten in ucbhelperNoel Grandin
Change-Id: Ic5a8ce908671bd492395bff01aa211b8bdd74ca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03loplugin:flatten in sdNoel Grandin
Change-Id: I57cf26d800d8d414014b88c250ee1cbd47551bc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100007 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03fix leak in ScCacheTestNoel Grandin
and put the init/destruct in constructor/destructor instead of setup(), we want this to run once, not for every test method. Change-Id: I7d5fcdd2974677f1509048c16fb40d03dff289c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100004 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03ofz#24648 fix slkfuzzerCaolán McNamara
Change-Id: I3dce445038a29a622ceea2415e7736768a95206d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100029 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-03correctly mark the "New menu" dialog as modalMarkus Mohrhard
The dialog is called from a modal dialog which means a modeless dialog does not make sense. Some of our internal dialog tracking code is confused by that case which confused the UI tests. Change-Id: I705877e8a751c55bfbd00ddeaf18ab86c95321c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99944 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-03tdf#134560 tdf#135107 make inspector contents human readableShivam Kumar Singh
This patch adds a dedicated hrc file for RID's of all the properties that can be displayed in the Inspector Change-Id: I258ca060508e28b7b66e96393fcef4fd104bb781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99983 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-03-Werror=redundant-moveStephan Bergmann
...now that GCC 11 trunk implements P1155R3 since <https://gcc.gnu.org/git/ ?p=gcc.git;a=commit;h=1722e2013f05f1f1f99379dbaa0c0df356da731f> "c++: Implement C++20 implicit move changes. [PR91427]", at least in -std=c++20 mode Change-Id: Ie3c8f391fe4a6a99144ab35b2b29214ac5413fc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99999 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03Validate SELECT rangeStephan Bergmann
63049e98a659290229d3356e76d49cea44575011 "Reliably set up controls of hyperlink dialog in constructor" fixed an issue that could cause Python UITest code to issue a bogus SELECT request that would fire an assert in rtl_uString_newFromSubString. Even if that issue is fixed now, it is probably a good idea to validate the requested range here. (An alternative would be to validate it in the underlying shell's SelectText, but that function is also called from internal code (which presumably already ensures that it is passing valid arguments), so it is probably better to stay with that function's narrow interface.) It would probably be nice if this function reported failure (by throwing a css::lang::IllegalArgumentException, say) instead of silently (modulo SAL_WARN) clamping the range, but it is called from Scheduler::ProcessTaskScheduling (vcl/source/app/scheduler.cxx) in a try/catch block that prohibits all exceptions. Change-Id: I5b7b4255861766a81a81501e391b1ff4e09b7db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99933 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8b7b468cfcb1591972ee2e47a295ee4cf86a46e8 - Fix tag contents Found you finally... Change-Id: I71e11b570e31ad1cc470dfea3e54935e000d80f0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100011 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-03Missing include (std::max; Windows --disable-pch)Stephan Bergmann
Change-Id: I31d44c0a1791c58c0fc348fb2ec42fe2e2ec4323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100003 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03Make test operate on copy of .odb fileStephan Bergmann
For whatever reason, CppunitTest_dbaccess_hsqldb_test had recently started to modify binary dbaccess/qa/unit/data/hsqldb_empty.odb in-place. Change-Id: I07b5185ddf4b809ef1e1f977c5ab1c34e2e7f18a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100002 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-03loplugin:flatten in sfx2Noel Grandin
Change-Id: I2ff95614c82a6ed79e5ac593c85473a78ee41a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to f0fc51ab506034db25dd325a3b3b0e123af62e98 - tdf131416 Basic syntax diagrams - Close, Get, Put and Open statements Change-Id: I09a89ededbf65c41a65e3d347111c9dac10cfdde Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99601 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-03oox smartart, linear layout: limit height of children to parent sizeMiklos Vajna
Constraints are OK to request more, but it seems PowerPoint doesn't allow leaving the parent, which simplifies the layout as well. Change-Id: Id67a8740f1eff506e4beae0c797ad50e0218dfe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99993 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to dc36eea48b4a2120911d0f99322ff4a35ea39eb6 - Update version 7.0 New features video Change-Id: I35fff323f6ccb6a035d87abcd8b08189276054e6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100000 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-03use more explicit types in xmloffNoel Grandin
instead of declaring them as a base-type, and then static-casting everwhere Change-Id: I53b901c5353bb39ca9a0357aa442f50d2f475e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03rename Clear() to dispose() in SvXMLStylesContextNoel Grandin
to make it "clearer" this is part of the memory cleanup on destruction process Change-Id: I789bdfa0323cf759ed4db2e2a657e73e581d9eed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03fix leak in SvXMLImportNoel Grandin
caused by a ref-counting cycle. to reproduce the leak do make CppunitTest_editeng_core \ VALGRIND='memcheck --leak-check=full \ --suppressions=$$BUILDDIR/solenv/sanitizers/valgrind-suppressions' \ CPPUNIT_TEST_NAME="testBoldItalicCopyPaste" Change-Id: I94dca092a75db8ddfaae4a210e1158fa066ed609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99989 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03avoid ref-counting cycleNoel Grandin
this doesn't fix the leak, just reduces the number of cycles involved here Change-Id: I31eda167864dc8b5cea2448f598e01f3a807481a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03sw: SwFlyInContentFrame, SwHTMLTableLayoutCnts, SwHTMLTableLayoutColumn ...Miklos Vajna
... and SwTextFly See tdf#94879 for motivation. Change-Id: I833b563a03824ae14014cdd418dcfd3b832a9a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-03BASIC : no need to initialize manually std::unique_ptrArnaud Versini
Change-Id: I7e4780d41dd43383820cc3ae4ce5cfba24a53b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99942 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-03oox smartart, linear layout: fix scaling of spacing without rulesMiklos Vajna
With this, finally the arrow shape has the correct horizontal position and width, even if the markup is as complex as the PowerPoint UI generates it (the previous version was a more minimal version). Change-Id: I59f237c582053067e890180a1ae40471e5f46dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99894 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-03loplugin:flatten in configmgr..i18nutilNoel Grandin
Change-Id: Idaeed33df4f1dd1b2acbdaf8a895c5d56c3ca14c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03Remove pointless checkMaxim Monastirsky
This check was originally introduced by me for a few toolbar controllers (save, underline, currency), as an attempt to reuse the same controllers also for non-split buttons (see tdf#98745 and tdf#101672). But since then it was copy-pasted to other places where it probably makes no sense. Change-Id: I7af2a3f5864ced88c91f330e87f32046d0c21383 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99960 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03Fix radio buttons in context menus for non-gtk3Maxim Monastirsky
The vcl implementation expects menu item attributes to be set on the sub menu they appear in, not on the parent menu. Change-Id: I7d6553126ed1dd5c1434529342b776aee01409a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99954 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-03fix build with (system-)cppunit 1.14.0Rene Engelhard
by #include <unotest/bootstrapfixturebase.hxx> so that CPPUNIT_TEST_FIXTURE is defined Change-Id: Iacbfb2f513df6e7eb7ca04f7900cd4e6b3fd69c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99963 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-03loplugin:flatten in vbahelperNoel Grandin
Change-Id: I05ecaf86cd92dd764a3c19a62ce911eef632a0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03Clean-up of abstdlgHeiko Tietze
Unnecessary functions removed Change-Id: I32dab4b4c5fe8ff351277cbbd32e0b462443d031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99959 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to ed6ae5a833fbf4ce2c59a479d2c4b5ad818ab128 - Fix errors after translators review Change-Id: I088a2a5e56cfd918f5418738fecb2cd98ab67526 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99949 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-03Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to b735b9689e0cf53a480cf9da537f75349685f576 - tdf#132643 Translate German section IDs Change-Id: Iefe83ed0bc3376ad1befbe8d3734654408be107d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99953 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-03tdf#134971 Don't overwrite default styles when inserting docThorsten Behrens
Seems code never really bothered not to touch default style info, when inserting from file. Original commit is: Author: Sascha Ballach <sab@openoffice.org> Date: Wed Feb 28 08:24:41 2001 +0000 import of default styles added Change-Id: Ibb639a585bedabdcc5987900ecca1e04f4bb593a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99015 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-02Fix typoAndrea Gelmini
Change-Id: I298d8c5aac6e340fb4d5c753abbd8fa80ffc9408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99962 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-02loplugin:flatten in UnoControlsNoel Grandin
Change-Id: I0702283083297fc956eb8bd5132a1144286e1fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-02loplugin:flatten in writerfilterNoel Grandin
Change-Id: Ifaa63738c4e38dddd385821f568911927d834f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99966 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-02loplugin:flatten in xmlsecurityNoel Grandin
Change-Id: Ic9e410c77a04edbd58485d4177da22e17efa8720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-02loplugin:flatten in xmlscriptNoel Grandin
Change-Id: I326aa7ebea7925f580fd12c6c58f62e4add20d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99965 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-02Make gtk's get_sort_order return the same as the vcl's oneMaxim Monastirsky
Change-Id: Ia6584b268cb7b53423c7ac3d353e07409e9a5dac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#135369 on removing an image link, ensure the linked to image is in the listCaolán McNamara
If we removed something that is a link to a real file from our list of images to pack, but that real image is not in the list of images to pack, add it in instead so the real image does get packed Change-Id: I71bcbdf872a59194a1d94f287dda8fc27e4a6464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#135368 change the mnemonic to point to our combobox replacementCaolán McNamara
Change-Id: Ib53b787399954e5be7e4b4080366fe64cc937de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99958 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#135121 don't fill the rectangle in the transparent case at allCaolán McNamara
leave the area untouched Change-Id: Icf195d383271b92f6523f8c6b6bc3b87fcae00be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#135098 assert/crash on checking IsSelected on cell being disposedCaolán McNamara
Change-Id: I32ce9fcca86de4608939d385f42c43afc46bfb7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#119533: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: I9131c8e2e1b7092f0c5b1dcdd7f9a93568ab8d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99895 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-08-02Revert "android: avoid expensive load of un-used sidebar icons on mobile."Jan Holesovsky
Unfortunately we need this on Android for the tablets, otherwise the sidebar lacks the icons. Also it is not easily possible to use the isLOKMobilePhone() check here, because that is per-view in general, and handled in sfx in particular, making it hard to use here in vcl. This reverts commit 9a38b194eec5bcf6cb8d073e5d35173c5856f28f. Change-Id: I2b599e884ad4d00b7c246743c180a5324c9a143d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99300 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-10 17:39:16 +0000