summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-02AlwaysDisableInput newly unusedCaolán McNamara
Change-Id: I0cdb7b74487f2338d16eca85616f840d921dad5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02IsCallHandlersOnInputDisabled newly always return falseCaolán McNamara
Change-Id: I4abfab9a413e3e43e23839f2cf3b0c26dcdea3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101853 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02SetCallHandlersOnInputDisabled is newly unusedCaolán McNamara
Change-Id: I4225ce786b83f44178a477ac034d8f8f5198159e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101852 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02SetCallHandlersOnInputDisabled unneeded if AlwaysDisableInput not usedCaolán McNamara
and don't need to use that if we use FixedText instead of Edit Change-Id: I162bf829a62a2c7cf8a975c99509607095712e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02annotation label doesn't need to be an Edit, FixedText is enoughCaolán McNamara
similar to: commit a2d97135411d566b0b1f3d47af7912c8412cee7f Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Aug 18 10:23:27 2020 +0100 annotation label doesn't need to be a MultiLine edit, FixedText is enough Change-Id: I5035ecc2d5d03f7aaeb794006a0cb305bb89a219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101850 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02weld TabBarEditCaolán McNamara
Change-Id: I513c81faa9b93fbcb7eb93ac60152dcc97b41481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101585 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02Accept iOS SDK 13.7Tor Lillqvist
Change-Id: I393e96f490f3b3f69f8738fa9b552d19ec36a24d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101897 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-09-02svx: Refactor GalleryObject member aURLAditya
The member aURL does not belong here and needs to be refactored, the reason is that there can be two type of URLs - XML and binary URL. Change-Id: Ieb4e57a6f144070f95282a7fd02d08bda6d11f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101084 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-09-02lok: send state updates for shape editing commandsSzymon Kłos
Change-Id: I0fcb8ef76df89723ee74aa96a003e0d49d558872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100081 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101520 Tested-by: Jenkins
2020-09-02lok: send calc-input-win position updatesSzymon Kłos
This will allow to handle click position correctly when notebookbar is used and input window position is changed after construction Change-Id: If7c725a1c096237f7eda85544083021511d05338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100648 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101522 Tested-by: Jenkins
2020-09-02Remove some unused includesMiklos Vajna
Change-Id: I90d4e3db3eefa41f8492cfe23c5088ea93134afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-02Improve exception when shape with illegal anchor is givenSamuel Mehrbrodt
Change-Id: I24cb57b39511db3523f776463a832513a1aae0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101843 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-09-02Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I58e196515614aad309c9df8784b08fa86415549d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101783 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-02tdf#135655 OOXML export: Fix OLE background colorAttila Bakos
Follow-up of commit 636d16efe45a55c1a5a7a451c46fbb8618bf0393 (tdf#135653 OOXML import: fix OLE background color). Co-authored-by: Daniel Arato (NISZ) Change-Id: Iee927898884e229108b489d6d26a83ef7ad2f9a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100924 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-02remove dead CTF_ALIEN_ATTRIBUTE_IMPORTNoel Grandin
ever since commit 9a081484321b3f42bee3b43d18c4bd75b9603b01 Date: Fri Sep 14 13:42:47 2012 +0200 fdo#49571: ODF import: ignore "text:enable-numbering" attribute Change-Id: Id90b9aa0feafc3d7427558d3a2394c4958111434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-02loplugin:unusedmethodsNoel Grandin
Change-Id: I523a42b721056f17a04870229834b0f2db00ff39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-02loplugin:unusedfieldsNoel Grandin
Change-Id: Icecc024c4385ec69508369d2645d8412e6dbff69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-02Turn OStringLiteral into a consteval'ed, static-refcound rtl_StringStephan Bergmann
...from which an OString can cheaply be instantiated. The one downside is that OStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a containers that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::string_view, without loss of efficiency compared to the original OStringLiteral, and without loss of expressivity (esp. with the newly introduced OString(std::string_view) ctor). The new OStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OStringLiteral is in all cases where an object that shall itself not be an OString (e.g., because it shall be a global static variable for which the OString ctor/dtor would be detrimental at library load/unload) must be converted to an OString instance in at least one place. Other string literal abstractions could use std::string_view (or just plain char const[N]), but interestingly OStringLiteral might be more efficient than constexpr std::string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. sal/qa/rtl/strings/test_ostring_concat.cxx documents some workarounds for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". Those places, as well as uses of OStringLiteral in incodemaker/source/javamaker/javaoptions.cxx and i18npool/source/breakiterator/breakiterator_unicode.cxx, which have been replaced with OString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). This change also revealed a bug in at least recent Clang 12 trunk CastExpr::getSubExprAsWritten (still to be reported to LLVM), triggered at least in some calls from loplugin code (for which it can be fixed for now in the existing compat::getSubStringAsWritten). A similar commit for OUStringLiteral is planned, too. Change-Id: Ib192f4ed4c44769512a16364cb55c25627bae6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101814 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-02Online: Hide shape area bitmap import button.gokaysatir
This patch is for Online. Online handles "import" actions differently. This patch disables "Import" button for only Online. Change-Id: I6f6987ea82c102fc5ac44a1c48a234c9f43484e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100391 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 4a31a63c5e4d4dac01426581c39bc1ef9278f6cb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100658 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-09-02tdf#134649 DOCX export: fix page break between tablesLászló Németh
Section break between tables wasn't exported, resulting missing page break and table content. For example, a table on a new landscape page was merged to the previous table, removing not only the landscape page, but hiding half of the table because of the narrower width of the previous page with portrait orientation. Change-Id: Id02529d023a6306fb5be42486d25f252d8821f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101823 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-02sw reqif-xhtml export, embedded objects: prepare pres data earlierMiklos Vajna
If an embedded object has some native data, we provide presentation data (replacement graphic) for it in the OLE1 container. We usually take this from the OLE2 container, but it's OK to omit the presentation data there. So refactor to have the presentation data available from the OLE node (already used for RTF purposes) earlier, that'll allow taking the OLE1 presentation data from RTF if it's missing from OLE2. Change-Id: Ib6b1b5e843308b0f7af04499de5a1ef5461f7b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101840 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-01tdf#136319 do logging before calling handler which might destroy the valuesetCaolán McNamara
though doing this logging always when ~100% of the time there is noone listening seems wasteful Change-Id: Ib18462b70136ac52a4b9340a3a0890b4f97a4593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I468a946d0d3a22650cfc2b2cf04c6a4fa42bba87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101798 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on linux Change-Id: I8322ecf2a4c960524fd45cd63fd991d9fa0a3590 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101796 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01tdf#134923 missing mnemonic widget target for labelsCaolán McNamara
presumably since... commit beeef93480fae65840646e4e36aa888efe92579a Date: Tue Mar 8 19:54:57 2016 +0530 tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Change-Id: Id59d573e1005e10be34994c8cc66c352b2cf500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01reduce KeyFuncType down to just the used categoriesCaolán McNamara
Change-Id: I97608bcabb30eba94278562254f7f9954af080f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101837 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01check if Edit was disposed while insert special character was still openCaolán McNamara
seen when testing renaming tabs in basic IDE Change-Id: Id0a5d7ae54f789f04701ac7dd9c18608704238d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01cid#1466575 Dereference null return valueCaolán McNamara
Change-Id: Ie8f0036bad6490a409d768d9fc98ff796def129c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101824 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I5beec4b326b7f59103de374dff8169718defc8ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101779 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I77ea2951798ce84bb5ec617ff16e7ea918b8ef5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101795 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01reduce log noiseNoel Grandin
Change-Id: Ifa81014e272b01fd6ffb5356444fffb1d10370b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-01no polygon merge in Skia if they contain no straight lines (tdf#136240)Luboš Luňák
Merging polygons with beziers is even more expensive, and those are very unlikely to be parts of a larger polygon that are meant to line up perfectly. Change-Id: Ic9d641d3264b962896347ed52addeca2a0d5ea22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101742 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-01do not try to merge a single polypolygon (tdf#136240)Luboš Luňák
Change-Id: Idad860288baf736caeefe9883d12ab50cca37dff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101702 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-01tdf#118148 Extended tips for HC2/scalc/Olivier Hallot
change#1 put back navigatorpanel.ui Change-Id: I12162c8a78942194dea5faa8a0d824d550281621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101752 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-01cid#1466573 Dereference after null checkCaolán McNamara
Change-Id: Ie8f5c015d32b67ad9148c1d0bb8d73425a5b563a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01cid#1466574 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8ec87810cd32b720a77930cdd607ace4d907d7a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8336c2a639a1d45c8370fd13204896f3f1494b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101801 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" Change-Id: I4cbe4a471c18e9bd26f6161d98a49cb32666816f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101791 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
IT passed "make check" on Linux Change-Id: Ic7eb9958a192f8ced72481e42119066b455450aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101800 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typoAndrea Gelmini
Change-Id: I62a851c4b3355ac63fa3586df72251122c5de99b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101793 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8bcc1598c7b885a025dd990eb2f75551e15b5c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101794 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typoAndrea Gelmini
Change-Id: I03dc9ad3ad496524efbbb2f1a48f76fb95d1bfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01tdf#135412: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I091f5e40161119fcc07c43deaede6bc49049bf87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101745 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-01Access2Base - Upgrade version numberJean-Pierre Ledure
Change-Id: I64b83fb50284fcd3455136158000114d992c3370
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ide85943961b6f5102294356ff623c6be8d7bc790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101813 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Ibaaa3bbce3f2d502073803035aaacdad07bb170c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I0d84ef2053f0dd9f804c5a99e3f9099f86460010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101812 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Access2Base - Remove workaround on Firebird product nameJean-Pierre Ledure
Bug 118809 has been fixed. Workaround may be removed without regression Change-Id: I8716fa75a6d98b7e15752692e5275dbcb81e7efb
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I3482e32e3ce4a7ebfa04f9d54e2ab23c164f50c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101808 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4733e6609ee99bef49c2771c83b450ee89d955b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-15 19:10:01 +0000