summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-08ofz#10259 ofz#10263 ofz#10264 ofz#10265 use-after-freeCaolán McNamara
Change-Id: I3e845c21f7a4e853ce9548f2992cab324dec05a8 Reviewed-on: https://gerrit.libreoffice.org/60200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08loplugin:useuniqueptr in xmlhelpNoel Grandin
Change-Id: I8a407e0492adf61e1d815cadd5da0a1623c2b23b Reviewed-on: https://gerrit.libreoffice.org/60191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08blacklist all ocDB* tokens for Calc threadingLuboš Luňák
A sort of follow-up to 92e6be6614, all functions possibly may have this problem. E.g. sc_opencl_test, if it somehow ends up actually using threads instead of OpenCL, uses ocDBCount, which indirectly ends up in ScColumn::GetInputString() calling non-threaded context. Change-Id: I6e2b1c9aa6dc9a7d8732cdf2e86b8041f19d5bac Reviewed-on: https://gerrit.libreoffice.org/60030 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-08drop some unused custom widget descriptionsCaolán McNamara
Change-Id: I21f170235729ee7ea34763d620704213bc9d3b32 Reviewed-on: https://gerrit.libreoffice.org/60171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08fix various focus problemsCaolán McNamara
Change-Id: Ic510420ec486fdf77438891d08521039d180e5d4 Reviewed-on: https://gerrit.libreoffice.org/60170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08weld FontFeaturesDialogCaolán McNamara
Change-Id: I67ab7388593aceb00b660e4d40904a4eef247620 Reviewed-on: https://gerrit.libreoffice.org/60148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Missed in 085269d25a705b656436feac47149296b4b4b35d Change-Id: I3cfab57232908b48d090658e0fbc948d62b3fc6f Reviewed-on: https://gerrit.libreoffice.org/60180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08cppcheck: variableScope in basicJochen Nitschke
use a range based loop in one case Change-Id: I3d3acc35739634797e2b6e4d1cc2909b3fe33750 Reviewed-on: https://gerrit.libreoffice.org/60188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang-tidy bugprone-sizeof-expressionNoel Grandin
this was not really testing anything before, because it was doing sizeof(char*) which is 4 or 8 Change-Id: I7eccdd3c6ae14a6fabb27202737fdb2fd12663dc Reviewed-on: https://gerrit.libreoffice.org/60182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08loplugin:simplifyconstruct in editeng..extensionsNoel Grandin
Change-Id: I646a24382554312d92a4a8746d5267767353a53f Reviewed-on: https://gerrit.libreoffice.org/60169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang-tidy bugprone-use-after-moveNoel Grandin
Change-Id: I93c33da06f638ec6c8432bd13f992c320cfde93e Reviewed-on: https://gerrit.libreoffice.org/60158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang-tidy bugprone-unused-raii in RequestHandlerNoel Grandin
The message from clang-tidy is: warning: object destroyed immediately after creation; did you mean to name the object? The guard in RequestHandler::ExecuteCmdLineRequests comes from commit cf333a878ceed18d0343520a2c65be69fc433b1f Date: Sun Jan 21 22:10:09 2018 +0300 tdf#38915: set cProcessed condition on any process outcome and I'm sure it's intention was to set the flag on exit from the function, not immediately. Change-Id: Ibf874a5774770df00b9db7f673554e7ffda55072 Reviewed-on: https://gerrit.libreoffice.org/60183 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2018-09-08-Werror,-Wformat (clang-cl)Stephan Bergmann
...%d vs. DWORD aka unsigned long, but no need for sprintf anyway Change-Id: I7e97ada40abf7785a0678c76c76b547d6571f497 Reviewed-on: https://gerrit.libreoffice.org/60160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-08Fix typosAndrea Gelmini
Change-Id: I75692373028a64ba71899a4fd8c240fa4f2f1c02 Reviewed-on: https://gerrit.libreoffice.org/60172 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-08clang-tidy bugprone-unused-return-valueNoel Grandin
In OStorage::openEncryptedStream the lines were marked with a TODO until the TODO comment was removed in commit 8083b46285fefc4af751e1b00d20b40bea196ea8 Date: Tue Jun 16 16:15:54 2009 +0000 CWS-TOOLING: integrate CWS fwk103 Since no-one has "fixed" this intended functionality by now, I just removed it. The lines in unoidl/ were introduced by commit 12353c73868d26690aa4ac008ef5e9f2db8bc12c Date: Fri Mar 1 23:23:50 2013 +0100 WIP: Experimental new binary type.rdb format I assume that not throwing these was just an oversight. Change-Id: I26fbcce267f2cc1154a30b8259176f59611dfbd8 Reviewed-on: https://gerrit.libreoffice.org/60161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang bugprone-unused-return-valueNoel Grandin
most of these changes just make the change of ownership when using std::unique_ptr clearer, but there is one definite leak fix in PlainTextFilterDetect::detect Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9 Reviewed-on: https://gerrit.libreoffice.org/60159 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08[tr][autocorr] Fix erroneous entriesMuhammet Kara
Change-Id: Iaded68785c50833aa998706b6840f86d99ffc17d Reviewed-on: https://gerrit.libreoffice.org/60155 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-08sd / pptx export: use extracted ooxml node type.Mark Hung
Prefer extracted node type over XAnimationNode->getType(), as the later has been converted to former and unknown condition filtered. As the switch-case statements use ooxml node type now, all kown node types are handled. Hence returning early for unkown case isn't necessary and is removed. That also fix unrestored mpConetxt in 9a9b81c7212f because of returning early. Change-Id: I614dcaa5b0ce32b19c396d0eab4499c1d67fa059 Reviewed-on: https://gerrit.libreoffice.org/60139 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07sd/ pptx export: resolves unhandled node type causing crashes.Mark Hung
found in http://dev-builds.libreoffice.org/crashtest/1103bddab3f695b61484960523c4c2c0de4f0f91/ https://bz.apache.org/ooo/attachment.cgi?id=49270 https://bz.apache.org/ooo/attachment.cgi?id=44458 https://bz.apache.org/ooo/attachment.cgi?id=54593 Change-Id: If9e19140f2fcffc0b261c1d91a40597684a51917 Reviewed-on: https://gerrit.libreoffice.org/60060 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07[tr][autocorr] Consistent capitalizations for TurkishMuhammet Kara
Change-Id: Icfb6d82f094a4ab743d0ec4f51ddfdda606a731a Reviewed-on: https://gerrit.libreoffice.org/60152 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-07Fix some std::unique_ptr array allocsJan-Marek Glogowski
Found by reviewing the output of and the code around git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]" The onlineupdater code needs a little bit more attention. Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0 Reviewed-on: https://gerrit.libreoffice.org/60162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07tdf#119019 DOCX track changes: fix invisible delete and insertLászló Németh
during editing in a paragraph with tracked paragraph formatting, by accepting the old formatting change automatically in the actual paragraph before text deletion/insertion. Note: it's not possible to reject paragraph formatting changes in LO, but showing them is a minimal requirement. Now they are still visible in change tracking dialog and by the vertical line before the related paragraphs until there are no new text deletions and insertions in those paragraphs. Change-Id: I526daad8dd96212ac73a10627128553452e4d31c Reviewed-on: https://gerrit.libreoffice.org/60101 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-07BitmapFilter::execute can be constStephan Bergmann
...after a little tweak to BitmapMosaicFilter Change-Id: I76b8ffdbf719a9d7960e7f3dafeb3adeb2300ec5 Reviewed-on: https://gerrit.libreoffice.org/60165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07WIN add SalGraphics* to WinFontInstanceJan-Marek Glogowski
HFONT lookup in ImplDoSetFont depends on the mbVirDev of the WinSalGraphics. Since we need too look up HFONTs for SalLayout without changing the corresponding SalGraphics, add a pointer to the WinFontInstance. Change-Id: Idb6573ce7267f0019c2183be47621d0eaef8e57b Reviewed-on: https://gerrit.libreoffice.org/60093 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-07WIN drop mhFonts[MAX_FALLBACK]Jan-Marek Glogowski
Everything now uses the HFONT from WinFontInstance, so there is no need for the additional fallback array. Change-Id: I15a197b262633569cb95c37689561db5323e1115 Reviewed-on: https://gerrit.libreoffice.org/60092 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-07Drop workaround for old MSVC that no longer appears necessary with MSVC 2017Stephan Bergmann
The comments talk about unspecific "compilation and/or linking errors" with MSVC 2008 and 2013, but building with latest MSVC 2017 at least works fine now, so assume the workaround is no longer needed. (Theoretically, external code being compiled with older MSVC could run into problems now, but lets take that risk of becoming slightly build-time incompatible here.) Change-Id: I9e20be355c765c3a881502773963a61305eb00f3 Reviewed-on: https://gerrit.libreoffice.org/60135 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07Multiple calls of BitmapColorQuantizationFilter::executeStephan Bergmann
...should probably be independent of each other Change-Id: I22fb860a5a197d5f3f0f8706782e25d07511a1d9 Reviewed-on: https://gerrit.libreoffice.org/60153 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07just edit Entry to readonly, instead of a shadow ro widgetCaolán McNamara
Change-Id: I28d6d3cceec5224a6b38bd44ec380974cd3bae12 Reviewed-on: https://gerrit.libreoffice.org/60104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Prepare to handle native SVG icons Today icons are PNG images, if later they become SVG natively... Change-Id: I42d886257b55b5676767c8b8879a6bf35eb4d5e6 Reviewed-on: https://gerrit.libreoffice.org/60156 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - add image dimension and alt content to icons some icons miss width and height values. Change-Id: I4b94a0cf64a29451c96bb8f58729914b2cb576cf Reviewed-on: https://gerrit.libreoffice.org/60157 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - adapt to merge of namero and namerw Change-Id: I46883713361bf8107b601e4cc775ef5bce185e3d Reviewed-on: https://gerrit.libreoffice.org/60138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07ofz#10100 skip namespace check in icuCaolán McNamara
fails under oss-fuzz with linker problem https://github.com/google/oss-fuzz/issues/1789 Change-Id: I5788fca1914c1b795a91d59f7d9271f854b4d464 Reviewed-on: https://gerrit.libreoffice.org/60134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld SvxCharEffectsPageCaolán McNamara
Change-Id: I067b7a8c93e997fd554558f334a2968bf27965c6 Reviewed-on: https://gerrit.libreoffice.org/60147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07sw: less vcl text layout calls in SwFont::GetTextBreak()Miklos Vajna
Number of GenericSalLayout::LayoutText() calls during "dt<F3>" in Writer: 105 -> 89. Change-Id: I0f2bb241536209cfccc1d78bed6f54bf5c31e627 Reviewed-on: https://gerrit.libreoffice.org/60133 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Height and width are <img> attributes Change-Id: Ia8084ff7029ddd06e450cbf03a7b1fb5efaa7dc7 Reviewed-on: https://gerrit.libreoffice.org/60136 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07update creditsChristian Lohmaier
Change-Id: I946580363eb272f95694b000d6daa997e761285d
2018-09-07[pt_PT] Added 21 autocorrect wordsMarco A.G.Pinto
Change-Id: I8ca06334d176d5d00f72d448cb92afcc891a7d83 Reviewed-on: https://gerrit.libreoffice.org/60015 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-09-07mysqlc: ensure cursor is not out of rangeTamas Bunth
when calling getXXX() methods of a simple result set. Change-Id: I9e018385bb73468ea520b03275232c0982cbcba0 Reviewed-on: https://gerrit.libreoffice.org/60095 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-09-07tdf#108691, tdf#119639 Don't print hidden objects in XLS(X)Aron Budea
In Excel hidden drawing objects aren't printed. When not hidden, printing is controlled by a separate 'Print object' setting. Only rely visibility setting for now, but properly: visible means also printed, hidden means not printed. Ie. import visible property also as printable, and only output visible property in XLS(X) formats. For the future, in XLSX format printability is controlled by attribute 'fPrintsWithSheet' of element 'clientData', don't know about XLS, there fUsefPrint/fPrint bits don't appear to be used anymore (see note in tdf#119639). Change-Id: I728107b30056f7bf073f2fefddece1bef1eb2e7a Reviewed-on: https://gerrit.libreoffice.org/59915 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Fix typosAndrea Gelmini
Change-Id: Idf3906894510d671c75c32a787ad315945b2c339 Reviewed-on: https://gerrit.libreoffice.org/60137 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-07weld writer page style dialog and SvxBorderBackgroundDlgCaolán McNamara
writer, format page is complete Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45 Reviewed-on: https://gerrit.libreoffice.org/60058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07Cppcheck: make 1-argument ctors explicitMike Kaganski
Change-Id: I437988b238af961c6a3ac61ed4e93ea8206f6001 Reviewed-on: https://gerrit.libreoffice.org/60123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07improve help message for uitest failureNoel Grandin
Change-Id: I7213ee2ca55ddc1a11c4f411d3b72f1b2382f7e7
2018-09-07tdf#99213: don't export invalid child nodes.Mark Hung
Create NodeContext for all child nodes at beginning and check if they are valid, either it has a valid target or it contains valid nodes, so that we only export valid node later. Change-Id: I660d99011eb57ddc79f727455fce0be8876e8b17 Reviewed-on: https://gerrit.libreoffice.org/59892 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07oox: create PowerPointImport instances with an uno constructorMiklos Vajna
PowerPointImport_getSupportedServiceNames() was copy&pasted from oox::core::FilterBase::getSupportedServiceNames(), so it can go away entirely. Change-Id: Ia6352cea1c2d65ba94cae66b500de951d82f455a Reviewed-on: https://gerrit.libreoffice.org/60124 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-07Cppcheck: release the handle that CreateThread returnsMike Kaganski
Change-Id: I4d6d04873d69d2ff1e5409372b353e0bb9a5d68d Reviewed-on: https://gerrit.libreoffice.org/60120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Cppcheck: resource leak warningMike Kaganski
Change-Id: I855097279cd091c1e8bd665bb0b48ce9279a9ca8 Reviewed-on: https://gerrit.libreoffice.org/60121 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute L10n in some regexp definitions and examples Change-Id: I614575fd63d08e05ffdf7c74a9f73a4c3021cf08 Reviewed-on: https://gerrit.libreoffice.org/60105 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix image dimensions expression in style Change-Id: I1803f18aa0512e5b618daa64efff6487c583fb76 Reviewed-on: https://gerrit.libreoffice.org/60106 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix icon sizes SVG images must have width/height set. Change-Id: Ia881ad81614d949f1d01764f3e750c066651d631 Reviewed-on: https://gerrit.libreoffice.org/60107 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-02 21:57:59 +0000