summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-01cppcheck: performing init in init list (desktop/editeng)Julien Nabet
Change-Id: Ie489d36852b9c6be449c44f7fcc0cf1ee0164833 Reviewed-on: https://gerrit.libreoffice.org/84144 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-01SpellingPopup: lok: keep the selection to make context menu work.Tamás Zolnai
Change-Id: Ida46a1140c889d1864b423eb9c5512d99a028fce Reviewed-on: https://gerrit.libreoffice.org/84155 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01Remove unused variable.Tamás Zolnai
Change-Id: I34a15cb1e457c3ac0329e5ba735ac93db99e9fbf Reviewed-on: https://gerrit.libreoffice.org/84154 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01SpellingPopup: lok: we don't need to disable menu items for online.Tamás Zolnai
Now, that we generate the conext menu in JS code, we can control the visibility of items. Change-Id: I09112619a9669e6ebf1a8d468e0329b8914db0ff Reviewed-on: https://gerrit.libreoffice.org/84153 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-12-01tdf#109425 Make paraspacing windows grab focusJim Raykowski
to their shown SvxRelativeField when focus is gained using keyboard navigation. The patch also corrects images used for before, after, and above controls. Change-Id: Ic1411ac0eddf3b281590ac5821171b5e8aaac976 Reviewed-on: https://gerrit.libreoffice.org/84103 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-01tdf#109425 NB bar compact: Make send mail button kb accessibleJim Raykowski
Change-Id: I4b0bbe9834cb950ff67210404c0e28225f1bd4a0 Reviewed-on: https://gerrit.libreoffice.org/84101 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-01tdf#109425 Fixes for notebookbar singleJim Raykowski
Enable grow and shrink controls to be keyboard accessed and make print preview controls show Change-Id: I6a31b881fb08bc73d4b4b475658c210824cbc109 Reviewed-on: https://gerrit.libreoffice.org/84105 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01boost::optional: replace uses of get_value_or with value_orStephan Bergmann
...in preparation for wholesale replacement of boost::optional with o3tl::optional, which will be an alias for either std::optional or boost::optional, and std::optional only has value_or. boost::optional::value_or was added with <https://github.com/boostorg/optional/ commit/3984c9f9a157ef116cea69bc8bb20f433320eb61> "Added function value_or()", which according to git-describe first appeared in tag boost-1.56.0. We appear to have no strict Boost baseline (the closest we get is with > [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost >= 1.36)] in configure.ac), and at least CentOS 7 TDF machine tb76 only has boost-devel-1.53.0-27.el7.x86_64. However, any environment using Xcode < 10 that needs to make o3tl::optional fall back to boost::optional should use --without-system-boost, and external/boost is currently at 1.69.0, so should be safe. ATTENTION: In isolation, this commit will break in any environment that uses Boost older than 1.56.0. It requires the following commit introducing o3tl::optional. (But doing these changes in individual commits was deemed more valuable than supporting a hypothetical future git-bisect against an old Boost.) Change-Id: Ib31affa3eebf0d0029d8620dc6abb7a60f6c7629 Reviewed-on: https://gerrit.libreoffice.org/84127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01Don't use boost::optional forward declarationsStephan Bergmann
...in preparation for wholesale replacement of boost::optional with o3tl::optional (which will be a using declaration for either std::optional or boost::optional, hence can't be forward-declared easily) Change-Id: I031ed1812a0c939f37253f7753e358f1ad9153a3 Reviewed-on: https://gerrit.libreoffice.org/84126 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01Rewrite uses of boost::optional, Windows reduxStephan Bergmann
...like 47dd2c63f649828a833543e21d4eca5866ec9ebe "Rewrite uses of boost::optional" Change-Id: I95373e151201563dcc9eb796f15121bc81341bfd Reviewed-on: https://gerrit.libreoffice.org/84138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01missing includeStephan Bergmann
Change-Id: I7dc79698e642b3b971a769c57d7c7b9cfded249b Reviewed-on: https://gerrit.libreoffice.org/84132 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add dep's for xapian-omindex build Change-Id: If3e3efbb04e40c906618aec8da5552560bd0678e Reviewed-on: https://gerrit.libreoffice.org/84145 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-01loplugin:mergeclasses treeview::TreeFileIteratorNoel Grandin
Change-Id: I9312806870b005e076fea3688f30ca86e93aeb4a Reviewed-on: https://gerrit.libreoffice.org/84108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30lok: add viewId to window painting, to allow special-casing on render.Michael Meeks
View switching should not cause the sidebar UX to re-build at all. Particularly it should not do this when we switch view just to render a sidebar. Change-Id: Iec0427cdc8308fc273d73ea56dd208bfa7036471 Reviewed-on: https://gerrit.libreoffice.org/84120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 92814f3389de346f3ae32cddb38f079763e68ddf) Reviewed-on: https://gerrit.libreoffice.org/84129 Tested-by: Jenkins
2019-11-30loplugin:mergeclasses SoundHandlerNoel Grandin
replace ThreadHelpBase with MutexHelper Change-Id: If971a701261164ff4d3871eab5dfebd2c5d5b89f Reviewed-on: https://gerrit.libreoffice.org/84111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30this std::set can be o3tl::sorted_vectorNoel Grandin
Change-Id: I74a6141321dc60884789fd3d1a8a2540b662121b Reviewed-on: https://gerrit.libreoffice.org/84110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30loplugin:mergeclasses FormScriptingEnvironment with IFormScriptingEnvironmentNoel Grandin
Change-Id: I334ad78681e2b7389388316881fd9f57455e875f Reviewed-on: https://gerrit.libreoffice.org/84109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30loplugin:mergeclassesNoel Grandin
don't filter out "Base", reveals some interesting stuff Change-Id: I62a36e70bce8e6e1346f78395dc1d32fbd8a0ddd Reviewed-on: https://gerrit.libreoffice.org/84107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ie92b52eabc425a4688b6d4f7cfb547ad59f4afc4 Reviewed-on: https://gerrit.libreoffice.org/84106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30related tdf#118947 sw tablestyle: no need to avoid numbered paraJustin Luth
Removed the hack that avoided applying table properties to paragraphs that had numbering/bullets applied. Most of the hackery around that happens in finishParagraph(), which runs before this, so any table properties already see all of the directly applied numbering properties. Since numbering heavily uses RES_LR_SPACE (which has multiple MemberIds), the previous inability to distinguish SET/DEFAULT per member probably caused problems, but since that happens now, it should be safe to also apply table-style properties. Change-Id: Id59a6249af55ea60255e2cef4ed9efe3d8321246 Reviewed-on: https://gerrit.libreoffice.org/81414 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-30Rewrite uses of boost::optionalStephan Bergmann
...to only use functions that are also available for std::optional (in preparation for changing from boost::optional to std::optional): * uses of get are replaced with operator * or operator -> * uses of is_initialized are replaced with operator bool * uses of reset with an argument are replace with operator = (All of the replacements are also available for boost::optional "since forever", so this change should not break builds against old --with-system-boost. An alternative replacement for is_initialized would have been has_value, but that is only available since Boost 1.68.) Change-Id: I532687b6a5ee37dab28befb8e0eb05c22cbecf0f Reviewed-on: https://gerrit.libreoffice.org/84124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Let getPageViewOutputDevice return const OutputDevice*Stephan Bergmann
...instead of boost::optional<const OutputDevice&> (in preparation for replacing boost::optional with std::optional, which doesn't support references types as template arguments) Change-Id: I02d2b617123cfa9ca0d6436c8a4104c5987f4eb5 Reviewed-on: https://gerrit.libreoffice.org/84121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' - tdf#92084 Help Pages for OPT_* Calc functions Note: The OPT_* functions implemented in release 4.0 have no HID_ defined. Dummy HID contants were inserted waiting for tdf#129115. Change-Id: Iac253a86ff8cbf8fd1a222c6326abc7e0c9f4f76 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/84122 Tested-by: Jenkins
2019-11-30Replace uses of boost::optional<>::get_ptr with free functionStephan Bergmann
...in preparation of replacing boost::optional with std::optional, which doesn't have get_ptr Change-Id: I432d6deb7cf9b892b6126245882c74ab680f2984 Reviewed-on: https://gerrit.libreoffice.org/84119 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Assign bool directly to boost::optional<bool>Stephan Bergmann
...instead of going via boost::optional<sal_Bool>. (In preparation of replacing boost::optional with std::optional, which doesn't support implicit conversion from std::optional<sal_Bool> to std::optional<bool>.) Change-Id: I5dd74dd1c6346c99bd3e2a9b1156c9fce56db77c Reviewed-on: https://gerrit.libreoffice.org/84116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30tdf#94947 Set preset-id for user defined motion paths.Mark Hung
User defined motion paths ( curve, polygon, freeform line ) did not have preset-id. Set the preset-id so that the preset type will be highlighted in the custom animation pane after editing. "libo-motionpath-curve", "libo-motionpath-polygon", and "libo-motionpath-freeform-line" are used for the three user defined motion paths. This patch is related to tdf#94947, though it doesn't make the original document display correctly by guessing the missing preset-id, but it prevent empty preset-id to be generated when creating those three motion path animation. Change-Id: I50c0133bea32e022b07e5d8c0a024810844f124d Reviewed-on: https://gerrit.libreoffice.org/83079 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-30Rewrite ParamValue::isStephan Bergmann
...without using boost::optional<>::operator! (in preparation for replacing boost::optional with std::optional, which doesn't have an operator! using is_initialized() would not be helpful, as std::optional doesn't have it either; using has_value() would arguably be even cleaner, but boost::optional only has it since Boost 1.68, so some --with-system-boost builds might not have it) Change-Id: Iee3c71c8e6ea93fb25221768880442f42f410b83 Reviewed-on: https://gerrit.libreoffice.org/84115 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30...and take implicit const casts into accountStephan Bergmann
...following up on 4f8a744c4fcf2c69462af19bd807fee32413158d "Make loplugin:unnecessaryparen treat member expressions consistently" Change-Id: I444d2995e88990c3c6fa2b912ef68032daf2cad9 Reviewed-on: https://gerrit.libreoffice.org/84112 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30sd: fix typo maEffectDiscriptorMap -> maEffectDescriptorMap;Mark Hung
Change-Id: Ie0e8dc67969ca680e80c544f954d3bef9adbcb33 Reviewed-on: https://gerrit.libreoffice.org/83078 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-11-30MSI: Disable creation of system restore points during installationMike Kaganski
We don't install low-level system components that have potential of ruining the system, which would be the reason to create the restore points. Some systems suffer from very long creation of the restore points, like in tdf#129087: ... MSI (s) (60:00) [09:18:54:201]: Calling SRSetRestorePoint API. dwRestorePtType: 1, dwEventType: 102, llSequenceNumber: 0, szDescription: "Removed LibreOffice 6.3 Help Pack (English (United Kingdom))". MSI (s) (60:00) [09:26:57:699]: The call to SRSetRestorePoint API succeeded. Returned status: 0, llSequenceNumber: 73. ... So let's just disable the generation of restore points, as per [1]. [1] https://docs.microsoft.com/en-us/windows/win32/msi/msifastinstall Change-Id: I452859d72284e0b2ea9a407e30a5e256a8c0a0f6 Reviewed-on: https://gerrit.libreoffice.org/84113 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-30tdf#129106 vcl: add SAL_INFO to show the dxArray intercharacter spacingsChris Sherlock
Change-Id: I948555cb4895390ded8b6c9b257486cdce175185 Reviewed-on: https://gerrit.libreoffice.org/84096 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-11-30Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Make this example click-copyable Change-Id: I38b1c3c4c5f086fcd7bea14c2f72392bba2c6102 Reviewed-on: https://gerrit.libreoffice.org/84114 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-30Clarify the commentMike Kaganski
Change-Id: I610057d4226616cad928eba82ce0055b37fe4e16 Reviewed-on: https://gerrit.libreoffice.org/84102 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-30Fix typoAndrea Gelmini
Change-Id: I8d7ed542dc331d3861fcfe2fec7250b5a4bbb166 Reviewed-on: https://gerrit.libreoffice.org/84094 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-30Removed executable permission on fileAndrea Gelmini
Change-Id: I32f116281f37d22d63d44f5da1010ee3ca6bd9c0 Reviewed-on: https://gerrit.libreoffice.org/84095 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-30SOTranscoder.java is unused (filter/svg)Julien Nabet
Since 90f5ce36231551e226d4b3e2fefaa8493af692ac svg-import-filter.diff: SVG Import Filter implementation in filter module 2010-09-14 Change-Id: Ic68e0e0c32fa26cccb0cb2092e5079ac74747794 Reviewed-on: https://gerrit.libreoffice.org/84093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30revised text for existing tipsSeth Chaiklin
Change-Id: I8a1c03d2282ad20a58dada4507fcab8d822f481e Reviewed-on: https://gerrit.libreoffice.org/84064 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-30merge classes VCLXTopWindow_Base and VCLXTopWindowNoel Grandin
Change-Id: I4c0718d2947449fa076b0afd3046587c73784558 Reviewed-on: https://gerrit.libreoffice.org/84035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-30Remove nonsense checkEike Rathke
bIsPasswordToModify was never modified there, so a check is moot. Change-Id: I96b4212452bf1ad4689c0d17d1ab41fecd8b447a Reviewed-on: https://gerrit.libreoffice.org/84098 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-30Resolves: tdf#97086 Allow "unlimited" password length for OOXML encryptionEike Rathke
Change-Id: I51175424e19ad02b81120c3fdea22732cd481a8d Reviewed-on: https://gerrit.libreoffice.org/84097 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-29missing includeStephan Bergmann
Change-Id: Ie122f39f8fd3c8613eea7c9dc17e2c63d4b45823 Reviewed-on: https://gerrit.libreoffice.org/84091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29missing include (for close)Stephan Bergmann
Change-Id: I0795ba6df244c2b2f2bde210dbfb2f4a5181995d Reviewed-on: https://gerrit.libreoffice.org/84092 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29Make loplugin:unnecessaryparen treat member expressions consistentlyStephan Bergmann
Stumbled across a warning starting to get emitted for some !(p->x) when I temporarily changed x from boost::optional (which has a member operator!) to std::optional (which instead implicitly uses a member conversion operator to bool). (That is, for the new static int foo3(Foo2 & foo) { (void) !(foo.p); (void) !(foo.b); (void) !(foo.n); return (foo.p) ? 1 : 0; } test, the first, third, and fourth body lines never warned, while the second one erroneously warned without this fix.) Change-Id: I60f6941aaa3a73db0f1373c954e47aa68d703170 Reviewed-on: https://gerrit.libreoffice.org/84079 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-29Enable O[U]String move ctor/assignment for WinMike Kaganski
Change-Id: If7ad38a7a802732e84db9352a475644327769d62 Reviewed-on: https://gerrit.libreoffice.org/84043 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29tdf#129007: fix autocompletionMike Kaganski
Using EditView::SelectCurrentWord in arbitrary selection positions is not a correct approach. When cursor is after "_" in "=_+FUNC", the method will select "=_+", i.e. the substring that cannot start any Calc identifier (and actually ending *after* current cursor). When matching identifiers like "bb.bbb" in "=bb.bb", the end result will be "=bb.bb.bbb", etc. So instead of trying to match words and hack around problems, let's simply find longest match in the string starting from beginning of the line, and ending at current cursor position. Testing trailing parts of that string of decreasing length, the first found match is the longest, which is what we need. This also avoids multiple calls to expensive EditEngine methods. Change-Id: Ia3470cc85a4ba9f9ab34cbe9db3250bf28e93350 Reviewed-on: https://gerrit.libreoffice.org/84087 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-29tdf#129098: parameters mixed in OPT_PROB_INMONEY (scaddins)Julien Nabet
Here's getOptProbInMoney signature according to XPricingFunctions.idl: 66 /// OPT_PROB_INMONEY(), probability of ending up in-the-money. 67 double getOptProbInMoney( [in] double spot, [in] double vol, 68 [in] double mu, [in] double maturity, 69 [in] double barrierLow, [in] double barrierUp, 70 [in] any strike, [in] any putCall ) 71 raises( com::sun::star::lang::IllegalArgumentException ); So "putCall" should be at the end. It's been like this since initial commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e9f31eaa49f9494113e72deaf0fe079701844ea4 Change-Id: I186348fe7470633abd32598954b7032102770a8a Reviewed-on: https://gerrit.libreoffice.org/84078 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-29tdf#118947 writerfilter: remove obsolete tablestyle fontsize hackJustin Luth
LO 6.5 commit 6bced3c6a1bf8d4652dd6ba75e41b128ce1bfc5c obsoletes this old hack. The default paragraph style has (almost) nothing to do with table styles. *Any* specified (non-inherited) paragraph style property should override a table style, including the default paratyle. One exception is the default occurance of the not-yet-supported word/settings.xml compat option overrideTableStyleFontSizeAndJustification = false. The default case should cause the table-style font to override a size 11 or 12 default-paragraph-style font. So that is actually double-reason to remove this old hack which threw out the table-style size altogether. Change-Id: Id1687f32b8431b6fa8770b01c344e75e0ffb344f Reviewed-on: https://gerrit.libreoffice.org/84044 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-11-29WIN enable NoAuthority testJan-Marek Glogowski
Change-Id: I5e8214efbf32a5bc43f002ef244826b9b899c692 Reviewed-on: https://gerrit.libreoffice.org/84071 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-29Related tdf#128974: Really deal with "default" and "default-release" profilesJulien Nabet
See https://support.mozilla.org/gl/questions/1264072 for some background info. Change-Id: I4939a0c9a8ad09753de4a152f464c647ec637f31 Reviewed-on: https://gerrit.libreoffice.org/84077 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-01-04 09:41:29 +0000