summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-04some std::set->o3tl::sorted_vectorNoel Grandin
which is much better cache-wise Change-Id: Iacec0df48f043bcdd761ed30c1b1513850a00152 Reviewed-on: https://gerrit.libreoffice.org/84311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03tdf#101513 add customizeable option to writer NB grouped compactandreas kainz
Change-Id: I3e8af6cee6b541f3208c2ad86dfe2bdc5ef83683 Reviewed-on: https://gerrit.libreoffice.org/84282 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-12-03Glade remove GtkMenuItem widget visible False itemandreas kainz
Change-Id: Ibe88210114c8b0dc483d8fe6a36d13dc0fcd599c Reviewed-on: https://gerrit.libreoffice.org/84333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Adapt SAL_WARN to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. Change-Id: Ic70d3e90e4b990d297e35f07379fe4952e138820 Reviewed-on: https://gerrit.libreoffice.org/84321 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03cid#1456145 Missing move assignment operatorCaolán McNamara
Change-Id: I55ed7d87def93a66668f5cf4f90fed1e1e5bcbee Reviewed-on: https://gerrit.libreoffice.org/84256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03toolbar item visibilty defaults to false in GtkBuilder but true in vclCaolán McNamara
Change-Id: I91152db48fee77b95fa542790839a574b87161db Reviewed-on: https://gerrit.libreoffice.org/84361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
Change-Id: Id40ebafeb227c432af8689b7db246a3615bc482b Reviewed-on: https://gerrit.libreoffice.org/84344 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03drop some unnecessary includesCaolán McNamara
Change-Id: Ic88ed0d36f1aae9f32a0097354042526fc18d649 Reviewed-on: https://gerrit.libreoffice.org/84244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03weld OAddFieldWindowCaolán McNamara
Change-Id: I1e0ca144943fd37769c7b6cfc7e77c4f001b31a0 Reviewed-on: https://gerrit.libreoffice.org/84233 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Adapt to C++20 deleted ostream << for sal_Unicode* (aka char16_t*)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print a pointer rather than a (presumably expected) string. But here it should be fine to print pointers, esp. as there are null pointers involved. Change-Id: I62fad4cb9eaaa612989f035f686086ef29093d70 Reviewed-on: https://gerrit.libreoffice.org/84351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
Change-Id: I6a86db428dcf92083ee13298417b3d3027e45822 Reviewed-on: https://gerrit.libreoffice.org/84338 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
(and do not unbox Any where it is not necessary anyway) Change-Id: Ic5461fb8b62157e9116cd2d557ee38fface28fb7 Reviewed-on: https://gerrit.libreoffice.org/84337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Also throw IllegalArgumentException for arguments of wrong typeStephan Bergmann
Change-Id: I1b52accc3f0eec3e6232b8211bf7bcbf65ed18f8 Reviewed-on: https://gerrit.libreoffice.org/84350 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Don't count terminating newline when determining line lengthStephan Bergmann
Change-Id: I3a5d306f32697e160f008e73de38fc53f2f1dbda Reviewed-on: https://gerrit.libreoffice.org/84349 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Use o3tl::doAccess, prevent -Werror=maybe-uninitializedStephan Bergmann
Change-Id: Ibc7bffe3bb2bf67f85102c03f48e3b44d89c60cc Reviewed-on: https://gerrit.libreoffice.org/84334 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03loplugin:mergeclasses ListBoxAccessibleBase with AccessibleListBoxEntryNoel Grandin
Change-Id: I9173e64b7ddef3184cacbce55b060d677e7ec1d0 Reviewed-on: https://gerrit.libreoffice.org/84347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Silence false -Werror=maybe-uninitializedStephan Bergmann
...where success of >>= has already been checked with CPPUNIT_ASSERT Change-Id: I127d559ab0bf212e4a32db4f297954d3b94032fc Reviewed-on: https://gerrit.libreoffice.org/84345 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Adapt to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But in these cases printing an integer is as expected, so add explicit casts. Change-Id: I7c2f1afaa2982b284aef8af183b71466c37142c2 Reviewed-on: https://gerrit.libreoffice.org/84339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03Silence false -Werror=maybe-uninitializedStephan Bergmann
...where success of >>= has already been checked with CPPUNIT_ASSERT Change-Id: I9aa553749988b6b2e26d9a5ac5b376cc5997aba7 Reviewed-on: https://gerrit.libreoffice.org/84335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03SAL_INFO_IF -> SAL_WARN_IFNoel Grandin
this is a very very useful warning when libraries fail to load Change-Id: I09bf64f6c65f285d6ab41f988b255a4842233428 Reviewed-on: https://gerrit.libreoffice.org/84314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Drop unnecessary o3tl::optional::resetStephan Bergmann
...where xRangeList goes out of scope anyway Change-Id: Ibb107ac7eee5504a161749f141997bd96fd07e83 Reviewed-on: https://gerrit.libreoffice.org/84336 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: Ib40fad986f99d02e58f0564fb68608e86989173c Reviewed-on: https://gerrit.libreoffice.org/84325 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: If2dce427fd8d52224996aaef93081d5a2e239893 Reviewed-on: https://gerrit.libreoffice.org/84322 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03external/clucene: Adapt to C++20 deleted ostream << for non-plain char typesStephan Bergmann
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print a pointer rather than a (presumably expected) string. So this infoStream output appears to have always been broken (the strings use TCHAR, which appears to unconditionally be a typedef for wchar_t, see workdir/UnpackedTarball/clucene/src/shared/CLucene/clucene-config.h), and appears to be just of informative nature, so just simplify it to not try to print any problematic parts. Change-Id: Ie9f8edb03aff461a15718a0c025af57004aba0a9 Reviewed-on: https://gerrit.libreoffice.org/84320 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: Id28d593d94fc176194871db32c1c5a287b98a26a Reviewed-on: https://gerrit.libreoffice.org/84319 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: Ife99f3bea2972e080b4c3da6f5068543d4010173 Reviewed-on: https://gerrit.libreoffice.org/84307 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03PopFieldContext calls CloseFieldCommand itselfMike Kaganski
Change-Id: I4ac75d6e73f4d60ac532829a56c5d23501e6a531 Reviewed-on: https://gerrit.libreoffice.org/84318 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-03Simplify a bit use of LabelPlacementParam (oox/chartexport)Julien Nabet
Change-Id: I940be544577d8955959d4b8c89feaa08f99e544a Reviewed-on: https://gerrit.libreoffice.org/84272 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-03Remove useless PatternPair (sc/vbainterior)Julien Nabet
Following 3471d83f49dcaab2cbbe18521ab1a405f15a0788 Use initializer list instead of using several inserts (sc/vba) + 1a5850e7c4414a06e1ad5603bf1d4565d3ba3a82 Following 3471d83f49dcaab2cbbe18521ab1a405f15a0788 (sc/vba) "Use initializer list instead of using several inserts (sc/vba)" I had forgotten to remove the initial commented code Change-Id: Idd9855e520383c17cf7564ae4646fd613fc45895 Reviewed-on: https://gerrit.libreoffice.org/84278 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-03enum WindowsStateMask type itself is unusedStephan Bergmann
(found with upcoming loplugin:unusedmember) Change-Id: I2a7de15da061c4c0d4dc163c59370db6da763c2c Reviewed-on: https://gerrit.libreoffice.org/84316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03use scoped enumStephan Bergmann
Change-Id: I41a810d14be0a7f18c91b62e5d982c12db593183 Reviewed-on: https://gerrit.libreoffice.org/84315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03tdf#129068 try dialog content area help before dialog itselfCaolán McNamara
we already check current notebook page before the dialog, now check the content area before the dialog Change-Id: Ieedb5727ddec6d24adc6e70144977b5c3063c0fd Reviewed-on: https://gerrit.libreoffice.org/84245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Use namespaces instead of structsStephan Bergmann
Change-Id: I82e49d666376c31f3a8e407aedd05cfaee2f2bde Reviewed-on: https://gerrit.libreoffice.org/84301 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03tdf#101513 add customizable option to writer NB contextual singleandreas kainz
Change-Id: I0c62b26d0b47cef7f02ee581412aa3cd2d6ac7e4 Reviewed-on: https://gerrit.libreoffice.org/84285 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-03remove some useless comment linesNoel Grandin
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Simplify a bit B2DPolyRange::appendElement (basegfx)Julien Nabet
push_back is more optimized than an insert Change-Id: I8932c4ee61569b5eee3d5dbc5fbfd8eff624d061 Reviewed-on: https://gerrit.libreoffice.org/84276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03Disable slide copy/cut when LockContentExtraction is setSamuel Mehrbrodt
Change-Id: I7bf9ba907a152fab81a9472bc7baf00331753828 Reviewed-on: https://gerrit.libreoffice.org/84289 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Jenkins
2019-12-03Use initializer instead of using several inserts (svgio/svgtoken)Julien Nabet
Change-Id: I50fd5570305e1cace848fc68c7a2a2f10b132873 Reviewed-on: https://gerrit.libreoffice.org/84277 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-03Directly use o3tl::optional comparisonStephan Bergmann
Change-Id: I864137704dd8c27d034dc34c947c97954dd18ef3 Reviewed-on: https://gerrit.libreoffice.org/84296 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03loplugin:mergeclases ICommandImageProvider with DocumentCommandImageProviderNoel Grandin
Change-Id: Ia6997489a8f21f33287e11e39fab1bb059070c89 Reviewed-on: https://gerrit.libreoffice.org/84195 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03tdf#42949 Fix IWYU warnings in sfx2/*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I56e4b5a44143ea15660cfa293e156036952dfe8f Reviewed-on: https://gerrit.libreoffice.org/84030 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-03avoid invalid static_cast when mixing X11 and OpenGL bitmapsLuboš Luňák
This can happen because lcl_SelectAppIconPixmap() temporarily disables OpenGL, but in case an icon to be loaded is already cached(?), the bitmap variant may be OpenGL. Happens when launching LO in OpenGL mode with the X11 gen backend, and then selecting Writer in the start screen. Change-Id: I65110dee79769c430eaa8a2cf3dc11119ab02520 Reviewed-on: https://gerrit.libreoffice.org/84246 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-03split instrinsics CXXFLAGS per each instruction setLuboš Luňák
The common usage pattern should be having one source file per each instruction set and then one source file compiled with neutral flags that dispatches to the relevant code based on runtime checks. Which means that there can't be any one "correct" flag, otherwise all files would get compiled e.g. with SSE4.2 but then CPUs capable only of SSE2 would crash running that code. Change-Id: I362bf66f672dae4588a48effe3bcd30c34ea75b3 Reviewed-on: https://gerrit.libreoffice.org/84227 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-03Remove trailing whitespaceSamuel Mehrbrodt
Change-Id: Ib4ba69ae42d294ed1d51c2c20d65897bbca26bfe Reviewed-on: https://gerrit.libreoffice.org/84306 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-03new[]/delete mismatchCaolán McNamara
Change-Id: Ife47f111b3910c2eca322678f3f7a67b5cc2cd24 Reviewed-on: https://gerrit.libreoffice.org/84218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03tdf#129134 ApplicationColors Scrolled List moves too littleCaolán McNamara
Change-Id: I5cb6ac017f1d2a916297676724d523634afb2020 Reviewed-on: https://gerrit.libreoffice.org/84252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03Make OpenCLMinimumDataSize configuration property non-nillableStephan Bergmann
It had curiously been added as nillable (by default) alongside other properties that were added as non-nillable with ef809ce9480182ea5c4f77843f72d1d45bd48c35 "More work on the new OpenCL options", but with a non-nil default value, and no code sets a nil value, and ScModelObj::getFormulaCellNumberLimit, which reads its value and expects it to be non-nil, would cause UB if it was nil. So make it non-nillable and thereby simplify the code handling it. (Similar to how e8bb827571f540ac4af2247cb11239bb96876669 "Fixed cppheader.xsl nillable treatment" retrofitted lots of existing properties to be non-nillable in the past.) Change-Id: I60ac95025f363e346f3102ef80f38d00862e6e9a Reviewed-on: https://gerrit.libreoffice.org/84248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03desktop: disable callback handling while changing the viewAshod Nakashian
When changing the view, some components are disabled and re-enabled. This triggers a flood of invalidations that then result in rendering requests. For each rendering the view is set, which triggers more invalidations. The Sidebar suffers from this, and it causes cpu pegging. This fix prevents this issue by disabling all callbacks during setView. Change-Id: If6b93b2ab31f568a0761f15d945a43de1bc2d4d0 Reviewed-on: https://gerrit.libreoffice.org/84184 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/84226 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-03lok: shape selection: perform the needed unit conversion in a clever wayMichael Meeks
follow-on fixup of: 35d6c6ffc9b3f66e3802d1770c4e87cf843c3a48 which ended up not removing the duplicated conversion logic it should have. Change-Id: I28ef0180749f6356ec456b4f0b1eef1b474fd6c9 Reviewed-on: https://gerrit.libreoffice.org/84284 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-29 16:44:42 +0000