summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-07tdf#99213: don't export invalid child nodes.Mark Hung
Create NodeContext for all child nodes at beginning and check if they are valid, either it has a valid target or it contains valid nodes, so that we only export valid node later. Change-Id: I660d99011eb57ddc79f727455fce0be8876e8b17 Reviewed-on: https://gerrit.libreoffice.org/59892 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07oox: create PowerPointImport instances with an uno constructorMiklos Vajna
PowerPointImport_getSupportedServiceNames() was copy&pasted from oox::core::FilterBase::getSupportedServiceNames(), so it can go away entirely. Change-Id: Ia6352cea1c2d65ba94cae66b500de951d82f455a Reviewed-on: https://gerrit.libreoffice.org/60124 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-07Cppcheck: release the handle that CreateThread returnsMike Kaganski
Change-Id: I4d6d04873d69d2ff1e5409372b353e0bb9a5d68d Reviewed-on: https://gerrit.libreoffice.org/60120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Cppcheck: resource leak warningMike Kaganski
Change-Id: I855097279cd091c1e8bd665bb0b48ce9279a9ca8 Reviewed-on: https://gerrit.libreoffice.org/60121 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute L10n in some regexp definitions and examples Change-Id: I614575fd63d08e05ffdf7c74a9f73a4c3021cf08 Reviewed-on: https://gerrit.libreoffice.org/60105 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix image dimensions expression in style Change-Id: I1803f18aa0512e5b618daa64efff6487c583fb76 Reviewed-on: https://gerrit.libreoffice.org/60106 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix icon sizes SVG images must have width/height set. Change-Id: Ia881ad81614d949f1d01764f3e750c066651d631 Reviewed-on: https://gerrit.libreoffice.org/60107 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Remove dup bookmarks Change-Id: If88b54807649c5046d7f513eb533156687417e93 Reviewed-on: https://gerrit.libreoffice.org/60108 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07loplugin:useuniqueptr in CoinMPSolverNoel Grandin
Change-Id: Ibe0dfdfabf6f56498564406441a9c505e93dd9a6 Reviewed-on: https://gerrit.libreoffice.org/60112 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07[tr] Add 27 new autocorrect entries for TurkishMuhammet Kara
Change-Id: Ifb0f6fbda69c0696f55a6430120e4ec2e1eb2754 Reviewed-on: https://gerrit.libreoffice.org/60096 Tested-by: Jenkins Reviewed-by: Marco A.G.Pinto <marcoagpinto@sapo.pt> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-07tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[t-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4ec951ddbc0a5ad4718bb44731eb2b4a0f718afc Reviewed-on: https://gerrit.libreoffice.org/60061 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-07tdf#119694: read embedded hsqldb file generated before 6.1Julien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb34571c19c5ac939fbf5aed2ab66ee18e298dc Thank you Drew Jensen for the bibisect! Change-Id: I9550f61709e8582a52554f578ef043c6551f09f0 Reviewed-on: https://gerrit.libreoffice.org/60117 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-07clang-tidy bugprone-use-after-moveNoel Grandin
Change-Id: I6213706ace039492429349c2459923b0e9a5d758 Reviewed-on: https://gerrit.libreoffice.org/60127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07Cleanup SvpSalGraphics LineGeometry creationArmin Le Grand
Target is to less modify the given PolyPolygons to allow better buffer/reuse. To do so, multiple steps need to be taken to make the creation of cairo_path_t correct and effective. Adapted AddPolygonToPath to no longer add a fixed PixelOffxet of (0.5, 0.5) for LineDrawing. Moved that at all places to set the needed linear transformation. Some places which know to work in DeviceCoordinates got directly adapted. The creation of geometry for polygon paints that use line and fill no longer offsets by that values for fill now (which should be better) Adapted AddPolygonPath to use the closed information from the given Polygon geometry - this is used in Win Gdiplus for years and shoud be safe Adapted AddPolygonPath to do correct PixelSnap when a ObjectToDevice transformation is used. This requires to have the ObjectToDevice transformation in the method and using it and it's inverse Adapted AddPolygonPath to support PixelSnapHairline which now needs to be supported in the VCL-layer. Adapted the BufferedData stuff accordingly (and saw that the old solution for this snap was not used - sigh) Corrected ::drawLine to correctly do PixelSnap if needed, version before would have lost it Change-Id: I5e8f71f7439b21f58561da5770b9054236a33235 Reviewed-on: https://gerrit.libreoffice.org/60083 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-07loplugin:useuniqueptr in ImpEditEngine::ConvertNoel Grandin
Change-Id: Iba910b17ca84e423e15b270fe109a2552d16cfba Reviewed-on: https://gerrit.libreoffice.org/60116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07loplugin:useuniqueptr in ImpEditEngineNoel Grandin
Change-Id: I9799c1b239a23fc0f497132ddf29f69c73b1529f Reviewed-on: https://gerrit.libreoffice.org/60115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07loplugin:useuniqueptr in NeonSessionNoel Grandin
Change-Id: I8ff5c031ddd6cf6546c6e4eee60cbe9f60d4fb5f Reviewed-on: https://gerrit.libreoffice.org/60114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07loplugin:useuniqueptr in HWPFileNoel Grandin
Change-Id: I0eb3f09b5ca82ce4810aafbb7d5d53f1faa00e3f Reviewed-on: https://gerrit.libreoffice.org/60111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-07Cppcheck: WNT -> _WIN32Mike Kaganski
Change-Id: Iaf26d9f3b32fd2c60bd94517e1dc12589ecab766 Reviewed-on: https://gerrit.libreoffice.org/60122 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Cppcheck: reduce variable scopeMike Kaganski
Change-Id: I5660fe6ddc745894c1e36176f4aa38ad568f09ba Reviewed-on: https://gerrit.libreoffice.org/60119 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07DeInitVCL in PythonTestStephan Bergmann
After b9757f5cfdb62b24e79eeb4c0ef0c8b98056cecf "loplugin:useuniqueptr in vcl/svdata" ASan/UBSan builds started to fail (like <https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of PythonTest_dbaccess_python (and probably other PythonTests), when during exit the static utl::ConfigManager instance already happens to be destroyed by the time the static ImplSVData's mpSettingsConfigItem is destroyed (which would normally be cleared during DeInitVCL, if PythonTests would call that, and which in the past had thus simply been leaked in PythonTests when that mpSettingsConfigItem was a plain pointer instead of std::unique_ptr). So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new private_deinitTestEnvironment, complementing the existing private_initTestEnvironment. However, while private_initTestEnvironment is called once (typically via UnoInProcess.setUp, which internally makes sure to only call it once) as soon as the first executed test needs it, private_deinitTestEnvironment must be called once after the lasts test needing it has executed. The only way that I found to do that is to override unittest.TextTestResult's stopTestRun method, which is called once after all tests have been executed. Hence a new test runner setup in unotest/source/python/org/libreoffice/unittest.py that is now called from solenv/gbuild/PythonTest.mk. That revealed a few places in PythonTests that didn't yet close/delete documents that they had opened, which has now been added. One remaining problem then is that classes like SwXTextDocument and friends call Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart pointer class ensuring that the pointed object is deleted with a locked SolarMutex", sw/inc/unobaseclass.hxx). That means that any PyUNO proxies to such C++ objects that remain alive after private_deinitTestEnvironment will cause issues at exit, when Python does a final garbage collection of those objects. The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter and its locking of SolarMutex from the dtors of UNO objects; until then, the Python code is now sprinkled with some HACKs to make sure all those PyUNO proxies are released in a timely fashion (see the comment in unotest/source/python/org/libreoffice/unittest.py for details). (Also, it would probably help if UnoInProcess didn't keep a local self.xDoc around referencing (just) the last result of calling one of its open* methods, confusingly making it the responsibility of UnoInProcess to close that one document while making it the responsibility of the test code making the other UnoInProcess.open* calls to close any other documents.) Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be Reviewed-on: https://gerrit.libreoffice.org/60100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07tdf#75341: fix condition to approve row (form)Julien Nabet
Considering rColInfo.nNullable != ColumnValue::NO_NULLS is ok to approve row isn't sufficient in the case the field is "Input required" in form. Change-Id: I27c57fe8ce5afac97eb0650f93703333c85f1421 Reviewed-on: https://gerrit.libreoffice.org/60109 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-07tdf#116453: Add a test case for this.Kohei Yoshida
Change-Id: I280f070bf974ac2f4a889f4c98a80a87092c013a Reviewed-on: https://gerrit.libreoffice.org/60118 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-09-07Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Mark XML Source as experimental feature ... since commit 65722772f00a40b8ca8adf21e31c22295ef7d215 Change-Id: I80d97004a9cd4dc9e6600e6bab64a43c5be91633 Reviewed-on: https://gerrit.libreoffice.org/59706 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-07Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Mention custom format codes for Calc's TEXT() function Change-Id: I29271e2f555cbc231b616e75b43b37775143feae Reviewed-on: https://gerrit.libreoffice.org/59984 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-09-07Fix typoAndrea Gelmini
Change-Id: Ib2c183f5edb94e68f43f92edd83cb8d3ae5b40e1 Reviewed-on: https://gerrit.libreoffice.org/60103 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-09-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Move bookmark out of list Change-Id: Ib1d844ed88a7389e1eeeb9f2279266745ba6acec Reviewed-on: https://gerrit.libreoffice.org/60099 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-06tdf#119302 WIN better font scale handlingJan-Marek Glogowski
Moves the scale factor into the LogicalFontInstance and uses the Glyphs font fallback level to use the correct font and scale. Probably the glyphs should be using a rtl::Reference to the LogcalFontInstance instead of the fallback level. I don't know if glyphs are evicted from the cache, if the fallback changes. There is now an assert and all places will use 1.0 as the default scaling factor, so LO should at least not crash. Change-Id: I9dd4fc3a5b5924fc379b48a7f71c9eed26b4779d Reviewed-on: https://gerrit.libreoffice.org/60091 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-06Pretty print FontSelectPatternJan-Marek Glogowski
Change-Id: Ia43dbfd6313935bec90ac88018011eacca0c0eaf Reviewed-on: https://gerrit.libreoffice.org/60090 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-06clang-tidy bugprone-use-after-move in BitmapFilter::FilterNoel Grandin
which necesitated changing the API and hence the call sites Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa Reviewed-on: https://gerrit.libreoffice.org/60086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#117551 Change icons to SVG equivalent Change-Id: I5d174b434429485d270ba7b6e9147a3bc2b84828 Reviewed-on: https://gerrit.libreoffice.org/60056 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Show how beautiful are our icons On hovering icons, enlarge them. Next step: change icons to SVG (tdf#117551) Change-Id: Ib43e3b54ed27352a8ca785c57dce9314adc00e4d Reviewed-on: https://gerrit.libreoffice.org/60053 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-06svtools: less text layout calls in RulerMiklos Vajna
Number of GenericSalLayout::LayoutText() calls during Writer startup: 2603 -> 1616 (18 -> 1 layouts / included number). Change-Id: I9a1a1131707bb6bc31683bbf609319f4bc22de92 Reviewed-on: https://gerrit.libreoffice.org/60087 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-06tdf#119036 - Inserting columns into RTL sheets will add them to the wrong sideheiko tietze
Commands renamed to Before/After according Writer Change-Id: I4af6fa134a70ff83a717bd53bb0531fd3f647300 Reviewed-on: https://gerrit.libreoffice.org/60081 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-06tdf#119293 - UI Consistency for inserting rows in Writer table"heiko tietze
Labels are set now depending on row/col as before/after and above/below .uno:InsertColumnsBefore and .uno:InsertColumnsAfter are captioned Before/After Change-Id: Ifb4f791b62e3c96f50d457c785b6f793deb4fce9 Reviewed-on: https://gerrit.libreoffice.org/60080 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-06loplugin:simplifyconstruct in canvas..cuiNoel Grandin
Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14 Reviewed-on: https://gerrit.libreoffice.org/60074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06loplugin:simplifyconstruct in dbaccess..drawinglayerNoel Grandin
Change-Id: I83624d8bc787aaaaf6071171c882a6e5bde70a0d Reviewed-on: https://gerrit.libreoffice.org/60075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06loplugin:useuniqueptr in VCoordinateSystemNoel Grandin
Change-Id: I369d6755d3de2dd885214115559150256298852d Reviewed-on: https://gerrit.libreoffice.org/60051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06ofz#10100 dump failed icu config.log on failureCaolán McNamara
Change-Id: I53059b6be263b2abc00e8818a9aeae74b9902a1c Reviewed-on: https://gerrit.libreoffice.org/60082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06rename back now originals are fully replacedCaolán McNamara
Change-Id: I1911055f9bf6bd636561209cadfb1dbf5650affa Reviewed-on: https://gerrit.libreoffice.org/60057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06weld SwColumnPage and SwColumnDialogCaolán McNamara
Change-Id: Ia649785047db2551044b4d765881309f83b5c838 Reviewed-on: https://gerrit.libreoffice.org/60044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06ofz#10228 Integer-overflowCaolán McNamara
Change-Id: I09cb2e8f4af7d34c32accf2590695799d0613d62 Reviewed-on: https://gerrit.libreoffice.org/60070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06WaE: -Wmaybe-uninitializedCaolán McNamara
Change-Id: I41c965512085cc56c06fb735d8ef86aaf3ecdbe9 Reviewed-on: https://gerrit.libreoffice.org/60071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-06tdf#42949 Fix IWYU warnings in chart2/source/view/{axes,charttypes,main}/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I33d3ac3edbda5e2a9958373123565e28210b55c8 Reviewed-on: https://gerrit.libreoffice.org/59956 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06Make AC_LINK_IFELSE (to check HAVE_CPP_INLINE_VARIABLES) work on WindowsStephan Bergmann
Change-Id: I6c71e079f21093d5f8dc4dbca20624e9fc927882 Reviewed-on: https://gerrit.libreoffice.org/60072 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-06xmlsecurity: just two bools are fine, no need for bitfield complexityMiklos Vajna
Change-Id: I3e28ef5646ff39b0e3e8ed8962bfacf5b79176a7 Reviewed-on: https://gerrit.libreoffice.org/60069 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-06sc header-footer dlg: Suppress false-positive warningSamuel Thibault
labelFT_H_DEFINED and labelFT_F_DEFINED are indeed two labels for the same widget, and only one appears at the same time. Change-Id: Ie8c29a43408d1ee29f15c686af906359ef3c50b9 Reviewed-on: https://gerrit.libreoffice.org/60046 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06sc [tz]test dlg: fix duplicate mnemonic labelKatarina Behrens
Change-Id: Ibf2780a2eb658f7210cb5e80cf2b8e2e65fe1bda Reviewed-on: https://gerrit.libreoffice.org/59979 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06sc random number gen dlg: fix some a11y issuesKatarina Behrens
Change-Id: I04c31c96538cb7da07e6bf2e43e6150f04f9d247 Reviewed-on: https://gerrit.libreoffice.org/59978 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-06Revert "tdf#119293 - UI Consistency for inserting rows in Writer table"Heiko Tietze
This reverts commit a3c8250c5b56a2cb40aa01b9a6a59e4daa1fd2f8. "Left/Right" is inappropriate for RTL documents. So we better use Before/After in accordance with tdf#119036. Change-Id: Id9cb721902d246f837c7440c2f0c049c7c1dc4ca Reviewed-on: https://gerrit.libreoffice.org/60073 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-29 10:35:23 +0000