summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-25svx: rework the theme dialog to allow editing theme colorsTomaž Vajngerl
In addition to editing of theme colors, this also changes the way how theme colors are represented in the theme dialog and the behaviour when changing applying a theme color change. Previously a theme colors were applied with double-click, now a double-click still applies, but automatically exits the dialog. The selected theme is applied also when OK button is pressed. Change-Id: Ic0f8399ede180d6ab0001a7f8b5dda0e7c49fa3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25add "m" prefix to member variables - SfxTabPageTomaž Vajngerl
Change-Id: I482c341518948bf92f81d4f89b7e307635220150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150974 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25Resolves: tdf#144547 ScRangeFindList: handle references in multi-line formulaEike Rathke
Also fix a color attribution error if when dragging the reference the new reference string is longer (colored too short) or shorter (colored too much including the next characters/operator/...) than the old reference string. Change-Id: I1b39fd5778d75290a0233f51a4198753fa858f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25tdf#154604 SdNavigator: Support listing in front-to-back z orderJim Raykowski
Enhancement patch to provide the option to list objects in front-to- back or back-to-front z order Change-Id: I2194cace08736d948002548887661314834cef89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150893 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-04-25tdf#38194 tdf#106556 Enhancement to highlight direct formatting,Jim Raykowski
paragraph style, and character style use in Writer documents Initial commit to realize direct formatting, paragraph style, and character style highlighting enhancement requests. Highlighting of character direct formatting is turned on/off using .uno:HighlightCharDF. Highlighting of paragraph styles and character styles is turned on/off using a check box in the Sidebar Styles panel. Closing the Sidebar also turns paragraph and character style highlighting off. Paragraph direct formatting is indicated by a hatch pattern over the paragraph style highlight bar and also by "+ Paragraph Direct Formatting" appended to the tooltip that appears showing the name of the paragraph style when the mouse pointer is over the style highlight bar. Colors used for styles highlighting are determined by a hash of the style name. Lightgray is used for character direct formatting. Known issue: Tooltip doesn't show for paragraph style highlighting in tables and in frames where the highlighting bar is drawn outside of the frame. Change-Id: I6e00ee38c1c169bc7c6542a1782c03b2593e1891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150451 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25add a fuzzer to test zip recovery modeCaolán McNamara
Change-Id: I25f82cd83afae0fb3b0cfc3f1586e28323369f8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25add --disable-pedantic to avoid warnings as error for xmlsecCaolán McNamara
like... symkeys.c:621:30: error: no newline at end of file [-Werror,-Wnewline-eof] #endif /* XMLSEC_NO_PBKDF2 */ ^ 1 error generated. make[5]: *** [Makefile:765: libxmlsec1_openssl_la-symkeys.lo] Error 1 Change-Id: I1dcd0cb6b350f412c30fb5a8d3aa4976cd0afde5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#154956 sw: delete bookmarks at end if whole node is selectedJustin Luth
Exposed by LO 7.2.2 commit 4bf04dea9afb30a9395e80b07a81d1908937ee8b Author: Michael Stahl on Fri Aug 27 14:38:18 2021 +0200 tdf#128106 sw: copy bookmarks at start if whole node is copied Change-Id: I9205463f9beb3704eeb63fe7556103230ba7283d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150772 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-25Resolves tdf#154080 - Allow customization of comment indicator colorHeiko Tietze
* New application color added * Border color depending on cell/sheet background * Comments color set to light magenta to align with similar tools Change-Id: I782e8359632c5a319e61f5d5ac3deb4614bd7e79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150970 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25Fix tdf#155004: ucb: webdav-curl: carry over Class1 bit only if setMichael Stahl
With d6182cb6704c06f33d284874b9fe96c85cce5bf5 there are cases when a webdav server inadvertendly releases the lock. Lets apply the fix only if the Class1 flag is actually set. Change-Id: I85e5253c7df0980f373d2dea788c331b81ed4a82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150552 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2023-04-25Remove lock file fuzzerCaolán McNamara
this found nothing in 12 months and exists to try and follow up on a confusing report which went nowhere in the end Change-Id: I7f3c6a5e2ccedad2e7b925b3c15b076cd22f1ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150972 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25expose recovering zips for testingCaolán McNamara
Change-Id: I4709a2fb0bbb0fcc4c7d57dad53c899e7ba79cb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25Resolves: tdf#155005 use of uninitialised valueCaolán McNamara
==2515797== Conditional jump or move depends on uninitialised value(s) ==2515797== at 0x33FAB399: ZipFile::recover() (ZipFile.cxx:1090) ==2515797== by 0x33FA4D32: ZipFile::ZipFile(rtl::Reference<comphelper::RefCountedMutex>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>, bool, bool) (ZipFile.cxx:111) ==2515797== by 0x33FEF134: void std::_Construct<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(ZipFile*, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (stl_construct.h:119) ==2515797== by 0x33FED528: void std::_Optional_payload_base<ZipFile>::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:278) ==2515797== by 0x33FEB73B: void std::_Optional_base_impl<ZipFile, std::_Optional_base<ZipFile, false, false> >::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:457) ==2515797== by 0x33FE77DB: std::enable_if<is_constructible_v<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>, ZipFile&>::type std::optional<ZipFile>::emplace<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:918) ==2515797== by 0x33FD61FD: ZipPackage::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (ZipPackage.cxx:760) ==2515797== by 0x64DE1EC: cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:732) ==2515797== by 0x64DDF19: cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:694) ==2515797== by 0x64E0E8F: cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (servicemanager.cxx:1018) ==2515797== by 0x34A3B25F: OStorage_Impl::OpenOwnPackage() (xstorage.cxx:435) ==2515797== by 0x34A3C16C: OStorage_Impl::ReadContents() (xstorage.cxx:541) ==2515797== Uninitialised value was created by a stack allocation ==2515797== at 0x33FAB02C: ZipFile::recover() (ZipFile.cxx:1034) since: commit abda72eeac19b18c22f57d5443c3955a463605d7 Date: Mon Feb 20 00:32:22 2023 +0100 tdf#82984 tdf#94915 zip64 support (import + export) where - aEntry.nCompressedSize = nCompressedSize; - aEntry.nSize = nSize; was removed before the subsequent use of aEntry.nCompressedSize/aEntry.nSize change things (git show -w for clarity) to check bounds first just for the range the extra fields might be in and read those, and then follow up with the original check that the newly discovered aEntry.nCompressedSize/aEntry.nSize are within the bounds of the overall file Change-Id: Iad4ce8297109b06bc5baf77df4f3e86659cbb4cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#155005 fail gracefully on encountering a negative compression valueCaolán McNamara
we are using sal_Int64 for this so a large enough value can be interpreted as negative here Change-Id: Id547a24591aca4b6ed7b7955621641a0666b0bd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150968 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25tdf#91332 XLSX export: fix missing solidFillTünde Tóth
Background color of shape inherited from theme lost after export. Regression from commit bc0a9076aa43a0782bcf81e55d3f84f6af0f68e8 "ooxml: Preserve shape theme attribute for solid fill". Change-Id: I2d8298ac17332ba3ad6a627ce8b07c23087ac7b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150674 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25tdf#119565 XLSX export: fix lost line properties inherited from themeTünde Tóth
Line properties (LineWidth and LineJoint) of shape inherited from theme lost after export. Perhaps regression from commit 5391d4872e71d1edba7acc4ad2d2e3b5b97e1723 "ooxml: Preserve shape style and theme attributes for line". Change-Id: I9977bb20f16245f3c95ccbe2c5c8033b5b0c9cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150547 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25tdf#150824 sw DOCX: fix export of new tracked tablesLászló Németh
New tracked tables handled by a single redline, which lost during the export: only the tracked text changes of the cells were exported, but not the table changes. This resulted also problems in MSO, e.g. rejecting text changes removed only single cells of the tables, modifying the table structure. To fix this, add missing tracking to the table rows, if needed. Follow-up to commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06 "tdf#79069 DOCX: support tracked table (row) deletion". Change-Id: Ic900cafa7bea3c934d8d1bd585b3e95f56746db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150967 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-25oox: add support for theme import and export of blip effectsTomaž Vajngerl
This adds support for (most) blip effects import, export and the document model. Change-Id: Iec15f4de22c31268019fa1a60432e40ae8f03635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150262 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25oox: write graphic (blip) in ThemeExport - BlipFillTomaž Vajngerl
Share the graphic writing from DrawingML class, which needed a bit of refactoring and use it when writing the BlipFill when exporting a theme with ThemeExport. Change-Id: I89bf3be98f607b7641d231982af2f7a5e2c3d3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150261 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25tdf#154991: sc_uicalc: Add unittestXisco Fauli
Change-Id: I1aa8e56fdbf0b8903cd04b78f4bb640fb31bd56d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150963 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-25workaround compile failures in libxml, with clang-17Noel Grandin
ever since commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b Author: Miklos Vajna <vmiklos@collabora.com> Date: Mon Apr 24 14:27:47 2023 +0200 Update libxmlsec to 1.3.0 failures reported to https://github.com/lsh123/xmlsec/discussions/623 Change-Id: I2952f0eda036f6ff69710b8a103bbfc846ed87d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150966 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-25Group sort bo_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
Change-Id: I6e17c01ce4d3a351a2cb49d214f73468d425b4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150952 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Inherit ml_IN formats and numberings from hi_INEike Rathke
Change-Id: Ied5f3f8e051d8d9292888d8831ae3e6a88270198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150953 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25Group sort hi_IN.xml LC_FORMAT FormatElement for better comparabilityEike Rathke
... and eliminate doubled space. Change-Id: I84229145072283975ff17e2db661784205fa9af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150950 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-25loplugin:unnecessarygetstrStephan Bergmann
Change-Id: I120b2ef4b8a409dc63495829bec872ebad01c868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25Resolves tdf#154991 - Fix crash with hidden columnsHeiko Tietze
Hidden columns do not have a background that can be taken into account for the text overflow indicator's frame Change-Id: I325873aede07fd890777624308a3f5a41f0f1795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150959 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-25loplugin:unnecessarygetstrStephan Bergmann
Change-Id: I36eaac02a9779ee8e1f69930ffeafedc8641301f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150961 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25oox: refactor ThemeExport to use member FSHelperPtr instanceTomaž Vajngerl
This refactors ThemeExport to use the member variable FSHelperPtr instead of passign it through functions as a parameter. This also forces many functions that were in anonymous namespace to become members of the ThemeExport class. This is needed because in some instances we will need access to FSHelperPtr instance as well as access to XmlFilterBase. Change-Id: I9e4ead9cd87ec2157535106be28596c4282fe167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150260 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25Make bin/includebloat.awk script output prettierGabor Kelemen
So instead of: sum total bytes included (excluding system headers): 21793372177 1197253280 132910 9008 /home/gabor/src/core/include/rtl/ustring.hxx 825845085 90207 9155 /home/gabor/src/core/include/rtl/ustring.h We can see something nicer: Sum total bytes included (excluding system headers): 21.795.559.123 Total bytes Size Occurrences Filename 1.197.253.280 132.910 9.008 /home/gabor/src/core/include/rtl/ustring.hxx 825.845.085 90.207 9.155 /home/gabor/src/core/include/rtl/ustring.h Change-Id: Iabcaadae964221ed532e7e7e97b10211e37d4857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150613 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-25Resolves: tdf#154958 add an empty spin button to use for the unused caseCaolán McNamara
instead of reusing the percentage one, which will set its min value under gtk Change-Id: I342f8f0588574c45c5752964b95232e419f752ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25ofz#57493 avoid TimeoutCaolán McNamara
Change-Id: I9fee1ad3467c18d2714ef211f2c95c6b4211415b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150946 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-25sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 1Miklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). What happens is that the DOCX file has a continuous section break, that is mapped to a Writer section, but then the fly splitting code didn't expect that the anchor might be inside a section frame. Fix this by explicitly checking for an in-section anchor in SwFrame::GetNextFlyLeaf(), which will give us a suitable insertion point on the next page. This does not fully fix the handling of the bugdoc, but at least now a reduced sample doesn't crash and is handled correctly. Change-Id: I52b5c901d899533bbb78131f443789d55db41000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150956 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-25Add some tests for (Japanese) i18n::IndexEntrySupplier behaviorStephan Bergmann
...in preparation for some upcoming i18npool/util/i18npool.component clean-up Change-Id: I8e93aa33759f2bdd6b9422b3833a608cfbed1df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150948 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-25Add script to find unused using declarationsGabor Kelemen
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls" Pros: - simple, fast! - finds some more unused declarations, somehow - works on non-linux specific parts of the code - clang-tidy (for me) trips on files with external headers, this does not Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-25Update libxmlsec to 1.3.0Miklos Vajna
See <https://github.com/lsh123/xmlsec/releases/tag/xmlsec_1_3_0> for the upstream release notes, notably: > (ABI breaking change) Switched xmlSecSize to use size_t by default. Adapt xmlsec-wrapper.h accordingly. Change-Id: If910e44441be65794d4441558e2838d00b4b927c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150647 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-25oox: extract image / graphic export into GraphicExport classTomaž Vajngerl
Change-Id: Ib37aee6c5f664e80d45530dae0de9c172e0773a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150259 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25oox: Harden the testTdf142605_CurveSize Test with extra checksTomaž Vajngerl
Even if it is likely that we fail, it's important that we check that we are checking thr correct shape and not some other shape. As there is only one shape we could assume that in the case that something goes wrong and we wouldn't be able to read the shape, we would end up with 0 shapes, but in case of an empty page we inject placeholder shapes into the page, so we end up comparing the size of a placeholder shape. In this case the test assert gets confusing as we obviously get wrong sizes, which suggest that something is wrong with the shape and not that the shape we expect to assert against is missing and we compare against a different (placeholder) shape. This adds more asserts, which make sure we actually have the expected shape first and also preven crashes if something would go wrong. Change-Id: I435f87d7e634c5135a376ad084373f8d5053555e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-25tdf#154774 KJ & Sukapura: +/^ images for spacing preview in MathRizal Muttaqin
Change-Id: Ibafddc6e1db98448cc94e72d48c577e8c719ae8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150951 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-04-24oox: combine graphic cache into GraphicExportCache classTomaž Vajngerl
We cache graphics to not export the same graphic multiple times if this can be avoided. The cache was integrated into DrawingML but we need access to it in different places, so this change extracts it into its own class. Change-Id: I71e3b67906f2948ca00c2ef7ca857bf80ab6a737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-24oox: extend ThemeExport to export font and format scheme of a themeTomaž Vajngerl
Also use the ThemeExport when exporting PPTX documents and remove all the hard-coded theme bits. Change-Id: I03791e23d6ac4023748b5a553e4824b72ed63a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-24introduce sw::SpzFrameFormat ...Bjoern Michaelsen
- ... as a base class of frame formats allowed into the spz frame format container - with a private ctor and friends SwDrawFrameFormat and SwFlyFrameFormat so only these two classes derive from it - with that, switch over the SpzFrameFormats to only ever allow these types into the container - in followups, likely quite a bit of stronger typing can be introduced. - ultimately, it would be nice to have each SwDrawFrameFormats and SwFlyFrameFormats in their own strongly typed container in the end. Change-Id: Ic30efc1220aded701533c9ca5003d2aaf8bbdaec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150452 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2023-04-24tdf#145359 related: Fix SdNavigator dnd z orderingJim Raykowski
Makes the object dnd z order follow the current behavior of bring forward and send back actions. Object placement top to bottom in the Navigator is wrt object z order back to front. Change-Id: I42e0902eabe7a2758a075a5f4357868994825a51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150810 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-04-24Resolves: tdf#153441 use a TriStateEnabled helperCaolán McNamara
Change-Id: I976e4271a072bfb53c676091509e1d4ef7dbcccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24ofz#58241 Integer-overflowCaolán McNamara
Change-Id: Ie5b82df4642c786e309022e3b5a436aef66d1137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24loplugin:unnecessarygetstr extend to more std::string checkingNoel Grandin
suggested by mike kaganski Change-Id: I5f5f254142767aca45a6101abdd84a0163ca6a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-24tdf#154859 sw: fix deletion of tracked row insertionLászló Németh
Row deletion of tracked row insertions resulted an empty, not tracked row. To fix this, disable row deletion on tracked row insertions, allowing only to manage changes for removing the row, e.g. by clicking on Reject Change of the context menu of the table row, like MSO does. This also avoids of clicking again on the row deletion to create an empty tracked row deletion from the empty not tracked row, and originally, from the tracked row insertion. Regression from commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Follow-up to commit 0204c00f241313e1d292b4c3ea117d42af7dec69 "tdf#147453 sw: disable Delete Table functions on tracked deletions". See also commit 95c003d75e0f8b255344715a35358072b5eba99d "tdf#146145 sw: 1-click Accept/Reject of table row changes". Change-Id: Ied38860939359caa52e09987cf968953399611ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150938 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-24resave with latest gladeCaolán McNamara
Change-Id: I8db5ddfa271ab3729d069486f9f4b05263fbe9b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24sw floattable, crashtesting: fix PDF export of fdo80989-1.docxMiklos Vajna
Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). There were two problems here: 1) We assumed that when we move content to a next page, that page is empty. This may not be true, and in case the next page has content, we should insert the content at the start of the page, not at the end. Specifying the sibling for MoveSubTree() fixes this. 2) We also hoped that if we ask for the next layout leaf, that will be from the next page. Again, this may not be true, SwFrame::GetNextSctLeaf() has quite complex conditions to detect this. Split flys don't have to span over multiple columns, so just require that the candidate is inside a different body then our anchor. The bugdoc has to be loaded in hidden mode, otherwise we already calc the layout on load, and then the problem is not visible. Change-Id: I6e1533369db24c7c275ec1d7dceaddc4128c268a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150904 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-24tdf#154884: do not stop if the first pair is not what we looked forMike Kaganski
The same character can be added later with a different font, so keep searching Change-Id: I7b83438ca476ffab23ca08268cf957045d75f6f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150937 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-24tdf#154698 allow "XML Form Document" to be localizedCaolán McNamara
like "Base: Relation Design" can be Change-Id: Ic4bebd0636da1eb598e667f7aa51b201ecf9cc27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-24 16:14:44 +0000