summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-11-01editeng: rename aBuf to aCharPositionArrayTomaž Vajngerl
Change-Id: Ie7614ee9eefe1160f6d1e6105cc5bf7b92a35cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142063 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-11-01tdf#126788 elide OUString construction SwTextNode::InsertTextNoel Grandin
if the node is empty, we can avoid the cost of constructing a new string Change-Id: I5792fc0a80019008c4e7f458d4472405123cdeb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142083 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-01tdf#142446 follow up: Fix missing ui file crash and a11y ui errorsJim Raykowski
I somehow missed adding the locally changed .mk files to commit 5f72a041c0160e4067ca931a9cec711b84b558f4. This patch also fixes gla11y reported a11y errors in the UI file and adds a help message to the dialog. Change-Id: Ib095b59f12571d53888916b26914fa99dd82979a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142087 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-10-31Translatable string fixesAdolfo Jayme Barrientos
Change-Id: I8dd8f70dd7c522d60dbd69cea8c78773d6dc2ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142085 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-31Fix typoAndrea Gelmini
Change-Id: Id77aa9674c4a7461ed4adbbeb70778d3800c113a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142068 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-31Fix typoAndrea Gelmini
Change-Id: I5090a74ff98240821555ce749316df3721da4a9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142067 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-10-31sd: Simplify codeXisco Fauli
Change-Id: I507064c9543729473fed41f1463e09146e31a715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31sdmodeltestbase.hxx: use clang-formatXisco Fauli
Now that the file has shrunk in size Change-Id: I6e9e245cd332c225eacc7ceca1be6d533bf58187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142081 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31SdModelTestBase is now unusedXisco Fauli
Change-Id: I34eee3f0159d7779161ecacdd6cf0aa69a670ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142079 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31CppunitTest_sd_import_tests2: inherit from UnoApiTestXisco Fauli
Change-Id: I64e810a67a394ee6daa555567a741d037b66db60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142078 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31tdf#126788 inline createTextCursorByRange into this call siteNoel Grandin
Change-Id: I1ee91ff56f4c5e0c0182f67a9c321e914ec6cd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142039 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31tdf#126788 inline CreateParentXText into this call siteNoel Grandin
Change-Id: Ib2defa8789180924405f29432736f7e03f80b9c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 04549b13ac062594e2204a8f8da7bf92ec290995 - Improve Help on Draw layers dialog Remove modify_layer.xhp and merge with insert_layer.xhp Change-Id: I6500aae19a7f4745ee94f7dffc664df724b568db Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142084 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31CppunitTest_sd_import_tests: inherit from UnoApiTestXisco Fauli
No need to have compareWithShapesDump in a different place, it's only use in one place Change-Id: I539950ce0749f1f0231f5770cd63549a0299341a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142076 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31ofz#52898 bad cast to SwXMLImportNoel Grandin
fallout from commit 2c4aabb220ad1e8f1cbc75f2361fe17893d7cc29 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Oct 29 11:11:36 2022 +0200 tdf#126788 speed up GetDocFromXMLImport where the prior UNO_QUERY code was hiding this problem Change-Id: I21efc27f4b04acb38138d2d44e207d5a6b9cb9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31CppunitTest_sc_macros_test: simplify code a bitXisco Fauli
Change-Id: I419f5a0c09643455be992f68b72f4903cfe98a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142080 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31fix regression from "editeng: don't use GetSize to set the size"Noel Grandin
Params are swapped since commit 190cd40e01bd36e99b265ef5da36a382199f18b9 (HEAD, master) Date: Tue Oct 18 21:14:41 2022 +0200 editeng: don't use GetSize to set the size Change-Id: I0a3fce0c8325fa59c385fa2e45a53215853e351a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142077 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2022-10-31tdf#150465 Improve description of RANDBETWEEN in function wizardRafael Lima
As requested by the user, this patch makes it clearer that both Bottom and Top values may be returned by the RANDBETWEEN and RANDBETWEEN.NV functions, making the Function Wizard and the online Help descriptions more similar. Change-Id: I730a9a5e42525f890c85c2489ef03797b812917a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141922 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31tdf#141339 Use pragma once instead of include guardsEmmanuel Peter
Change-Id: Icea246369ca215745e4b1ca1764bedb83123409e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141339 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 1ace4c64188685b2fb3abed212ddb134ceddb885 - Add screenshot for Help on Snap dialog Change-Id: Ie960428b391f71b354ccb97d643978cbf6d42e67 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142049 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3962eff25dac38ed1422845c47a0ace437a3772a - Add Insert Layer screenshot in Help Change-Id: I8ac8024ff5f2dad893248fe75566ab152e72a762 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142048 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31Add Properties area in insertlayer.ui dialogOlivier Hallot
Help pages for Insert Layer mentions a Properties area in the insertlayer.ui dialog. This patch adds (back?) the Properties area in the dialog. Change-Id: I502b1aa055519a32c7747c11b813b3727421e28e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142045 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31CppunitTest_sd_import_tests: use clang-formatXisco Fauli
Do it before changing the inheritance Change-Id: Ia668d371637e23ceba19984ca622f4e57a74aeca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142073 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31tdf#126788 inline CreateXTextRange into this call siteNoel Grandin
Change-Id: Iba3c0a35ebd9e1c6e639cde79225c3ab896bc97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31CppunitTest_sd_export_tests: fix buildXisco Fauli
6f32f1a12be06c4da92b807d8a35cb079984e26a "tdf#72238 xmloff,sd: Import of <style:table-cell-properties>" and c66def668e43bb40eee54fe91e752ba1330cb911 "CppunitTest_sd_export_tests: inherit from UnoApiTest" were merged at the same time, breaking the build Change-Id: If856edab62c2ef31a2dbfe6c5315f51fde0bd031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142072 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31CppunitTest_sd_tiledrendering: inherit from UnoApiTest (part2)Xisco Fauli
Change-Id: I541eb1f119c37c263814a9a5c7944461220b11e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142070 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31CppunitTest_sd_import_tests-smartart: inherit from UnoApiTestXisco Fauli
Change-Id: I4ef95f3899cc67aaba0d9d657341890b3cb73fc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142069 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31editeng: don't use GetSize to set the sizeTomaž Vajngerl
Change-Id: I80a2701d7c125dbe6c80f8c32b125c7b176a8bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142062 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-10-31editeng: prefix the instance variable aDefFont-> maDefFontTomaž Vajngerl
Change-Id: Ie9d18c19792962159e4e2ff4ddf91560323e42e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142061 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-10-31lok: fix convert-to batch mode, quiet interactionHenry Castro
If it is a batch mode to convert *.csv to *.ods, use the quiet interaction to avoid unwanted filter dialogs. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I4ef82c1079888ae099084072c146b5db4cc0f2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141950 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ash@collabora.com>
2022-10-31CppunitTest_sd_activex_controls_tests: inherit from UnoApiTestXisco Fauli
Change-Id: I6c1e25f235e8a5c67b0e098660a29dc154fe9962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142065 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31tdf#126788 return concrete type from CreateXTextRangeNoel Grandin
to make it easier to optimise call sites unnecessarily creates tons of these Change-Id: I39bced82ae03fe33dbf0592f384332ab49f914fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31SdModelTestBaseXML is now unusedXisco Fauli
Change-Id: I2bd3cced5a7dd96840190f42c1ce2cbd94533206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142060 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31CppunitTest_sd_export_tests: inherit from UnoApiTestXisco Fauli
Change-Id: I08bc56eeb4e5e67da1c79c489ffc002b6a1e2fe0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142059 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31tdf#113187 exclude angle conversion from count of maGuideListRegina Henschel
The ooxml import uses the special viewBox value '0 0 0 0' to indicate that the point coordinates are relative to shape size and not to viewBox and need special treatment. To detect this case the number of guides in maGuideList was used. But that number might be larger than the guides in ooxml because each arcTo command introduces two additional guides for the conversion from 1/60000 degree in ooxml to degree in LibreOffice. The patch excludes these guides from count. Thus now a path which has no references in its points will get a viewBox with non-zero width and height in all cases and is rendered now. Change-Id: I410638a1fe02f692fd46313c88b5ea518f1d094f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142050 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-31tdf#72238 xmloff,sd: Import of <style:table-cell-properties>Maxim Monastirsky
Handles fo:border*, fo:padding*, fo:background-color and style:vertical-align attributes. Export is unchanged for now, as older versions still can't read this, and on the other hand we probably want to keep the import of the wrong attributes for the long term, to not break existing documents. Also, we can't fully export fill properties anyway because of tdf#103602. Change-Id: I8687507b98602ffcd05adb2087c894bb45aa3c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142058 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-10-31simplify logicNoel Grandin
we know bSearchUsed is already false here. It has been this way since initial commit. Change-Id: I598b02fedaa71f07d6f24928c5b9d56761970e3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142055 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31tdf#143377 Correct maximum Skew for TextOrientation in CalcArmin Le Grand (allotropia)
For zero or 180 degree text orinentation errors can happen in the Border visualization, theoretically also in the Text rendering. Ths has to do with sin(0) and sin(180) being zero and lead internal to numerical problems, e.g. a very huge Skew that when applied show the reported 'errors'. I limit this mechanism now to +/- 1/2 degree from the critical mentioned places, for Border and Text - to not risk to have different points of corrections. The UI only allows angles of 1 degree steps, but UNO API and pdf import may allow more. Change-Id: Idbc68f6a7beab84df0672165c2a813d96eeff84e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141999 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-31Revert "tdf#126788 replace dynamic_cast with static_cast"Noel Grandin
This reverts commit 32b0b79c3f71e4aca995aa92ee519d93a3ca2b3b. Reason for revert: apparently sometimes we can have a regular SwPaM here? Change-Id: Ib09028a8ca565cea35defba5783ca4f869c59c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31tdf#126788 only call TotalCount() if we need the resultNoel Grandin
Change-Id: Idcacc67f005204ac499f8cdff2792e97636ae85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-31tdf#151654 related: dereference after nullptr checkMike Kaganski
pPV nullptr has appeared in commit 6fcee31ed5e1dadcbf9614967592ff188a250007 Date Thu Jul 02 14:28:15 2009 +0000 CWS-TOOLING: integrate CWS aw065 but it was still dereferenced unconditionally after that. Change-Id: I4a9ec2345e4093673eed092f6ddb16ee21b9d00f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-31tdf#151071 Sifr follow upstream: Form Control, Record, Cell Styles, ShadowRizal Muttaqin
Change-Id: Id939ddaefc435778fcd8ae17112875b698903b9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142051 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-31tdf#151837 Sifr: Icons in Left Area of XML DocumentRizal Muttaqin
Change-Id: I6ca99b08145c0bb7f1151e11203dc0edba788f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142052 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-10-30tdf#129610 SdNavigator: Realize multiple selection of objectsJim Raykowski
This enhancement patch makes possible, mutiple selection of objects in the draw view using the Navigator page/objects tree. Standard multi-select mouse and keyboard methods, Ctrl/Shift + mouse button/ keyboard navigation keys, seem to work as expected with gtk3, x11, and qt vcl backends. Double mouse click and the Enter key, moves keyboard focus to the selected objects selection frame. Single mouse click and keyboard navigation keys select the object in the view while keeping the keyboard focus in the Navigator tree. Patch code done to make navigation to empty name objects, commit f0878173e1963cf8db5f60ced6d19da24e18bc41, is moved to the SdNavigatorWin selection object handler, ClickObjectHdl, by this patch. UITesting: TreeListEntryUIObject "DOUBLECLICK" action change: Multiple selection as implemented in this patch, requires the tree list entry to become the cursor entry when selected. Change-Id: I58a36117242e40ce2811488c1fa8ef2aa72b28e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141440 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-10-30'use strict' and 'use warnings' in all installer PerlMike Kaganski
Change-Id: I6068b795a7dfac24651c8e4a100f78dbee11f98b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142044 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-30Bump glade release for sd/.../insertlayer.uiOlivier Hallot
Change-Id: Iccc52cefcd8de0586dc3c20a8da04ff68b54b7fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142043 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-30tdf#126788 reduce number of comparisons to query XUnoTunnelNoel Grandin
Change-Id: I581fa6944f9da9195651bacd2f11fd7f35967ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-30tdf#126788 avoid temporary SequenceNoel Grandin
Change-Id: Id2cc39529aa26429e929704271db450abe6bd1e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-30Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 021a444733a8022967b374642057d2032318634b - tdf141474 CreateUnoService accepts keyword arguments tdf114263 CreateUnoServiceWithArguments new help page Change-Id: I217746d0817cefcaab7ecb07d30b2c3f2ad8bfff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141916 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-30tdf#151818 xlsx SmartArt import, apply theme text colorRegina Henschel
Similar as patch 2406ba67 for tdf#54095 but now for import of SmartArt objects in xlsx files. Change-Id: I12ca8c476fb9d141cef991e8e98ad13b53c70613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142027 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
generated by cgit (git 2.34.1) at 2025-01-18 00:35:06 +0000