Age | Commit message (Collapse) | Author |
|
Documents starting with an even page on a mirrored layout need
to switch left/right margin on the first page.
Applies also to docx export.
JUnit test included
Change-Id: Ia363941c6a7a25f9208acc7e40b77baa88080780
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168658
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
|
|
amid lots of junk, found by sed -i -f ref.sed */*/*.cxx
--------------------ref.sed --------------------
{
N;
s#\([^\n]*\n\)\1#\1#g;
P;
D;
-------------------------------------------------
Change-Id: I2788c098d91b149a3728fd597ee227078ccfc038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169059
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to 4c8b04c8d9d3a2367bb3205b852f2d7b75082f90
- tdf#154226 Add link to LO books on Help pages
Added a row of icons on the footer of the Help pages.
Change-Id: I40e1e697e5defa21ba3fb6f93198489ac401924b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169033
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 9f43bf5caf95051c06f0c08f326f8d864c501d58
- tdf161612 Precisions for XMATCH function Help page
Change-Id: Id50a01c9c33284124f022540ac51c1f1651848e7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169007
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
When a JS function implementing a UNO interface method returns any or a sequence
type (like queryInterface, getType, and getImplementationId in uno.js), it
could not create a new instance of that type and return it, as it would have
needed to call .delete() on that instance, but couldn't. In uno.js, getType and
getImplementationId solved that by returning pre-instantiated instances that
were deleted in the final release call. But that did not work for
queryInterface, as pre-instantiating the relevant any instances would have
caused cyclic references that would have caused the final release call never to
occur.
So redesign the C++ the_wrapper classes (used by the Embind allow_subclass
machinery): If a UNO interface method returns any or a sequence type (i.e., a
type on which .delete() must be called), change the JS implemenation's return
type from by-value (which meant that the C++ code received a copy) to
by-reference---which means that now the C++ code can access the original
instance and delete it. But which also means that the JS code must always
return a fresh instance now!
(Ideally, the embindmaker-generated code would use by-pointer rather than
by-reference for that return type, but that caused
> emsdk/upstream/emscripten/cache/sysroot/include/emscripten/wire.h:116:19: error: static assertion failed due to requirement '!std::is_pointer<com::sun::star::uno::Any *>::value': Implicitly binding raw pointers is illegal. Specify allow_raw_pointer<arg<?>>
> 116 | static_assert(!std::is_pointer<T*>::value, "Implicitly binding raw pointers is illegal. Specify allow_raw_pointer<arg<?>>");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
errors with no obvious place where to put such allow_raw_pointer markers, so
lets go with this little hack at least for now.)
Change-Id: I3c37b79b8fbf09c19782c6532bc95d4d63505c63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169008
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: Ied2b0ed968987f44446abf1066b7e9af106e909d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169039
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I3979577a82539c6b9d36bef0faa2a34689be2a17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169038
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2fcec37cd9d22862dd136c97e5b4097e69fd41cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169035
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
ever since
commit 2d8056d884ee3ab7b4454c378618dceb6f5a7ae8
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Apr 4 10:55:36 2024 +0200
loplugin:unusedmethods
Change-Id: I2ccdbf45ac688e39df23fd69b8ec21efebad044c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169003
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I153b36b8cc5e91f46bff42dba2f36fce733a8df9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169002
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I75995fb7640977276feeea2e2963725974adbe42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169001
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: Ie653fc6880e096ca4fad4dc1cf77bb3f16915dbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169000
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I55f419e08323d0fe7cc16bc525fc93920980f4c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168999
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Regression from commit ca71482237d31703454062b8b2f544a8bacd2831
(tdf#153083 writerfilter: import locale-dependent TOC \t style names, 2,
2023-01-31), open the doc, apply 'Level 2 Heading' on the first para,
then switch back to 'Signature' again using e.g. the sidebar, the
numbering of the first paragraph is gone.
This was initially a wider problem, but since commit
ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be (tdf#160402
filter,writerfilter: import locale-dependent STYLEREF names,
2024-05-06), the problem only affects built-in styles. There were two
remaining problems: 1) the separator for the TOC field can contain
whitespace, which resulted in a style named ' Signature' and 2) the
style was always cloned, even if the name was not localized.
Fix the problem by first trimming the style name in
DomainMapper_Impl::handleToc() and then only cloning in
DomainMapper_Impl::ConvertTOCStyleName() if we see that the style name
is localized. A localized style name can be observed when opening e.g.
sw/qa/extras/ooxmlexport/data/custom-styles-TOC-semicolon.docx that has
Intensives Zitat vs Intense Quote.
One remaining question is why the numbering is lost when the cloning
happens, that's not addressed here, as the cloning should not happen for
this document in the first place.
Change-Id: Ibc2ea20cc3c9ec6bec9bdcdabce1469a0457317a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168994
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
* Update translations from branch 'master'
to b6092afde898f454189047221479af58e31049fa
- update translations for 24-8/master
and force-fix errors using pocheck
Change-Id: I4a4726ec04a147df4f78d95213a82bf9e0c13a61
|
|
Change-Id: I31647952090224e3195afc636613d1ae56ecb10e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168995
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
|
|
It should check for the wholesome encryption more directly; PBKDF2 is
unreachable from the UI in this case anyway, this can only be tested
with LO_ARGON2_DISABLE=1 in the environment.
Change-Id: I5e74471300df1c6ef3892dc544f13328e5898abb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168998
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
|
|
If there is a Name attribute set for a hyperlink, the text is exported
to PDF as tooltip.
note: not every PDF reader displays this text
Change-Id: Ib9f1c13403c1555bfae733d662754c0e052378f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168993
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
|
|
Previously, setting stroke width and cap was only done when running
unit tests. But the same drawing contraints are necessary when running
with a Retina display on macOS.
Change-Id: I74f7347d30a410f7d3485388ffec61b32730b948
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168973
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
|
|
The problem is that XBufferedThreadedStream does not implement
XSeekable, so the new code in ZipFile::checkValidPassword() throws an
exception, and then joining the UnzippingThread hangs.
Implementing XSeekable doesn't appear to help, as the mutex that
is used by XBufferedThreadedStream and the UnzippingThread is already
locked by checkValidPassword() [fixably] and by getDataStream().
So just disable threading for AEAD streams, these are read immediately
anyway so threading isn't much of a benefit.
(regression from commit 2f512aaa6c39390a5a0eb1d1e37f070127d068a4)
Change-Id: I16027d5b03ba6e102bc143c22383eb7f08590e5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168893
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
See tdf#94879 for motivation.
Change-Id: I9aa439b2fba8c10710ea0f491272a5f9823a27a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168979
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: Ie755b1cbc175d98756f6e6ecc173f32c65c7ff7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168955
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I061481f7218bc0365c6783662c24642da5f63370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168954
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I3859c3a491abbe74d12f08d86948196dddb462ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168822
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Id748b79e7685f5e99df142aa2aa9449a18a32d5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168821
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Ia2f20b05b043d45df090f2843a4d365c692770fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168813
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Jenkins
|
|
This removes the duplicated code.
Change-Id: I54ada6875f7897b7eb480f10b8e1c8be887ca5ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168978
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
When the annotation text changes we need to sync this with the SDR
object (if the object is showing the annotation text - like free
text annotation).
Also move annotation object searching to the annotation class, so
it can be reused in AnnotationWindow.
Also change uso of UNO XAnnotation in AnnotationWindow and use
concrete type (sdr::annotation::Anootation) instead.
Change-Id: I46db479ae8471c82ac58487a0125df15697245be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168977
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: If4b8ddcbee9468655944effb931347c8077abc3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168976
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
- We're adding a new LOK callback LOK_CALLBACK_VERTICAL_RULER_UPDATE.
- The reason is that we currently override the existing callback.
- Using the same callback for both vertical and horizontal rulers causes an issue.
- override will create problem like it will only send any one of the ruler orientation update.
- It results in online updates being limited to just one ruler orientation.
- By introducing a new callback, we ensure updates for both vertical and horizontal rulers both are captured correctly in online.
Change-Id: I02d0e3e7e4ac8a07a83644460aa0ba36e0f3c013
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167481
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 11b936629dd4ef9308d63b312900b8b7c8ff19b4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167464
Tested-by: Jenkins
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: Ifc82d3dd2624868f812533b9df9a34af51a06888
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: Iec53dad76756241b0f0ec31e76def89e336ee6ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168952
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
insert comment, click on it to expand it, click on menubutton and
use "delete all comments by..."
crash on use of invalid iterator as callback trashes the vector
being iterated over
Change-Id: Ia86de87207f706f35a023efa433c5e67b8bb436a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168970
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
so we get the same filled MenuButton in both applications
Change-Id: Iea41a17285287ec2794e4cdce6eaae0906fff291
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168969
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and ~20 of similar warning
The current size of SfxItemSet is 144 bytes, and std::function is 32
bytes of that.
If we reintroduce Changed as a virtual method we can avoid the need for
this callback. All of the calculation work that was originally
unconditionally done, and then thrown away, was moved into the specific
SwAttrSet case of this so the other normal cases don't do any wasted
work anymore.
Change-Id: Ieec90f6d28dad8a6bf1cf8f402042812bd81c331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168967
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
from 2018 commit 7dc9fb33db45c269fece6cfec993b124491c68f6
tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*
Change-Id: Ia6ada37ff06355198d00fbf0f7fdfa0e0aede71c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168896
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
|
|
Change-Id: Ief36190e10dc03246497d4fd9475d9141dd1d7b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168975
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Besides expected performance improvement, this helped to find several
elements that were duplicated in the long list. Frozen map does not
allow duplication of the keys, helping avoid these mistakes.
Change-Id: I2192d0ed50b6b8611fd08715f713742a993b28dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168961
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ia3bb4a2c100e7dccafe9710c7af3a99268e53239
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168963
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I3be6bd8effb33183f67d63d910663d2741b24de5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168965
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I3d26c49a46f7382b34bd1619cfe7ff09db5e200c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168964
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I767eb6e62285434ff70e65f631e8bc77caf02995
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168966
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I87d963e254607e7389429cba2839b6a318f44107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168962
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: If9a36dcd447eef355f137b5afe16f917e9c0cfa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168960
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Id7f4d7a27720856c5e53dab4333a8ecf370004dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168959
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ieb2c72dbdfec8431bd23da8a5e4844f3c1a5b74e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168958
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I40d3a2dba67a3e0f7d65964396c6fa5b875a287c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168957
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I627487a79f819351ec38e34b3fac432c36670d7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168915
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
probably since:
commit 35f59457ff434b7b97cad6ce1dbef6ff07f7bc96
Date: Thu Nov 16 17:03:39 2023 +0100
tdf#158135 - UI: Part 30 - Unify lockdown behavior of Options dialog
for Writer - Compatibility Page.
Change-Id: Icaf1320f4f819294d49f99b3f1728fa025c51e11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168914
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I07642b427461d76f4fb0a48158598d62f1d2d24e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168951
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|