summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-22tdf#103690: Set up notifications only after VCL has been initialisedTor Lillqvist
On some Macs, it seems that LibreOffice (or any app?) gets an NSApplicationDidChangeScreenParametersNotification as soon as it has started and asked for such a notification. Our handler for that notification assumes that VCL is initialised. Thus we should not ask for such notifications before VCL has been initialised. I could not reproduce the reported crash with an unmodified LibreOffice, only after inserting a sleep after the notifications had been set up. But I am fairly sure this change fixes the problem. Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329 Reviewed-on: https://gerrit.libreoffice.org/50164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-22Remove useless special handling of single-value rangesMike Kaganski
... as they are treated by generic code just fine. A check added to guard against overflow (0xFFFF + 1 -> 0). Change-Id: Ibef85191eab82002981e12f83f313f3d122da74c Reviewed-on: https://gerrit.libreoffice.org/50163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-22Fix clean-up of gb_UIConfig_get_a11yerrors_targetStephan Bergmann
The old code tried to remove non-exisiting *.a11yerrors files corresponding to a UIConfig's individual *.ui files, not the one single *.a11yerrors file corresponding to the UIConfig itself. Also, there's no need to have a UIA11YErrorsTarget merely for clean-up. Just do that clean-up as part of gb_UIConfig_get_clean_target. Change-Id: I6676f08496254398801bb75172c1326d1c843071 Reviewed-on: https://gerrit.libreoffice.org/50156 Reviewed-by: Samuel Thibault <sthibault@hypra.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22Updated coreOlivier Hallot
Project: help 235783d1ed47620748fe297f5ff5133121fbe75e tdf#114995 CSV Link external data help page Change-Id: I932bb17e0c599ea79dba950733e354e86f6efce4 Reviewed-on: https://gerrit.libreoffice.org/50193 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22Updated coretagezi
Project: help 75cf318614f73c93a51538a9508ccca2b47f82b1 Deletion [Runtime] from names functions [Runtime] was deleted [Runtime - VBA] was replaced to [VBA] Combination of words "runtime functions" and "runtime categiries" was replaced to "functions" and "categiries" respectively Change-Id: I1f03a5f2ef1697e216e144ecccbfb8942b315718 Reviewed-on: https://gerrit.libreoffice.org/49914 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22Updated coreOlivier Hallot
Project: help 5339d3c91fb81ea593a96c5602b767d68aba623f tdf#115831 Review of rename sheet help page Change-Id: Ibe2db947cd6a1ef52231013a6ecdb9efbf2e99a2 Reviewed-on: https://gerrit.libreoffice.org/50192 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22Remove unused forward declarations from vcl/syswin.hxxStephan Bergmann
Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b Reviewed-on: https://gerrit.libreoffice.org/50155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22gb_UIConfig_get_imagelist_target missing from clean targetStephan Bergmann
Change-Id: I541bd57815bd66978326486b29165d0480d8a7b6 Reviewed-on: https://gerrit.libreoffice.org/50157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22Updated coreLaurent BP
Project: help 90671d8531b28cebf6129402932320a437cf4544 tdf#115831 Renaming of sheet Renaming of sheets have the same constraints whatever the file format used. Max number of sheets is 10,000. See tdf#44443 File modified with HelpAuthoring Change-Id: Iff4ecdea6cdfede9844475eaac31c27c9d903a3d Reviewed-on: https://gerrit.libreoffice.org/49949 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22Process all added uifilesStephan Bergmann
Change-Id: I9efb05973e7d8468afb82bd9875d527412a4fd1c Reviewed-on: https://gerrit.libreoffice.org/50116 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Iee7034c3800b159694c3d03a8eed665d3360e6b8
2018-02-22update creditsChristian Lohmaier
Change-Id: I189e30718e5818d183dc308ecbb96f4943b4e20a
2018-02-22tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+Shubham Verma
Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f Reviewed-on: https://gerrit.libreoffice.org/49898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-22uitest - writer Watermark dialogZdeněk Crhonek
Change-Id: If701a563ce2ff0e811dfcaae6852ada05c925ce3 Reviewed-on: https://gerrit.libreoffice.org/50126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-22Updated coreChristian Lohmaier
Project: translations db79c92222d122d554eb563cb501b8eafb289b38 update translations for 6.0.2 rc1 and force-fix errors using pocheck Change-Id: I760bd52e6a79b34ebf7f59f7d7c11ce7605b4a79
2018-02-22tdf#115383: revert mixup of E_ROFS and E_SPIPE in file.hxxAron Budea
Regression from a9739f2dec197793fa9400dd95be49494dc85264 Change-Id: I1b55b0201888a63bd2439be8c0421f450d609018 Reviewed-on: https://gerrit.libreoffice.org/50103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-22update clang-format blacklistNoel Grandin
after I accidentally formatted it in commit 50d0ec571f302fe54ac7ddac827b571c94554bec rename redundantcopy loplugin to redundantfcast Change-Id: I8e006fa9a90af3d70ef7e6a9fdef2d6f294e0fba
2018-02-22solenv: Fix gb_MoTarget_get_install_target argumentRico Tzschichholz
This fixes l10n-*.files generation of packageinfo and makes "install-packages-l10n-*" targets work again. Change-Id: Ib4d726f1079360cade8d5f398b1f5144d6693152 Reviewed-on: https://gerrit.libreoffice.org/49528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rico Tzschichholz <ricotz@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22ColorData->Color in vcl quartzNoel Grandin
Change-Id: Ie0de7f989ab4aefa900da6b9b75fcfe98584c8f3 Reviewed-on: https://gerrit.libreoffice.org/50124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22The vim mode line supposedly needs to go at the end of the fileStephan Bergmann
Change-Id: I413b01e93000f9f81ba6190811cea51c04f1d58b
2018-02-22drop unused button mask enumCaolán McNamara
Change-Id: Id94c6ecdfc642888eea8c13e55d38326b2d7ad12 Reviewed-on: https://gerrit.libreoffice.org/50145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Replace "ReplacementGraphicURL" with "ReplacementGraphic" propertyTomaž Vajngerl
To transport the replacement graphic we use "ReplacementGraphicURL" property, but as it uses an GraphicObject URL it needs to be replaced. The new "ReplacementGraphic" does this with an XGraphic object as instead of the String URL. Change-Id: Iddf01c9aecb2a31a467e7b9d399495e0428d1859 Reviewed-on: https://gerrit.libreoffice.org/49993 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22gla11y: Use python interpreter decided by configureSamuel Thibault
configure uses $PYTHON to determine lxml availability, so the make rule should use the same instead of letting gla11y find a python interpreter through "env", in case e.g. $PYTHON is python3, and lxml is available in python3 but not in python (actually python2). Along the way, rather use PYTHON_FOR_BUILD for coherency. Change-Id: Ied4c05aca462cc16685c61f36b56bb9e8612d90e Reviewed-on: https://gerrit.libreoffice.org/50087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcastNoel Grandin
Change-Id: I358e9673edcba81336b3895479e787d981fad7a5
2018-02-22sw: clang-format textboxhelperMiklos Vajna
This was more or less consistent before, but the recent automatic rewrites broke consistency, just give up on manual formatting here. Change-Id: Ieb387e3d7230d227e33ba0b420cfa572309c5330 Reviewed-on: https://gerrit.libreoffice.org/50119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-22tdf#115873 sd navigator: allow selecting but not focusing on objectsMiklos Vajna
There were also two cases here: - changing the selection with the keyboard or single-click only updated the selection in the navigator - pressing enter or double-click also selected the shape in the main window and gave the focus away Introduce a 3rd case for single-click: update the shape selection but doesn't give the focus away. This way double-click is not needed to sync navigator -> main doc selection but keyboard navigation should still work. An additional trick is to make sure that the current shell is the draw shell (and not the slide sorter) after navigation, so follow-up operations work with the selected object and not with the whole slide. Finally, a third related problem was that the selection jumped back to the item of the slide after clicking on a shape in the navigator. The reason for this was the navigator list was constantly cleared and re-filled in SdNavigatorWin::InitTreeLB(), as SdPageObjsTLB::IsEqualToDoc() returned false (even if the list was up to date) in case of shapes which had children but no name. Fix this by using the same SdrIterMode::Flat iteration mode that SdPageObjsTLB::AddShapeList() does, so the fill and the equality check of the navigator iterates the same way. Change-Id: I0bfc3e8b49f7ef01d5797a68284616dcd2a81c5d Reviewed-on: https://gerrit.libreoffice.org/50118 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-22Add wrongly formatted file to blacklistStephan Bergmann
Change-Id: Ia9ec032eb40e4152e881b466311f7e34c845addc
2018-02-22rename redundantcopy loplugin to redundantfcastNoel Grandin
Change-Id: I34e28a30a4f1fd264c18c901cd94094531543271
2018-02-22Merely forward-declare NotebookBar in vcl/syswin.hxxStephan Bergmann
Change-Id: Ia29e495130f5b83f3422d68597dedcb3b0b27a07 Reviewed-on: https://gerrit.libreoffice.org/50120 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22loplugin:redundantcopy extend to ColorNoel Grandin
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4 Reviewed-on: https://gerrit.libreoffice.org/50114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22loplugin:changetoolsgen in tools..toolkitNoel Grandin
Change-Id: I3d87ee59258567b5a82cb459248539faea1b3ca9 Reviewed-on: https://gerrit.libreoffice.org/50101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22ColorData->Color in scNoel Grandin
and fix the sal_Int32() conversion operator in Color, which was always returning 0 Change-Id: I0aefaedc34ee0a8bccd43238ccfe8196d2dd5c5c Reviewed-on: https://gerrit.libreoffice.org/50051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21IPolyPolygonEditorController used in dynamic_cast should be SAL_DLLPUBLIC_RTTIStephan Bergmann
...so that the dynamic_cast also works on macOS (where RTTI equivalence is determined by address, not by strcmp). The two relevant dynamic_casts are in BezierObjectBar::GetAttrState and BezierObjectBar::Execute (both in sd/source/ui/view/drbezob.cxx). (They can be triggered from the Impress UI by adding any "Motion Paths" animation to a shape, then selecting and manipulating the path's control points.) The source of those dynamic_casts appears to always be sd::MotionPathTag, defined in sd/source/ui/animations/motionpathtag.hxx in the same library, so wouldn't technically require IPolyPolygonEditorController to be SAL_DLLPUBLIC_RTTI. However, while 367e8743adbe1319f5be29c001c93b747f7aa665 "INTEGRATION: CWS pathfinder01" introduced that sd::MotionPathTag deriving from IPolyPolygonEditorController, 346e0ffe907c85af85573dc42c19795ec1c9872c "INTEGRATION: CWS pathfinder01: #i41800# added inteface IPolyPolygonEditorControler to allow edit of non marked path objects" also added IPolyPolygonEditorController to SdrPolyEditView in include/svx/svdpoev.hxx, for unclear reasons. So better be conservative and assume SAL_DLLPUBLIC_RTTI is needed after all. Change-Id: Ieefabf7b00357876046014bbff098076108f9dea Reviewed-on: https://gerrit.libreoffice.org/50109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21Add some extra assert to this test caseTamás Zolnai
To find out why this test fails for some linux tinderbox. Change-Id: I49d1afbbac631abe49378b12b888615e3e0e1bef Reviewed-on: https://gerrit.libreoffice.org/50121 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-21Manually recognize some IIDs that don't have cleartext names in the RegistryTor Lillqvist
Change-Id: I9deadfdd324f9b9014fef8370593e107302ed843
2018-02-21report the saved mimetype when saving graphic + mime from streamTomaž Vajngerl
When saving we need to determine which mime type to use for the graphic. Return this information back to the caller so the metadata can be written into the file if necessary. Also add function to determine the mime type from the XGraphic by converting it to a stream first (only then we can determine the format that will actually be used and written to the storage file. Change-Id: I796da715e47f29d77dea605a2769a2217ecd6ba5 Reviewed-on: https://gerrit.libreoffice.org/49992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-21Limit ScColumnsRange::Iterator to available columns within boundsEike Rathke
Change-Id: Id5481a975dce99a51cc5619e200e5ea46ad3ad1b Reviewed-on: https://gerrit.libreoffice.org/50106 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-21Use printf instead of echo, just in caseStephan Bergmann
...$PRODUCTNAME happens to be -n (which is notoriously problematic with various versions of echo). Change-Id: I09dfb562689138aa0135982725bf2c254ce06e59 Reviewed-on: https://gerrit.libreoffice.org/50104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21Revert "simplify ImpXPolygon"Stephan Bergmann
This reverts commit f9c2bcc8b761f5e21354c0fb7bca6aa432d11ec2. Drawing all sorts of curves and polygons in Draw causes various crashes in svx/source/svdraw/svdopath.cxx, apparently because in the past ImpXPolygon's pPointAry had a "buffer" of more elements (nSize) than it had nPoints, and the code heavily relied on that, assigning to such excess elements of pPointAry past nPoints (and presumably calling XPolygon::SetPointCount later?). Conflicts: svx/source/xoutdev/_xpoly.cxx (Reverted the mostly, if not completely, automatic changes there done by 924c0e34fdc36cd44100dafc2c68656ce32374e6 "loplugin:changetoolsgen in svx"; they will need to be re-done.) Change-Id: I6cb41fd218c3bdd0b3bbeb45f5b3d68649901a48 Reviewed-on: https://gerrit.libreoffice.org/50057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21forcepoint #3Caolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I5681f9123a21fee100a2eda1e8284e559ede51b4 Reviewed-on: https://gerrit.libreoffice.org/50064 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-21Bin useless codePranav Kant
Change-Id: Id3ffa2333946a9551da9d0f9ecbd2885716b9376 Reviewed-on: https://gerrit.libreoffice.org/50102 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-21Use iterator pre-increment/decrementEike Rathke
Change-Id: I079850116648dc69b8c92fa23b30233f63d9b6e7
2018-02-21Pass ScColumnsRange::Iterator as const&Eike Rathke
Specifically for each operator==() call two temporaries were copied, for operator!=() even twice as much.. in for(...:GetColumnsRange()) Change-Id: I4b426ae855454544e50efca35aa73303138f7ba7
2018-02-21Revert "uitest: add timeout for blocking actions"Stephan Bergmann
This reverts commit fb4d5885f3c8d00ae528ddf57b2abaa4aabfbcf3: "For one, as Michael already responded, many builds (local, Gerrit/Jenkins, other tinderboxes) now fail UITest_writerperfect_epubexport with what looks like random 'raise DialogNotClosedException()'. Gut feeling is that it's way more than used to fail UITest_writerperfect_epubexport with a deadlock." (<https://lists.freedesktop.org/archives/libreoffice/2018-February/079494.html> "Re: UITest_writerperfect_epubexport hang (only sometimes)") For example, <https://gerrit.libreoffice.org/#/c/50070/> "tdf#115853: save current custom property when adding line" Jenkins linux_clang_dbgutil_64 now failed twice in a row with what looks like random "raise DialogNotClosedException()" failures in UITest_writerperfect_epubexport. And for another: "As long as its unclear what the underlying problem is, what benefit does it have to add a timeout failure path in the test? Without the added timeout, a local failed test will be ready to be inspected (and moggi now gave suggestions what exactly to inspect in another mail in this thread). And failed tests on the tinderboxes will eventually time out either way." (<https://lists.freedesktop.org/archives/libreoffice/2018-February/079491.html> "Re: UITest_writerperfect_epubexport hang (only sometimes)") Change-Id: I36db7526b68a1cf6be596aa82c57095e4067c150 Reviewed-on: https://gerrit.libreoffice.org/50080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21Pass missing (hopefully optional) parameters as Any()Tor Lillqvist
Change-Id: I93e69e589cd81fbc9606b1b08233da7fb8f5d043 Reviewed-on: https://gerrit.libreoffice.org/50089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-21tdf#115015: make crypto settings better fit allocated spaceKatarina Behrens
Oh dear how much do I dislike fixed size dialogs. Everytime they are enlarged to fit new content (esp. gtk3 is rather space-greedy there) someone starts to whine the dialog is now too large Doing what e6d7d7375221 does is not really an option, since there are some 30+ tabpages to try and test for optimal size here. Change-Id: I3ffb2d794f76781eb62186093b928289593585cf Reviewed-on: https://gerrit.libreoffice.org/50032 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-21loplugin:changetoolsgen in swNoel Grandin
Change-Id: If07efe4c15cfc28df38a9327856d39313ca78d50 Reviewed-on: https://gerrit.libreoffice.org/50078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21Updated coreOlivier Hallot
Project: help e256ca7d98c9e4da4e14bd405e648edf394a56c4 tdf#115905 Impress custom animation fix Custom animations are now in menu Format Change-Id: Iade534e2278de56ff3b7b5647d18196ead6973b8 Reviewed-on: https://gerrit.libreoffice.org/50098 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-21forcepoint #4Caolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I569ca80267ad9b5a21da0029ba903d2a4c45a035 Reviewed-on: https://gerrit.libreoffice.org/50065 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-24 06:17:44 +0000