summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-15Missing test dependencyStephan Bergmann
Change-Id: I3df5512984efa280a0abf05e55ad8d2babc2dc55 Reviewed-on: https://gerrit.libreoffice.org/63403 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-15Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - tdf#119415 Revert string change In some languages the string gets too long. Change-Id: I1301920df06b264ccdbd806af476b22601a38405 Reviewed-on: https://gerrit.libreoffice.org/63415 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-15Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: I5b972286d3b44f0ce99dd65b00e7f8d8c44325be
2018-11-15loplugin:staticmethods in editengNoel Grandin
Change-Id: Ib1a45e69736beb034c1e99e8e0fcb10aef9ffb70 Reviewed-on: https://gerrit.libreoffice.org/63405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15declare/init nContextIdx only when NDEBUG is undefinedDennis Francis
This is necessary to fix a non-debug build failure : https://ci.libreoffice.org//job/lo_tb_master_mac/27264/consoleFull#283816981d107d11c-eea5-4209-baa1-fcfb59f7f8a6 Change-Id: Ic4882a155dc3a8ea84129ddefe8076693787271c Reviewed-on: https://gerrit.libreoffice.org/63402 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-11-15Fix typosAndrea Gelmini
Change-Id: I5437180fd019ec3b9e2ccaa245b852f37cc091cd Reviewed-on: https://gerrit.libreoffice.org/63400 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-15Make parameter parsing linear, not loopMike Kaganski
Just cleaner IMO. Change-Id: I89c0c13b8b0be55dcbc2e5536abf982d75e4034d Reviewed-on: https://gerrit.libreoffice.org/63401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-15loplugin:staticmethods in vclNoel Grandin
Change-Id: I00333677db711761510a35dfae5ce70d61fb9491 Reviewed-on: https://gerrit.libreoffice.org/63397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15tdf#42949 Fix IWYU warnings in sc/source/filter/{excel,lotus,xml}/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I087492531b4fc17a3196ea820dbaa0f742aea16d Reviewed-on: https://gerrit.libreoffice.org/63148 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-15SmartArt Pyramid: Now lays out shapesekuiitr
This algorithm was initially not implemented, because of that it was not able to show shapes which relates to pyramid, but with this patch, It rendered correctly except some minor adjustement values issues which can be fixed in upcoming patches. Change-Id: I298c812615956d67eb00e1b7544d7b171a4ac14a Reviewed-on: https://gerrit.libreoffice.org/57241 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-15gtktiledviewer: Handle LOK_CALLBACK_SIGNATURE_STATUS to avoid an assert.Jan Holesovsky
Change-Id: Iae56708d94a229911a5d008d519120ac59069cf3 Reviewed-on: https://gerrit.libreoffice.org/63391 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-15gtktiledviewer: Compile-time check instead of an annoying assert.Jan Holesovsky
Change-Id: Iece75f6f40bf7d7dfcde372cf9b4606adb9e34b2 Reviewed-on: https://gerrit.libreoffice.org/63390 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-15loplugin:staticmethods in svxNoel Grandin
Change-Id: I94df3aa40fa79877ccebf1ed8709bd7cc47748d9 Reviewed-on: https://gerrit.libreoffice.org/63398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15Cache the vConditions array...Dennis Francis
used in ScInterpreter::IterateParameterIfs(). Store this cache as a member of ScInterpreterContext (maConditions). Create a static pool of ScInterpreterContext's so that the embedded maConditions is reused everytime a formula-group/ formula-cell is calculated. There needs to be two separate static pools - one for threading, one for non-threaded computation of formula-cells. With this, we can have better performance of the cached maConditions as well as mScLookupCache. In threaded case there is no recursive computation of cells as dependencies are all pre-computed. The thread-indexed lookup cache array in ScDocument is removed as now the lookup caches on context lives as long in the static context pools. This cached vConditions array can take advantage when there are lots of SUMIFS/COUNTIFS with arguments of similar dimensions in the document. Otherwise it will be allocated from scratch for every COUNTIFS/SUMIFS formula-cell. Change-Id: I654b05e55035ce6efcf07d32d36623c9d76b0ff6 Reviewed-on: https://gerrit.libreoffice.org/63066 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2018-11-15libxmlsec: drop last not needed patchMiklos Vajna
This was patching the nmake build system for nss purposes, but we use nss on Linux/macOS only, and there we use the autotools build system, so this patch had no effect at the end. Change-Id: I0f0c3e0d045818ad3e456dd49017ae328ef6e053 Reviewed-on: https://gerrit.libreoffice.org/63385 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-15no more SwClient/SwModify for SwXTableColumnsBjoern Michaelsen
Change-Id: I1522cec0e01b4c9ccb4b252b8dc0a480edb22102 Reviewed-on: https://gerrit.libreoffice.org/63350 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-11-15Bin unused headerJens Carl
Change-Id: I711c9e8c8be50ea5e7ff363b2889f82788497129 Reviewed-on: https://gerrit.libreoffice.org/63396 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15tdf#45904 Move XEnumeration tests for ScUniqueCellFormatsEnumeration to C++Jens Carl
Change-Id: Ifd90f34abfbe7a832e11d8e0e57eb97ccd81d310 Reviewed-on: https://gerrit.libreoffice.org/63386 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15Help files: http -> httpsSophia Schröder
+ some more conservative changes Change-Id: I28ca18b962ffe42ca8b2938de606b30d2692855c Reviewed-on: https://gerrit.libreoffice.org/63194 Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-15Fix copy-paste blooperZdibák Zoltán
Change-Id: I6b52117fdf51da9f402b8904f472e443320d4841 Reviewed-on: https://gerrit.libreoffice.org/63393 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-15tdf#45904 Move XEnumeration tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_DDELinksEnumeration. Change-Id: I586fbd67f6c862f529461265536e68fea84b8c17 Reviewed-on: https://gerrit.libreoffice.org/63394 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15Fix typoAndrea Gelmini
Change-Id: I9ccd24ad6baf3e3ebe6c988ad14df0f5f7c96ca0 Reviewed-on: https://gerrit.libreoffice.org/63392 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-14Resolves: tdf#121229 ignore internal children of VclScrolledWindowCaolán McNamara
Change-Id: Iecc474db8093520ba2d90aedfc5da66507f3033b Reviewed-on: https://gerrit.libreoffice.org/63357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14Removed duplicated includeAndrea Gelmini
Change-Id: If60f7469fbb55debac4194174745514451c8cb16 Reviewed-on: https://gerrit.libreoffice.org/63368 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-14Fix typoAndrea Gelmini
Change-Id: I12bfb9940c5eeebbf8499fe745331dae8e745bf6 Reviewed-on: https://gerrit.libreoffice.org/63369 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-14Fix typoAndrea Gelmini
Change-Id: Id6accd441c11c521dc1a9dee4e3e5b5f8bb99929 Reviewed-on: https://gerrit.libreoffice.org/63383 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-14sw: fix modification of ole obj native data during HTML importMiklos Vajna
It is expected that if you load an OLE2 storage (from reqif-xhtml) and you save it as ODT, the OLE2 data is not modified. This was almost the case, but we insisted on removing the OLE2 preview from the storage. Add a new flag to OleEmbeddedObject, so import filters can opt in for not modifying the OLE2 data. [ The nice situation is that we already had a test file which had a preview stream in the OLE2 storage, so we can easily assert there that the size doesn't change. ] Change-Id: I9b8b29f015dd4f2513e51a1066767218580cb5d8 Reviewed-on: https://gerrit.libreoffice.org/63381 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-14Resolves: tdf#119700 save correct table:last-row-spannedEike Rathke
Regression from commit f6e6a6139e90d6e88fb65308e8592193ac602a8a CommitDate: Mon Nov 21 07:49:06 2016 +0000 tdf#48140 Replace uno CellRangeAddress and CellAddress with direct calls that calculated endrow-startcol instead of endrow-startrow. Change-Id: Ie576f9abdcdc23fc5f0a06735caadc24e975360f Reviewed-on: https://gerrit.libreoffice.org/63374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-14don't select all new text if there was no old textCaolán McNamara
Change-Id: I087f396e4de196af57974e4462f2a4e7553a6293 Reviewed-on: https://gerrit.libreoffice.org/63370 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14tdf#45904 Move _XEnumeration tests for ScCellFormatsEnumeration to C++Jens Carl
Change-Id: Icf133ae51a564d889997d3920de2816aadd105e1 Reviewed-on: https://gerrit.libreoffice.org/63353 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-14Add EMF and WMF mime types to Draw .desktop fileSamuel Mehrbrodt
It's hard to find an application that can display these file types on Linux, so suggest LO for those. Change-Id: I9b32b4ee2057e82a13b8fc95478f2bc2cf7ffca5 Reviewed-on: https://gerrit.libreoffice.org/63372 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-14Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' - Database files should appear with app:"BASE" in instdir/help/*/bookmarks.js ...instead of with app:"SHARED", according to a request by buovjaga. That means that helpcontent2/source/text/shared/explorer/database/*.xhp files (and their per-locale counterparts) should be processed into workdir/ CustomTarget/helpcontent2/help3xsl/shared/explorer/database/*/bookmarks.part (which were empty until now) instead of workdir/CustomTarget/helpcontent2/help3xsl/shared/*/bookmarks.part. This change requres gb_AllLangHelp_*_BOOKMARK_HELPFILES introduced into the core repo with <https://gerrit.libreoffice.org/#/c/63364/> "Prepare gb_AllLangHelp_add_helpfiles for special bookmark needs". Change-Id: I8f37fcec67a37aee4260042e550214a34495254a Reviewed-on: https://gerrit.libreoffice.org/63365 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-14Prepare gb_AllLangHelp_add_helpfiles for special bookmark needsStephan Bergmann
...where (according to a request by buovjaga) in instdir/help/*/bookmarks.js, lines mentioning "/shared/explorer/database/" should appear with app:"BASE" instead of app:"SHARED". That change will come in a follow-up commit to the helpcontent2 repo. Change-Id: I7c99e5f89e001d1e507f283d16e2ee264f3ab33a Reviewed-on: https://gerrit.libreoffice.org/63364 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-14make sure ScConditionEntry::Interpret() doesn't confuse calc threadingLuboš Luňák
ScConditionEntry::Interpret() creates a temporary cell and interprets it without it actually being in the document at the specified position, which threading relies upon. Change-Id: I06fcc11dfbe14e715de4c173e061064ac90da990 Reviewed-on: https://gerrit.libreoffice.org/63182 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14abort if opencl fails with SC_FORCE_CALCULATION=openclLuboš Luňák
Otherwise calculation would silently fall back to other methods. Change-Id: I3cf624b709e7007ae16736a1ecb91b7d3c18df8e Reviewed-on: https://gerrit.libreoffice.org/63189 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14$SC_FORCE_CALCULATION to force Calc use opencl/threads for everythingLuboš Luňák
So that e.g. unit tests can be easily run with OpenCL forced. This forces even single cells to be evaluated using the forced method (many correctness tests are just a single cell which normally would not be used for grouped calculation). Change-Id: If5c6e77a6e0d8696d5416d760cf5e47b8acf3d27 Reviewed-on: https://gerrit.libreoffice.org/63188 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14blacklist ocMatch for calc threadingLuboš Luňák
It calls ScDocument::IsInVBAMode(), which eventually leads to trying to acquire the SolarMutex, which deadlocks (since the main thread keeps it the whole time). Change-Id: I7f05597ca3c1f5667c9a6527dc7421da3c3e075e Reviewed-on: https://gerrit.libreoffice.org/63185 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14make ScInterpreterContext also accessible without passing it aroundLuboš Luňák
E.g. ScModelObj::GetFormatter() can be rather deep in the call chain and it just doesn't make sense to pass ScInterpreterContext* to all the relevant places (and it's a question if it makes sense to pass it around at all, googling shows that thread_local is not really _that_ slow). Change-Id: I9114ef8a10d82a10968391718099edccde7a2663 Reviewed-on: https://gerrit.libreoffice.org/63184 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14avoid valgrind uninitialized jump warning with clangLuboš Luňák
I'm not sure what exactly the actual problem is, but valgrind reports unitialized reads of mbMulti, although that one is fine and the culprint is in fact mbCenter. Which happens to be bit 16 of the bitfield, and the generated assembly looks fishy, just for that one specific bit. Adding extra padding, extra statements or even just reordering avoids it. So this is lame, but just reorder it and be done with it, this should be otherwise harmless and I've spent enough time on this. Change-Id: I25be55ebe0e9b6dc981793aa7caeae2a40bb27a5 Reviewed-on: https://gerrit.libreoffice.org/63186 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-11-14Reorder ScFormulaCell membersDennis Francis
When evaluating/getting result from a formulacell(which has been evaluated before), first bDirty/bTableOpDirty are accessed from MaybeInterpret()/NeedsInterpret(), then aResult is accessed, so it makes sense to put the first 7 bools(with bDirty/bTableOpDirty) in the beginning, then aResult, then rest of bools and other remaining members. The expectation is that when bDirty is accessed in NeedsInterpret(), the relevant contents of aResult is also fetched to cache and remains there till aResult is needed. Change-Id: Ide0d1e809ca045ef347520f26c4d3ab9faa994bb Reviewed-on: https://gerrit.libreoffice.org/63065 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2018-11-14Resolves: tdf#121394 listen to key strokes only if GDK_BUTTON_PRESS_MASK setCaolán McNamara
Change-Id: I5471ed2f4243f79fd0bcb4f65079318c4dd65e26 Reviewed-on: https://gerrit.libreoffice.org/63345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I6a8f97f088cef39345372ce2d726ad8fb7c051ee Reviewed-on: https://gerrit.libreoffice.org/63356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-14move fmtfieldCaolán McNamara
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5 Reviewed-on: https://gerrit.libreoffice.org/63363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14tdf#119178: use current range as a range for conditional formatVasily Melenchuk
During addition of new conditional format it is possible to select different range, not one used initially. And new range should be used for correct relative reference in formula evaluation.` Change-Id: If73a0ddbb268c86e8c99f0703db1a5a97fb6ca66 Reviewed-on: https://gerrit.libreoffice.org/58800 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-14Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: If3779c613d8d2b8157cc37cfff0ef332909b07ae
2018-11-14Fix typoAndrea Gelmini
Change-Id: I6761bc281a1db0aef044eb2887083920b23470c9 Reviewed-on: https://gerrit.libreoffice.org/63349 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-14Map VML shadow more properly to css::table::ShadowFormatStephan Bergmann
For one, CppunitTest_sw_ooxmlexport6 failed under -fsanitize=implicit-signed-integer-truncation when passing a negative ShadowFormat.ShadowWidth into a sal_uInt16 SvxShadowItem (see below). Fixing the mapping from VML shadow to ShadowFormat in ShadowModel::pushToPropMap caused ShadowModel::pushToPropMap to fail again, however, testing against 57811035 in testOuterShdw (sw/qa/extras/ooxmlexport/ooxmlexport6.cxx). fa9d574ae1656b64670fbbac64ddd85461698149 "Code changes for fdo#74107:File Corruption - Issue with outerShdw" doesn't explain how that value came about, so assume that it was just whatever value happened to be observed in LO at that time, and now adjust it accordingly. And, for another, opening sw/qa/extras/ooxmlexport/data/testOuterShdw.docx in LO now produces a green bar with red shadow at the top of the first page that better resembles the original. > editeng/source/items/frmitems.cxx:1154:18: runtime error: implicit conversion from type 'long' of value -1160 (64-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 64376 (16-bit, unsigned) > #0 in SvxShadowItem::PutValue(com::sun::star::uno::Any const&, unsigned char) at editeng/source/items/frmitems.cxx:1154:18 (instdir/program/libeditenglo.so +0x16716ea) > #1 in BaseFrameProperties_Impl::FillBaseProperties(SfxItemSet&, SfxItemSet const&, bool&) at sw/source/core/unocore/unoframe.cxx:759:48 (instdir/program/libswlo.so +0xba32230) > #2 in SwFrameProperties_Impl::AnyToItemSet(SwDoc*, SfxItemSet&, SfxItemSet&, bool&) at sw/source/core/unocore/unoframe.cxx:1004:19 (instdir/program/libswlo.so +0xba3cbb9) > #3 in SwXFrame::attachToRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:2665:20 (instdir/program/libswlo.so +0xba78d71) > #4 in SwXFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3003:9 (instdir/program/libswlo.so +0xba877fa) > #5 in SwXTextFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3242:15 (instdir/program/libswlo.so +0xba926a2) > #6 in SwXText::insertTextContent(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, unsigned char) at sw/source/core/unocore/unotext.cxx:619:15 (instdir/program/libswlo.so +0xc2dc17f) > #7 in writerfilter::dmapper::DomainMapper_Impl::PushShapeContext(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/DomainMapper_Impl.cxx:2330:30 (instdir/program/libwriterfilterlo.so +0x14d2953) > #8 in writerfilter::dmapper::DomainMapper::lcl_startShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/DomainMapper.cxx:2964:18 (instdir/program/libwriterfilterlo.so +0x132c46f) > #9 in writerfilter::LoggedStream::startShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/LoggedResources.cxx:151:5 (instdir/program/libwriterfilterlo.so +0x1763e70) > #10 in writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1678:27 (instdir/program/libwriterfilterlo.so +0x1ad7fba) > #11 in writerfilter::ooxml::OOXMLFastContextHandlerWrapper::lcl_createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1917:63 (instdir/program/libwriterfilterlo.so +0x1ae026e) > #12 in writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:208:21 (instdir/program/libwriterfilterlo.so +0x1aa90d7) > #13 in non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx (instdir/program/libwriterfilterlo.so +0x1aa9378) > #14 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) at sax/source/fastparser/fastparser.cxx:439:44 (instdir/program/libexpwraplo.so +0x24df4c) > #15 in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:1254:21 (instdir/program/libexpwraplo.so +0x249499) > #16 in (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:310:18 (instdir/program/libexpwraplo.so +0x240fee) > #17 in xmlParseStartTag2 at workdir/UnpackedTarball/libxml2/parser.c:9583:6 (instdir/program/libxml2.so.2 +0x6f9027) > #18 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11342:14 (instdir/program/libxml2.so.2 +0x7300dc) > #19 in xmlParseChunk__internal_alias at workdir/UnpackedTarball/libxml2/parser.c:12244:13 (instdir/program/libxml2.so.2 +0x72426a) > #20 in sax_fastparser::FastSaxParserImpl::parse() at sax/source/fastparser/fastparser.cxx:1081:25 (instdir/program/libexpwraplo.so +0x23e8e7) > #21 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:870:9 (instdir/program/libexpwraplo.so +0x237c3b) > #22 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1377:13 (instdir/program/libexpwraplo.so +0x2528eb) > #23 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:503:22 (instdir/program/libwriterfilterlo.so +0x1a6a8d7) > #24 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:186:24 (instdir/program/libwriterfilterlo.so +0x1a272bb) > #25 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2251:34 (instdir/program/libsfxlo.so +0x38d811f) > #26 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:772:23 (instdir/program/libsfxlo.so +0x38a1299) > #27 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1795:36 (instdir/program/libsfxlo.so +0x3a4372e) > #28 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:688:28 (instdir/program/libsfxlo.so +0x40c49f0) > #29 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1149:37 (instdir/program/libfwklo.so +0x15212f1) > #30 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:383:20 (instdir/program/libfwklo.so +0x1511cd6) > #31 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:169:14 (instdir/program/libfwklo.so +0x150d988) > #32 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:619:12 (instdir/program/libfwklo.so +0x16705ce) > #33 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx (instdir/program/libfwklo.so +0x16707da) > #34 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:50:60 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x8f1f6) > #35 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:762:23 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport6.so +0x2460b1) > #36 in SwModelTestBase::load(rtl::OUString const&, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:717:16 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport6.so +0x2449d6) > #37 in SwModelTestBase::executeImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:264:13 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport6.so +0x2440bf) > #38 in testOuterShdw::Import() at sw/qa/extras/ooxmlexport/ooxmlexport6.cxx:924:1 (workdir/LinkTarget/CppunitTest/libtest_sw_ooxmlexport6.so +0x33cf2d) [...] Change-Id: Ib26db2f175192c8756f825128fc5b852fcc24abf Reviewed-on: https://gerrit.libreoffice.org/63355 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-14Simplify containers iterations in sw/source/core/[d-l]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I143e9a769e1c1bb0228933a0a92150f00e3e1f20 Reviewed-on: https://gerrit.libreoffice.org/63347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-14"oh dear, what can the matter be?"Stephan Bergmann
Lets assume that e3290499009492e39e5ddd870d314bb5df494199 "loplugin singlevalfields improvement" enabled loplugin:singlevalfields by accident. (It fails miserably for me.) Change-Id: Id308a17469babae195fa8261d937036b0cc39ff0
2018-11-14tdf#42949 Fix IWYU warnings in include/svl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ide75232858599c275e023c2300201090acd22307 Reviewed-on: https://gerrit.libreoffice.org/63237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>