summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14Revert "loplugin:constfields in stoc..svgio"Noel Grandin
This reverts commit 0ddf3e0a628599d01356cb5262b93faca073ee9f. Change-Id: I3e476399a465950defc15ac4d6199a638c4a4baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Sukapura: Add tiny blurred shadow to more iconsrizmut
- Update User Interface, (Calc) Group & Ungroup, Footnote & End Note icons - Add Status Bar icons Change-Id: I40b0700d024af216b62028524cb73b45b8901492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90477 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-13tdf#129471 alphabetize Navigate By option in writerShivam Kumar Singh
The "Navigate By" option in find does not have a particular order. In this patch all the options are sorted alphabetically . Change-Id: I52fdce37ac86ed12b7ea123f7238bf2b788f8a2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87670 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-13android: Pass Intent's action in ctor alreadyMichael Weghorn
This also prevents some static analysis tool from issuing a false positive that "The application uses implicit intent that may be insecure under certain conditions". Change-Id: I1d4198b1c26c764c927d99c9a9e144da96ebc109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90457 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-13compare using GtkTreePath instead of GtkTreeIterCaolán McNamara
Change-Id: I53d8f686fd924c82fc00285f28dbdc7c73577f7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-13uitest: select child instead of moving downXisco Fauli
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13Revert "loplugin:constfields in svx"Noel Grandin
This reverts commit 1a6397030381a45f27ab7a2a02e6e6d0f9987c84. Change-Id: Iaa706bb4ea3144ef57ab359b982400abc589b97e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90454 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svl"Noel Grandin
This reverts commit 5181253946ca1877cc42050452aa6d733d6da3f1. Change-Id: I30e30aae45c33824c0df823a9fad710faa81ea3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90453 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in sw"Noel Grandin
This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea. Change-Id: I527e9366b05e8a20633720e334395b285991c524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13uitest: import missing LocaleXisco Fauli
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13vcl: warn about unused GraphicConversionParameters instancesMiklos Vajna
I just made the mistake of creating one but then forgetting to use it, warn about that. Change-Id: Ie7e6e34eb234468d4a255e438b9551c81a9d2fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90459 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-13replace tabs with spaces, and unclog clang buildbotNoel Grandin
since commit 02c9e05551d69980e0757b1b0a624692ea21a96b Date: Thu Mar 12 17:34:12 2020 +0100 tdf#131291: Add UItest Seems that only some buildbots are being strict about this and generating an error like: IndentationError: unindent does not match any outer indentation level Change-Id: Ifc8d01eefca0028cf134c8e71237fc0b59bc27d5
2020-03-13tdf#131304 writerfilter: cache Word compatibilityModeJustin Luth
GetWordCompatibilityMode() is an expensive call that is called at least for every table row. Caching will soon be even more beneficial when LO also starts writing out this value and thus quickly caches a non-negative result. Anything created by MS Word since at least 2010 specifies this optional setting, so most .docx files specify this value - and thus will benefit from the cache. One difference that I ignored is that Word replaces a "number greater than what I know" with its own compatibilityMode value. (tested in Word 2010 and 2016.) That is probably only a concern at export time anyway... Change-Id: I0ee71d34150c5f3d9858adb678814a10c7fe8959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90434 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-13skip on-demand entries on iter_next/iter_previousCaolán McNamara
Change-Id: I5a12cae948893ea4e221f335cc29acc663e1ce29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-13xmloff: create SchXMLExport_Oasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ia4fed34fe8b5e89d2e70950f2939941c96bb5f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90445 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-13Revert "loplugin:constfields in starmath"Noel Grandin
This reverts commit e494cc2942899fd92a2273eaed2bf41eb74ea8a9. Change-Id: Ie73ecb4b7299e70dea729c374763f9e2df2aa6f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13tdf#80194 proof search: assert to find proof of code correctness.Justin Luth
I'm sure that these functions need to change because they just seem very wrong. I think these are fall-back, safety sections because usually the nEsc is already converted away from _AUTO_ prior to reaching this point. But this is all just based on code-reading. It would be nice to have proof of this - especially since the values for subscript are unexpected. I would have expected it to use a value comparable to DFLT_ESC_SUB, and not some random/magical -20. (Note: the _AUTO_SUPER historically refered to an absolute 33 and not DFLT_ESC_SUPER until I recently changed that...) Change-Id: I3bef0841f9a20f09994b2372e9a7db5941b29c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88997 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-13Fix for tdf#131297 Add Sundanese [sun-ID] locale data.rizmut
Change-Id: I2a7de5723f8ce82cf10b59ed5f77d2a7dfbb10e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90353 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-13tdf#42316 always evaluate macro signatures on loadJan-Marek Glogowski
As already stated in the comments of the signing unit tests, disabling macro security will not only ignore the signatures, but actually drop the macro signature, as these are never evaluated and as a result can't be restored for the new document. Change-Id: Ie41a9e72d3367c2eed58a52387bb67d8c41abff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90435 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-12tdf#130094 Work around content pastes twice after undoJim Raykowski
commit 24019d56fbc4ac94bd1b72b37a9bcabc7ef8164b seems to have introduced this behavior. This patch is a work around that skips code introduced by the above commit when selection type includes number list type. Change-Id: I7a74ad7262e3e008f6aa11fe04fb81b9604ef3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87795 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 996909e80712157f57b650fec7b529320398dd4f - Helponline: Make that image shadow look not tacky Change-Id: I7e0b370ad883e787a8c7b7970d8d96653e577f8e
2020-03-12tdf#130976 replace `rtl::math::isInf` with `std::inf`.Yukio Siraichi
Change-Id: Id0f0e07b324230d2d69cbf4ab07b0fff5b24474d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90377 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12Revert "loplugin:constfields in slideshow"Noel Grandin
This reverts commit 56940b766e5d52cb1c17b4250e4c7e2c375b7b65. Change-Id: I5b585ff44870193becc0770e6504ac645b254ef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in smoketest..sot"Noel Grandin
This reverts commit 1de7e818a417a412678013c100b4bf73fd8858ac. Change-Id: Ie1100fd1af636a0538f589845b9391ba40dbf12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in sfx2"Noel Grandin
This reverts commit 8411b80d46765f1ddd4e37aa634ec963dcf4b04f. Change-Id: Ibf3aa3ce4bfedf9d47001ad824db7c48ff093a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#131291: Add UItestXisco Fauli
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-12Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to cd70c38c6fae4d4ccdf861a923ac2be944944808 - Remove line breaks from translatable string 🤦‍♂️ Problem reported by Steen Rønnow at Weblate. Change-Id: I7f0dd381e36d0349d83d2db3f774a8cc86487a2d
2020-03-12Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 42797a6bc9f90ab9bfa4818bc1344f52125d2afa - tdf#128494 Change Spellcheck to Spelling 1098fba99acb8c8cc7e87c55ece12ef175593147 left Help in a broken state. Change-Id: Ie8d8f6506a6634fefce875590fe54fa2e477c82a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90060 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-12Revert "loplugin:constfields in sd"Noel Grandin
This reverts commit 453879cfd8f4a8e22847043231a0929e4d50f238. Change-Id: Ic542fd6b1f09d71d8e6c9530198fe45151d75e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in shell"Noel Grandin
This reverts commit ec7e3609917092ee00667c78ff40cd4c2f0adec1. Change-Id: I11aa028f6562f97b0d251d6b326e9aecb45d03de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Revert "loplugin:constfields in scaddins,sccomp"Noel Grandin
This reverts commit 1ab27f9ae6f32c7502884c02c2217bbdcf035c48. Change-Id: Iaf9b011201ee763aaf4d08ceedd6074bafad1c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90409 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 6009017afc932c6949b477d809c5537457b686d6 - corrections and clarifications on help page for field Variables - correction of "Chapter by Numbering" name - add indications of when certain options appear for different options. - add "DDE Statement" (and embed explanation from "Section") - move warning to more appropriate place - <h1>, <h2>, <h3>, <warning> - add <section> and <variable> in Cross-references help page so they can be embedded for Name"into Variables page. - add <section> in Section help page about DDE to embed in Variables. - remove unnecessary spaces Change-Id: Ibbaa2d2beb482ee95d10d5e632d41603a7e152ae Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90041 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-03-12Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 4801c038bbd392c61f44d47f34c9302bc20d5931 - tdf#106668 clarify how to apply styles - reorganize page to separate information about applying styles from information about the Styles deck - clarify how to apply Character and Paragraph Styles - move links about the updating, loading, new style commands from under the descriptions to the titles of the commands - remove heading and description "Applied Styles" (because not relevant to this page) - add information about predefined shortcuts for applying styles. - change information about Styles toolbar into a <tip> and update the toolbar name. - add link about docking/hiding windows to related topics Change-Id: I24aef3b7f632097f201545c54f7080645f767317 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90285 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 695f6b4be016b252315f213421331680cbaaaa8c - Fixing an uppercase typo + superfluous whitespace + small reformatting of the source file Change-Id: I1ceca55968f7e4918804c86c4c35a4407828331c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88021 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 0c44674c45452bafc67388bf333d01a632988ca3 - Small whitespace issue Change-Id: Ifc63c363932cb3749d7f99754f94b252a495de62 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88038 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to a8013ec6c4bc8f02286987dfdb4372ea33a430a4 - Mainly whitespace fixes + visibility improvements Change-Id: I82f31ebdbae945ab823154242480930958707fb9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88095 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-12android: Fix 32bit build.Jan Holesovsky
Change-Id: Ife6740860cd7e1844b1ff0166694652538048a44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90411 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-12tdf#130208 use TableCellBackgroundColor instead of BackgroundColorandreas kainz
Change-Id: I2f1d5fdf976f9e787d64098a091022182156e401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90408 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-12Survive missing <Eras> elementEike Rathke
Change-Id: Ic7e609ebac10921b4891877802892fe2cde9ecbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90406 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-12tdf#131297 Add Sundanese [sun-ID] to language listEike Rathke
Change-Id: I2935811e1fb3bc13cb61a849aeaf9e628a55cdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90383 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-12tdf#124424 Corrections at SvgGradientHelper for EMF+Armin Le Grand
Change-Id: Ibda3568887de5df2bc45a9bc8cb424ba7658a768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90382 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-12rework Skia setupLuboš Luňák
Calls to SkiaHelper::isVCLSkiaEnabled() may be done from many places, even if LO uses a VCL plugin that doesn't use Skia, which leads to the Skia code not being prepared properly (and crashing/asserting). So make the SalInstance of those relevant VCL plugins call a setup function that is required for Skia actually getting enabled. Avoids crashes/asserts in the About dialog if the Skia UI checkbox is enabled but e.g. the KF5 VCL plugin is actually used. Change-Id: Ib56a5f32e88bd130a4c564031313f85e99898ba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90376 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-12Resolves: tdf#126366 revert use of SfxDispatcher::LockCaolán McNamara
Revert "tdf#121607 defer other requests until password dialog is dismissed" This reverts commit 205aeffda1a29865576fb865f23dfb6761ebfab1 as far as I can see the original problem doesn't reappear anyway Change-Id: If5fd3383f3473662bc87a367fad2c1febe1c6a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-12typo: SIP_SA_GRAD -> SIP_SA_GLOWAndras Timar
Change-Id: I4d94824108e4e5b3432f7d152c36f2f0933f9205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89972 Tested-by: Jenkins Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-12comparison operators should be constNoel Grandin
Change-Id: Ifa76e004128223460945d58d1c59c4e23db0f108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#130977 replace `rtl::math::isFinite` with `std::isfinite`.Yukio Siraichi
- make all calls look like `std::isfinite`. - change the comments referring `rtl::math::isFinite`. Change-Id: I0cde9ceb9f20150467b454cddde5e62003cfde1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90234 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-12tdf#83901: move UItest to CppunitTestXisco Fauli
Change-Id: I0d074da097912f8abba6bae6171596076d71e998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90345 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-02 16:36:20 +0000