summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-01Fix typosAndrea Gelmini
Change-Id: I2238961a7b124652e90e948e27a6ca9d98dc54ac Reviewed-on: https://gerrit.libreoffice.org/76826 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-01drop newly unused EnableImageDisplay + EnableTextDisplayCaolán McNamara
Change-Id: I534c5fcfe2e8b55d0f01075b62e7168a10e805a9 Reviewed-on: https://gerrit.libreoffice.org/76819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OMySQLIntroPageSetupCaolán McNamara
Change-Id: I8378860bfc5cb087b5c04a73e99965afdee4c23f Reviewed-on: https://gerrit.libreoffice.org/76822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Ie5e66723ad497f927bc26bbe01c8194712455caf Reviewed-on: https://gerrit.libreoffice.org/76821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OFinalDBPageSetupCaolán McNamara
Change-Id: Ie05e086c393ef6572c92e7c4975b1c9dd9e3ad48 Reviewed-on: https://gerrit.libreoffice.org/76818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OGeneralPage and OGeneralPageWizardCaolán McNamara
Change-Id: I7caa08a5e060371c9b80ff83b141c27af09246bf Reviewed-on: https://gerrit.libreoffice.org/76817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01no point in using a map anymoreCaolán McNamara
seeing as we want alphabetical sort now, there's no point in calling GetLineRange and using a map and only need to set the widget as sorted in the ctor, it remains always sorted Change-Id: Ieb5e5c8d9e36375a723376b0009062d6313c8779 Reviewed-on: https://gerrit.libreoffice.org/76810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126661 unexpected sort between freeze+thawCaolán McNamara
Change-Id: Ibb6b404d32e38c72fb1ff4be73f3a5f116d55692 Reviewed-on: https://gerrit.libreoffice.org/76809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01sort outside thawCaolán McNamara
Change-Id: Ifafae5f4ddba816ef3b11d4babd54ae6495a487f Reviewed-on: https://gerrit.libreoffice.org/76816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126282 add English (Sri Lanka) [en-LK] locale dataEike Rathke
Change-Id: I0a678a3599c43e5158c843d7781a0f55a3b03261 Reviewed-on: https://gerrit.libreoffice.org/76808 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-01tdf#126282 add English (Sri Lanka) [en-LK] 0xA409 to language listEike Rathke
Change-Id: I2b02498684c952f9a6bf8f6bc17a3355c3607aac Reviewed-on: https://gerrit.libreoffice.org/76807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-01remove some resolved ui suppressionsNoel Grandin
and enhance the script to make finding the unused ones easier Change-Id: I937246e98d93fb999a23f2283b6794eaaa6dfa99 Reviewed-on: https://gerrit.libreoffice.org/76806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01skip some indirectionNoel Grandin
these don't need to use std::unique_ptr Change-Id: I03140c7957fd59443db932c37890a6742c6d3bec Reviewed-on: https://gerrit.libreoffice.org/76800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01tdf#126544 writerfilter: check parent style exists before assigningJustin Luth
If you set the parent style to a style that is not yet created, then it silently fails, and thus inherits from nothing! Change-Id: Ibb85235643dd5b1eb9b0bd43f701580f24b2b7fa Reviewed-on: https://gerrit.libreoffice.org/76805 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-01sw comments on frames: improve doc coordinates -> doc model pos conversionMiklos Vajna
In case an as-char image at the end of a paragraph was commented and the user clicked past the end of the paragraph, we defaulted to extending that comment, rather appending content. (The cursor was placed between the as-char image and the comment anchor, not past the comment anchor.) This doesn't seem to be useful, probably the expectation is that if the user clicks before the comment anchor then we extend the comment range, and if the click is after the comment anchor, then we don't. In both cases we used to *select* the comment anchor, so typing a character deleted the comment instead. This commit is a step in the direction of never selecting the comment anchor: now if you click past the comment anchor, then we place the cursor after the comment anchor. (But clicking before the comment anchor results in unchanged behavior for now.) Change-Id: I6c36ec4344591fdf330a73bcd3cdd6fd0610e339 Reviewed-on: https://gerrit.libreoffice.org/76803 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-01clean up ViewCallback nicely in sw and sdNoel Grandin
Change-Id: I471768083e46b43df37b500bb51dfa13a1b54b75 Reviewed-on: https://gerrit.libreoffice.org/76797 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01weld SvxDefaultColorOptPageCaolán McNamara
Change-Id: I5741ee4d0df724e9f1df72ce668f9f2e53541280 Reviewed-on: https://gerrit.libreoffice.org/76802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126496 - "Page Fields" in pivot table unclearHeiko Tietze
Renamed to Filters Change-Id: I512a06830635a8b6c62ca8a0ad64683f9824b9e0 Reviewed-on: https://gerrit.libreoffice.org/76777 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-01remove unnecessary code in doc_registerCallbackNoel Grandin
after commit 98c0cefb18d8af7aa4732708ba0ae6be2e808d6f Date: Wed Jul 31 12:40:29 2019 +0200 desktop: fix UB in DesktopLOKTest::testCommentsCallbacksWriter() Change-Id: I254d8413e707d4525efbfb2050e5b29f70c4bed7 Reviewed-on: https://gerrit.libreoffice.org/76796 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01drop some resolved ui suppressionsCaolán McNamara
Change-Id: Ie717e13ba703149ab563c3930d5174fdd5e5d6c7 Reviewed-on: https://gerrit.libreoffice.org/76794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#126623 Correct URL for Mysql JDBC page Change-Id: I326e123ec446aa818c0761ed172f2c4cfd09bbd0 Reviewed-on: https://gerrit.libreoffice.org/76801 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-01drop newly unused OptHeaderTabListBoxCaolán McNamara
Change-Id: I08926e91a61e7bdd4de4ac96083e970268801d6f Reviewed-on: https://gerrit.libreoffice.org/76789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld SvxPathTabPageCaolán McNamara
Change-Id: If9b982d9e73adbb55e940ae12e5d894dd803f7f3 Reviewed-on: https://gerrit.libreoffice.org/76788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01should toggle all others to false, not trueCaolán McNamara
regression since... commit 5c32ba63163d9556ff89782a8074924cdf9dc554 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 4 14:30:03 2019 +0100 weld OTableSubscriptionPage Change-Id: Iec3bec1b49af3e60b80301665ff3834f24f72222 Reviewed-on: https://gerrit.libreoffice.org/76787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01tdf#126641: don't fail on file URLs with fragmentMike Kaganski
This only fixes part that the URL refuses to open the target file. Honoring fragment isn't fixed here, since it's the system call to ShellExecuteExW that in this case internally converts the file URL into a system path, and strips the fragment from it. Regression from commit d59ec4cd1660410fa1b18c50d2d83b1417a82ddc. Change-Id: I6c9ed27e9a5bd7f2780dd3be96f816a6e825e043 Reviewed-on: https://gerrit.libreoffice.org/76778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01missing includeStephan Bergmann
Change-Id: I9c3d551d2053b53bde3b032036bc531a02217300 Reviewed-on: https://gerrit.libreoffice.org/76782 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-01tdf#126168: sw undo/redo crash fixedVasily Melenchuk
After undo of style creation we have a dangling pointers to deleted style in SwUndoSetFlyFormat. So instead of keeping pointers to SwFrameFormat which can be invalidated, we could keep style name and find style by name. Change-Id: I9a60d6b3311278d7391d676010c31c862189fd08 Reviewed-on: https://gerrit.libreoffice.org/76351 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-08-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update page with video on 6.3 New Features Change-Id: If9819fc8a3c324f3c4a5d6acff9f5edab3a69833 Reviewed-on: https://gerrit.libreoffice.org/76795 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-01Notify the client when we close the sidebarAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/71844 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 60c048e665c7e8dc32c378f0364931b6e26a9ca2) Change-Id: I4879d65285e01cf2fd99233d226f4201997b4dd7 Reviewed-on: https://gerrit.libreoffice.org/76784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01Silence -Wunused-function on AndroidMike Kaganski
after commit bf6bde2da134dad60ecbf8f3e97674abadb7349e Change-Id: Iaf6f1457f95e5b821879b735c16a692cca7515db Reviewed-on: https://gerrit.libreoffice.org/76791 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01clean up ViewCallback nicelyNoel Grandin
Change-Id: Idb882460092642bc77804560cd8fd6432a590323 Reviewed-on: https://gerrit.libreoffice.org/76776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01LOK: support sidebars in writer and calcAshod Nakashian
[ Miklos: added code to release LOK notifiers in SfxWorkWindow::DeleteControllers_Impl() during shutdown. ] Reviewed-on: https://gerrit.libreoffice.org/71843 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5ddf630222241bec4deda56d10992c35ae4efe06) Change-Id: I3a3bd1fb6922e435599f604328f558be60594729 Reviewed-on: https://gerrit.libreoffice.org/76556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01mysqlc: Add test for textual blob typesTamas Bunth
Test setting and querying the following data types: TINYTEXT, TEXT, MEDIUMTEXT, LONGTEXT Test them using prepared statements. Change-Id: I43387034ad8c32c3731cde70a22cc8b3dd652b78 Reviewed-on: https://gerrit.libreoffice.org/76747 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-08-01Unify some code across platforms to use static initializersMike Kaganski
Static initializers were used for the environment strings since commit d19c40f45dc8e8bcd9db4c6b83bdcf6367f6fbe7 to workaround thread-unsafe getenv. The special case for Android was initially introduced in commit 60628799633ffde502cb105b98d3f254f93115aa, to allow modifying the environment in the code; then was fixed in commit 4fbf6df784529d48cf194a2d9c495ffb47933d59. That was relying on the functions being called each time their results were used. But commit 9f027559557cb132835d8a13cdc0281ad4e757ae changed that, making the results static, thus only calling the functions once on all platforms. This was effective more than a year already, so presumably the special-casing for Android isn't needed anymore. Thus, this patch unifies all platforms to use the same approach (calling getenv once, storing copies of result in static variables. Also this stores flags used in maybeOutputTimestamp to static variables, too, to avoid parsing strings each time the function is called. Change-Id: I84bdbfb900c15b407fb555296d2613bd3d62da7e Reviewed-on: https://gerrit.libreoffice.org/76573 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01loplugin:stringconstantNoel Grandin
Change-Id: Ia79eb53c3ab3a61a247ed56e0e1a956518721fa0 Reviewed-on: https://gerrit.libreoffice.org/76775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01tdf#126138 sw: disambiguate SwTabFrame::FindLastContent()Michael Stahl
Most callers don't actually care about the SwContentFrame but want its upper; introduce FindLastContentOrTable() for those. Last frame can be a SwTabFrame quite simply if you delete the trailing paragraph with Ctrl+Shift+Del from the last cell of nested table. Change-Id: Ieab9e1ff2a5fa7b75d84dfc3cc4d17c867751b0c Reviewed-on: https://gerrit.libreoffice.org/76759 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-01tdf#126138 sw: invalid static_cast in SwTabFrame::FindLastContent()Michael Stahl
Change-Id: I64412f32f1be78a647710e96f0a92cd78921d784 Reviewed-on: https://gerrit.libreoffice.org/76755 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-01tdf#126244 Chart view: fix rotation of complex category labelsBalazs Varga
The first level of vertical category axis labels orientation should be horizontal, other levels should be rotated to 90°. Also do not allow text break for complex vertical category axis labels. Change-Id: I01a6d9f753e767927fa71e2967dc3e6bad270565 Reviewed-on: https://gerrit.libreoffice.org/76754 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-01tdf#126590 DOCX import: fix absolute hyperlinks to documentsTünde Tóth
Absolute links in DOCX documents created with Word didn't work. Change-Id: Ie23c9ded1c88752768b925ec26df3061beeddd8e Reviewed-on: https://gerrit.libreoffice.org/76581 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01xmloff: create XMLImpressStylesExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6b99c5975eacbaba5dbec1ae679c9e5726bdfd6b Reviewed-on: https://gerrit.libreoffice.org/76766 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01tdf#118699 change tracking: fix accept before empty lineLászló Németh
Empty paragraph after deletion of wholly paragraphs doesn't get the style of the tracked deletion by accepting the change. Fix also tdf#125916 again. Note: lcl_CopyStyle() hasn't been changed. Change-Id: I07720ec7e11fe99c6e7accf19535e2eebade191f Reviewed-on: https://gerrit.libreoffice.org/76381 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-01tdf#118699 change tracking: don't number empty linesLászló Németh
after tracked deletions with numbering in Hide changes mode. Change-Id: I9a0c01d3aa00a2d54ffd37c8b85027eb2feeb841 Reviewed-on: https://gerrit.libreoffice.org/76335 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-01tdf#125990 change tracking: remove text join workaroundLászló Németh
at wholly deletion of paragraphs, disable failing unit tests related to the temporary regressions. This partially revert commits commit 22639148ae5400bac98f32a75d7431b857c80195 "tdf#54819 change tracking: keep paragraph style after full deletion" commit 8acc15b5113c798ecdbeed91456a92e7b0c1334e "tdf#118699 DOCX import: don't add numbering." commit caeb6ff68d49e1b1ca911cf3f63371b855ee935d "DOCX import: clean-up FinalizeImport() of change tracking" etc. Change-Id: Ia42749fd9f22f3bc1c7c2f38b604b1926631fc77 Reviewed-on: https://gerrit.libreoffice.org/76324 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-01tdf#125319 sw_redlinehide: handle empty paragraphs more like WordMichael Stahl
Partially revert commit c20308f1b919ca5ce61233068946e5fddb7eadb3 Partially revert commit 4439427aadeaa0cb611011b46f0fa14bfa196f33 "#i100466# correction for showing and hiding redlines" This gets us somewhat closer to what Word does but not exactly the same; Word actually creates a separate formatting redline about paragraph property changes at the time when you merge the paragraphs, but Writer's formatting redlines are quite unhelpful. Unfortunately ODF documents from OOo 3.2 and later (possibly also pre-3.0, haven't checked that) will look different if they contain such redlines. Change-Id: I6ca67e45d805014dd0b94b0ff063780fce4207c6 Reviewed-on: https://gerrit.libreoffice.org/72425 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-01Publish XAcceleratorConfiguration and related interfacesSamuel Mehrbrodt
Change-Id: Ie3f699f673fde938dd2f9b1851420b88a2540f28 Reviewed-on: https://gerrit.libreoffice.org/76580 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Only build LOKDocView-0.1.gir when necessaryStephan Bergmann
Prior to 634844354ee6ed884128086a80c3ee32c889d8c9 "sysui: fix rpm errors in freedesktop-menus (4.14.1)" it had been build as part of sysui/desktop/share/create_tree.sh, which is presumably only called when building for deb or rpm PKGFORMAT. Building it now in more cases started to cause issues, like > g-ir-scanner: link: /home/sbergman/llvm/inst/bin/clang --gcc-toolchain=/home/sbergman/gcc/trunk/inst -fdiagnostics-color -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-scope -fsanitize=undefined -fsanitize=local-bounds -fsanitize=nullability -o /home/sbergman/lo/core/tmp-introspectga_nlzjv/LOKDocView-0.1 /home/sbergman/lo/core/tmp-introspectga_nlzjv/LOKDocView-0.1.o -L. -Wl,-rpath,. -Wl,--no-as-needed -L/home/sbergman/lo/core/instdir/program -Wl,-rpath,/home/sbergman/lo/core/instdir/program -llibreofficekitgtk -lgio-2.0 -lgobject-2.0 -Wl,--export-dynamic -pthread -lgmodule-2.0 -lglib-2.0 > /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_handle_function_type_mismatch_v1' > /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_vptr_type_cache' > /usr/bin/ld: /home/sbergman/lo/core/instdir/program/liblibreofficekitgtk.so: undefined reference to `__ubsan_handle_dynamic_type_cache_miss' in an ASan+UBSan build (where g-ir-scanner should apparently use CXX instead of CC for linking, but there appears to be no easy way to tell g-ir-scanner to do so). Change-Id: I5a960c6ed387722138d4b3d156c87038f3e5b8ca Reviewed-on: https://gerrit.libreoffice.org/76769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01new loplugin:mapindexNoel Grandin
Change-Id: I6b5f73b2187009e95d4d666e03e5803f522cee06 Reviewed-on: https://gerrit.libreoffice.org/76584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01tdf#126584 Disable styles next style edit style buttonJim Raykowski
...on dialog opening for paragraph and page new style creation. Change-Id: I64dd51947261249293581c73bd1c410f3b54a592 Reviewed-on: https://gerrit.libreoffice.org/76717 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Sometimes static checks are enough.Mike Kaganski
Change-Id: I61e7a28c5beab8f0c619767545009cefae6ddcd9 Reviewed-on: https://gerrit.libreoffice.org/76772 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01NB writer: start with visibility supportandreas kainz
Change-Id: Ib2b930b596a361e4999153b8f9d7b984cd3864d8 Reviewed-on: https://gerrit.libreoffice.org/76770 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-12 06:23:23 +0000