Age | Commit message (Collapse) | Author |
|
ComplexColor includes everything a ThemeColor has and in addition
also can have various other representations that are supported by
OOXML. This is important for compatibility reasons to preserve the
color information.
Change-Id: I677775a96511dc1742c75b1949e002eaa8c622e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151226
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I40107fc38a4d080d969fee862595660d2f585e51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151225
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ib9f653c6add8713a9acf9f6b4605323bcb2c6db6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151470
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ie2d68ff2dc9cbc99a10fd3403a72737be4b991dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151478
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ie4e8c24bf776d0ba0e1b7f986fd506521816d2e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151477
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibcf59feaa1631c06a393017d1b6342d4a646b9a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151387
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Right now this doesn't make any difference, since Bitmap is the
superclass of AlphaMask.
But when I switch to using alpha instead of transparency, passing
AlphaMask around is going to mean something different to passing plain
Bitmap around.
Change-Id: Ic1541e5f0a3b97331793cd23e23115faa7f382b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151463
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The BitmapEx constructor already does this check, no need to do it here
Change-Id: Iacd0e1b1d4aa3dfae120e0d4a60a6924ecd9f778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151460
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The cursor position is pushed in SwView::ExecSpellPopup, and popped
in the end, to restore the changed position e.g. when the action is
cancelled.
In the replacement, the PaM of the pushed cursor is updated in
DocumentContentOperationsManager::ReplaceRangeImpl, likely to avoid
several updates during the further processing. The stated goal is
to move all PaMs out of the deleted range, but the direction is not
stated explicitly.
If this correction is removed, the cursor PaM gets corrected anyway,
and arrives at the end of the replaced text. So, to fix the bug, and
to be compliant with the default case, let's correct to the end of
the range, instead of the random direction (GetPoint() may return a
position at either end, depending how PaM was created).
Change-Id: I83bcf01bcc0bf7277a9a34263b524b1212785814
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151462
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to bcabd26061bf9740878cdbbbf09c2efb686d2b24
- Put back string for related topics
Change-Id: I63fecc145ddab0948931ffbd8898fd3d1096cff3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151485
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 35f61fce142836d5bc2542d474e779532f7e68d7
- Update Help page for Line and Filling toolbar
+ several updates and refactoring
Change-Id: I218204d3c37def5acfc89a5eb5b36a19ed3b38be
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151484
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to b8c81e75d9094cddd2b62f7835d67e6fe2070254
- Update icon
Change-Id: I2bf5920120d2c96a06cd17edef7666ca5c7c2901
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151483
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 9eff87dfdf14777f4a867c5f6614868a9f8bb631
- Refactor - no change in contents
Change-Id: Ib8d52fee2054790a97ce5fa57ba573884a96fecf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151482
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 4bb76d76debdcb5d63ac58da66723759b2af92eb
- Refactor help file, no content change
Change-Id: I7f8034e20776809112d86f9253d2980dd343de8c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151481
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 8b3d7e6a7832b4c0dd6b489b9ca0f3229dfeb79b
- Refactor - Visit help file for icon updates
Change-Id: I69004353c7b6df30e3679900fa9bbe877983d1fc
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151480
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to fb88bf7fa8e5909ef7da5dde76545eb3b944279b
- Refactor help page - no contents change
Change-Id: Iecc4632f24421c5fd77636bb9489e298cb72428b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151479
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I56480780903a39534c3bab8e79e3864fcba10470
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151473
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Thank you Mike for having spotted it! :-)
Change-Id: I210edf2e05eb6ba02ac9cdd999c4f2233819cfa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151476
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia85598b6558f8f34187f40d6f5e5285bbc28abf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151471
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
See a6287e21f1dab6ae382c24ceeb4c0212b7cad2d7 "framework: sal_Bool->bool"
+ /opt/lo/bin/clang-format -i framework/inc/taskcreatordefs.hxx
as requested when submitting patch with logerrit
Change-Id: Icb21563590a4104f3cb678db44fc4b5f1d884764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151475
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia30740ce0422b2fe5a85e288f18de68a1dca9b33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151474
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I260f6bd060b9f1ec3a782ff765b676f78d126d40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151461
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I48db543231f0b7abb7e27173b9bbfd0b657dc716
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151457
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I70c0a72d6bbbec7e809edc856976633fce3efa9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iebfd224091c108bb5068b716c39da0979a7ab3ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151437
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
I was daydreaming, when thought that we can rely on the system-provided
file URL. Windows creates such URLs using current 8-bit codepage, and
URL-encodes the octets from that string, which fails when the URL is
treated as UTF-8 after URL-decode.
Change-Id: I2703586d371c1254e693a5760c5b6b74101e299d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151456
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
The copy&paste of ranges with shapes had the following further bugs:
* For cell anchored shapes the position was taken from the source
rectangle instead of the anchor.
* Resizing was calculated from source and destination rectangle, but
should only depend on size of object range.
* tdf#125938 Shapes were moved without adapting the anchor.
* tdf#155091 Source with filtered rows produced doubled objects in
paste.
* The CopyToClip method has a useless NbcMove(size(0,0)). NbcMove
is a move 'by', not a move 'to'.
* tdf#155093 Pasted object has same name as source object and thus
is not accessible via Navigator.
* tdf#155094 Transposed pasted objects have wrong position
* tdf#155095 Objects over collapsed group are incorrectly resized
* tdf#141437, tdf#141436 transposed objects have wrong size
Only objects, which can really resize, are now resized. In case of
transposing no objects are resized. Transposing would need to
transpose the object geometry, but that is missing.
The offset inside the start anchor cell is adapted to the size of
the destination cell to keep the anchor in this cell.
Object resizing considers that filtered rows are removed whereas
collapsed or hidden rows are shown in pasted area.
Object resizing does no longer use global factors but calculate the
desired snap rectangle and fits the object into it.
Change-Id: I42924b28a2d652d8b70cb8e1a1d7ca4324b09cf6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150161
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
* Update helpcontent2 from branch 'master'
to 06878198a15d3f7777cde8d24d0c889bd0ff8ec1
- Proofreading
Change-Id: I314b97f7472ba5159ec7394e243991c2a3e08969
|
|
Indeed, the cDecSeparator and cGroupSeparator require that the buffer
uses the proper character type, otherwise it won't be possible to use
Unicode separators in rtl_math_doubleToUString.
Change-Id: Id26bed72776475c1be5b092e3ffcff0e75ffe557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151451
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
we can drop the lock immediately after construction (since
the iterator holds a thread-safe COW link to the underlying listener
container)
Change-Id: I08f8fa9ed7393747938572097f3c25f5f3f847fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151440
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
click or shift + enter key
Enhancement to make a selection from the current cursor position in
the document to the position in the document that is navigated to
when a content entry in the Navigator tree is double clicked or the
enter key is pressed.
No selection is made when the current cursor position is in a table,
header, footer, footnote, or frame.
To make shift + double-click behavior for x11 and qt5 the same as
gtk3, FunctionSet::SetCursorAtPoint is added to the Shift case for
SelectionMode::Single in SelectionEngine::SelMouseButtonDown.
Change-Id: Id845dad8011ff7777a24f9b2730f10c62271c368
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151157
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
* Update helpcontent2 from branch 'master'
to b176d62d7cb328903699b6ccc0b30e0c91a0ff97
- Color quick selector help page
Change-Id: I479e0e00fa36035551c47139dda3c2491d3c4dc6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151444
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
e.g.
==34359==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0xf83e3b4 in xmlParserPrintFileContextInternal /work/workdir/UnpackedTarball/libxml2/error.c:201:24
#1 0xf848d44 in xmlReportError /work/workdir/UnpackedTarball/libxml2/error.c:406:9
#2 0xf841166 in __xmlRaiseError /work/workdir/UnpackedTarball/libxml2/error.c:0
#3 0xf8755e0 in xmlFatalErrMsg /work/workdir/UnpackedTarball/libxml2/parser.c:602:5
#4 0xf8ed9a3 in xmlParseDocument /work/workdir/UnpackedTarball/libxml2/parser.c:10824:2
#5 0xf915b0e in xmlDoRead /work/workdir/UnpackedTarball/libxml2/parser.c:15175:5
#6 0xf9178fc in xmlCtxtReadMemory /work/workdir/UnpackedTarball/libxml2/parser.c:15452:13
#7 0x8d849f in LLVMFuzzerCustomMutator /src/libreoffice/vcl/workben/fodt2pdffuzzer.cxx:68:21
#8 0x83044a in MutateImpl /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMutate.cpp:550:22
Change-Id: I95c00d8ba0e4f9886ea6a03828cb2f065c6eff1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151454
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
after
commit c55d5586304f23f9d8acbaffefba68a3a11c6175
Date: Sat Apr 1 16:10:33 2023 +0100
BinaryDataContainer: hand out shared_ptr's to SvStreams.
and
commit 0f2581204a70038ed7ca78089a9bd96d158e02c0
Date: Mon Apr 3 09:34:54 2023 +0100
BinaryDataContainer swap out implementation.
it is possible that a eLinkType of GfxLinkType::NativeGif and a
nStreamLength of 0 could lead to BinaryDataContainer::getAsStream
being called on a default ctored BinaryDataContainer which would
mean an mpImpl of null and a null dereference here
Change-Id: Id964e3ce97e5527c5357576131fe03440f1ea00c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151453
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and
cid#1529286 Explicit null dereferenced
Change-Id: Ibe7832ddcfe0239aa71626075209ef6a052af914
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151452
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
When in edit mode, the text can be deleted, so the text box size
can become smaller, but the auto-fit algorithm didn't take into
account.
In this case we already have the font and spacing scaling already
set to a specific value and we need to find a scaling value where
the margin is the smallest.
This change also adds a test for the issue.
Change-Id: I6c52f06dfbf5a1e582f7b31aceabf4736498ee90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151412
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I00f644392860162cf7294ff8119bf00a5ec69b3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150889
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I3e40f0731c219cb40019d38a0a986a53776cce83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150888
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iaea6bf7c539d1ab5e0399e07531be08f2764f488
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150887
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
And change o3tl::iterateCodePoints to use sal_Int32 for its
second param, to integrate better with places where the parameter
comes from an UNO API, which cannot use std::size_t
Change-Id: I7b9dd2c9bc7f48e6c4a912f039f1b5dae7beae69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151421
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia985e96eb441d03ace050f4f184a899fba897830
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150873
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I8211a1fe19bbd900f866c46d5b7ec68a37bc38cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150859
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I1202763917dab414e8bc540bd89d736e74fa1450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150858
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
and unify with *ToAscii(Lower/Upper)Case
Change-Id: I06999b4f5f34abc8da2860b7f9e279608edb40dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151381
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
No need to use different temporary objects here
Change-Id: I1b47cae8b80adea5426c780003bddf68310a0060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151380
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This limits the number of places that know how to deal
with a given type.
O(U)StringNumber doesn't need an own overload, because
it has operator basic_string_view.
Change-Id: I6e82dc2cef103b578153fbc3ce16e96247ea9d74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151379
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
rtl_(u)str_valueOf(Float/Double) are the most inefficient choice:
their implementations call rtl_math_doubleTo(U)String, asking to
allocate a new rtl_(u)String; then copy the string to the provided
buffer on stack, and destroy the rtl_(u)String; and then copy the
buffer into self. Even using O(U)String::number() would be more
efficient, avoiding the intermediate stack buffer copy.
But rtl_math_doubleTo(U)String can take also the O(U)StringBuffer's
data directly, allowing to insert efficiently. Use that.
Change-Id: I720ea7be6f4b2b92865a18eafcdb9ca9a089b854
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151377
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
It was broken from the start: it was introduced like this already
in commit 9399c662f36c385b0c705eb34e636a9aec450282
(initial import, 2000-09-18).
Creating a temporary copy as a return value makes no sense.
Change-Id: I6910d426c2437038ec4979be2c44cd72146dec9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151375
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Very tiny screens or huge scaling may result in cut-off
content at the app pane. The scrollbar should solve this.
Change-Id: I33e6fa3b428c8643f8024bb1287d93dfe4f3b1bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151422
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I325a76423a98a405dfb0f69fbd89eb9253c36390
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151439
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|