summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-28avoid a calc threads assert because of an undetected cyclic dependencyLuboš Luňák
ooo#103156-1 has a quite complex cycle of cells, some of them (and only some) in formula groups. And the complex Interpret() nesting confuses its cycle detection into believing that Interpret() can simply return without providing a value, which is ok if it's called from dependency checking of threaded calculation, but is not ok when it's called for a single cell evalution. So make the code set cyclic-dependency error even when it's possibly inside dependency checking, since if it's really that case, the error will be later overwritten by the actual value. This is still not a completely correct fix, as the document on repeated hard recals alternates some cells between correctly reporting an error and providing some bogus values (e.g. column S in the second sheet). But the document uses iteration, which complicates all this stuff even more, and after spending quite some time on this I'm still not sure on how to fix that. So at least for now, at least avoid the assert. Change-Id: I395f97d104d98b5c043d1f17878338d3f1b31146 Reviewed-on: https://gerrit.libreoffice.org/66911 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-01-28sw: prefix members of SwTableAutoFormatMiklos Vajna
Change-Id: I17515ea4e444986f50d554c864540a625a521970 Reviewed-on: https://gerrit.libreoffice.org/66984 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-28both branches have a common pieceCaolán McNamara
Change-Id: I1fd28f7dc0911bfdb8fd46aee91c3a81ce034ba6 Reviewed-on: https://gerrit.libreoffice.org/66899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-28o3tl::make_unique -> std::make_unique in sax...svtools (except sc)Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e Reviewed-on: https://gerrit.libreoffice.org/66751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-28Fix typoAndrea Gelmini
Change-Id: I372918497b91bd2da0432df7b27795cbf29dc6b8 Reviewed-on: https://gerrit.libreoffice.org/66982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-28Fix typoAndrea Gelmini
Change-Id: If648e007a6db44e26021c12ac919d81ccceaa081 Reviewed-on: https://gerrit.libreoffice.org/66981 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-28Fix icon load error for uno commands with paramsMuhammet Kara
Change-Id: I31e4c28322a3492a603bce5c7226e2dbcf131173 Reviewed-on: https://gerrit.libreoffice.org/66980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-27Bail out earlyMatteo Casalin
Change-Id: I7851f4952ca2c863d92fd14fa19005ed35634033 Reviewed-on: https://gerrit.libreoffice.org/66941 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27tdf#122990: return if no mpMenuBarContainerWidget in ApplyPersonaJulien Nabet
Related to patches for tdf#122241 Change-Id: I0ce46a3a362855aaa6c11f375d20c2212f1cb20b Reviewed-on: https://gerrit.libreoffice.org/66973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-27Could not determine MSC version with French UIJulien Nabet
Fix regexp for cl.exe This command returns some special characters preventing regexp to work. For more details, see: http://document-foundation-mail-archive.969070.n3.nabble.com/Could-not-determine-MSC-version-Visual-Studio-2017-td4256538.html Change-Id: I734dcd533b0f38430d1be8852f1e4f721221e580 Reviewed-on: https://gerrit.libreoffice.org/66959 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: I7c0bb328def955efce7b3866776e4d47a0ba32c0 Reviewed-on: https://gerrit.libreoffice.org/66947 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Get data from full string, without tokenizationMatteo Casalin
Change-Id: I8cdaef18329543cbbe316b9499d6707d645a789d Reviewed-on: https://gerrit.libreoffice.org/66644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Optimize: getToken()+comparison+copy() ==> startsWith()Matteo Casalin
Change-Id: Ic0e343f80ef91aad9baef8cc48648207b0365c68 Reviewed-on: https://gerrit.libreoffice.org/66642 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Use getTokenCount instead of custom codeMatteo Casalin
Change-Id: I645854f4e0d5d57f8507a13e29dbb920e9f1ab85 Reviewed-on: https://gerrit.libreoffice.org/66940 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Take advantage of known index to avoid an OUString copyMatteo Casalin
Change-Id: I3cf7a10f5d27ddc626adea07697aa65e01f6f978 Reviewed-on: https://gerrit.libreoffice.org/66942 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: Icf0075e7487ea29db5f52846be531d30b231ee05 Reviewed-on: https://gerrit.libreoffice.org/66945 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Use indexed getTokenMatteo Casalin
Change-Id: I104565b86874ed7cf99f85b9c784b3873e078ffa Reviewed-on: https://gerrit.libreoffice.org/66937 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27getToken: reuse known index informationMatteo Casalin
Change-Id: I87f274addcba0776016e9996a0b568f503e2081a Reviewed-on: https://gerrit.libreoffice.org/66939 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Use optimized OUString concatenationMatteo Casalin
Change-Id: I8314d0e6a6ac922a88ff891af2f1071e7b5692e6 Reviewed-on: https://gerrit.libreoffice.org/66943 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Reduce OUString temporariesMatteo Casalin
Change-Id: I13777809dbee314e5b0002f8da9d5009c7fc3c5b Reviewed-on: https://gerrit.libreoffice.org/66946 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-01-27Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed executable permission on SVG file Change-Id: Id70e4005d576fc9b13589aa53ade1cc211f6f3e3 Reviewed-on: https://gerrit.libreoffice.org/66960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-27Fix typoAndrea Gelmini
Change-Id: Iccc171ce433e38c4eea4e73dcdba76720aa78056 Reviewed-on: https://gerrit.libreoffice.org/66969 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-26Make the text on Redaction toolbar buttons visibleMuhammet Kara
Change-Id: I3d6bc2adb91fbe16da008797b7b7e5189726c500 Reviewed-on: https://gerrit.libreoffice.org/66968 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-26tdf#99573 uiwriter: clear RES_BACKGROUND -> XATTR_FILL_*Justin Luth
The paragraph background wasn't being cleared when hard formatting was removed (unless roundtripped via .ODT only) because a couple of years ago RES_BACKGROUND was aliased to XATTR_FILL, but lots of edge cases are still missed. Perhaps there is a more generic place to handle "reset attribute", but I didn't find it. SwFormat is where most of the aliasing is happening. Change-Id: I9d0a3c70f03f0a5b22155e689e27e3372535aec6 Reviewed-on: https://gerrit.libreoffice.org/65609 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-26tdf#116371: export rotation of SwGrfNodeMike Kaganski
Change-Id: I42620da798a35dfada67d9a9fb23d554cc20b16f Reviewed-on: https://gerrit.libreoffice.org/66963 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-26Support new HK variant in Source Han Sans 2.0 and Noto CJK Sans 2.0.Mark Hung
Support HK variant that are newly added to Adobe Source Han Sans 2.0 and Google Noto CJK Sans 2.0 and add missing TC, SC, HW, etc. in English font names. Change-Id: I3edccecfd0926d8c11a30bbb5be0debc0f8edf5a Reviewed-on: https://gerrit.libreoffice.org/66955 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-01-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#114263 Help page for Partition [VBA] + some hyperlinks and reordering of text in calssmodule and compatible, option vba support. Change-Id: Ic387086a5874989d22cf93caf0f3d0f48fd77a9e Reviewed-on: https://gerrit.libreoffice.org/66910 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-26Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Improper Python code requiring update Change-Id: Ia59f0e5d67718771152cca49704173701bf1f0f8 Reviewed-on: https://gerrit.libreoffice.org/66957 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-26tdf#122814 KDE5: conditional disable of Qt shortcutsAleksei Nikiforov
Change-Id: I5375f0b555e483b2c108550d319e64d781b96f75 Reviewed-on: https://gerrit.libreoffice.org/66673 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-26tdf#120836 KDE5: Clipboard: don't put images to clipboardAleksei Nikiforov
Image generation is very slow. Change-Id: I34d45ed1f4d665613700f01cceec59069b091a79 Reviewed-on: https://gerrit.libreoffice.org/66680 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-26add a Dialog::runAsync for the non-controller caseNoel Grandin
.. and use it to make the solver warning dialogs async Change-Id: I3589a1d3ae58190bf545bac1e2a95f81a114d44f Reviewed-on: https://gerrit.libreoffice.org/66896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-26Add XActionLockable tests to ScNamedRangesObjJens Carl
Change-Id: Ibadda3535294fb58ea371e00357da8cd504d5f9a Reviewed-on: https://gerrit.libreoffice.org/66953 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26Add XPropertySet tests to ScNamedRangesObjJens Carl
Change-Id: Ia591ab4657ce2e2020ca2328c65702599a70c691 Reviewed-on: https://gerrit.libreoffice.org/66952 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26Add XServiceInfo tests to XServiceInfoJens Carl
Change-Id: Ic483e819d179b6e7a461fcb11b91c6d9a296ca07 Reviewed-on: https://gerrit.libreoffice.org/66951 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScNamedRangesObj. Change-Id: Id6eea13bb00e291fdaf1c03b77630bb672938767 Reviewed-on: https://gerrit.libreoffice.org/66950 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScNamedRangesObj. modified: sc/qa/extras/scnamedrangesobj.cxx Change-Id: I1274e23acbd125dd784ae7591bfab8d3d146d2e2 Reviewed-on: https://gerrit.libreoffice.org/66949 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScNamedRangesObj. Change-Id: I6455bad007d3347c805352384196d538b99ea72e Reviewed-on: https://gerrit.libreoffice.org/66948 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScNamedRangesObj. Change-Id: Ia19281b8e481eda2535eb6f26c60dedc65f1beec Reviewed-on: https://gerrit.libreoffice.org/66933 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26Add XServiceInfo tests to ScSpreadsheetSettingsJens Carl
Change-Id: Ib3de198dfe9147897a972bf2ce0a9b20e68bb155 Reviewed-on: https://gerrit.libreoffice.org/66927 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26vcl: test gradient draw into a metafile, extend the dumperTomaž Vajngerl
Change-Id: I87600c8cb648686b80092a9526a07ed71b324907 Reviewed-on: https://gerrit.libreoffice.org/66918 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-25Qt5/KDE5 use logicalDotsPerInch to report DPIJan-Marek Glogowski
It looks like all other backend don't use the physical, but the logical DPI to report the resolution. So use the QScreens logical resolution when reporting the DPI values. Also use QScreen for KDE5, as the Svp defaults to 96. This might fix tdf#122131, but since I can't reproduce... Change-Id: Iefc75acf26f8664f2a9ad995edbdc749be2228cf Reviewed-on: https://gerrit.libreoffice.org/66525 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-25Forge the freeform redaction toolMuhammet Kara
out of the Freeform Line tool in Draw. * Replace .uno:LineToolbox with .uno:Freeline_Unfilled in Redaction toolbar * Add new parameters to .uno:Freeline_Unfilled - SfxUInt16Item Transparence, SfxStringItem Color, SfxUInt16Item Width, SfxBoolItem IsSticky * Handle the params in FuConstructBezierPolygon * Now the freeform line draw tool on the Redaction toolbar works with a default width of 5mm, color of COL_GRAY7, and a transparency of 50%; and it sticks when it is clicked/selected once until user deliberately deselects it by clicking on another tool or by clicking outside of the page. * Known problem: icon is not displayed on the toolbar after adding the params Change-Id: I6b09276ca82782dbf214aab8d2ba3b407fb0d81c Reviewed-on: https://gerrit.libreoffice.org/66916 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-25lok: calm down CnP issues & simplify.Michael Meeks
Change-Id: I67669b9b3accbcf89bddf3b8dc8435edba89224b Reviewed-on: https://gerrit.libreoffice.org/66925 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-01-25lok: don't crash in simple LOK use-case with no callback.Michael Meeks
Change-Id: I7bceba10f002ad5751e3d810f9a9767ad2e875bc Reviewed-on: https://gerrit.libreoffice.org/66924 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-01-25tdf#45904 Move XPropertySet Java tests to C++Jens Carl
Move XPropertySet Java tests to C++ for ScSpreadsheetSettings. Change-Id: Id969a566fcb4e544c26a4097e0f49a01bc967ad7 Reviewed-on: https://gerrit.libreoffice.org/66926 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: I7603a2f8eb144bf243cbf5b5d4812e7aa3a1649a Reviewed-on: https://gerrit.libreoffice.org/66907 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-25NFC filter\ww8 misc code cleanupsJustin Luth
comment spelling, unnecessary if statement, and clarifying that a variable that I want to use later is never changed. Change-Id: If42ee9cc036188d06ceb858a23724383e3933e18 Reviewed-on: https://gerrit.libreoffice.org/66920 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-25add basic support for generating CodeLite IDE filesNoel Grandin
Change-Id: I70613baada4f82e5e56f9a21547733c3a6907b53 Reviewed-on: https://gerrit.libreoffice.org/66908 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-25Assert missing SalGraphics font on GetTextLayoutJan-Marek Glogowski
Trying to layout text without a font can't work. Without a font, currently the text is simply not painted, but this is still a programming error, so warn the developer. And we can get rid of all the intermediate OutputDevice font and gpahics checks, as everything now uses Harfbuzz and there won't be any layout which can't use the cached runs, so just generate them directly. Change-Id: Iae1fab0afeefec1cb1ca82c4e5d8dcbe9919859d Reviewed-on: https://gerrit.libreoffice.org/66818 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-25Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: I4cdde42510bdf0cf50a91caf208133666a412b27 Reviewed-on: https://gerrit.libreoffice.org/64893 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-09 02:12:43 +0000