summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13avoid loading all calendars of a localeEike Rathke
Change-Id: I42d572a5dbd4c89351bd1f03aae75b9b7dbe7e30
2016-09-13switch to using LocaleDataWrapper::doesSecondaryCalendarUseEC()Eike Rathke
Change-Id: I6621e82249feeed3d88ee463447d08c4f812259c
2016-09-13introduce LocaleDataWrapper::doesSecondaryCalendarUseEC()Eike Rathke
Preparing to replace the number format import hack of 95c91f098e8974c41c8d403a351fe53db6822165 and generalizing for known locales. Change-Id: I0413987e302eaa84ef6a7dde2ecb365144313e81
2016-09-13cosmeticsEike Rathke
Change-Id: I32c1df5a8e7164c59ebfe0d1e1d11dd6f3b8edf8
2016-09-13add xdg-email as the default email routeCaolán McNamara
because xdg-email is apparently the only route that knows how to support adding an attachment to thunderbird Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e
2016-09-13coverity#1372877 I'm guessing this is what might have been the intentCaolán McNamara
warning is 'Constant' variable guards dead code Change-Id: I06e65f576180d7ff62417828c26f969982788b55
2016-09-13coverity#1372442 Unchecked return valueCaolán McNamara
Change-Id: I2ff6c844e62ced35477f96a710a31cdd902f3505
2016-09-13Graphyic->GraphicCaolán McNamara
Change-Id: Id405e6a41d8c8ed56471ec058633a21ee4346737
2016-09-13coverity#1371335 Self assignmentCaolán McNamara
these copy ctors are seriously confused Change-Id: I07b2d8cc16ba983cd74782207260b3057f8e7d7d
2016-09-13loplugin:rangedforcopyStephan Bergmann
Change-Id: Ie3faef85382f7e23244e10362bfbe3469357dbfd
2016-09-13sw: emit LOK_CALLBACK_GRAPHIC_VIEW_SELECTION as part of registerCallback()Miklos Vajna
Have a Writer shape selection in the first view, create a new view, the second view doesn't see the selection. But the same works if the shape selection is created when the second view was created earlier. Emit the svx selection state as part of SwCursorShell::NotifyCursor() to fix the problem, but take care of not sending the status to the new view itself. Change-Id: Iff3979235e1c12cc64867c3184354967f451370b Reviewed-on: https://gerrit.libreoffice.org/28857 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-13Revert "tdf#73797 Enable object rotation (.uno:ToggleObjectRotateMode) for ↵jan iversen
writer" This reverts commit 594182ce7c2551dd1d13a014cfdfd96a057e63de. Change-Id: Idf2580e84d4190ba0aaba1a3394a4318043da458 Reviewed-on: https://gerrit.libreoffice.org/28858 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-13coverity#1372879 Integer overflowed argumentCaolán McNamara
Change-Id: I9e5115a00781d07c9c57e39854d6e1482bd02795
2016-09-13tdf#89315 writerfilter add missing parents to out-of-order stylesJustin Luth
Styles that inherit from a parent style, but were defined in style.xml before the parent, were losing their base style. Change-Id: Ic12876dddb1aa961cd8ef7579061cca30c320c71 Reviewed-on: https://gerrit.libreoffice.org/28785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-13tdf#101976 cui: fix crash when setting AutoCheckEnabled and it is read-onlyMiklos Vajna
With instdir/share/registry/data/registrymodifications.xcu being: <?xml version="1.0" encoding="UTF-8"?> <oor:items xmlns:oor="http://openoffice.org/2001/registry" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> <item oor:path="/org.openoffice.Office.Jobs/Jobs/org.openoffice.Office.Jobs:Job['UpdateCheck']/Arguments"> <prop oor:name="AutoCheckEnabled" oor:op="fuse" oor:type="xs:boolean" oor:finalized="true"> <value>false</value> </prop> </item> </oor:items> and then trying to set 'Check for updates automatically' in Tools -> Options -> LibreOffice -> Online Update. Change-Id: Ifb196b6351c8a9182dfcf2ddf0a1e0555bcccedd Reviewed-on: https://gerrit.libreoffice.org/28856 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-13Add commentTor Lillqvist
Change-Id: I53db8747403d55faf5e94f089c925e7491aae911
2016-09-13Bin noise commentsTor Lillqvist
Change-Id: Ie89d4a18d06b81748ceb593a08d10cd1c14640cc
2016-09-13tdf#102065 Notebookbar: Menu bar disappears when cancelling dialogSzymon Kłos
Change-Id: I6f83248eddfc279fe69f0f9c1d64d6b453bb1d3e Reviewed-on: https://gerrit.libreoffice.org/28843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2016-09-13tdf#101094 (30): Better explanation of OPTIONS errors in debug buildGiuseppe Castagno
Change-Id: Iea0eef5d3cd67c73325eb7af883ef8ce286187cd Reviewed-on: https://gerrit.libreoffice.org/28850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-13fix a TODO in XclImpExtName::MOper::MOperNoel Grandin
where it was not mapping the XLS error code to CALC Change-Id: Ia44d6a6793960b52f43a0983d231347ba193636c Reviewed-on: https://gerrit.libreoffice.org/28839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-13remove open-coded versions of GetDoubleErrorValue and CreateDoubleErrorNoel Grandin
Change-Id: I07a1540a1b9ca60fa1e62e9cc0091866d9f2f64d Reviewed-on: https://gerrit.libreoffice.org/28838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-13loplugin:constantparam in dbaccess..editengNoel Grandin
Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc Reviewed-on: https://gerrit.libreoffice.org/28833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-13avoid crash with nullptr accessMarkus Mohrhard
e.g. http://crashreport.libreoffice.org/stats/crash_details/7d19c6e6-19cb-4ba0-a51f-7b7eef514ae1 Change-Id: I97c9da78bc30b730843753da677574ae247cb430 Reviewed-on: https://gerrit.libreoffice.org/28853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13add FINV test caseZdeněk Crhonek
Change-Id: I787608e8927ad61feb01c61dd17959ba763004d7 Reviewed-on: https://gerrit.libreoffice.org/28846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13try to avoid the deadlock around the clipboard, tdf#56818Markus Mohrhard
This deadlocks in the case that we have an external process communicating with LibreOffice as the SolarMutexReleaser allows a connection to be processed while the normal code has just released the SolarMutex. If the external call code now goes down the same code path we deadlock on the SolarMutex together with other mutexes in the clipboard code. Change-Id: I18fd6953c9566452a31b1a4c32c68494ec7a52ac Reviewed-on: https://gerrit.libreoffice.org/27251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-13sw: Make DelHFFormat() localTakeshi Abe
Change-Id: Ifcfcccfa5a7c6f8696de5c2084736fa40659998d Reviewed-on: https://gerrit.libreoffice.org/28842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-09-12add MATCH test caseZdeněk Crhonek
Change-Id: I485ad67c4f022ffdb059a9925e62fb2d60a9f01a Reviewed-on: https://gerrit.libreoffice.org/28848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-12Bin a few unused forward declarationsTor Lillqvist
Change-Id: Ic10de79427d3a353451c9b603495f55459a5936d
2016-09-12fix bug in ScDBExternalRange::findFieldColumnNoel Grandin
where it was calling "pErr = nullptr" instead of "*pErr = 0" Change-Id: I509381b13d00a0c1115fcf625a7363ec6f4da583 Reviewed-on: https://gerrit.libreoffice.org/28837 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-12add FDIST test caseZdeněk Crhonek
Change-Id: I3ad539f4f59c0f6c9a43f69aca1d74aa9f3e3343 Reviewed-on: https://gerrit.libreoffice.org/28845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-12add FISHER test caseZdeněk Crhonek
Change-Id: I6817f7b9478ada45cc3c2b89292c1a6a4782326e Reviewed-on: https://gerrit.libreoffice.org/28847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-12tdf#90721 Line color initial behavior similar to fill colorMaxim Monastirsky
Change-Id: Icf6d35d188f57e1b91da1ce5947f35c97c4f2e78
2016-09-12Bin a few unused forward declarationsTor Lillqvist
Change-Id: I33d021d811ade38befa4c61de740ce86dfe08376
2016-09-12cppcheck: variable scopeJochen Nitschke
Change-Id: Ibe52bb265a064cd454d408ccac06f3bbbb5236e6 Reviewed-on: https://gerrit.libreoffice.org/28683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-12sw: emit LOK_CALLBACK_TEXT_VIEW_SELECTION as part of registerCallback()Miklos Vajna
Have a Writer text selection in the first view, create a new view, the second view doesn't see the selection. But the same works if the text selection is created when the second view was created earlier. Emit the selection state as part of SwCursorShell::NotifyCursor() to fix the problem. Change-Id: I7d71c9b58941c8ca8720b0e63e54bc757b1aaf61 Reviewed-on: https://gerrit.libreoffice.org/28844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-12Resolves: tdf#101879 explicitly put menubars at the start of task listsCaolán McNamara
Change-Id: Ia6a36b08f84960b01472833504cd65bfbad473eb
2016-09-12tdf#101889: add absent brackets to OpenSymbolMike Kaganski
The code points for the glyphs were chosen according to IANA and Unicode: http://www.iana.org/assignments/character-sets/character-sets.xml ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/ADOBE/symbol.txt Adobe Symbol font map has been corrected accordingly. Fixed MT Extra font to always have symbol charset. Change-Id: I45d4f33f2b640cc852175c7c5d5c875cb72a9297 Reviewed-on: https://gerrit.libreoffice.org/28677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-09-12tdf#91966: In SDK, set CPPU_ENV=mscx for 64-bit WindowsStephan Bergmann
Change-Id: Ib93b2db40f43f98d8369cb91ca35692cc92f023b
2016-09-12Disable GCC 6 -Wnull-dereference again for nowStephan Bergmann
...at least with both gcc-6.1.1-3.fc24.x86_64 and a recent GCC 7 trunk build it produces lots of incomprehensible (potentially false positive) occurrences in a --disable-debug build, like > [CXX] store/source/stordir.cxx > In file included from /home/sbergman/lo/core/store/source/stordir.hxx:30:0, > from /home/sbergman/lo/core/store/source/stordir.cxx:20: > /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreDirectory_Impl::create(store::OStorePageManager*, rtl_String*, rtl_String*, storeAccessMode)’: > /home/sbergman/lo/core/store/source/storbase.hxx:237:23: error: potential null pointer dereference [-Werror=null-dereference] > m_nUsed = rhs.m_nUsed; > ~~~~^~~~~~~ > /home/sbergman/lo/core/store/source/storbase.hxx:236:23: error: potential null pointer dereference [-Werror=null-dereference] > m_nSize = rhs.m_nSize; > ~~~~^~~~~~~ > /home/sbergman/lo/core/store/source/storbase.hxx:235:23: error: potential null pointer dereference [-Werror=null-dereference] > m_nAddr = rhs.m_nAddr; > ~~~~^~~~~~~ > [...] > [CXX] store/source/storlckb.cxx > In file included from /home/sbergman/lo/core/store/source/storlckb.hxx:29:0, > from /home/sbergman/lo/core/store/source/storlckb.cxx:20: > /home/sbergman/lo/core/store/source/storbase.hxx: In member function ‘storeError store::OStoreLockBytes::readAt(sal_uInt32, void*, sal_uInt32, sal_uInt32&)’: > /home/sbergman/lo/core/store/source/storbase.hxx:595:26: error: potential null pointer dereference [-Werror=null-dereference] > return isA<U>(p) ? static_cast<U*>(p) : 0; > ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351> "NULL dereference warnings" looks like this is a known problem. Change-Id: I5eb0c9def7dd12e3a440d280e3fa2331317031b4
2016-09-12coverity#1371323 Missing move assignment operatorCaolán McNamara
Change-Id: I806cb0a1ede9c025c00fab58a3fd8835887c0a44
2016-09-12this doesn't need a virtual dtorCaolán McNamara
Change-Id: I5c628a063fb5309f493729ee4bd7b122a3d2c3d5
2016-09-12coverity#1371178 Missing move assignment operatorCaolán McNamara
Change-Id: Ib7df699269bcacd5dbf64662c47b538aee9235a5
2016-09-12impress: extend dumpAsXml to table cell and stylesNoel Grandin
Change-Id: If11ca945cae4f5127394dcc3871f4b6a76c24fac
2016-09-12sw: emit LOK_CALLBACK_VIEW_CURSOR_VISIBLE as part of registerCallback()Miklos Vajna
Have a graphic selection (and thus a hidden text cursor) in the first view, create a second view. The view text cursors should be hidden in the second view as well. Change-Id: Ic22db84aab62c8f43c2da3d4a19b56c993c9f012 Reviewed-on: https://gerrit.libreoffice.org/28836 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-12sw: partially revert commit d0b09f41efe938e94a84e783c9ff5742edcbfba8Michael Stahl
These still trigger sometimes in JunitTest_toolkit_unoapi_1 and i haven't had time to track that down, so back to SAL_WARN for now... Change-Id: I4d9f653ffddc7c704d33950d847345f4895d3f87
2016-09-12Indentation fixesMiklos Vajna
Change-Id: I78575ebd6b78b2f5873bcec6c8c46d941a92ceb2
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-06 19:45:18 +0000