summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-24Handle Tr vertical orientation before shapingKhaled Hosny
See https://github.com/behdad/harfbuzz/issues/355 (cherry picked from commit 5c617a811724a45dd8688869eeafac4c44f6a8aa) Change-Id: Ic82d74046980fae3e7a973fee90fe5bb4f2b8588 Reviewed-on: https://gerrit.libreoffice.org/35387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit 49eadd40b5f0de6fa97498d89f20118b996385d2)
2017-03-23sw lok: Use unique redline identifier, instead of array indicesPranav Kant
Use a static integer counter as identifier to each redline Change few unit-tets that was testing redlines by using a hardcoded array index. Instead use these unique redline identifiers now. (cherry picked from commit fe3007b013ac74760a6377387bebd15dbd23420f) Conflicts: sw/inc/docary.hxx sw/source/core/doc/docredln.cxx sw/source/uibase/uiview/view2.cxx Change-Id: I63aec3fc8ab10d0dad0c936600d16e96999a2bcd
2017-03-23sc lok: Edit annotation by idPranav Kant
Change-Id: Iaea08b7a31fab1a8c9b8edc193754821c6608c53 Reviewed-on: https://gerrit.libreoffice.org/35249 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 055d8821e664446b7e66b73970a324f765e35f9c)
2017-03-23sc lok: Delete cell note by IdPranav Kant
Change-Id: I97224afb4eb7af36abefd0c3b59ee07de7eaa601 Reviewed-on: https://gerrit.libreoffice.org/35247 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit fab4640bd3979352d6fde06decea1834f178f348)
2017-03-23sw lok: Notify when redline position is changed + unit testPranav Kant
Make RedlineNotification function a static member of SwRedlineTable class Reviewed-on: https://gerrit.libreoffice.org/35177 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 1eb69f6b9c78b19d3944c90c17ff8d498affc316) Conflicts: sw/source/core/doc/docredln.cxx Change-Id: Ifbd6014198838b1106e873c9563d215e95b3572d
2017-03-23sw: Simplify - no need to create a pointer herePranav Kant
Change-Id: I5c7d1d47f347b3ce8de6e2e4995da8724a464941 Reviewed-on: https://gerrit.libreoffice.org/35045 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 41c7ee5f0a3d0e128134665d709fd46e663fd373)
2017-03-23lok: Do not use UNO for fetching tracked changesPranav Kant
See inline comment for reasons. Also, move the SwRedlineTypeToOUString function as inline to same header file containing redline types. Change-Id: I9b4be4f104c095b2ccd8287d935347c81fd25974 Reviewed-on: https://gerrit.libreoffice.org/34950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit e6cca48bc9deb1049f8d501406269b71f91511ca)
2017-03-23lok: Create change tracking position tooPranav Kant
We want to expose change tracking comments to lok clients also. For this, lok clients needs to know the position in the document where the comment should be shown. Change-Id: I38794387cef3d11b5e0c1cfd0967408d8e54ded3 Reviewed-on: https://gerrit.libreoffice.org/34949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 9582fae07e9ea2df20a7265c62402180995c57da)
2017-03-23lok: Allow changing comment text of document redlinesPranav Kant
The id of the redline is optional. If not mentioned, the current redline is assumed to be the one whose comment text will be changed. Change-Id: Ia859de171603239a78f4bdef5eff0facd580d027 Reviewed-on: https://gerrit.libreoffice.org/34923 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit c3d1be64e882f7e0edd0e693b9f73a0556bcb003)
2017-03-23sw: Bin unused vectorPranav Kant
Change-Id: I948d07c178344b66ea91eddf5771dc65b3ea9d30 (cherry picked from commit 09b56c34fa6651083c7b2a2973c7ca3986d7a50b)
2017-03-23lok: Listen to change tracking related commandsPranav Kant
Change-Id: Ieafd31342b356d7e95e4321cc49580b57f32e5be (cherry picked from commit 67dad2676dbbe1557f51a4fb16975499c16829f5)
2017-03-22lok sd: Fix crash when searching.Jan Holesovsky
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the check for the HasView has been removed. Turns out that there are conditions when this really can happen, leading to crashes in the LOK searching. Unfortunately I did not manage to find a reliable reproducer to create a unit test :-( - so I suspect this commit might be more a workaround than a root cause fix. Would be great to find out the exact conditions leading to the situation when the EditEngine does not contain the EditView, and evaluate this fix against that - but that's hard without a reliable reproducer. A unit test for this fix is missing from the same reason. The unit test from ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes. Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
2017-03-20lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e
2017-03-18Bump version to 5.3-1cp-5.3-2Andras Timar
Change-Id: I92462b715c59f606bc116a4338e368b3c589bc51
2017-03-18tdf#106001: Clamp CharScaleWidth outliers when exporting to DOCXAron Budea
Atribute is of type ST_TextScale, which has to be between 1 and 600. Change-Id: I9b9cddc47d194f1364d91675c9b825752b2f5e06 Reviewed-on: https://gerrit.libreoffice.org/34713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit a3a0eac099831de6fd7c53b66f85b964e41a5a13) Reviewed-on: https://gerrit.libreoffice.org/35335 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit e35f5ceefd586f03ace4cb3909bf5dd46007f49b)
2017-03-18Revert "Don't package unoinfo in case of Mac OS X like app structure"Stephan Bergmann
This reverts commit 3a663f7a4580b97518aee4e0c797b549c67ef1a5. Whatever that commit was supposed to be good for, not packaging unoinfo on macOS breaks functionality, see e.g. <https://bugs.documentfoundation.org/show_bug.cgi?id=106292#c10> comment 10 to "XMessageBox#execute() in Java fails to draw a window on macOS Sierra". (cherry picked from commit 3e5aa33ef4ea8f5839e358dd62acdc09fe64dda8) Change-Id: I51cb79d157887bfcaf2dce6900675439d33d0be0 Reviewed-on: https://gerrit.libreoffice.org/35314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit b0c3d69c7e763048270bb39ff1dc29f563d2cc0f)
2017-03-17lok: It's not that important to skip some of the messages.Jan Holesovsky
More important is always to perform the paint. Change-Id: I392dd6cea4a5f43a646fca04d284b365b5fb5b78
2017-03-17the range should be updated after the references, tdf#104026Markus Mohrhard
Change-Id: I2cb674b8b3bc64df031b473b337d266a2eaab43d Reviewed-on: https://gerrit.libreoffice.org/35289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 3f0f35c89f3f64fcb110483fd562a59f729dc344) Reviewed-on: https://gerrit.libreoffice.org/35297 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 0ee960fb555deb0a91e8c0e81812ab888ff13c2f)
2017-03-17tdf#105729 RTF import: \ltrpar should not override \qc from styleMiklos Vajna
This is similar to commit 92fd894ea18672cba4cf961bdc4c0bc98f168102 (tdf#94435 RTF import: \ltrpar should not override \qc, 2015-10-05), except that here the \qc is inherited from the style, it's not a direct formatting. The problematic code was added in commit 2638faa2e834c2da4c195224fd88d32c29b3d0cc (writerfilter08ooo330: applied patch for writerfilter08, 2010-07-28), and it's not really clear to me what is its purpose, given that the DOC import equivalent in SwWW8ImplReader::Read_ParaBiDi() doesn't set the paragraph alignment. Fix the situation by not touching the paragraph alignment for the RTF case at least. (cherry picked from commit 2cc5f18d10cf6ef1349d9518e6f67977f7c5d9bf) Change-Id: I2baa2c8c8012d972740da7cf3f710117812859b3 Reviewed-on: https://gerrit.libreoffice.org/35190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit b5c4e120540053d0cb737720503cb7038f12d5bd)
2017-03-17Resolves: tdf#102777 broadcast SC_TAB_INSERTED when inserting scenarioEike Rathke
So ScViewData::maTabData gets an entry added which deleting the scenario can remove again. (cherry picked from commit 4c8059a3e140171399ac85ceb882d23bb458599d) Change-Id: I166baeff5408ef67faef41364515a13b8d4610bb Reviewed-on: https://gerrit.libreoffice.org/34942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit d846a0d7643cf32a43069d9beb3a419a5a4af9f4)
2017-03-17tdf#103931 DOCX import: fix lost section breakMiklos Vajna
When there are multiple sections in a document, every <w:p> element triggers a handleLastParagraphInSection() call, and that's how the previous section is ended and the next one is started if necessary. In case the section contains no paragraphs at all, the section was lost on import. Fix this by also calling handleLastParagraphInSection() on <w:sectPr> as well. It's not a problem if there are both <w:p> and <w:sectPr> in a section (which is the usual situation) as only the first call closes the previous section / starts the next one. (cherry picked from commit 6603947329a7b372a173a3c60e013e532d0bc5cf) Change-Id: I64f2c403dcb2ceca76d444ab06df3052235d2795 Reviewed-on: https://gerrit.libreoffice.org/34718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 1e88c10327642e6867db5708e3fd0fb7065bc74c)
2017-03-17tdf#106466: Use graphite2 shaper firstKhaled Hosny
We want to always prefer Graphite shaping when supported by the font, which is also what HarfBuzz does by default. Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655 Reviewed-on: https://gerrit.libreoffice.org/35046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 3cee50476e422e3ed84169cdcbe6bd9883fc9316) Reviewed-on: https://gerrit.libreoffice.org/35058 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 68b546b17afa0082862f2a20b8f089ae9124a16a)
2017-03-17ofz#877 reference to stack alloced obj outlives objCaolán McNamara
(cherry picked from commit ae174b009bcf0f84073b9ebbf01ad31b274b789e) Change-Id: I8c854e2f651f8bf0018e8249827aae0fe23057e7 Reviewed-on: https://gerrit.libreoffice.org/35271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 037069698c6aa78a3509c0527b0bd00c412ba735)
2017-03-17Resolves: tdf#106557 don't crash on missing line spacing argumentCaolán McNamara
this is all a bit addled, but at least don't crash Change-Id: I19c35205446cebc83b8299839bcab8e02ff7c07d (cherry picked from commit ab10f03ec4dc7d5d7659fb62c59972c80221f733) Reviewed-on: https://gerrit.libreoffice.org/35261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit d0b73f86c667e3637cc439868cb84e7182d98786)
2017-03-17ofz#876 avoid accessing empty rowsCaolán McNamara
(cherry picked from commit b9892037c303e645ee1a987d80734361700d91ac) Change-Id: Iba539fb03611bbe5627cc7976c1146d08a2ab5fd Reviewed-on: https://gerrit.libreoffice.org/35256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 8d28a387172ed36c7c06b377bbc7041ec0b825d9)
2017-03-16Following tdf#106190 Treat blank after fraction barLaurent Balland-Poirier
To consider that denominator is found (bDenom=true) there must be some digits found after fraction bar Dummy format # ?/ ? can now work again (even with blank as thousands delimiter). However such format can not be saved (except in XLS) Change-Id: I657e97e09a6ae4c08a29ad6d0b586c85a9968e3d Reviewed-on: https://gerrit.libreoffice.org/35111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4e1448d43e08d3f0a6ff67e75346e9559ad2af09) Reviewed-on: https://gerrit.libreoffice.org/35196 (cherry picked from commit f1a108f4dfd3d82dd39a9606f54a25a076ac516d)
2017-03-16don't forget to set the managed flag, tdf#105544Markus Mohrhard
Change-Id: I46d534a157b05ce22ba42e269ca8266e3403ecd2 Reviewed-on: https://gerrit.libreoffice.org/34229 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0b9e33cceb635cd3c173bd1f461af98cfd6f6ed2) Reviewed-on: https://gerrit.libreoffice.org/35182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit d9128bc895bfa9740cd85c766a10217e35aaa937)
2017-03-16tdf#106271 Cannot disable Menubar under UnitySamuel Mehrbrodt
Empty the global menu when the user wants to hide the menubar. When showing it again, the global menu is refilled. (cherry picked from commit f2fa5951bf3d02439a3e96d1f9d89962f0901edc) The following commits have been squashed into this commit: 1. Destroy menu widget when enabling Unity integration Like GtkSalMenu::ShowMenuBar did before f2fa5951bf3d02439a3e96d1f9d89962f0901edc ("tdf#106271 Cannot disable Menubar under Unity") Should fix https://lists.freedesktop.org/archives/libreoffice/2017- March/077225.html (cherry-picked from commit 27f89f08cf4086802ce67f12389414bef6ab64ca) 2. Don't use SetDisplayable when enabling Unity mode because now it tracks the global menu too, but all we need here is to hide the in-window menubar widget. (cherry-picked from commit 3daa6c66eb9a4c334d6f72a8fd4bb09d7360a913) Change-Id: I3c5e17100622cd8d22c4348cf90a76233dd0fd4c Reviewed-on: https://gerrit.libreoffice.org/34919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 449733a5c3b59c7b56db1db3dbc7fd0dcefd1a55)
2017-03-16Related tdf#54443 List only matching JREsSamuel Mehrbrodt
I.e. show only 64bit JRE for 64bit LO and 32bit JRE for 32bit LO Change-Id: Id5e890637c7e1014bcb4e6fdd9ed9a33765112d5 Reviewed-on: https://gerrit.libreoffice.org/35026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9143dd4ebe37b608e43d04434cf831624bf55b65) Reviewed-on: https://gerrit.libreoffice.org/35162 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c8f0a37ff804e6329b21a4b7bfabb0667263c6e5)
2017-03-16fix conditional format import from XLSB, tdf#105486Markus Mohrhard
Change-Id: I2b781f45221e434c8ec0ee079afb54c505faf2b5 Reviewed-on: https://gerrit.libreoffice.org/34396 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit aaea9beabcdfa16ffd36116591c5ebea25906b94) Reviewed-on: https://gerrit.libreoffice.org/35154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e237c0109c94da27715c115cecee69d382d6c183)
2017-03-16tdf#106456, don't try to use invalid ranges in external ref codeMarkus Mohrhard
Change-Id: I38e622df87dd4b5e37dd248c5181978e13890fda Reviewed-on: https://gerrit.libreoffice.org/35132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 951fcc6556346e19a028443c70dea27d0cbc9c36) Reviewed-on: https://gerrit.libreoffice.org/35180 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 20bcaeb0f8509e4b12d72d4612b5f3c9bfde3489)
2017-03-16string access out of boundsEike Rathke
This is a combination of 3 commits. string access out of bounds Change-Id: I4f6e6e8e77cdabe593bca5719b6ef38aeecc5da7 (cherry picked from commit 77a8cf7eaf638276030d1c5be8705f5603f071a9) prevent string access out of bounds Though only the closing 0-character and the following check excludes that, dbgutil asserts. Change-Id: Ife1299042a60f6f058c4cf58b406d1cc022786a7 (cherry picked from commit c407fff205a270e02fe07885805b7250e71c28f8) guard against a (theoretical?) endless loop of blanks only Change-Id: I68d6cca1b359aa8fba42663bddb1107c31102415 (cherry picked from commit fe73eff36718b6d99d0cf92d750c457872cc4dcc) Reviewed-on: https://gerrit.libreoffice.org/35043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 0f7a1bce18b08045fd98d5de99bb9ed69a7d474d)
2017-03-16Resolves: rhbz#1431540 crash in SwDBManager::releaseRevokeListenerCaolán McNamara
Change-Id: I8e61163de7e6192bdf613ab6b58906326499d6c2 Reviewed-on: https://gerrit.libreoffice.org/35137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e1f36eddf4596901a51de42322ccbf8d1df9d139) Reviewed-on: https://gerrit.libreoffice.org/35138 (cherry picked from commit 445b719b8bbff9181cea3601649bb21c27acd7b5)
2017-03-16rhbz#1431476 dnd has started copying instead of moving slidesCaolán McNamara
Is suspect something has changed in gtk3, and I think we're not supposed to use gdk_drag_drop_succeeded at this point, but instead we'd get a dragFailed signal on the failure case Change-Id: I6b305db56a29255b468ca9182d1f7e57cb4c10f4 (cherry picked from commit 4ea76db5e53235971b597a2810a6d12618d6aaea) Reviewed-on: https://gerrit.libreoffice.org/35135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 3a4d2433fbf2ef6f41b82482ea99ed79fb2d6735)
2017-03-16ofz#829 ensure palette can fulfil largest index usedCaolán McNamara
Change-Id: I95aa4796875ee71e8b06a2bb8985845f270b8817 Reviewed-on: https://gerrit.libreoffice.org/35104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 71f095d734c93e22279c2ab8afe788182eb5bdbb)
2017-03-16ofz#820 oom terminateCaolán McNamara
comments claim return is len of data, but negative numbers for compressed data errors are returned. Make things return the amount of successful data read and turn into unsigned size_t to match ofz#727 Change-Id: Iadddfae67bb5d4960ddf82e169fc2592ded85950 Reviewed-on: https://gerrit.libreoffice.org/35078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 4a7e226fa4bb5fe5e94a7cc5883b1747a4fd716b)
2017-03-16Resolves: tdf#106459 3D reference can't be handled as vector referenceEike Rathke
Change-Id: Icba12a6218086079a7d5538f7263bccb1f2ee1b0 (cherry picked from commit ca1f051972946b24cb6658143fb0d0ac3587a988) Reviewed-on: https://gerrit.libreoffice.org/35051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit b16868ab2f7f3f0e09d68faba75d16fff1d851c1)
2017-03-16ofz#801 avoid oomCaolán McNamara
Change-Id: Id3167d1eb3f058543ab7596008012d51b3d242b7 (cherry picked from commit 1353ebe535732022aef4377030d86ad7153c3144) Reviewed-on: https://gerrit.libreoffice.org/35036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 7dc65a1e0ff3059bc1f7ab77c302930e61f72831)
2017-03-16ofz: turn assert into throwCaolán McNamara
cause size arg is controllable by the file data Change-Id: Ia92b56c04271557afbec1ab47620bcb34f1c0e8a (cherry picked from commit 1e8d00719c851d69d36cd66eb115c517c1696b64) Reviewed-on: https://gerrit.libreoffice.org/35083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 562a13c8d2325f7cb80c61f198c87b98d8922e63)
2017-03-16Collabora Office: hackish fix of repaint problem of vcl widgetsAndras Timar
Change-Id: Ib0eaba0767ff18d03464ba7d1ec1ffdd2ba3ca78 (cherry picked from commit 55066180e80b77cdf8520b11cc60dec73c6e0d58)
2017-03-14tdf#106270 vcl PDF import: use BitmapWriteAccess::CopyScanline()Miklos Vajna
This requires one function call / row only, cross-platform and works with OpenGL enabled as well. Change-Id: I12fd0f52a1a7e8e683b50071ded95f63fecc4d40 Reviewed-on: https://gerrit.libreoffice.org/34774 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f1d6f202e2b8ff555cedde6315685342325b16fc)
2017-03-14tdf#106206 PDF export: fix unexpected /Im0 in page contents streamMiklos Vajna
The early return should just skip the code that's specific to pdf images, not everything. Change-Id: Ia9e02b05051a085a9fdf2f690c21f9ffccb7bf4d Reviewed-on: https://gerrit.libreoffice.org/34685 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit e7adffff8039175bc50b56b4c07ce0b9d8fed629)
2017-03-14tdf#105093 vcl PDF export: add embedded video testcaseMiklos Vajna
Fails with commit 4ad249af88d15f2c8a09f0721a59d82718fcc201 (tdf#105093 sd PDF export: handle embedded videos, 2017-01-04) reverted. Change-Id: I413ec9a5da3c0783541dcd28fb9a62dd896f955b Reviewed-on: https://gerrit.libreoffice.org/34681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 64bac5c0f005afd46bbf402c5d548e2ee6c9e5c4)
2017-03-14xmlsecurity PDF verify: fix parsing of nested dictionariesMiklos Vajna
This is triggered by an upcoming unit test for tdf#105093. Change-Id: I3c8e8662fcadaea1f6e19bf6194d8159916f368b Reviewed-on: https://gerrit.libreoffice.org/34678 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit a9a9b8155f65421fa8cb2bf108b847f212462f4f)
2017-03-14tdf#105461 vcl: add text highlight textcaseMiklos Vajna
Fails with commit ee32c7d8083ae1449d6b379034be92995c142da9 (tdf#105461 PDF export: handle text fill color, 2017-02-01) reverted. Change-Id: I3628a16d0810e3be3fb352340d06cdba472dcd3f Reviewed-on: https://gerrit.libreoffice.org/34621 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4e203ca3915e0cee2e7e02b95e78b3f5a8870098)
2017-03-14the test implicitly requires pdfiumMarkus Mohrhard
Attempt to fix build issue found by "RandomCondig" tb build #244 Change-Id: I8b6a0a3d0f812a3220fb0d7d21318871454f7eca Reviewed-on: https://gerrit.libreoffice.org/34646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 89b64e865bfb6739be07d1fb0b5dfa5fa3651a44)
2017-03-14vcl: add initial CppunitTest_vcl_pdfexportMiklos Vajna
Invoke the PDF export filter and then use the PDF tokenizer from xmlsecurity to assert the contents of created PDF file. The testcase fails with commit 6db0f1feb1d9931d2726dd11a889c58815710ce0 (tdf#106059 PDF export: create a reference XObject for PDF images, 2017-02-22) reverted. Reviewed-on: https://gerrit.libreoffice.org/34609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 58eac1105f8504bd5320911fc6fe967ccaa3d469) Conflicts: vcl/Module_vcl.mk Change-Id: I90526fef41d9560ae447f586df766bc50a491c43
2017-03-14xmlsecurity: various small cleanupsMiklos Vajna
Reviewed-on: https://gerrit.libreoffice.org/33779 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 68c58b46918bb377a8d37a3cd1c9a9ba734390f1) Conflicts: xmlsecurity/source/helper/documentsignaturemanager.cxx xmlsecurity/source/helper/pdfsignaturehelper.cxx Change-Id: Id713460036331fd9f98fd1eca85ca61f57cf5afe
2017-03-14loplugin:subtlezeroinit: xmlsecurityStephan Bergmann
Change-Id: Ife06c74e1665273350b497a1a584d7f76297c13d (cherry picked from commit 7dedccd06d5c822b6bcaeba81753ca9e75fad376)
2017-03-14xmlsecurity PDF verify: handle multiple startxref in the last 1024 bytesMiklos Vajna
Usually this is not a problem, but it's easy to construct a document manually that contains multiple startxref tokens at the last 1024 bytes. Make sure we read the last of those, not the first one. This is triggered by an upcoming unit test for tdf#106059. Change-Id: I94fbb5d407c4a03b7c2c6e207200127bb374e750 Reviewed-on: https://gerrit.libreoffice.org/34607 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 7737457558cafe35c2efe613b4be8ad7abe50dea)