summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-05-02Revert "SwTOXTypes can just be a std::vector typedef"Noel Grandin
This reverts commit f894da4e687302702d14218138f96ed1c4983124. the default behaviour of SwVectorModifyBase is to free the elements in it's destructor Change-Id: I7a34fe5cc3cb8ffbcbb92068f4bb816dfd9acd43 Reviewed-on: https://gerrit.libreoffice.org/37168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02Add more unit tests for Date::Normalize()Eike Rathke
Change-Id: I013317bfa9dad02194177cca0907b0ffbb171ccd
2017-05-02Date::Normalize: handle day 0 and empty dateEike Rathke
* Empty date (initialized with Date::EMPTY == all 0) stays empty. * Day 0 is normalized to the last day of the previous month. * Day 0 AND month 0 is also normalized to the last day of the previous month (and not the last day of the previous-1 month). * Before, * all day 0 cases weren't handled at all and day 0 stayed day 0, which doesn't make sense in a Normalize() context * empty date wasn't detected and resulted in nonsense date -0001-12-00 Change-Id: Ib12ff7694e1adb17724af038a266f6f284285f36
2017-05-02Test that empty date is not a valid dateEike Rathke
Change-Id: If5f2db3d4bae9158b482b01ce7dbb7335b4cb16b
2017-05-02tdf#91820 Add design mode and image original size to menuYousuf Philips
Change-Id: Ie5462446fee738c11f944bc2dab7da6f6a454954 Reviewed-on: https://gerrit.libreoffice.org/37032 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-05-02tdf#107455 Fix accelerators in the Slide menuYousuf Philips
Change-Id: I89eae1da902ccb64247eb294450bc300d055ece0 Reviewed-on: https://gerrit.libreoffice.org/37034 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-05-02Date::IsValidDate: year 0 is notEike Rathke
Change-Id: I44e476f354d04a1d070a7348e3b00d75497231c2
2017-05-02Revert "SwFieldTypes can just be a std::vector typedef"Caolán McNamara
This reverts commit 5eaad8eb1d46b6f85605c5ac210e8b1397b18b22. cause it now leaks as the ~SwVectorModifyBase base deletes the entries Change-Id: I02374f4b439b9cf3e8f331aa9c6892b4418f37f0
2017-05-02ofz fix leakCaolán McNamara
Change-Id: I237f19f237e6b78f98798352c1f881b0d27a6a9e
2017-05-02fix indentCaolán McNamara
Change-Id: Ic949efdb47861770e9e333e154ede54d7fa88e50
2017-05-02tdf#39468: Translate German comments in sw/source/core/text/txthyph.cxxJens Carl
Change-Id: I55df1deaf3a44bb8be0225756761da2f7d2667aa Reviewed-on: https://gerrit.libreoffice.org/37095 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-05-02SbiRuntime::isVBAEnabled() needs to be guarded with #if HAVE_FEATURE_SCRIPTINGEike Rathke
Change-Id: I7fab0c946c13a9779fad05f88be6ae6a9da93775
2017-05-02tdf#39468: Translate German comments in swJens Carl
Translate German comments and terms in: sw/source/filter/html/css1atr.cxx sw/source/filter/html/htmlfld.cxx sw/source/filter/writer/writer.cxx Change-Id: I05228ea5369e0d1e7f06158dc5369ba89284c2c9 Reviewed-on: https://gerrit.libreoffice.org/37093 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-05-02BASIC: handle the full tools::Date range from -32768-01-01 to 32767-12-31Eike Rathke
* Input of two-digit years only possible through CDateFromIso() though to maintain compatibility with previous behavior and also VBA mode. * VBA mode restricted to years 1..9999 Change-Id: Ia9574c3bf136619b4831b349d263c96b162d1ed4
2017-05-02Removed duplicated includeAndrea Gelmini
Change-Id: Ie341ead5b40bdeed25205e31203a5fa861ff0f42 Reviewed-on: https://gerrit.libreoffice.org/36981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-02No compelling reason for an unnamed namespace in an include file hereStephan Bergmann
Change-Id: Ib5660bde8108808a24c3863952bf6e0dfffaf288
2017-05-02ODR violationStephan Bergmann
Change-Id: Ic442d59c3066b7de8280d5719dd4da806b7a8092
2017-05-02Adapt to Clang 5 change of PPCallbacks::MacroUndefined signatureStephan Bergmann
...since <http://llvm.org/viewvc/llvm-project?view=revision&revision=301449> "PPCallbacks::MacroUndefined, change signature and add test." Change-Id: I6a420dc4ca33607fef1356e8869cedee87192e93
2017-05-02Adapt bin/gen-boost-headers to Clang 5Stephan Bergmann
...since <http://llvm.org/viewvc/llvm-project?view=revision&revision=301647> "Use the -Wunknown-warning-option group for the 'unknown warning group' diagnostic in #pragma diagnostic". * external/boost/include/boost/{locale.hpp,locale/gnu_gettext.hpp} would have been removed by 'make cmd cmd=bin/gen-boost-headers' as they are still unused from c25eee44966703cb27d632bccb39b20978341ffd "build boost::locale library", but there's reportedly a patch in Gerrit to actually use them, so I fixed them manually for now. * The deviating comment style is to keep lines no wider than 80 characters. Change-Id: I64603ae8d8a82781eda46f12c9dd5c68dcf395b9
2017-05-02printerinfomanager.hxx can be moved into vclCaolán McNamara
probably was exposed while padmin was still a thing Change-Id: I9605b7ae0c5bc59aa998580f5a28dc7b527219e9
2017-05-02loplugin:checkunusedparams in frameworkNoel Grandin
Change-Id: I963159550da9d735bb70636917ecc290744298b4 Reviewed-on: https://gerrit.libreoffice.org/37142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02bin/gen-boost-headers: Don't stumble over "boost" in pathnameStephan Bergmann
...like workdir/UnpackedTarball/liborcus/m4/boost.m4:#include <boost/version.hpp> which would then be mis-parsed by grep -o '\bboost.*\.\(h\|hpp\|ipp\)' to a HEADER of boost.m4:#include <boost/version.hpp instead of just boost/version.hpp (-h is a non-standard GNU grep extension, but so is the already used -r. An alternative fix would be to replace the later grep -o with something like grep -o '\bboost[^#]*\.\(h\|hpp\|ipp\)' instead.) Change-Id: I0b41ed520b2fed70e8982abc0e84a34804c02549
2017-05-02tdf#106359: missing leading dotMike Kaganski
Change-Id: Ibfcbeb0778d9000dad8097384d7f5c7d75be2252 Reviewed-on: https://gerrit.libreoffice.org/37152 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-05-02test to see if we have enough space without thisCaolán McNamara
Change-Id: I83c1d83bc3c34e32f3d4564322a5df871d8b73b5
2017-05-02add ww6 fuzzerCaolán McNamara
Change-Id: I7e84f29b321676c373f86acba375816a0e9ad386
2017-05-02tdf#105703: Restore user-defined motion paths for animationsKatarina Behrens
Yet another fallback from Google Summer of Regressions. The rest of the functionality has been removed by loplugin and other hyperactive code cleaners, so I've restored it, mostly unmodified. Change-Id: If0576abe9ce86c6f939d54bcf8f872dfce131e68 Reviewed-on: https://gerrit.libreoffice.org/37138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02untranslated strings are just stringsCaolán McNamara
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02Resolves: tdf#99467 pasting text from java apps to gtk3 gives bad resultsCaolán McNamara
Change-Id: Ib2625c900def20baa470f0a15e4f72a3f763099e
2017-05-02loplugin:checkunusedparams in ooxNoel Grandin
Change-Id: I95bce82654bd0da7ed76ebd22b107b870ed15a1f Reviewed-on: https://gerrit.libreoffice.org/37144 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in hwpfilter..lotuswordproNoel Grandin
Change-Id: I4925a95cc74571c2e0ffd413d7ac8bc162c247d7 Reviewed-on: https://gerrit.libreoffice.org/37143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02sw: prefix members of SwLayHelperMiklos Vajna
Change-Id: I6beec3d0083f6b2f4055b7cffe9c59a630a89261 Reviewed-on: https://gerrit.libreoffice.org/37135 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-02loplugin:checkunusedparams in basctl and basicNoel Grandin
Change-Id: I077ce96aed3c79045d5e8438109a8b1690ff1218 Reviewed-on: https://gerrit.libreoffice.org/37062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in forms..formulaNoel Grandin
Change-Id: Iacd973b97fccda217c691cca0a8f440640ff7a0b Reviewed-on: https://gerrit.libreoffice.org/37140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02tdf#77816 Duplicate dlg: enable fractionnal angleLaurent Balland-Poirier
In Duplicate dialog of Draw: Count angle in 100th of degree Change-Id: If1af9a42e7c35d39edbdc3fa624489d7e38b42e1 Reviewed-on: https://gerrit.libreoffice.org/36816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02unused wizards basic file and dialogCaolán McNamara
Change-Id: I56e82ab480b33d3205516e371302b1a091678e22
2017-05-02revert 'tweak for pdfiumless build'Caolán McNamara
commit 8d747b8cf849b7d705048544ac20eceba7eb5a45 Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Apr 29 20:01:40 2017 +0100 tweak for pdfiumless build and lets see if commit 6f53cf281eb3c13fc516ff79decb70b2a87a96d0 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Sat Apr 29 05:11:40 2017 +0200 apparently the executable does not need pdfium directly anymore is sufficient here Change-Id: I2bf381e1d51d851aa829730b3d13edb1c03ea873
2017-05-02Updated coreOlivier R
Project: dictionaries c82ad83da55f7c0d4667edea003b8038e473dcd1 tdf#107558 French spelling dictionary (6.0.3) and thesaurus Change-Id: Ia3da9c3b2e4a0ca1032edad131838b3a705e0597
2017-05-02Fix typos in color namesGabor Kelemen
Change-Id: I6d26b17a3fa51f6ff16fa1968b5ce445e949f43d Reviewed-on: https://gerrit.libreoffice.org/37128 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-02loplugin:checkunusedparams in extensionsNoel Grandin
Change-Id: I1ea1a43da45039fc5d62f21e83c216461abf99de Reviewed-on: https://gerrit.libreoffice.org/37134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02Don’t mark any field without strong LTR text CTLKhaled Hosny
Regression from e3b7ef45d4364fda15691b5748a9a88bc908afc6 which removed the condition this block was implying, so putting it back here. This should fix Jenkins_Callgrind tinderbox, we probably should have some unit tests based on the file from [1] and [2], but I don’t know how… 1. https://bz.apache.org/ooo/show_bug.cgi?id=89825 2. sw/qa/extras/ww8export/data/tdf91083.odt Change-Id: I88ad2564908b3a269e95d1969366c8506801818b Reviewed-on: https://gerrit.libreoffice.org/37050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-02tdf#107204: Make sure we always do Unicode Bidi, take twoKhaled Hosny
[ Now that the side-effect will be fixed by <https://gerrit.libreoffice.org/#/c/37050/>.] Writer seems to have an “optimization” that only applies bidi algorithm if the text direction is nor LTR and there is some characters that we classify as complex script. This is a very simplistic optimization as evidenced by the bug above. We certainly don't want to skip bidi the text differently based on the default direction (whatever that means), and not all RTL scripts are complex ones, even if they are we might be behind Unicode in our script classification. Just trust that bidi algorithm does the right thing and don’t do premature optimization. If this turns out to be a real performance issue, we will need to find a better optimization. Change-Id: I276e2ae0ac92fb51d2e37ef2ad0b11efc6b441ef
2017-05-02AutoText: read names of entriesSzymon Kłos
+ extended model to parse <docPartPr> and <name> marks + names are inserted to the document before content of each entry + SwDOCXReader interprets first paragraph of each section as a name Change-Id: Ib7de152ba1c6bea4f4665f98d321019c3f68863e Reviewed-on: https://gerrit.libreoffice.org/37124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-02Revert "tdf#107204: Make sure we always do Unicode Bidi"Miklos Vajna
This reverts commit e3b7ef45d4364fda15691b5748a9a88bc908afc6, as it breaks the testTableKeep part of CppunitTest_sw_ww8export on the Jenkins_Callgrind tinderbox (and also for me locally) and there is no fix in progress to address that. See the bug for a comparision of the old/new layout for the problematic testcase. Khaled says it's OK to push this revert till it's clear how to fix the bug without side-effects. Change-Id: I669de98ffa8b519024e332ae468808d7e7243df2
2017-05-02loplugin:checkunusedparams in cppcanvas and dbaccessNoel Grandin
Change-Id: Ia66e6326f3d1750b4e46a3f9f7127e7ed4aa99ca Reviewed-on: https://gerrit.libreoffice.org/37068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in drawinglayerNoel Grandin
Change-Id: Ib497b284a80fae69930f226d2e70368cb9e962ef Reviewed-on: https://gerrit.libreoffice.org/37072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02create SfxGroupId based on o3tl::strong_intNoel Grandin
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71 Reviewed-on: https://gerrit.libreoffice.org/37108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02SwFieldTypes can just be a std::vector typedefNoel Grandin
Change-Id: I10b43a71c8cedc6efbb30056d3da7fd431f04791 Reviewed-on: https://gerrit.libreoffice.org/37121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#107145 display applied filters for page field in pivot chartTomaž Vajngerl
Add field output description which shows the description of the filtered output, which can be either "- all -" when nothing is filtered, "- multiple -" when multiple values are outputted or the specific value - the only value remaining. Change-Id: I8fca6050dabba9878e9f3a31e4be7a03e3b87467 Reviewed-on: https://gerrit.libreoffice.org/37125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-01tdf#107526: fix icon managementJulien Nabet
by following http://opengrok.libreoffice.org/xref/core/vcl/inc/svdata.hxx#91 Change-Id: I57d13e33c31f25580c93ef2abfec78e9386a8c04 Reviewed-on: https://gerrit.libreoffice.org/37126 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>