summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-07-20external: update pdfium to 5187Miklos Vajna
build.patch.1 is extended to avoid: > C:/lo/master/workdir/UnpackedTarball/pdfium/third_party/libopenjpeg/openjpeg.c(438): error C2491: 'opj_decoder_set_strict_mode': definition of dllimport function not allowed and also is extended to avoid: > /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/stl_tree.h:2028:5: note: no known conversion for argument 1 from ‘std::pair<fxcrt::RetainPtr<CPDF_Object>, std::unique_ptr<CPDF_PageObjectAvail> >::first_type {aka fxcrt::RetainPtr<CPDF_Object>}’ to ‘const CPDF_Object* const&’ Change-Id: Icacc05627a8612b33d6445685d26470e7c757b8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137238 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-20tdf#149915 Proper creation of vnd.sun.star.pkg:// URLGülşah Köse
Using different methods of creation (one using DecodeMechanism::NONE, another using DecodeMechanism::WithCharset) gave differently encoded end results, comparing unequal. The proper way is using DecodeMechanism::NONE on the document's URL, as implemented in commit 06756e412b2a02030ce3355b3fe4e2ecc71d2301 Author Mike Kaganski <mike.kaganski@collabora.com> Date Sat Nov 18 22:41:40 2017 +0300 One more proper construction of vnd.sun.star.pkg URL Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com> Change-Id: I272f277ef8b4bd23e6cb7884e68f3c79f742683a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136901 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-20ofz#48366 TimeoutCaolán McNamara
Change-Id: Id643e80696843e0c22ae7eee2b5862320948ae27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-20ofz#49200 TimeoutCaolán McNamara
disable slow path for fuzzing Change-Id: Ic23d7ba56210915b53b4330edb44458a672ba4ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137255 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-20tdf#92610 Fix missing/conflicting accelerators on Header/Footer tab pageGabor Kelemen
Change-Id: I54099745b1246b474d2f389b7c87abb18d944cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137241 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-20VBA: Add Select Method to ActiveDocumentHannah Meeks
Change-Id: I0d8d02c555fd113b96661085b339b12d83c6010f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137109 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-20VBA: Add test documents for vbaHannah Meeks
Mostly disabled for now pending core fixing Change-Id: Idf71cea820c52f2b56fb26b1d8de2666026bf90e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137105 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-20tdf#139759 doc import: import comment highlight/shadeJustin Luth
Round-tripping depends on earlier commits for this bug. These two attributes are SvxColorItems in EditEng, but SvxBrushItems in Writer. So direct mapping doesn't work. Although it might be a highlight, LO doesn't have such a silly duplicate thing in the editeng code. So just map this as the same thing used for normal char background. As of LO 7.x, we default to exporting as char background anyway, so highlight is on the way out in LO. P.S. Highlight is one of 17-ish colors. It is the background button in the Char panel in MS Word. Background is on Word's Para panel (even though it is a character property), and so it can fairly easily be removed in MS Word. Change-Id: Id25879d90ba4a0eeff2d6afed030fc029d1c1039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137239 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-20tdf#127236 vcl: fix missing encryption of PDF images during exportMiklos Vajna
Regression from commit 78e25558e86188314b9b72048b8ddca18697cb86 (tdf#106059 PDF export: create a reference XObject for JPG images with PDF data, 2017-02-23), once a PDF image was inserted to a document, an encrypted PDF export lost those images. The reason for this is that we started to preserve PDF images as vector data with the above commit, but this means we copied over PDF objects from PDF images to the export result as-is, so encryption was not performed for them. Fix this by separating the write of the PDF object headers, stream content and object footer and then calling checkAndEnableStreamEncryption() / disableStreamEncryption() for each object, even if it's not something our PDF export created but comes from a PDF image. Note that when existing PDF files are signed, PDF objects are also copied into a vcl::filter::PDFDocument, but such PDF images are never encrypted, so it's fine to have stub implementations in vcl::filter::PDFDocument. Change-Id: I2f74b9f51cd35b4319221532ca890e197bab9cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137242 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-20move wintypes.hxx from tools to vclChris Sherlock
Change-Id: Ief9949fd4252de9e33df172af07aa7ed097b5520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136560 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-20forcepoint#107: reproducible testcaseCaolán McNamara
make this reproducible without asan Change-Id: I32cee0a22616e96d85c59d76319a6f6074fcde8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136228 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-20tdf#149551 separate TextRotateAngle from TextPreRotateAngleRegina Henschel
The import filter had only one member for both and had it mapped to TextPreRotateAngle. That resulted in lost text area rotation when a shape had both types of rotations, and sheared text when only text area rotation existed. The patch introduces a new 'moTextAreaRotation' member for the 'rot' attribute of the <bodyPr> element. It is mapped to 'TextRotateAngle' property. It becomes the 'draw:text-rotate-angle' attribute of the <draw:enhanced-geometry> element for a shape and 'style:rotate-angle' for chart elements in ODF. It must also be used to simulate 'upright' and is used for the 'rot' attribute in <txXfrm> of diagram shapes. The 'moRotation' member is now only used for the 'TextPreRotateAngle' property. That angle describes a rotation of the text without changing the text area. Valid values are multiples of 90deg. It is used for simulating vertical writing modes that are not yet implemented. It has no corresponding attribute in ODF. To make the meaning clear in code, the member is renamed to 'moTextPreRotation'. MS Office recalutes a diagram on file opening from layout.xml and data.xml. That is not yet implemented in LO, but we use drawing.xml, which gives the state of the diagram at time of saving. The patch handles the 'rot' attribute of <txXfrm> element as well. It has to be mapped to moTextAreaRotation, because it might contain angles, which are not multiples of 90deg, for example diagram 'Gear'. The <off> and <ext> child elements of <txXfrm> describe the actual used text area rectangle. The existing import calculates the difference of the actual used text area rectangle to the predefined one and incorporates it into the TextArea*Distance attributes. The patch adds calculating the current values of the text area rectangle as it would be using the preset markup. At that time in import there is no SdrObjCustomShape object, thus we cannot use its GetTextBounds() method. So it is down manually, covering most of those types, which are used in diagrams of MS Office. Remarks to unit tests: Now the rotation introduced by txXfrm is no longer in TextPreRotateAngle, but in TextRotateAngle. According changes are in SdImportTest::testN86510_2 Test, testFdo87488 Now the correct preset text area rectangles are used. That requires adaption of the needed distances. Done in SdImportTest::testBnc870237() SdImportTest::testTdf93830() SdImportTestSmartArt::testTdf134221() The buggy 'upright' export is fixed. Adaption in ScExportTest2::testTdf137000_handle_upright() Change-Id: I79df1559f88b76e96988fe745304dc4162de6316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136447 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-20Remove pngwrite.hxx and .cxx as it is replaced by PngImageWriterofftkp
pngwrite is now replaced by PngImageWriter which uses libpng so these old files are removed. Change-Id: Ie91c314f30b8f56682890000b90009f408a79094 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137140 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19tdf#149439 set initial customoption values from lpoptions when presentCaolán McNamara
I presume there's a better way to do all this. Change-Id: Id7e6cd3be5b82e419f17bba31834fef7cfe8299b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-19Fix typoAndrea Gelmini
Change-Id: I1ad198827abb2b7a8fd9165deeb85c56c5c1c255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-19vcl: AInfo -> AnimationDataChris Sherlock
Change-Id: I4a4f8e2e346010edd1fde004eb9f14b67fc8487a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76407 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19tdf#149985: sd_import_tests2: Add unittestXisco Fauli
Change-Id: I0ce12e862ca90ab62da508820aecb3bce93445b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137235 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-19tdf#135794 sw: add no-headers to AllowCommentsInFootnotesJustin Luth
DOCX also doesn't allow comments in headers / footers so add that situation to the existing option that was attempting to improve DOCX compatibility. By default, comments are still allowed in headers. Change-Id: I5f9ee59cc0292e41e57ba46fa7cf41ac691acabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137210 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-19tdf#119840 reduce lines we need to scan in CompressRedlinesNoel Grandin
.. to start at the point we modified things. Reduces load time by approx 10% Change-Id: I37214247f0cb7b1246c498aba6c2085bf12a21aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-19tdf#119840 loop backwards in DocumentRedlineManager::SplitRedlineNoel Grandin
reduces load time by approx 20% Change-Id: Id1314ed640e54a104cfe26e4784c847f43ce64bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-19Don't compare using long in PngFilterTestofftkp
Change-Id: Ia6f0f7339e3e42acb2fe14eda914b21fc51b7d5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-19tdf#148913 sw: fix crash with pending infobars on WindowsLászló Németh
Usage of VclPtr<SfxInfoBarWindow> wasn't thread-safe on Windows, resulting random crashing during loading big documents. Regression from commit d89786054715b44aa983d0752484216825c74ae2 "tdf#125909 tdf#141298 sw: show (Hidden) Track Changes infobar". Change-Id: Ic6a6ad43a8cf7ea650ef6d1c0aa5c76c48763ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137230 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-19tdf#149170 sfx2: fix regression about spurious dialogMichael Stahl
Open a document that is locked, choose Read-Only, then click "Edit" on infobar: it is still locked, so a dialog pops up. Click "Cancel". Now a *second* dialog pops up that *again* asks if you want to open a copy of the document - this appears pointless so let's remove it. Change-Id: Id96a1211caea63e7559c67b08a6581d1a0ce9add Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137234 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-19Replace old png writer in pdfverify.cxxofftkp
Change-Id: Iee38f9e86151717001ec4e4c083ec658603ad7c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137139 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Remove unused pngwrite.hxx include in vcldemo.cxxofftkp
Change-Id: I8fe829eb34c07c2da47d93ef07f3dee098a9eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137138 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19tdf#119491 sc odf export: fix password protection of shared filesBalazs Varga
Handle SID_ENCRYPTIONDATA for shared password protected docs. Change-Id: If9554a991a39d6be45ed688a0bd638cd166589c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137146 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-19Replace old png writer in gtksalmenu.cxxofftkp
Change-Id: I6851d7a6c8bbd1fbb02b3ba74f46d13e1fd80223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137137 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in transfer.cxxofftkp
Change-Id: I1423bd4e7650da71f31de50df8a88ee3c09db33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137135 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in gtkinst.cxxofftkp
Change-Id: I5a9aefe1b957b800b5c56f3200d28ef727324cac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137136 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in OpenGLHelper.cxxofftkp
Change-Id: I028db48230fae64a539ee0a7964d73c039289740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137134 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in ImplImageTree.cxxofftkp
Change-Id: I26702462ec19056f33a582083e69630bec1fb3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137133 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in QtTools.cxxofftkp
Change-Id: I4f6438b811e7e97aedda90508423982cb82e0008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137131 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in svmtest.cxxofftkp
Change-Id: Iebd1dbf56fe4305871b9a091488ee5acd4f58814 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137130 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in baseindex.cxxofftkp
Change-Id: I660579ed6ea886f9ab3fc913b785f92740f48dc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137125 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in screenshot_test.cxxofftkp
Change-Id: I5271b56bcce32e1ce71544421b9581518b05455e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137124 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in sfxpicklist.cxxofftkp
Change-Id: I8dd9925ea07fa16cea6918eef0e6d468d7b743c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137123 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in SlsBitmapCompressor.cxxofftkp
Change-Id: Idc8ddcce918c5258f623f3b9065cfb523cb23629 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137122 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in imagemanagerimpl.cxxofftkp
Change-Id: I8bc30a218b67d165d1a8ae3d663e5482a8113aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137118 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in emfreader.cxxofftkp
Change-Id: Ibc3ed62d5d09d2da9d7866deb21f49340ba71eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137117 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in converters.cxxofftkp
Change-Id: I360963c2ad36a7bce5a257c9740b1e5690efc8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137116 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in test_desktop_lib.cxxofftkp
Change-Id: I9f73b316521bcacb9042375adef3a3339ab2166f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137115 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in screenshotannotationdlg.cxxofftkp
Change-Id: I21fbd95db7f8a9f036c5ecfbd08d7a46a9683dd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137114 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in emfplus.cxxofftkp
Change-Id: Ibdc550e55d73ed71def6e5aef129520ab2062eeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136936 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Replace old png writer in graphicfilter.cxxofftkp
Change-Id: I68b35e82fd5ca4de87b3b9c3c6be5cf802f071ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137132 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19vcl: allow OutputDevice::GetTextRect() cater for rotated fontsChris Sherlock
Change-Id: I52bdfe75ef1dd7973d14cad72e31a1e559bb7876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136667 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Fix endian-dependent test for goodStephan Bergmann
SvmTest::testComment introduced in e10df88b8ae4138862d4dd25c221189878641aa4 "Add Comment cppunit test to vcl" calls SvmTest::checkComment twice, first for a programmatically generated svm document, and then for the canned vcl/qa/cppunit/svm/data/comment.svm. 4f533655dd635dab30574c2a3b3915377124bd60 "this test is endian-dependant" had fixed the endian-dependent check in SvmTest::checkComment for the first, programmatically generated case, but broke it for the second, canned case. As seen on s390x: > xmltesttools.cxx:171:Assertion > Test name: SvmTest::testComment > equality assertion failed > - Expected: 00540068006500730065002000610072006500200073006f006d00650020007400650073007400200064006100740061 > - Actual : 540068006500730065002000610072006500200073006f006d0065002000740065007300740020006400610074006100 > - In <>, attribute 'data' of '/metafile/comment[2]' incorrect value. So just not make the problematic MetaCommentAction payload endian-dependent in the first place. (And one wonders why the test even needs to test such a problematic payload.) Change-Id: I203dae6545e0d4e63e7c2d521a27c661e1cf633c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-19crashtesting: assert seen on loading moz820988-2.svgCaolán McNamara
Change-Id: I8ceab08348875cd8a88c440091ac0227012ab358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-19Related: tdf#149990 solenv/bin/desktop-translate.py readabilityIlmari Lauhakangas
Satisfies many pylint suggestions and includes a formatting pass with Black. Change-Id: I33794902ab303f63b52a3412e4e4d18b492cc74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137101 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-07-19vcl: migrate from getOpenHeight/Width() to GetWidth/Height()Chris Sherlock
Change-Id: Ia51d6a6f2e9dcb6ba6193f7617848e7bd560dabb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137170 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-19Simplify the template makefileLaurent BP
Remove unused variable Change-Id: If2e69f30e8f94d662d619ded6b85f2a737ef3412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137196 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
generated by cgit (git 2.34.1) at 2025-03-11 19:55:36 +0000