summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-03-22Colibre: tdf#148029 Remove dark area in dark variantRizal Muttaqin
Change-Id: I9cdfdaefa1a9f487e471fe3a3f958da3b9e86904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131917 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-22Colibre: tdf#148135 ^ Group and Ungroup iconsRizal Muttaqin
Change-Id: I25680b8191718a931f32b84b39d01c6e0d24b75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131937 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-22tdf#107572: sc_macros: Add unittestXisco Fauli
Change-Id: Ib80c8791ead9a151986642d835171fac04c1b1d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131936 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-22use dashing info from struct LineInfo in EPS writer (tdf#146804)Luboš Luňák
It had a random(?) hardcoded '2' as the dashing info. While at it, I've also made few other places use the common implementation of creating the dotdash array instead of doing it manually. Change-Id: Id349ca138c98d08eef47dc0bfe6d162e03fc4a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131932 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-22tdf#108292: sc_uicalc: Add unittestXisco Fauli
Change-Id: I0543b0ce1914ff5d69370802b65da311c37111f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131935 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-22Adapt loplugin:indentation to --enable-qt6Stephan Bergmann
> In file included from vcl/qt6/QtClipboard.cxx:10: > vcl/qt6/../qt5/QtClipboard.cxx:142:16: error: statement mis-aligned compared to neighbours [loplugin:indentation] > Q_EMIT clearClipboard(); > ^ etc. Change-Id: I8ceacfd5eafe963699d8313d3f8cadbed4ccd260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131929 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-22tdf#114406: sc_ucalc: Add unittestXisco Fauli
Change-Id: I0d6be8945e3aaecdccfc674c70f60b6f150f3c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131934 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-22tdf#135234 : Change initial focus of SpellDialogSarrah Bastawala
Change-Id: Ic316a8d99ad12a51a79b2e2680aa5cec5eac5c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131182 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-22Solve exception in implts_flushConfigItemJuergen Funk
Regression from 4256c764aee0777770466115a97420d9b55c23ac in framework/source/services/autorecovery.cxx in line 1997 sloved the exception Change-Id: I4bee90b94307978c9c5186c1c5fdaca1aa420e21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131901 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-03-22wina11y: Slightly clean up WinResIDGeneratorMichael Weghorn
Changes: * drop the optional `maxNum` param for the constructor, it's never set to anything different than the default value * store negative number in member (renamed from `max` to `m_nMin`) instead of storing positive number and inverting that when returning it in `ResIDGenerator::GenerateNewResID` * Use -1 as the first resource ID instead of -2. Also, add a comment that negative child IDs are used because it's common to use such ones to indicate unique resource IDs in IAccessible2. Quoting James Teh's comment on an NVDA pull request of mine [1]: > The use of negative child ids doesn't fit well into the IAccessible > spec, but it has been done by IAccessible2 for a very long time and > should be considered standard for all intents and purposes. A negative > child id should be treated as a unique id, while a positive child id > should be treated as a child index. > > That said, as noted in #13277 (comment), IAccessible2 elements are > always full IAccessible objects, not "simple elements". Thus, anything > that returns an accessible (including accSelection) really should return > an object pointer. In the case of accSelection, this means VT_DISPATCH > for a single selection or VT_UNKNOWN and iEnumVARIANT (with VT_DISPATCH > elements) for multiple selection. > > In short, NVDA supporting negative child ids returned from accSelection > isn't necessarily "wrong", but ideally, LibreOffice would be fixed to > return full objects. The latter (returning full objects) has already been addressed in commit 00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Jan 31 07:41:14 2022 +0000 tdf#147083 wina11y: Return a11y object instead of child ID but a unique ID is still relevant, s. e.g. the documentation of `IAccessible2::uniqueID` [2], which also mentions potential ways to implement unique IDs: > One means of implementing this would be to create a factory with a 32 > bit number generator and a reuse pool. The number generator would emit > numbers starting at 1. Each time an object's life cycle ended, its > number would be saved into a reuse pool. The number generator would be > used whenever the reuse pool was empty. > > Another way to create a unique ID is to generate it from a pointer > value, e.g. an object's address. That would be unique because no two > active objects can use the same allocated memory space. The first approach is what the LO implementation currently does, except that negative numbers are used. [1] https://github.com/nvaccess/nvda/pull/13277#issuecomment-1024622871 [2] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#aac1342376cf195a6a6e9ee3b7e30ae3b Change-Id: I6c0a6c4a4e3a69396205fe2d69cd66af6525a273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131927 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-22sw clearing breaks: add HTML filterMiklos Vajna
Map between SwLineBreakClear and <br clear="...">. The import-time workaround with the anchor-only wrapping is no longer needed, the layout is now capable of doing this. Change-Id: I53fa49f11e13fc3338b3cf70d8f87f3633c414c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131924 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-22loplugin:loopvartoosmallStephan Bergmann
...with --enable-qt6, where QList::size() return type has changed from int to qsizetype (aka ptrdiff_t); but just replacing the use of int with a use of qsizetype would fail with --enable-qt5 in some build environments where the Qt5 qglobal.h doesn't happen to already be included, so simply replace this with a range-based for loop and be done with it Change-Id: I5a6c7b0468ed7cef6de7fb647fdb2631a8cb5b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-22Win/X11OpenGLDeviceInfo don't need a common base classStephan Bergmann
Change-Id: I9fc7e763b8cf055c3aabaaa97fe8c85ebc5e71b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131926 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-22tdf#147861 ww8import: use GetFieldResult, not current DocPropertyJustin Luth
In all the testing I could think of on DOCX and DOC examples (and only a very few exist in the unit tests) the actual value of the DocProperty was irrelevant to what Word shows as the document loads. It always takes the in-document, as-last-seen static text. As a way to hack a fix using existing capabilities, I marked as FIXEDFLD the unknown custom fields that weren't handled separately. That fixes what is displayed as the import value, (which of course means that F9 will no longer return a modification back to the DocProperty value). It also means the (fixed) field is lost on export, but a follow-up patch handles that for DOC/RTF/DOCX. There were NO DI_CUSTOM examples in existing ww8 tests, but: -ooxmlexport8: fdo74745.docx, fdo81486.docx -ooxmlexport10: tdf92157.docx and in these cases the plain text matched the variable anyway, but a manual manipulation showed that LO is importing DOCX wrong as well, so a similar import fix needs to happen for RTF/DOCX. My fear is that there are some special-magic-associations that worked properly the old way by accident that I will break by marking them as fixed. No backporting please since obviously very few people report bugs about fields. Change-Id: I3f167eb3bd570b66ee829241bf9d31d557fc8749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-03-22gtk3_kde5: Don't call deprecated QFileDialog::setConfirmOverwriteMichael Weghorn
QFileDialog documentation says [1]: > This property is obsolete. It is provided to keep old source code > working. We strongly advise against using it in new code. > > This property holds whether the filedialog should ask before accepting a > selected file, when the accept mode is AcceptSave > > Use setOption(DontConfirmOverwrite, !enabled) or > !testOption(DontConfirmOverwrite) instead. Documentation on `QFileDialog::DontConfirmOverwrite` [2] says: > QFileDialog::DontConfirmOverwrite 0x00000004 Don't ask for > confirmation if an existing file is selected. By default confirmation is > requested. It already said that 10 years ago. Given that's the default, there's no need to set it explicitly at all. [1] https://doc.qt.io/qt-5/qfiledialog-obsolete.html#confirmOverwrite-prop [2] https://doc.qt.io/qt-5/qfiledialog.html#Option-enum Change-Id: I77a0022dc4128d157ba49c9aa8de447bb2c08379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131923 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-03-22tdf#104390: rtf import: init default font for entire state stackVasily Melenchuk
If first document element is buried deep in destinations and thus deep in state stack (m_aStates) initialization of default font is very local and will be lost after closing these destinations. So let's initialize entire states stack with default font if none is provided istead of initialization just a top element. Change-Id: I966c282f43b84baece909a4c3cd359cbcd317e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131906 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-22OpenGLHelper::GetDigest is only used on WindowsStephan Bergmann
This is in preparation of getting rid of X11OpenGLDeviceInfo for non-Windows platforms. Change-Id: I9c08292716244d046bf223eb760880db43b6824b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131921 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-22Simplify CoCreateInstance / CoGetClassObject with COMReferenceMike Kaganski
Change-Id: Ieb1035410c3c6c4b40ea779e829a940460d19b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131922 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-22sc: support sparkline bar colors, add markers to sparkline linesTomaž Vajngerl
Change-Id: I705a7f57cc4d6544ecb35a5f93c18a27056b9944 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131918 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-03-22sw: document SwXTableRowsMiklos Vajna
Which has a backing core C++ class, unlike table columns. Change-Id: Iebc546b8c3424f976043deceee8307eae764bbb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131914 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-22tdf#145614 Convert #define to enum or constexprDeep17
Change-Id: I3090ae3421ae55b7c546d82aeb49a56e93c9f02c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131913 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-21Use IID_PPV_ARGS to have less explicit castingMike Kaganski
Change-Id: Id8839a68320d7d0e2453b3d584dc5708c653cdf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-21ScColumnsRange::Iterator actual needs to be bidirectionalStephan Bergmann
...since 1463625ae26900d2461fd72a5a2c894b9f1b8726 "dynamic column container: fix some more for loops" started to use it with std::reverse_iterator (but apparently forgot to update the iterator_category, causing > In file included from sc/source/core/data/column.cxx:20: > In file included from sc/inc/column.hxx:22: > In file included from sc/inc/global.hxx:22: > In file included from sc/inc/address.hxx:22: > In file included from include/rtl/ustrbuf.hxx:35: > In file included from ~/llvm/inst/bin/../include/c++/v1/string_view:206: > In file included from ~/llvm/inst/bin/../include/c++/v1/__string:13: > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/copy.h:12: > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/unwrap_iter.h:14: > In file included from ~/llvm/inst/bin/../include/c++/v1/iterator:669: > In file included from ~/llvm/inst/bin/../include/c++/v1/__iterator/reverse_access.h:14: > ~/llvm/inst/bin/../include/c++/v1/__iterator/reverse_iterator.h:53:5: error: static_assert failed due to requirement '__is_cpp17_bidirectional_iterator<ScColumnsRange::Iterator>::value || bidirectional_iterator<ScColumnsRange::Iterator>' "reverse_iterator<It> requires It to be a bidirectional iterator." > static_assert(__is_cpp17_bidirectional_iterator<_Iter>::value || bidirectional_iterator<_Iter>, > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sc/inc/table.hxx:146:37: note: in instantiation of template class 'std::reverse_iterator<ScColumnsRange::Iterator>' requested here > std::reverse_iterator<Iterator> rbegin() { return std::reverse_iterator<Iterator>(maEnd); } > ^ etc.) Change-Id: Ice7527412a379a5ecb655349386e8814c911e87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131909 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-03-21Removed duplicated includesAndrea Gelmini
Change-Id: I22b71580a79500e169ed9cab775501583975d67f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-21Fix typoAndrea Gelmini
Change-Id: Iba19e41fcc9277d428476e876b6a0bf50e7f18d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131912 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-03-21Related tdf#114286: put duplicates commands in GenericCommands (SplitCell)Julien Nabet
Change-Id: I8d63d47782a77350ab0f38b1a96cd045b44500a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131676 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-21Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to b79af43f87d6932dd49b4fac1552378a56f5ba5d - Help page cleanup Change-Id: I1066974181278b56071f16234358d67d8038e134 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131200 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-03-21ofz#45878 add a way to set some limit on hugely complex clipsCaolán McNamara
Change-Id: I6bbf7c6068560e3bb656560fb5c6cc2ed72cecd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131907 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21tdf#118047: RTF import: better deduplication for header/footerVasily Melenchuk
Here are two related fixes in one patch: 1. By default current style index is 0, not -1. Due to this we can assume usage of default "Normal" style during deduplication. Seems there is no difference in case of no style mentioning in run or mentioning "Normal" one (\s0), so value -1 looks unnesesary. 2. During header/footer "substreams" processing StyleTableEntires was not reused in new domain mapper impl instance. So deduplication did not work well. 2a. To avoid copying of whole StyleTableEntries between instances it is stored as pointer in domain mapper impl. Change-Id: Id003d35554e9b43186238920d9a6373452095121 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131899 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21Colibre: tdf#148029 Remove dark area in dark variantRizal Muttaqin
Change-Id: Iefbe24e122aab9c2ea95a4b93f4bf49d0940e17c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131903 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-03-21Move implementation of doubleToString to sal/rtl/strtmpl.hxxMike Kaganski
... to reduce inter-relations between compilation units, and drop *StringTraits from sal/rtl/math.cxx. Change-Id: I0d7544dead03651dc71ec923cab10580f15cf49a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131895 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-21Related: tdf#118320 tabpane is too white in darkmodeCaolán McNamara
the only reliable darkmode hammers are a button or drawing with some solid color derived from a theme element, try a button here Change-Id: I842a415020abd26dc60e51438f9fd3c961ecd830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara
Change-Id: I73ed541c9a8fb6d9b0a8ee86ce7cf581721a9b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ced4b1d58efe8b35289643376d082fb416edae21 - tdf#146847 Typo in IDIV Basic help page Change-Id: Ib303ad532c2daf9de856ed8c5c5cd2df673920d2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131854 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-03-21Related: tdf#118320 swap TILES_SELECTED and TILES_FOCUSEDCaolán McNamara
so the selected tab gets the same bg as the tab page Change-Id: I26222cf755c4c30f8712fb7a4690c84784d9b508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara
Change-Id: I63f4828fb35a1f24c98ccd235af91d186b48058a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYDEBUG is always 0Caolán McNamara
Change-Id: I9255b0c6447126e5b0907b12622b668bb4c79474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21yyoverflow is not definedCaolán McNamara
Change-Id: I5769b82ededd15a50892bc4e9478f69edb4722c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYPARSE_PARAM is not definedCaolán McNamara
Change-Id: Icda8e09ceb5e2bebb5187d00c0baa1bcccda88a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYPURE is not definedCaolán McNamara
Change-Id: I5942de482c6216fba2c35fa6d113c44639d349e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131891 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21YYLSP_NEEDED is not definedCaolán McNamara
Change-Id: I324e811a84916f27037b2fe9df0aed2db5458564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21sw clearing breaks: add RTF filterMiklos Vajna
Map between SwLineBreakClear and \lbr<N>. Change-Id: Ibed94ad74157a08787212a34176590a1dc4d5547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131886 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-21related tdf#147861: cleanup + a function provides the nameJustin Luth
This is not quite a NonFunctionalChange because it avoids adding " (fixed)" to the name. But that is what I want anyway for bug 147861, so this is an all-around good simplification. Plus, the writerfilter loop doesn't need to run if an inside clause will never be true anyway. Putting this cleanup separately helps highlight the actual fix and not clutter the real patches. Change-Id: I12f345cc92627398ad00fe32b64b98b54e5ed14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131413 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-21dval can be constCaolán McNamara
Change-Id: I452f666230aca5b6033dcb16495ae382e4fd1073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21ofz#45816 Direct-leakCaolán McNamara
Change-Id: Iaf31e6b46cc5ab68de46c250926d6a4709eddd75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-21tdf#141908 Replaced usage of sal_Int32 and sal_uInt32 with Color in unit tests.Siddhant Chaudhary
Change-Id: Ieb8b6b3c3bfab0ab49bc55cf42db7be4f08e964b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131408 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-03-21tdf#147589 In document with OLE link, don't show temp-file is in useJuergen Funk
Regression from 218f36dd614cf828e949f605faaf6a6fd615da26 change the handling in OTempFileService::closeOutput That was the problem in the OLE-Link handling Change-Id: I5a7fa74b4a731f758e1c405dfb9cd298b30086a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130408 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-03-21sw: prefix members of SwWW8WrGrf, WW8Export, WW8PLCF and WW8PLCF_HdFtMiklos Vajna
See tdf#94879 for motivation. Change-Id: I86c9fd2c634b2f5422b0820dd5423008b1c0360c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131884 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-03-21Reorganize the code a bit to drop some detail::* helper functionsMike Kaganski
Change-Id: Iee7402f5de7287678e1691b48b6493d3131ef7ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131883 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-03-21a micro-optimizationMike Kaganski
Change-Id: I2d94c2d3d7a159953b264e21a0fce8f0a0340163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131856 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>