summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-18Do not forget to remove just unloaded object from the cacheMike Kaganski
It turns out that unloading objects does not necessarily remove it from the cache automatically (e.g., SdrLightEmbeddedClient_Impl::stateChanged is not called with respective change). In this case, the cache size grows, and it attempts to clear more excessive objects at each append. Remove the object explicitly after unloading to avoid it. Change-Id: I392c8eb6ef8e3fe89f148366021f61b9c0428a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120637 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18loplugin:passstuffbyrefNoel Grandin
Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18Don't forget to break the loop earlyMike Kaganski
Change-Id: I56f99b976fd27c558ff4e3089b2c0f85250602f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120636 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18Remove redundant nullptr checkMike Kaganski
The only place calling UnloadObj is UnloadCheckHdl, which already makes sure that the pointer is valid. Change-Id: I78bd89b76427d18af1f38b29a8cf93bf02592030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120634 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18This check is redundantMike Kaganski
It was checked a few lines above. Change-Id: I04ae6fd34f36c54dee9097ff05aefcc9447738dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120635 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#143778, tdf#143785: sw: add UItestXisco Fauli
Change-Id: I3a917feb4a3ea6f14e7236e1bcdbc8b9e2bcf93b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120654 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-18Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/2add5864d55a5cbe376da8a342549a8dbf46387b> "Merge pull request #158 from flathub/extensions: Add an org.libreoffice.LibreOffice.BundledExtension extension point" Change-Id: I1a1515e8ece2d8aec83abb6c8775f784083573a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-18Don't use std::ostream operator <<(char16_t const *) deleted in C++20Stephan Bergmann
similar to 4af56d8189012f96d0471d7f50a3e44636666516 "Don't use std::ostream operator <<(char16_t const *) deleted in C++20" Change-Id: Ica7b02c14b66fea64f630bed4943c04ae999485e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120662 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-18online: keep sidebar openedSzymon Kłos
when we switch mode in online keep sidebar in opened state. For example when switching from notebookbar to classic mode - sidebar is set to "Tabs" what makes sidebar hidden in online. The same happened when crash occured. Change-Id: I5d0d1dba4c89b5e380a0bf717fabf4337016894c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119496 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120660 Tested-by: Jenkins
2021-08-18jsdialog: dump more options command for panelsSzymon Kłos
Change-Id: I04d71d318d97916f040de7a617a802dd895faed5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119104 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120659 Tested-by: Jenkins
2021-08-18uitest: make use option 'Separated by' is checkedXisco Fauli
Change-Id: I504e17ab015803662b051427a7e80aea2789ecf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120625 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-18tdf#96561: sc: Add UItestXisco Fauli
Change-Id: I393860264a9411c503db5276c951b98124282540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120608 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-18Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to d42ad54f4c9c1b07ca851ce76ceb77f512c4f1ba - tdf#142574 Create help page on "wildcards" This patch creates the wildcards.xhp help page and makes the required adaptations in tree files to disambiguate "wildcards" and "regular expressions" in the help system. Change-Id: I82f1e192b6bf9e605fc3cfde50b648ce902cefdb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120573 Tested-by: Jenkins Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18Fix erroneous commentsMike Kaganski
At least they work symmetrically with set* counterparts, and seem to be used as returning radians. Change-Id: I6fedbb127ff587822dbea2351c51e2472edaa962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120591 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#139734:Drop redundant asserts after MacrosTest::loadFromDesktopYildiray
Change-Id: Ie32c3dd5bf5fc1386cf2b480d88f97c7d11c2fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120325 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-18Don't crash on SidebarController dispose when app is closingSzymon Kłos
When app is closing it is possible SfxGetpApp() will return null. So GetCurrentTheme() cannot return reference to correct theme. Remember which theme has registered SidebarController to unregister when disposing. Change-Id: If223233f621601f445472b0413a56e9c51e59673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118970 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120630 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18jsdialog: dump FixedImageSzymon Kłos
Change-Id: I9803558fa19ef5e508817d5db0bdeb54827f63d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118969 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120629 Tested-by: Jenkins
2021-08-18jsdialog: sidebar: do relayouting not too oftenSzymon Kłos
To avoid jumping in Online avoid not needed relayouting. Change-Id: I4a59a9aa077de60ffd0486bb843fd2ce5b4174d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120628 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18undo changes to TextAlignCaolán McNamara
revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 29 20:49:29 2021 +0100 convert TextAlign to scoped enum lets leave this as it always was Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18ofz#37315: Invalid-enum-valueCaolán McNamara
Change-Id: I573ecf0cd1bd7b71ebf77a503d9937ee9f9d867c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18specialise std::optional for OutlineParaObjectNoel Grandin
we can re-use the o3tl::wrapper pointer to indicate empty Change-Id: I26e502a7dacfb2bd3d465e71c8fdd89a6a80969b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18ofz#35787 skip expensive ResetAttr if the document is in dtorCaolán McNamara
lets try it initially just for fuzzing builds Change-Id: I4ae08348c53756a8f3693ba7cd5c6c3e255d91bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18tdf#143736 Fix loading hyperlink from various shapesSamuel Mehrbrodt
Change-Id: I86de90ee605fab8f11e7c01892fbbff6acf790a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120609 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-18improve SvxShapeCollection::getByIndexNoel Grandin
Change-Id: I4cca7c0b6344241256d038902069a20ece314358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18jsdialog: dump selected state for toolitemsSzymon Kłos
Change-Id: I8c2c017168e4feae6e24118153906ee24ed90a5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118893 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120615 Tested-by: Jenkins
2021-08-18jsdialog: dont use popular id for glow colorSzymon Kłos
to avoid confusing it on updates Change-Id: I2b19dc41a17e070ac1c8869d478c3b0b09a54223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120614 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18jsdialog: send type for popup messagesSzymon Kłos
Change-Id: Ic0f189645dc9a1164cbbc528b3a5d30d72ee3333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118552 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120613 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-08-18gtk3: fix warning about GtkBin already containing a widgetCaolán McNamara
Change-Id: I9df18e9cc865a8600f26605530eb99b9ba8f0d36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18tdf#114441 :Convert use of sal_uLong to better integer typesYildiray
Change-Id: Ifc7c1ce21f9dbaf77a0ae2ffa598e219809a250d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120541 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-18tdf#59820 - Adjust column width of imported ASCII filesAndreas Heinisch
Don't adjust the optimal column width of imported ASCII files in Calc by using the simple text mode. In the simple text mode, the length of a column is determined solely by the length of a text and not by the actually needed size. Change-Id: I02a1e0fbfad88a31bd474124c2f4367b660bdfdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120514 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-18ofz#37305: load of value 131 which is not a valid value for type 'bool'Caolán McNamara
Change-Id: Icd535272bfc2ef62399fa889f73acd705b566973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120622 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18avoid constructing OUString on hot path (tdf#105575)Noel Grandin
Change-Id: I7c9925fc7f68cdc9bd1a9c1834daabff09c8cf6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18remove dead codeNoel Grandin
ever since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I1fd724f2e4f31353da60d2615e6c840bbb88dfcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18loplugin:sequenceloop also check for B2DPolyPolygonNoel Grandin
which has the same problem Change-Id: I98f9924626f26739e91d6a9d21e4276473ea314d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18Simplify SdrTextObj::RecalcSnapRectMike Kaganski
Change-Id: Ieab3f3143e96af56c87720451de4194138f0463b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120590 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18Simplify Rect2PolyMike Kaganski
Change-Id: Ie20662c6040da8a77db8168a7aa32e001a01ae6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120589 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#134569 writerfilter: move tableParaProps on table endLevelJustin Luth
The end-level of a table only comes at the ::finishParagraph of the FOLLOWING paragraph. So for table-in-table, it is necessary to move the paragraph properties captured during the paragraph to the correct table level's collection. This fixes 7.0 regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c and depends on prior commit related tdf#134569 writerfilter: negative means table end Change-Id: I83183f38e1cf68b7db09813ca1b4a2491e7b54e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120526 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-18Update git submodulesMing Hua
* Update helpcontent2 from branch 'master' to e4f55790b32ad295322c712ed49d0349f4eea66d - ScriptForge Basic: fix example MB_* are properties of the service, so the service variable needs to be properly specified. Change-Id: I033f3e54ca69707c25030723fb5dc426a3ad6691 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120586 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-17Removed duplicated includeAndrea Gelmini
Change-Id: I4103d44e0535b39555f2f62e36ce6109e39cabfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120595 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-08-17rtl::Static -> thread-safe static localNoel Grandin
Change-Id: I9f8fe250813f4f376dc46c6f3d7e25e90fdbb50e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17reduce alloc costs for some basegfx objects (tdf#105575)Noel Grandin
we can use a default object for the default constructo case, and remove one malloc for each default constructed object Change-Id: I0bec37ef9161a210973abb25669a9f16a5e0ea75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17Resolves: tdf#139220 with ~1000 selected shapes a11y UpdateSelection crawlsCaolán McNamara
so fetch the selected shapes once and sort them for quick lookup in the loop over maVisibleChildren. As an aside, not changed here, SvxShapeCollection::getByIndex looks suboptimal with a body of std::vector<Reference<uno::XInterface>> aElements(maShapeContainer.getElements()); return uno::makeAny(Reference<drawing::XShape>(aElements[Index].get())); Change-Id: Idec7c003e7c5ee02000d4642d4fdb0d940548d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120610 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Fix o3tl::convert for Rectangle, to operate on right/bottom valuesMike Kaganski
... instead of using confusing/ambiguous size having two interpretations. This reverts some of the unit test changes made in commit fa339b3adb53300ae68913bed87e18caf9f2e262. Change-Id: Ic56417703e32c1d92bcee76ad8ff494824bd4a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120564 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-17ofz: Indirect-leakCaolán McNamara
Change-Id: Ia29c771d6dbdf37b55ce0e63cc73564bcea6f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-17Fix typoAndrea Gelmini
Change-Id: Ib67f29eec54557811eb1136673030249b296289e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120599 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I8cf2ea25ee343b747497a8a83edb48c2421863bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Improvement to ml element exporterdante
Change-Id: I12303add11406c0ab65ca02084945989f41380d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I93062ed58f820a0f88a236c4134ff9adce06006c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120601 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I28ef5ac72fb06406d049e1076f48dcd2d06a42af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120600 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-17Fix typoAndrea Gelmini
Change-Id: I05739d1b82ec872cd8c7d68d3945893c9e6c3648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120597 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-28 19:39:28 +0000