summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-19ofz#37370 Null-dereferenceCaolán McNamara
since... commit 5b025285b3528910a4360899abb2bbbaadc72c97 Date: Wed Aug 18 07:35:05 2021 +0200 Simplify Rect2Poly where tools::Polygon from tools::Rectangle ctor has special handling for an 'empty' Rectangle Change-Id: Ifb93efeee4c2c1fe1f9fe5422e0e648ad91da77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19tdf#143939 sw: track format changes of the actual wordLászló Németh
If there is no text selection, character formattings are applied on the word under the text cursor, now with storing the original direct character formatting in a redline "extra data" for rejection of the tracked formatting change. Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892 "tdf#143918 sw: fix reject of multiple changes" (clean-up the format tracking code into the new lcl_SetRedline(), and applying that for the not handled case, too). Change-Id: Ie6bc4dc17dbf84cc61970cef66689aec8ddc4595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120707 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19tdf#143722 DOCX import: map using default TOC heading styleGabor Kelemen
of Writer ("Contents Heading") instead of "TOC Heading". This essentially reverts the fix to bug #83300. When that was added the TOC import was broken enough that it made no visible regression. In 6.3 the TOC import was fixed up so now it's more annoying. The unit test of bug #83300 is reused but depends on the fix to bug #143726. I checked the example file of bug #83300 and the layout problem of comment 6 that was fixed there does not come back. Follow-up to commit 5440492ff9f949ee9ed9052e8bab6f5136d78b2a "tf143726 DOCX: export default TOC Header style with correct name". Change-Id: Iaee73729ea46a0c36d08ccc6fc5fb04fdf592a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120092 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19vcl: move ImplReleaseFonts() to outdev/font.cxxChris Sherlock
Change-Id: I4bd54c24f415e28014690fd775a3a5136d2be433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115371 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19vcl: add braces to SetBackground() function to make reading easierChris Sherlock
Change-Id: Icb91c4e8aae3f6f25515ca75a3cc230d9238dd4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115370 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19vcl: move background functions to background.cxxChris Sherlock
Change-Id: Iee2e42f3881512d2e779d16505c50f76731e398a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115369 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19drawinglayer: split polygonprimitive2d.hxx into multiple filesTomaž Vajngerl
The header polygonprimitive2d.hxx contains multiple primitives, which should be independent in their own header files. Split them in its own file, but for now keep polygonprimitive2d.hxx with includes all the new headers so that compilation goes through with no need to change any other files. Change-Id: I5c8ea2ed0c6d38374c1b871fef562b2164b9c8fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120708 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19tdf143726 DOCX: export default TOC Header style with correct nameGabor Kelemen
This seems to have been a typo since it was mapped to the default name of the Table of Authorities index's heading in Word which is not really supported anyways. Change-Id: I4cadce18c30c5497f27479fcc251fdf85d859145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120091 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19use std::optional<OutlinerParaObject> in SwPostItMgrNoel Grandin
it is a COW object, no need to allocate separately on heap Change-Id: I9388d2a850a39a8645071dfb2907a4fe7785ac21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19tdf#143567: Distinguish bitmap vs. pattern fill styleKatarina Behrens
By the time fill style state change (SID_ATTR_FILL_STYLE) happens, the actual bitmap fill may or may not be known. If it is not known, it is impossible to tell whether it is a regular bitmap or a pattern. That's why this toolbar sometimes incorrectly reports bitmap fill instead of pattern one To solve the problem, we adjust fill style listbox selection only later, by the time we know for sure the fill IS a pattern Change-Id: I0aa95c49601d77dca29ab54ad4c056a76a90e049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120687 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-08-19ridljar: check that UnoClassLoader is used for NativeLibraryLoaderMichael Stahl
The native libraries are local to class loaders, so System.load("java_uno.so") will fail with any other class loader. Change-Id: Ifa3b1b8dfef07b64828943654e28ff1f0fb5a494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120527 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-19toolkit: fix deadlock in MutableTreeNodeMichael Stahl
Broadcasting may call back into this, from TreeControlPeer::updateNode(). Release maMutex before broadcasting to fix it. (regression f7ee6baa1b14410fa79aac5dd9d6877df44a823a) Change-Id: I91a8e043aaed02422601e5d4d5253379abab5d7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120616 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-19remove some locking from UriReferenceNoel Grandin
we write these fields in the constructor and then never modify them again, so safe to skip locking Change-Id: I5cb5ea085ee8c2f6e4ce6417c2648265aa5a06d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19reduce skia re-alloc costs (tdf#105575)Noel Grandin
by reserving space before building the SkPath Change-Id: Ic01f614bf574fd3252d379ed38e3039cb0c56b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19tdf#143890: Show preview of diagonal borders / CalcBayram Çiçek
- in "Properties sidebar > Cell Appearance", Calc shows preview of the selected cell borders. (preview is at the bottom of "Background" text) - this feature doesn't work for diagonal borders. - diagonal borders preview is now shown with this patch. Change-Id: I9d98b045ccef5e8469cc38f08e5f14c3199d027c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120519 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-08-19use std::optional<OutlinerParaObject> in SdrUndoAttrObjNoel Grandin
it is a COW object, no need to allocate separately on heap Change-Id: Ibfecb263eedb6ef5eca8122e80a564cb1e872db1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120699 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to e0504d8b59b76437009203f68877a07fb9951cde - tdf#73359 update information about image/frame alignment Change-Id: Iecca0467229b019c9dd35589375ba269e2dcb713 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120585 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-19tdf#143918 sw: fix reject of multiple changesLászló Németh
Reuse "extra data" (i.e. tracked direct character formatting) of the previous redline on the formatted text range to track all character formatting changes, i.e. the new and the previous ones, too. E.g. modified text size and color of the word are rejectable now, not only the last one (e.g. text color) of the multiple formatting changes. Follow-up to commit 0115a77eb84afb0d820d8e23f45e49b30b82a8d3 "tdf#50447 sw: track changes of character formatting". Change-Id: I6a82603ecce9885cd06bc27bedbadaac72f97240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120668 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19reduce visibility of some symbolsNoel Grandin
Change-Id: I16b6be2217f56e5961e1352201a8ee4e2b033e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19Make Custom Color Picker dialog asyncSzymon Kłos
- now supports also XAsynchronousExecutableDialog - inherits from SfxDialogController to attach correct LOKNotifier Change-Id: Ic21db4057b8087d74a437b1c8ec95408ade5264d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119012 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120670 Tested-by: Jenkins
2021-08-19jsdialog: dump id for imagesSzymon Kłos
Change-Id: Ia25dde027f79bc9c3c22cbaccdb41c2ff1ae4214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119504 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120661 Tested-by: Jenkins
2021-08-19Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to a50cd071131aaf106c24c9d3b58cb0b90e019fcb - tdf#132643 Translate German section IDs Change-Id: I428adb56cf10454a2737d7ce75b81fe143acdd9a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120508 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-19augment CFLAGS for libxml2 instead of overwritingCaolán McNamara
so CFLAGS containing msan's -fsanitize=memory are not discarded Change-Id: I3a6cdbe88b1aae37a48e73d5ed7ea06e92d78f6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19ofz#37300 Direct-leakCaolán McNamara
since... commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value Change-Id: I9e28844226184ba2f54d11888b020d080e9b57ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19cid#1490358 silence bogus Dereference after null checkCaolán McNamara
Change-Id: I58734852180f345ac2242d5d89e3d7e5da2ed6e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19cid#1490357 Dereference after null checkCaolán McNamara
Change-Id: I107dc27a4bec1794293192dea986670220989ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19save LastTipOfTheDayShown when the dialog is shown not in its dtorCaolán McNamara
Otherwise if a tip dialog is left open then its considered not to be have be shown and new ones will constantly open on every new document. Especially problematic in impress if you leave the first one open and select a template to open from the template dialog then you get two of them in the same frame. Change-Id: I94cd34aa031e133d8c229a0de78582fda1dbdf4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19Drop GetSdrObjectFromXShape and use SdrObject::getSdrObjectFromXShapeMike Kaganski
Change-Id: I0d233878ee49fcdc1338ec3bd700e5482d558163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120694 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19tdf#143736 Add testSamuel Mehrbrodt
Change-Id: I132a31f7bb06f31cabfa92b647a9e4dbdb7b4b6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120692 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-19cid#1490354/1490355: Logically dead codeJulien Nabet
Change-Id: I2f20f60d01e5b5969a51041726b13cb2e1a2d0af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120682 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-08-19tdf#143736 Fix loading hyperlink from textboxSamuel Mehrbrodt
Change-Id: I56f5aec153d9544a6c345e0cbb5857cf5d0074b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120673 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-19tdf#142264: make sure to load potentially unloaded objects when savingMike Kaganski
Commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc happened to reveal a pre-existing problem that XLSX export only saved those OLE objects that were kept loaded in the OLE object cache, subject to thevalue of org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects. Before that change, the imported charts were marked modified on load, and that prevented them from unloading in OLEObjCache::UnloadCheckHdl, because SdrOle2Obj::CanUnloadRunningObj returned false. After the mentioned change, the charts started to load without the wrong "modified" state, which allowed them to be properly managed by the cache, and the export filter implementation error surfaced. It's likely that commit 692878e3bb83c0fc104c5cca946c25ccf2d84ab2 tried to workaround the same underlying problem for charts that for some reason / at some point in time didn't get marked modified on load, and that commit converted an error shown in Excel into silently missing charts. This change makes sure that whenever a reference to chart document is requested from XclExpChartObj, it is actually loaded and ready for reading data. Possibly something could be done on the level of old reference that becomes non-functional (although valid) as the result of unloading, so that it would automatically reload on following use. That would make operating on the references robust. I didn't find an obvious way to do that. It is interesting to investigate, it the heizenbug related to images disappearing from documents, as users keep reporting without robust reproducers, might possibly be caused by a similar problem. Change-Id: I45fcdc98254157d805c7519340b5265526f27166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19Do not count pages for initial page breaks, tdf#124983 follow-upEike Rathke
Use a loaded page size or leave it. Otherwise the previous implementation could had lead to tremendous waiting time blocking everything on large data without. See source code comment. Also trigger updating page breaks only for one grid window, not multiple repeating everything all over. Remove bSetup parameter that does nothing but either doing something or nothing, check in caller instead. Move member variables to where they belong. Change-Id: I5efc321e5bc5af075a77631aa9d94b0c50ae6b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120689 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-18GCC bug 96878 is fixed in upcoming GCC 12Stephan Bergmann
However, restricting the workaround to GCC <= 11 then revealed that some old versions of Clang apparently had a similar issue, causing "error: use of class template 'OStringLiteral' requires template arguments; argument deduction not allowed here", and thus also need the workaround. I saw the non-workaround code fail with a build of Clang 6.0.0 and succeed with a build of Clang 7.0.0. Change-Id: I6e4cf6c8c3a11618a578401574e5679e6b65d7f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120657 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-18Avoid LIBO_USE_SOURCE_LOCATION feature on user-facing LockFileExceptionStephan Bergmann
(see 1d0bc2139759f087d50432f8a2116060676f34e1 "use std::experimental::source_location in uno::Exception"), causing the unopkg executable to print something like > ERROR: unopkg cannot be started. The lock file indicates it is already running. If this does not apply, delete the lock file at: > ~/.config/libreoffice/4/.lock desktop/source/pkgchk/unopkg/unopkg_shared.h:44 mentioning an unhelpful source location Change-Id: Ie9ed716c9edc6c73c173a034ce8bd9bfaf05c0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120669 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-18UnloadObj always dereferences its SdrOle2Obj* argCaolán McNamara
Change-Id: I24f68e83c15f7fad464ad164e75e7cd49ae17b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18Teach symstore more duplicated DLLsThorsten Behrens
Amending commit b4dfba947768834ffecc09056992019878711c8b with adding the copied DLLs here, too (symstore complains otherwise) Change-Id: If5cc155cf2fe11b0f97cd152993609fd2c835316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120686 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-08-18ofz#36713 Indirect-leakCaolán McNamara
Change-Id: I665d7eb66f04fd78b6345f22d5f5724e5778a211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18GetObjRef already returns the needed referenceMike Kaganski
Change-Id: I9f18bcb56906ee75ec015bbd38de26dcb2828d06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120639 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#143353 defer tip of the day until impress template dialog is goneCaolán McNamara
wait until that dialog is dismissed before showing the tip dialog Change-Id: Id0e7e28f09c5a9727e10eda55e468adb56bfda70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18ofz#37322 Bad-castCaolán McNamara
use a SwUnoCursor for the LastAnchorPos around here, this is similar to ofz#9858 Bad-cast Change-Id: I194a39ae13c382740b0ba8145dcc33fb2107105d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-18loplugin:constparamsNoel Grandin
Change-Id: Ic7410f836e584df45101e78e345c8b3c8d355e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18use visitor callback to avoid container construction (tdf#105575)Noel Grandin
Change-Id: I4dd3382ceca82f93664e66b32bcfa7c74eb58fdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18remove incorrect commentXisco Fauli
Change-Id: Iafb37b52fde75fcf92341980b512c4c0c12c6f44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120681 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-18tdf#118470: unit test for escaped unicode chars in strings importDennis Francis
Conflicts: sc/qa/unit/subsequent_filters-test.cxx Change-Id: I4c4190538bdcb3292546d6d5884eb7900807060c Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120666 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-18tdf#118470: sc oox: recover escaped unicode chars in strings importDennis Francis
according to OOX open spec 2.1.1742 Part 1 Section 22.9.2.19, ST_Xstring (Escaped String). In this implementation, some restrictions mentioned in this spec are not kept for simplicity. Change-Id: If27797a9625d49be54c600c8a864965f1101ceb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120665 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-08-18Fix typoAndrea Gelmini
Change-Id: I2e1bc1530bd0a8cf6fef93dcaf8092458da79231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120598 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-18Potential nullptr dereferenceMike Kaganski
SdrOle2Obj::CanUnloadRunningObj dereferences its first argument unconditionally after checking if it's XEmbedPersist2, so for null argument, it will always crash. OTOH, OLEObjCache::UnloadCheckHdl checks if xUnloadObj is null, *after* calling SdrOle2Obj::CanUnloadRunningObj with it. I don't know if it's OK to try to unload objects that don't return a valid XEmbeddedObject, so I decided to live dangerously and keep unloading those. Change-Id: Ib4901cbaf2dcd3ba4ae6fed983c09c10f1efe852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120633 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-18tdf#137742: sw_ooxmlexport16: Add unittestXisco Fauli
Change-Id: Iefc6f78a3045ab844df5c9055379336a40ac7ae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120671 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-18tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButtonArmin Le Grand (Allotropia)
The original method SvTreeListBox::StartDrag always triggers a MouseButtonUp event and tries to initiate a Drag of a Line of a TreeListBox (on MouseMove, btw). This is not wanted if the last MouseButtonDown started a ButtonActive mode and activated CaptureMouse, prepared to trigger Action on that Button on MouseButtonUp. It leads to unwanted/strange behaviour of Buttons/CheckBoxes when used in TreeListBoxes. The behaviour is also dependent on the UI implementation used under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all (unfortunately) behaving differently, but a first suggestion/ step to enhance the situation. Found now for gen/qt5/kf5 that when on the LineEntry, but not on the CheckBox, on MouseButtonUp the other line gets switched. Corrected that. Also moved call to base class method MouseButtonDown in SvTreeListBox to the end of function due to that call may lead to current incarnation getting disposed. That was the reason for the crash described in tdf#143749 Note: for gtk3_kde5/gtk3 there remains the problem that the CheckBoxes get switched on MouseButtonDown, butt these are generic widgets and this needs to be solved differently. Change-Id: I9b73d9a7230469664dd6041f81b399e7d933852b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120593 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
generated by cgit (git 2.34.1) at 2025-02-28 15:37:18 +0000