summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-07-11tdf#149880: handle url when it's inside the quotation marksXisco Fauli
Change-Id: I053323f9b48c8856d520095da0a4768ac03b0176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136847 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> This commit also contains svgio: make readLocalUrl standard-compliant See https://bugs.documentfoundation.org/show_bug.cgi?id=149880#c12 Thanks to Mike Kaganski for the references Change-Id: Idb06cf40ee992dd73120ce051d8ba4f61faaadfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136877 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit e03cd0893eb2031d775764b4696b838dd09fb474) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136864 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136885 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-11tdf#149893: Color names are ASCII case-insensitiveXisco Fauli
See https://www.w3.org/TR/css-color-3/#html4 Change-Id: Ifdf887bad08ab606abef78fa8335bc49507f4a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136879 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 8da687a2843a2cc9e5db3c82204260bde783a76c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136863 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136882 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-11sfx2: fix null derefs of SfxViewFrame::Current()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_tryLoadBibliography Change-Id: I80d764c4bbcf0c5affa3386fbb11f5a79e98b699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136767 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-11tdf#130252: Impress: Clone formatting not cloning highlight colorJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=130252#c5 for full analysis Change-Id: Ie87663c716a6ed31f753e0db5519436f6947aad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136785 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 7b49b3ebc17378566942e7b263e0e5f2b400dbd1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136758 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-11compact the RichString classNoel Grandin
Which reduces peak memory load from 495M to 455M when loading a large spreadsheet Change-Id: Iad78524bedf3db193820be2d507652abde59d67c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9047c22d05df16b5488acfcc70c1b6f4dc8dd13b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136772 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-11Accept iOS SDK 15.5Tor Lillqvist
Change-Id: I19f54042613769993b92cfaf04de292cfbb72b5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134459 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136903 Tested-by: Tor Lillqvist <tml@collabora.com>
2022-07-08android: add Grammar Checker component to native-code.pySzymon Kłos
Change-Id: I87e6e74393d387beb254291e668ca7eb56e5370b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136823 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2022-07-08lok: allow shrinking too big widgetsSzymon Kłos
This is followup for: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b Add sanity check to avoid potential crash in the Collabora Online server nExtraSpace can be negative for shrinking the widget - this is correct. For example listbox can have many entries, in GetOptimalSize it returns size required to show all of them, then here we calculate how much of that size we can allow to be used. When we have too many entries we use negative nExtraSpace. The original problem is not that we get negative number but case when we get value that is much bigger than size of a widget and it becomes invisible. So this reverts hack which makes impossible to shrink widget what causes problems with listboxes in tunneled dialogs. Also it setups better size request for csv import dialog grid widget - so we don't paint it as 10px rectangle - what was workarounded by the previous patches. Change-Id: I478660b12cf0b6a783c704201800018e9849cc23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136728 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2022-07-07lok: skip app background rendering for lok case.Michael Meeks
this is/was mis-placed and tends to make a mess of large sheets' tiles close to the bottom at ~2^20 rows. Change-Id: Iac0977d58428707ff56c0ac30a7740c0ed0b27c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136884 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-07jsdialog: formulabar: dont send huge paragraph id when not foundSzymon Kłos
Change-Id: Ia5586023f639815e54628bfad1a8df11c295c741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2022-07-07Avoid compiler warningTor Lillqvist
Change-Id: I322b2c0ea14bbf8ed2fe1a306c0ed28f5e5ae258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136875 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-07-06compact the RichStringPortion classNoel Grandin
Which reduces peak memory load from 548M to 495M when loading a large spreadsheet Change-Id: I74adfddd1722bba7a9dfae6dd0135e5f2b78b1a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 16c722b2b13373d2206cb562ad8cf606efc48d35) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-06remove span data storage from oox importNoel Grandin
We are not using it, and removing it reduces peak memory load from 648M to 548M when loading a large spreadsheet Change-Id: I683bfba6c8f151d8845bbd7d5f92cde2a9c17807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 168f3572dc4c17910543ca0e93a0c5e04113fbf2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136770 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-06Use the same solenv/bin/ooinstall as in the cp-5.3 branchTor Lillqvist
Specifically, pass the correct product name and not a hardcoded "LibreOffice" for the make_installer.pl script's -p option. As such, instsetoo_native/util/openoffice.lst.in hardcodes the product name as "CollaboraOffice" so we could as well do that also in ooinstall. (cherry picked from commit 852ffcae172c8ce1536f847410d94b6fcb486b96) Change-Id: I9b2d84bcc18e21b325960f7057e259daa37234a5 Reviewed-on: https://gerrit.libreoffice.org/55640 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 12d1b08aac8cc8c3176040efc7290377e380f0c4) Reviewed-on: https://gerrit.libreoffice.org/79128 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 0069417b55c99166aec5489ccef803eba25d2b4f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136842 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-05sw content control, picture, lok: fix change of placeholder after insertMiklos Vajna
Commit c769c369c87a46ec877b7eefee27988044a2798f (sw content controls: fix picture placeholders, 2022-07-01) fixed picture placeholders on the desktop, but left the LOK case still broken. This is a problem since picture placeholders are protected (which is wanted), and these only allow SID_CHANGE_PICTURE, not SID_INSERT_GRAPHIC. Fix the problem by adapting SwXTextDocument::executeContentControlEvent() to dispatch SID_CHANGE_PICTURE (and not SID_INSERT_GRAPHIC), but do keep the slot ID of the argument as SID_INSERT_GRAPHIC, since SwView::InsertGraphicDlg() looks for a non-interactive URL as SID_INSERT_GRAPHIC even if we're changing an image, not inserting a new one. This means that LOK clients can't use SID_INSERT_GRAPHIC to change picture placeholders, they have to go via SwXTextDocument::executeContentControlEvent(), which is what gtktiledviewer does already. (cherry picked from commit 4002a399af823055b6ba59db18ded1caba4969c9) Change-Id: Ica42939f6564da3d59396a4b302be826d3968f8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136808 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2022-07-05Added option to disable ssl verification for languagetoolMert Tumer
This will allow to use self-signed certificates with local run languagetool APIs Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-07-04Rename UI Variant from Standard Toolbar to CompactPedro Pinto Silva
To be more in-tune with COnline options Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I38c4d1639dbf7d726fb8c3d784a298cd01a97201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136743 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-07-04sw content controls, checkbox: reduce left vs right amount of shading mismatchMiklos Vajna
This was a visual problem with all content controls, but most visible with short ones, like checkbox. A content control's layout starts with a field portion (shaded), followed by a content control portion (also shaded). The shading around the checkbox character is not balanced, the left side has more shading. Half of the additional shading is caused by shading for the field portion: avoid this in case we know where will be a content control portion after the field portion. The result is not perfect, but the left/right mismatch for the amount of shading around the checkbox is much better this way. (cherry picked from commit 0203485a7f7dd85f8d3e04ce91579051aa89d26a) Conflicts: sw/source/core/text/porfld.hxx Change-Id: I147d23c43e679113c84c21fbfc0c8ac1ca9e51b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136795 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sw content controls: link ODF proposalMiklos Vajna
(cherry picked from commit 3f379f00b17268fbb63ba072d04336acb0c7e398) Change-Id: I18a62cce01eb8a5cc1764ee813a9265cb02c5fdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136794 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04tdf#149748 sd theme: fix crash on selecting none from color barMiklos Vajna
Opening Impress, going to view -> color bar to enable it and then clicking on "none" resulted in a crash. This went wrong in commit f5db3b12ae1cd3bfe6ee5d260aec9532cc65f2dc (sd theme: add UI (sidebar) for shape fill color, 2022-04-06), where I assumed that in case the slot is a SID_ATTR_FILL_COLOR, then its item set also has a SID_ATTR_FILL_COLOR key. This is usually true, but not in case of "no color" (i.e. transparent). Fix the problem by just skipping theming metadata for such a color. It seems to me that the color set of a theme is not allowed to contain such "no color" colors, so this should be safe. (cherry picked from commit c09eb0f74c0a110e4a4cfc4783b59883aad30475) Conflicts: sd/qa/unit/uiimpress.cxx Change-Id: I3fb65548dca1d78631311de56c15fdb655b9645a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136751 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04cid#1503836 silence Dereference null return valueCaolán McNamara
(cherry picked from commit 64046625553ecbfd9fe0661e5b6f48e283a909e0) Change-Id: I11dae0872d1f4add67b59ffd9696134c1dd2dbea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136750 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sd theme: consider accent1 color when inserting shape with solid fillMiklos Vajna
Once a theme is defined for the master page of the current slide, PowerPoint inserts a shapes with their fill color & line color set based on that theme (so this color is master-page-specific), while Impress sets the fill & line color based on the default shape style. The Impress behavior has the benefit of doing the usual style-based formatting, but now a document-level style overwrites a (master-)slide-specific theme, which is inconsistent. Fix the problem by extending sd::FuConstruct::SetStyleSheet(): if we construct a shape with fill, then not only apply the style sheet, but also set the fill & line color based on the theme (if there is any). Note that this works both in case the shape is instantly created on click (LOK case) or when the user first draws a top-left -> bottom-right point pair to define the position / size of the shape. At the same time line colors don't support themes yet, so that color is just a plain value for now. (cherry picked from commit 486810603fb3f84847bb549004ed0394a2e22d0b) Conflicts: sd/qa/unit/uiimpress.cxx Change-Id: Ic6ae8f91bd719bd80f2b56f12b001d29b0961e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136749 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sd theme: add UI (sidebar) for shape fill color effectsMiklos Vajna
Which was perhaps the last missing piece of the "sd theme: shape fill color" story. (cherry picked from commit 645413a14a91a72bc06acf0fb4703ff7b9fffec9) Change-Id: Ice75d91412aa56afe0c9995086097d491ebf7299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136748 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04tdf#149205 sd theme: fix PPTX export loosing dk1 and lt1 colorsMiklos Vajna
Document theme of Impress documents were exported to PPTX only partially: dk1 and lt1 was hardcoded to the SYS_COLOR_SCHEMES define, while the rest was written from master-slide-specific svx::Theme. The benefit of this is that our theme is just a set of colors (<a:srgbClr> markup in OOXML), while dk1 and lt1 is more dynamic by default in PowerPoint (<a:sysClr> in OOXML). The downside is that this way a custom dk1 and lt1 color was lost on export. Fix the problem by switching to <a:srgbClr> markup even for dk1 and lt1: not using the <a:sysClr> markup doesn't seem to be a problem in practice, or at least much less problematic than rendering with bad colors. If there is a need, dedicated <a:sysClr> markup support can be still added later by extending svx::ColorSet::maColors to not only store a list of colors, but also some additional properties of those colors. (cherry picked from commit 4a54a24c207f3040390e2fefec41cbbf0edd5eca) Change-Id: I26df3fd8c891c217df0d36382f6599805198f4bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136747 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sw content controls: fix picture placeholdersMiklos Vajna
This went wrong in commit c321498f915f4e8b3f4853232860ce040ab48e46 (sw content controls: reject typing inside checkbox or picture content controls, 2022-06-10), now a freshly inserted picture content control is not replaced with an image on click. The problem is that we want to forbid typing into a picture content control (it should only host a single as-char image), but changing the picture's bitmap is meant to be still possible. Fix the problem by allowing SID_CHANGE_PICTURE even if the cursor is protected: this allows changing the picture again, and a real read-only document still doesn't show the "change" menu item in its context menu. If we later find some other corner-case where this command should be still disabled, we can extend SwGrfShell::GetAttrState(), similar to how e.g. inserting images in input fields is disabled there. (cherry picked from commit c769c369c87a46ec877b7eefee27988044a2798f) Change-Id: I8b55e930330b9748ecda950dedae907b86c57e2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136746 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-04sw content controls, dropdown: use DecorationView for the button's arrowMiklos Vajna
Instead of drawing manually, which was the way form field dropdowns did it. Also enable anti-aliasing. (cherry picked from commit 48010539f695bc269034f12cf72aa0665cca10de) Change-Id: Ia1ab5fe6168e0fb51dba3c760301764cfd1e0514 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136745 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-02Update git submodulesChristian Lohmaier
* Update translations from branch 'distro/collabora/co-22.05' to f9bd9ed1749294bfb0113bbf05645e788918e9b7 - update translations for 7.3.5 rc1 and force-fix errors using pocheck Change-Id: I6b8f0f326c1ef1f3804409057e3081bf2b2caaa0
2022-07-02allow to specify a macOS provisioning profileChristian Lohmaier
having one is one of the prerequisites of using TestFlight Change-Id: I9e20eb99905071fade4179dfbe2da5b7e5dd1c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136618 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit b43f0b0295953c8d5d16c5b9eccaddb5ec214bab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136695
2022-07-02tdf#149603 macOS: fix workaround to use web help if Safari is the default ↵Christian Lohmaier
browser Safari won't access the local helpfiles from LO's app folder unless you enable Safari's webdeveloper menu. The workaround broke since f31f0038f5fd9254584a06665066faf9715d1cd8 switched from window to widget references and hence using a different codepath, skipping the workaround added in 44893662d510c4173e55ba27af02d0258a697a5d Change-Id: I0c59066fe1cef1514c6595e0439d31d3e60e02f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136685 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 82acd35e3cc5dc458930daaf6de9f41c7deb73dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136704
2022-07-02sw: avoid another EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/lcl_ModifyBoxes Change-Id: I786bbf87734dd3963bd84caecc5c5f45693d42c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135185 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit aeeb0141aca4f1698b09bc8f06ded41247b54279) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135255 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-07-02tdf#149787 capture a copy of mpViewShell and mpViewCaolán McNamara
so the callback can outlive the FuArea Change-Id: I392ffa46b6f13795faef7284c1cae74428655b5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136694 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-02allow pretty names in --enable-macosx-code/package-signingChristian Lohmaier
also reorder the logic to avoid duplicating the matches for default value and manually provided one. Change-Id: I4466cbeaf5abd7168f21e22cd910f63568c14e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136224 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 2f5b54ba51157a2346e10dfb82e3d434d6030aaa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136551 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-02related tdf#126961 don't crash when access to the macOS address book is deniedChristian Lohmaier
quick'n'dirty fix, ideally the user should get a message to reset the privacy setting and try again... Change-Id: I51cb852e305e285c87ff3a0e15b5198a2b1c5970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136620 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 5ab29d945a18824eec53426edece4f19a02610ed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136640 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02don't specify entitlements that are not used (sdremote w/o bluetooth)Christian Lohmaier
the network.server entitlement is only needed when the sdremote is enabled, and the bluetooth one only when the bluetooth part is built. Also warn about bluetooth not being built because of obsoleted/removed API. It was "silently" dropped before (lost in the flood of configure output). Change-Id: I38d83aa1132307b5b4b5d6dceba8f9020ffb2373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136617 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136626 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02tdf#126961 fix access to the macOS address bookChristian Lohmaier
Having the personal-information.addressbook entitlement is not enough. Without the plist key NSContactsUsageDescription, macOS will not ask the user to grant access and the request is implicitly denied without any feedback/logging. Change-Id: I954fa86b35a128f08e5c498191bc0949e0edeebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136619 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit ccf518a6fd2819e6a328e953d5e7356d8d9bd11f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136637 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02tdf#141313 only hide Impress Remote option if there is no sdremote at allChristian Lohmaier
it was incorrectly based on bluetooth support, but the remote can also be used in the local network. Regression from 4cdb960a79aff565f956f618116f3ea4b3836aa4 still worked for users who had it enabled in earlier versions, but not with new profiles. Change-Id: Ib4026c60fed0842b3bad483d78e46dd73d1d75f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136615 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 8d7c441097cc0279a9819fe0673b8cad40ae94db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136642 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02impress remote connection dialog must also work without bluetoothChristian Lohmaier
as otherwise you can never confirm the pin to approve new devices. old regression from 7c8c73dd5cf84050a8a2c51b04d7f5278b409fd7 still worked for users who had it enabled/linked in a previous version... Change-Id: Icf9fb6ae4259252da47c3709ab99fb7a2a70aeac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136616 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit c7147cd2504d1d3f91ca5b0a5e119ca9d2185b37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136635 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02Don't link against private CoreUI framework when sandboxedChristian Lohmaier
Actual use of the code was already disabled since 2014 with b8bee05dbf85bc4f5834520aa5d64e9ae18aba4e - but the link flags were not conditionalized. Change-Id: Ia1dd299cb78274850eb6a7b10259991bb4970ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136614 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 7a493a7d64dc634ae2d5d6931b8ce33223cb3985) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136553 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-02BridgeFactory should be a singletonNoel Grandin
regression from commit 9be078ae0d4cc4e4c01952bb42c9bb5943bbde86 Date: Sat Jul 4 09:12:35 2020 +0200 binaryurp: create instances with uno constructors Change-Id: Ib7a7316fdee4afffac35b282adaf437ff8bdd009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135904 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7531f027c742a601c13a7a849dfae795a148d899) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135989 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit e04635f338b9a39df0ed62b0909b0ac56c9a5b76) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136030 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-02tdf#126263: do not try to delete non-temporary filesMike Kaganski
Change-Id: I5df7db7eac6224fce833e6b9d4ea220cade44e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136483 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136491 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136506
2022-07-02tdf#126263: make sure to convert system path to file URLsMike Kaganski
Change-Id: Ia21f29e3a1eb078a7df2366399c59d46ab26ff3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136482 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136490 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136505
2022-07-02Integer division could cancel small values of wrong signMike Kaganski
... as seen at some documents where the values are like -1. There the checks in pushToPropMap may pass (the division result would be 0), but the original small negative values would fail the asserts that were introduced in commit 5772cef244dbee5834efbc693bc714d89ae6301d Author Mike Kaganski <mike.kaganski@collabora.com> Date Wed Jun 15 18:33:38 2022 +0300 tdf#134210: Reimplement cropping from srcRect and fillRect Change-Id: I114588862b5cfd2b2e4491424430cc139bdbaae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2d9f3c066a065d6aa98f1e594dcf8a091fec2bde) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136471 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136556
2022-07-02tdf#134210: Reimplement cropping from srcRect and fillRectMike Kaganski
This avoids the scaling after the crop, since scaling is performed anyway when applying BitmapMode_STRETCH. This improves resulting bitmap quality. Also consider the "crop to zero" case (when the sum of cropped parts is equal to 100%). In that case, just use an empty graphic as the fill bitmap. This makes the differences between srcRect and fillRect processing explicit, simplifies the code, avoids extra rounding inaccuracies, and takes care of the edge cases that were considered in commit 2859ec288f2c1323ea3123d82cb1684b349ff598 Author Miklos Vajna <vmiklos@collabora.com> Date Wed Jun 15 15:52:18 2022 +0200 oox: fix div by zero in lclCalculateCropPercentage() The change in SdImportTest2::testTdf134210 is because we now don't scale the cropped image. The previous value was an interpolated color, while the new value is the actual color of pixel [0, 41] of the original image. Change-Id: I24fa9928cff32bcaa6a7b3e34def14700fddd7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135917 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5772cef244dbee5834efbc693bc714d89ae6301d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136038 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c7a21bfed044154cac23328d37b46f34aeda0709) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136155
2022-07-02tdf#149692 crash importing document with vba formsNoel Grandin
This bug appears to date back to commit a43cc9ec8dde4f311bcf8ff96e6a26d56b2abdcf Author: Noel Power <noel.power@suse.com> Date: Wed Apr 17 17:08:59 2013 +0100 implement MultiPage, Page & TabStrip import for oox Change-Id: Ia4784e4c34189f05e516704fa2e2485e4560fa4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a15fe37bf1dc50fcf88cea9c0038b217119671b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136472 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ef79ccd5bbd5fbc0f0c132c4fc5a48fcd1fbbc16) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136535 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-02sw: avoid divide by zero in SwTextGridPage::CharorLineChangedHdlCaolán McNamara
See https://crashreport.libreoffice.org/stats/signature/SwTextGridPage::CharorLineChangedHdl(weld::SpinButton%20&) disable the offending widget if the value is zero. crash reproducible under gen with CJK features enabled by: format, page style, text grid, grid (lines and characters), max base text size of 1000 and then click in "characters per line" and then click in "lines per page". Change-Id: Ic0f8131955ab01412dd54bdd5d3bffe518938fb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136470 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-02LOK: Allow image upload from WOPI-like host with self-signed certAndras Timar
Change-Id: I28a7de489b06fd5a993b82bb39274eb6f0c373ce
2022-07-01sd theme: add UI (area dialog) for shape fill color effectsMiklos Vajna
SvxColorTabPage::aCurrentColor already had these effects and XFillColorItem already had a way to store the effects, just connect them in SvxColorTabPage::FillItemSet(). (cherry picked from commit 2589f8a155d00b22078607ddd0229d155a394f3a) Change-Id: Ie3f6c1916d2cfa3f26732e105b9bae101d70fc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136733 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-01tdf#148961 sd theme: add PPTX export for shape fill color effectsMiklos Vajna
Which allows taking the fill color theme index from the model even in case there are effects. Previously effects meant reading from the grab-bag, and only the no-effect case read the color theme index from the doc model. (cherry picked from commit 109debb0ca0c864296ad7f557cfbc2b05c9ec3c2) Conflicts: oox/qa/unit/export.cxx Change-Id: Ib50c3128b971a388f14ad721ed7f73043916a736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136732 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-01tdf#148929 sd theme: limit PPTX import for shape fill effects to lum mod/offMiklos Vajna
Regression from 30735bdb5a0a81619000fdd24b2d0fbf45687f01 (sd theme: add PPTX import for shape fill color effects, 2022-04-27), the bugdoc's A2 cell lost its tinting (its background color is no longer lighter than A1) after saving back to PPTX + import again. The code assumed that in case a fill color has effects, it can only be luminance offset or modulation, since that's what the PowerPoint UI generates when setting a fill color explicitly. This did not take the table style case into account, which uses tinting to make a color lighter. Fix the problem by not importing the theme index / effects if tinting is used -- the current doc model is limited to theme index + lum mod/off with effects. This limitation can be removed while text color / fill color effects are not limited to lum mod/off, but also support tinting/shading. (cherry picked from commit f932b00f3a72dd802a6e50af84c3dc55072a22a0) Change-Id: I382cc0067518cc262e261a462999170cb7db261b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136731 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-01sd theme: add ODP import/export for shape fill color effectsMiklos Vajna
Map a themed color with effects to: <style:graphic-properties draw:fill-color="..." loext:fill-theme-color="..." loext:fill-color-lum-mod="..." loext:fill-color-lum-off="..."> (cherry picked from commit 0c13e4768c3c7937c2fd71675c86ff8a0ca3fe50) Change-Id: I18d8ddf8d6050ef468a8d67a9e797a576f682e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136730 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-12 12:43:36 +0000