summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-24cid#1555216 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555525 COPY_INSTEAD_OF_MOVE cid#1555562 COPY_INSTEAD_OF_MOVE cid#1555676 COPY_INSTEAD_OF_MOVE cid#1556099 COPY_INSTEAD_OF_MOVE cid#1556527 COPY_INSTEAD_OF_MOVE cid#1556607 COPY_INSTEAD_OF_MOVE cid#1557084 COPY_INSTEAD_OF_MOVE cid#1557141 COPY_INSTEAD_OF_MOVE cid#1557937 COPY_INSTEAD_OF_MOVE cid#1556099 COPY_INSTEAD_OF_MOVE cid#1557774 COPY_INSTEAD_OF_MOVE Change-Id: Ifd716627d985dd43f4d1a9ce3df151e519fab03a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177163 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-24tdf#164005: also initialize locales in hyphenate()Mike Kaganski
... which is also used in queryAlternativeSpelling Change-Id: I7f0bbbc6e598d56156efe1446f422f9674ed6f25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-24Revert "tdf#152299 - Remove unused define(s) from C/C++ files"Julien Nabet
This reverts commit 16a5ae7c90a3349854fb3975b435c24f08c0a51c. It seems to break public API. Change-Id: I0ef2c6e975b4cf20b9894ddf33f36444e2230ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177168 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-24Revert "tdf#152299 - Remove unused define(s) from C/C++ files"Julien Nabet
This reverts commit aee4e184119512dc407d8a3696653b57d3d9a54f. It seems to break stable API. Change-Id: I64b7b1b5a5f5d53649a6117de34790238313ed23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177170 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-24Simplify a bitMike Kaganski
Change-Id: I0b3e02669b326533f4579f57a41a16da53cf8ff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177188 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-24tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macroMohamed Ali
Change-Id: I958365b3db058ec809702a5ddde1d153467f21ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177158 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-24Turn SD_MOD macro to a functionMike Kaganski
Change-Id: I1303e9d48e92ac00eee12af9ed299cdaad2ce009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177072 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-24Turn SW_MOD macro to a functionMike Kaganski
Change-Id: Ide1f6fd2fc8a80b31353a14e416505a2349cea2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-24Turn SC_MOD macro to a functionMike Kaganski
Change-Id: I5fc11037902bc6200fdaf4749260efe8e658bdce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177070 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23GetAttrOutlineContentVisible may be constMike Kaganski
Change-Id: If94b948ddcc2fac9bce254947b78afc1c6f0383e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177078 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23related tdf#157255: add DisableLayerHighlighting expert settingJim Raykowski
This allows the layer objects overlay to not be done when the value set for DisableLayerHighlighting is less than the number of objects in the layer of the tab which the mouse is hovered over in the layer bar. Change-Id: Ie49ecb11bfb029ada57824c0acbbd133e1fe83b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176809 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-23Avoid new string allocations, when only checking if emptyMike Kaganski
Change-Id: I35a44dedd27b5c3470ed035e64ec0461d8d0cbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177074 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23Reduce copying of ScEditEngineDefaulter's SfxItemSetMike Kaganski
Change-Id: Ifea96f2cf586b4e5b63761e2f03944dade764430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177073 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I9b27cfb715f6cd0a9b6ea21da9cb24fc8d8ec739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177050 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I377154880c52685e5b1588221d631c51967c490a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177047 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I93494b4dec546d48b7dced2f1a6c774177c99c86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176782 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I0a6d9a12f3e6d84ad4ba665ba16dd05fb6f9786f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177048 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I95b7b249082f5c2755ca54a0656912011d2cb116 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176983 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I161af7b70421a819f5ecb6b95867e6fa142fe3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177046 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I183330f8c2e947d6c8dffbcabc7da6c115e08a8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176963 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I3207e070fba8407fd8475c8d774b3a500cae8e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176965 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: If150b8fec5350cb513550711a61923cc1a273a80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177052 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Id74c10f5965d97bf24b49fc9ee777bf7b0ad251d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177051 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ided473c985f8bdca007d3da34f92e42fb5080f54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I01cc9d30499783e531777eb17e332490afab4d6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177098 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#158237 Use C++20 contains() instead of find() and end()Simon Chenery
Change-Id: Ib0ed8868b94c1470768a95fb26767cf25fe4bf8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177028 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Id5d1b36ba734c3cf10b83f472ab5afe3a142a464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177060 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I38b932ab81842b5f209d89ef5229d61e10f3ffd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177097 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I1e460b817dd876977e520251b6a79d9fb9c283d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177100 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23Spelling mistake in codeBogdan Buzea
Change-Id: I9db111c16865a2b7514e62a21a66d5497cda91fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176966 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#130857 qt weld: Hide widget marked for deletionMichael Weghorn
Add a helper method QtBuilder::deleteObject that takes care of marking no longer needed objects for deletion and use it in the 3 places so far calling QObject::deleteLater themselves. If the object marked for deletion is a widget, hide it as well, as it could otherwise still be "in the way". This was seen wit the edit (QLineEdit) of the editable combobox in the "File" -> "Properties" dialog, "General" tab (in a WIP branch for adding support for that dialog), where the unnecessary edit was shown on top of the combobox, hiding the combobox content + dropdown button. Change-Id: Ie299b80824c94d40cfac9f7962c9bd4ba95b446d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177057 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-23tdf#130857 qt weld: Call checkbox toggled handlerMichael Weghorn
Change-Id: I0943a2d8e35acea8e1af97bdd151bba65b0af24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177056 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-23tdf#130857 qt weld: Handle invalid ID in QtInstanceNotebook::get_pageMichael Weghorn
If QtInstanceNotebook::get_page gets called with and ID that none of the existing pages actually have, return nullptr early and don't try to QtInstanceContainer instance for the null widget, which would trigger an assert when nullptr is passed to the QtInstanceWidget base class ctor. Calling QtInstanceNotebook::get_page with an ID for which no page exists yet is what SfxTabDialogController::AddTabPage does explicitly before asserting a page to assert that there isn't such a page yet. SalInstanceNotebook::get_page and GtkInstanceNotebook also have specific handling for that case. Change-Id: Ib2044fd4c9f986f2252afed5754a6383f940e5e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177055 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-23tdf#130857 qt weld: Implement QtInstanceDialog::weld_content_areaMichael Weghorn
When this method gets called the first time, insert a widget with a QVBoxLayout at the beginning of the dialog's layout, remember and return that. On subsequent call, return the same one. Initially, handle the case where the dialog's layout is a QBoxLayout (subclass), which is the case for the "File" -> "Printer Settings" -> "Options" dialog in Writer. This should be easy to extend for other layouts as well when needed. For now, assert when another layout is used, so it will become clear when working on adding support for another dialog that needs this. Change-Id: Ia41a87f8cf62666efc91c05f25dae5fccb3da41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177054 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-23tdf#164006: Only use original word's positions, ignore extra encoded lengthMike Kaganski
The encoding of the string passed to Hunspell/hyphen service depends on the encoding of the dictionary itself. When the usual UTF-8 encoding is used, the resulting octet string may be longer than the original UTF-16 code unit count. In that case, the length of the buffer receiving the positions will be longer, respectively. But on return, the buffer will only contain data in positions corresponding to the characters, not code units (it is unclear if we even need to pass buffer that large). So just as the following loop only iterates up to nWord length, the calculation of hyphen count must use its length, too, not the length of encWord. I suspect that the use of UTF-16 code units as hyphen positions is wrong; it will break in SMP surrogate pairs. The proper would be to iterate code points. However, I don't have data to test, so let it be TODO/LATER. Change-Id: Ieed5e696e03cb22e3b48fabc14537372bbe74363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177077 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#164005: make sure to initialize locales before use of HyphenatorMike Kaganski
Change-Id: I23ab742801ab00b68e4f8c5e7bc415c401e28c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177076 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Iae168766fdfcbf4c68aa0770b0c42e96a61001c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176964 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ic07d9b5e5ed5c486f2fefbd535b4209a1a62eae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177066 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Ifbdf8e07aa8085e465df45b48fe54345f0ad56e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176961 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I23379077766af9c04357bd098b132a03a9b35877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177061 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#162195: use SwFrame::IsHiddenNow when building indexMike Kaganski
Before commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565 prerequisite: make hidden sections have zero-height frames, 2024-02-15), the hidden sections were absent from layout, so didn't appear in the SwTOXBaseSection::Update* functions. Now they are zero-height, but present, so their visibility must be taken into account explicitly. Change-Id: I95cc72b383a99e1f65152579c5458e253a3f60ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177079 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I171b90858f58c4afa8984f55864712e8b7a93b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177088 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: I7206e5ac7f525d810505230ef4dcdaa5fff3fbf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177065 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea
Change-Id: Iac23bad883f54bd980d051fe74474efdcd2572a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-23Use specific SvtModuleOptions::Is*Installed for clarityMike Kaganski
Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23Simplify a bitMike Kaganski
Change-Id: I6cb0d64119b859446e015eccb6438396960f351e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177068 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#163486: PVS V1028 Possible overflow. Consider casting operands,Aron Budea
...not the result. Change-Id: I4ba8afa5989aea906000bb9c4059855015055002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177042 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-11-22Related: tdf#160517 - chart odf: import/export formatted chart titlesBalazs Varga
No need to check chart title paragraph style name and ID, since its never exists. follow-up of: d7214aba95bbdcbd40e87ef50fc66f2e2ec4f5ff 6fdad723729a458eaff7ca509cb202ad355832be Change-Id: Ieffe3026adc848cfbf3a847b4f876b5aa2e2a026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177011 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-11-22bump product version to 25.2.0.0.alpha1+Christian Lohmaier
Change-Id: If5be3912a516f279ada6f6b5d82b927701a0ac16
generated by cgit (git 2.34.1) at 2025-01-09 16:05:11 +0000