Age | Commit message (Collapse) | Author |
|
This is a follow-up to 2d64651e889e55f63c90ded24e63e17eaf52102f "Fix loading of
basctl with --enable-mergelibs", removing checks that can never be satisfied.
(There is no plausible scenario where basctl would legitimately not be
installed. All uses of sfx2::getBasctlFunction are conditional on
HAVE_FEATURE_SCRIPTING, and basctl is included in section ooo in Repository.mk
together with sfx, so the latter cannot be installed without the former being
installed. That is also true for Linux distros like e.g. Fedora, where both
libraries are included in the core package.)
Two of the redundant checks had been added with
c6fc2647c8df5b9a7c41a192f2b78812d1f3656d "coverity#1132691 Dereference null
return value" and 5fb8f03be61add8320045471edc55ce3f7c4fa8d "coverity#1224981
Dereference null return value", presumably in a misguided attempt to silence
false Coverity warnings. The third check had been added with
0b21b8b146fc4b982c7c9bbb866b9ff18a29332a "initial commit for vba blob ( not
including container_control stuff )", for unclear reasons.
Change-Id: I4a6137edfe4b51d297b115990e16d910325694af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92143
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Prior to this commit, numbering on paragraph styles
was lost on import. This didn't affect layout at all,
but it did affect user editing.
DOCX: export already was fine, just import was missing.
RTF: export is explicitly ignored for non-paragraphs,
(ParaNumRule_Impl), so I am ignoring RTF, since
this fix is meaningless unless both import and
export are working.
This is a bit tricky because styles.xml is loaded before
numbering.xml, so the names are not known until after
numbering.xml has finished. So this helper function runs
at the end of the numbering.xml import process.
Several existing unit tests nicely confirmed a few things.
-tdf95377.docx: numId 0 overrides an inherited numbering
-chtoutline.docx proves that outlineLevel styles are exempt.
-fdo61343.docx actually has nothing in numbering.xml,
so it is possible to have a numbering with no name.
Of course, it is a really messed up document, too...
Change-Id: I270a581f08704c2595d861ce5c5b546f9d6ba6b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92058
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
This speeds up the loading of the bugdoc:
- old cost: 6378 ms
- new cost: 1891 ms (30% of baseline)
Images were initially loaded at import time, but commit
acb803b730f2c6bd82e39beab58949ec14f85eb0 (tdf#125591 DOC import:
lazy-load metafiles with explicit size, 2019-06-11) changed this, so
that they are lazy-loaded. That improved performance, but sometimes gave
incorrect results.
Then commit d8371cdfd092c6426c01aae130ea4eaa6d627a6f (tdf#127446 vcl
image lazy-load: fix custom size handling of metafiles, 2019-09-30)
fixed the correctness problem, but the loading was no longer lazy in the
tdf#131496 case.
This is an attempt to bring back lazy-loading for vector-based images,
while maintaining the correct preferred size.
The problem was that the PPT import triggered a vector -> bitmap
conversion during load:
#0 0x00007ffff03c7e36 in ImpGraphic::loadPrepared() (this=this@entry=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1424
#1 0x00007ffff03c72c7 in ImpGraphic::ImplSwapIn() (this=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1444
#2 0x00007ffff03c7535 in ImpGraphic::ensureAvailable() const (this=this@entry=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1402
#3 0x00007ffff03c9481 in ImpGraphic::ImplExportNative(SvStream&) const (this=0x1f88a90, rOStm=...) at vcl/source/gdi/impgraph.cxx:1590
#4 0x00007ffff03bf9a8 in Graphic::ExportNative(SvStream&) const (this=this@entry=0x20534e0, rOStream=...) at vcl/source/gdi/graph.cxx:544
#5 0x00007ffff1c79a28 in svt::EmbeddedObjectRef::SetGraphicToContainer(Graphic const&, comphelper::EmbeddedObjectContainer&, rtl::OUString const&, rtl::OUString const&)
(rGraphic=..., aContainer=..., aName="Object 1", aMediaType="") at svtools/source/misc/embedhlp.cxx:773
#6 0x00007ffff1c79b6f in svt::EmbeddedObjectRef::AssignToContainer(comphelper::EmbeddedObjectContainer*, rtl::OUString const&)
(this=0x207ae90, pContainer=pContainer@entry=0x1f8de40, rPersistName=...) at svtools/source/misc/embedhlp.cxx:369
#7 0x00007ffff239f736 in SdrOle2Obj::Connect_Impl() (this=this@entry=0x20734f0) at svx/source/svdraw/svdoole2.cxx:984
#8 0x00007ffff23a6310 in SdrOle2Obj::Init() (this=this@entry=0x20734f0) at svx/source/svdraw/svdoole2.cxx:695
Try to defer that conversion by not doing a
maVectorGraphicData->getReplacement() in ImpGraphic::ImplSetPrefSize(),
rather just store the preferred size and apply it later when
getReplacement() is called.
This helps, because the above OLE-from-PPT case loads the graphic, but
only to export it as SVM, so it doesn't need a vector -> bitmap
conversion otherwise.
Change-Id: I24790c0a3e298d5fbb3faff35d529e79cc72845a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92144
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
to provide a more generic callback interface and expose
it as public to allow other usage.
Change-Id: I6bc62a05fee750586f7281d8c24f2133884e77ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92134
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Default is to decompose and process the primitive
recursively, but it is not necessary since the shape
is regular. So perform the hit test using getB2DRange()
like FillHatchPrimitive2D or FillGraidentPrimtive2D.
Change-Id: Ie9d91943d2f3502938e41b7f6b0a364d9da15d63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
- Update line icons
- Update Font Color icons
Change-Id: I2bd9970c62669dc97a528c61df10566e83edb39a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92140
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I8872a9dc81cdccb9cd8809e819184c3119fc358c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92119
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92133
Tested-by: Jenkins
|
|
Change-Id: I2c3d19dff2da99b030f6a7e1a8b62be509e073da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92118
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92132
Tested-by: Jenkins
|
|
Change-Id: Ie4154042296c9a239bf9a2bc5f3ab1d7ee59c148
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92131
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
in SkiaCompatibleDC::getImageAsDiff
when loading the larger example file.
We hit the abort because we have a rectangle here
with width and height -2.
Not sure where that is coming from, because the crash
doesn't happen in debug build, only optimised.
Change-Id: I448b418dee26536d361e82e4d649be447ba43725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92127
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I51881c04c071a411855da1629319bfbe735f51ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92114
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ifa8f49e18902c2d279e5ac04c8187d9a1a4b9de1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92111
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: Id733bfb64cd750f80a13b36e1937137354282787
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92109
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I9c2f21491ef97f9a1b82f43cdb9b0b978689f70b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92110
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Remove duplicated StyleSheetImport section,
and redundant valid pointer check.
Change-Id: I468733fc627fbdbebb2daf7087ce9e65158751df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92065
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
* Update helpcontent2 from branch 'master'
to f8cd9798934f2cb336b09990c6d2f84a6cadcc36
- tdf#131960 Clarification of FLOOR/CEILING functions
Change-Id: Ifb90e95d632f0305d15562e9732dac7e3dc6d6ca
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92097
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Papered over already with a bandaid in
c13f75de521cfb67ca4db431708f8cd366b23587, happened again after skia
upgrade; let's now fix th eICE on CentOS7 devtoolset-7's gcc proper.
It appears that this error
workdir/UnpackedTarball/skia/third_party/skcms/src/Transform_inl.h:696:13: note: The ABI for passing parameters with 16-byte alignment has changed in GCC 4.6
static void clut(const skcms_A2B* a2b, F* r, F* g, F* b, F a) {
^~~~
workdir/UnpackedTarball/skia/third_party/skcms/skcms.cpp: At global scope:
workdir/UnpackedTarball/skia/third_party/skcms/skcms.cpp:2645:1: internal compiler error: Segmentation fault
is caused by the clut() function still inlined for gcc. Patch makes this
go away by leaving clut() with external visibility, thus getting gcc to
outline it. Original Google hack with __attribute__((noinline)) alone
appears insufficient.
Change-Id: I8a566994ac815ae480ef1ce1b80c4fb59bef2f92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92094
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I9114ff79c808a552edf06be534e10f2106dfe171
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92092
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I95ff8794addcce6a73d32f49222adffd7d824255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92090
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
since we put it into the config_options.h header
Change-Id: I72320762f8f7b671d69675b8afb17b7bfa2e706d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
In Online, sounds cannot be heard, cannot be selected, so it's confusing
to have sound settings on the Custom Animation Dialog
Change-Id: Iff5155289700c412d9e50542de7e4fcf7830b67a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92087
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
In Online, sounds cannot be heard, cannot be selected, so it's confusing
to have sound settings on the Online sidebar.
Change-Id: Ica4ee1e73bc0972048986ff9c2fbcba5d4bd9bd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92086
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I7f86ea7135fcb4071cc0162c233c63be6c9485bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92083
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
|
|
Change-Id: Ib4702627578e06f209c9c58021971eb4e1ed39a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92081
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- no need for mpPolyPolygon to be allocated out of line.
- expand out LongDqPtr typedef, not much longer and makes the code
easier to read
- allocate mpBound inline using std::optional
- rename RangeCache to RangeCacheItem
Change-Id: I55032a31eaefa844059edb5f0ee599f1b813ac80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92079
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I80aa192651595a719a5ac9a06423d2cf80aa7a3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92078
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I3458110f0cd7a5ff9e81d59d864f831038335ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92077
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
There is no need to hide std::shared_ptr<VectorGraphicData> type
under an alias name. It doesn't make the code more understandble
and it usually is the exact opposite because we know with what
type we are dealing with.
Change-Id: Iec80ee99697ff2fe3a8275fc2787b5370510ebe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92069
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I4826b94da3982be8807c4eba63971cb7d3df9d8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92070
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ibfec031daaa3b92d2286113c3ef981cfa6d09f05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92072
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I5e4ef6aadd25697beb0d3289ee22cef1e5ac433b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92071
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ic914fcb9a0bf9b30feff40ec39c1002ac6eae1cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92068
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
so we print out the full namespace, which is quite handy when
tracking down attributes that are not being parsed.
Change-Id: I085d39b365d43c1a53a7c176b633ea38e6a7fb45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92064
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9ac779a4b4a5578842a466bf5d03529ba658b6b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92066
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I227e304c6868afe7a98dbd8e96487270d06ce1eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92067
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
regression from
commit 1872b44c9a2ee2bd00be54c6c310b72579d7a47f
use FastParser for the XMLVersionListImport
Change-Id: Ib6e9e14758c25c6ff090fe8f929984449e045c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92063
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
regression from
commit 0ef5c47547bec6319b853326603f3b807407fe78
sc: rowcol: tdf#50916 convert core/tool
Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
To make the code easier to read.
Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...as is used by GCC trunk libstdc++ std::unique_ptr since <https://gcc.gnu.org/
git/?p=gcc.git;a=commitdiff;h=5b074864f8c593fd4bccee788a023a37b446b2ed>
"libstdc++: Add comparison operators to std::unique_ptr", which caused
unexpected warnings like
> sfx2/source/dialog/tabdlg.cxx:1057:17: error: parentheses immediately inside vardecl statement [loplugin:unnecessaryparen]
> bool bSet = ( m_pSet != nullptr );
> ^~~~~~~~~~~~~~~~~~~~~
(CXXRewrittenBinaryOperator was introduced with <https://github.com/llvm/
llvm-project/commit/778dc0f1d49230f53401ae0c190fe460bda4ffd1> "[c++20] Add
CXXRewrittenBinaryOperator to represent a comparison", which first appeared in
LLVM 10.)
Change-Id: I68024d975dc4accbfa9da855baa37bf9f990b99c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92061
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I71a532667d4ef6b2db223fddc8afcf7384bfe7fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92057
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I2fa7c291c2635fb7ec15a8cc30f7a4a39a2f5b37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92054
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I4ae66d3c69850fefedebcc4beeaa924de9859570
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91757
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I83e3f0a75369739579b95471cfea90569bebf4ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91813
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I7863aedccbf22a0958f407b8f3aefe7ed997f9b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91812
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I2ee332ffeb9004535882a7859f1821624ef5efa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92017
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
In an age where GDB (or whatever other platform debugger
you prefer) is easy to use, there is no point in
asserting something that is going to crash anyway, is there?
Asserting is only good in these cases if you follow it using
an _if_ statement. Noel informed me that it can also be used
to silence false positive coverity warnings.
Change-Id: I5a5cb7a22019768ec2807f6918d4a8ebb51194de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92049
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1cf633ea0be39c58bf38026d5ea73ad89bec72bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92052
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I69beef7f6014af1940cd89749f1712a40c74e543
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92053
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: Ib81a7d1c3330eced1680ba0966e49dbe063fb116
|
|
The errors are from DirectWrite not available, but I guess may happen
in some setups? But no point in spamming warnings either way.
Change-Id: Ic25ddcad474ccf007925ebf7afcd784da19f4b92
|