summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-22tdf#121129: custom listboxes in kde5 fpicker, first stabKatarina Behrens
for FILESAVE_AUTOEXTENSION_TEMPLATE only so far (e.g. menu Insert > Image) Change-Id: I5674025788ce9bab4094f717e2b940e7cd6891e3 Reviewed-on: https://gerrit.libreoffice.org/66705 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-21tdf#122031 Change element order for OOXML compatibility.Gülşah Köse
Change-Id: I8cca2db6157996dd25afa4c95e769725188fdfb9 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66686 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2019-01-21Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed executable permission on image files Change-Id: I74aba60b5c77fe9acb6252c207846035a9f67473 Reviewed-on: https://gerrit.libreoffice.org/66667 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add SMATH Elements in Contents Tree Change-Id: Ie2bcfa12cc85dab248063c1977638e044396e374 Reviewed-on: https://gerrit.libreoffice.org/66697 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update New Features video for 6.2 help online Change-Id: Ibe32ecee310b5d844c18e3cebec534328219325f Reviewed-on: https://gerrit.libreoffice.org/66695 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-21Update git submodulesMark-R
* Update helpcontent2 from branch 'master' - tdf#121065 Replace Attributes, Brackets and Format Icons with SVGs Replace Attributes, Brackets and Format Symbols PNG images with SVG and updated 03090800.xhp, 03090200.xhp and removed at21706 in Package_html_media.mk also removed lines with at21717, at21718, at21719, at21720 and removed line with im21106.png in Package_html_media.mk Change-Id: If504f6a39845695aef30a61826fecf8433a326ed Reviewed-on: https://gerrit.libreoffice.org/66659 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-21Simplify nXWidth initializationStephan Bergmann
...which happens to avoid an unhelpful -Werror=strict-overflow with GCC 7 and --enable-optimized: > vcl/source/edit/texteng.cxx: In member function ‘bool TextEngine::CreateLines(sal_uInt32)’: > vcl/source/edit/texteng.cxx:2197:9: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow] > if ( nTmpWidth > nXWidth ) > ^~ Change-Id: Ia87933da6e38b8b462d2ea34c3db6a84c5840f92 Reviewed-on: https://gerrit.libreoffice.org/66690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21tdf#101826 ww8import: add XATTR_* to textbox attr setJustin Luth
Somewhat magically, just adding XATTR to the FlySet makes background colors/gradients/images appear. This has been broken since XATTR was introduced in LO 4.3. Change-Id: I84554045f49618a5eb927edfebdf641c5a93b673 Reviewed-on: https://gerrit.libreoffice.org/66310 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-21Add a couple of known parameters to WordBasic.ToolsOptionsViewTor Lillqvist
Change-Id: Ifd472f4ca79ab97a1d6d5c5007537375121f6f58
2019-01-21Implement WordBasic.FileSave()Tor Lillqvist
Change-Id: Iafb5be16ebb23aa09e0300a77c2f2dbe29b85cad
2019-01-21SAL_INFO also for parameter names that are not foundTor Lillqvist
Change-Id: I1b3fd47a23002673cb81811ebfd0034ca546d837
2019-01-21Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselectCaolán McNamara
Change-Id: I941e32a973cdd1bc79e3739b24fdf834aa52cb11 Reviewed-on: https://gerrit.libreoffice.org/66628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Link 2 Help pages on GetPathSeparator() Change-Id: I81c23ff64baff8303d2f1936c2e426bd7ba59163 Reviewed-on: https://gerrit.libreoffice.org/66685 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-21sw_redlinehide: fix assert caused by buggy lcl_ModifyOfstMichael Stahl
converting ooo67907-1.doc to ODT asserts in fillSoftPageBreakList() while mapping an invalid (too large) GetOfst() of a follow frame. There are some problems with the lcl_ModifyOfst() implementation and usage: 1. the implementation iterates over all follows; but the follows will get the same SwClientNotify() call as the frame itself, so in effect the follows' Ofsts will be modified multiple times 2. the calls to lcl_ModifyOfst pass in a positive nLen whether the text is deleted or inserted; surely for deletions the Ofst should be subtracted from instead of added to 3. the special-casing of RES_DEL_CHR to COMPLETE_STRING while RES_DEL_TXT uses the length does not appear to be justified The assert happens since b15f1ed2a1df45a57b587ac90efa90c1c18866fc but the lcl_ModifyOfst logic never made sense. Change-Id: Ie92628515bbee0fcc2123eb412057d8c0fd0b2f1 Reviewed-on: https://gerrit.libreoffice.org/66679 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-21tdf#122748 Don't restore previous language selectionSzymon Kłos
Change-Id: I8688c65695080804bae22209ed5d4890ced1a8dc Reviewed-on: https://gerrit.libreoffice.org/66678 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-01-21tdf#122808 search formatting dialog should be modalCaolán McNamara
Change-Id: I8b33fcbbf538660703f6cdb9818e8fae2c623be9 Reviewed-on: https://gerrit.libreoffice.org/66674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21Forgot to adapt one of the format stringsStephan Bergmann
...in 113536e974d7ebbbc484b0ef40406f9b4d14e511 "Avoid -Werror=format-{overflow,truncation}=" Change-Id: Ie26abed8c5694a3b26777771737ded2b3b484935
2019-01-21tdf#122689 KDE5: Fix selection clipboardAleksei Nikiforov
Selection clipboard now should properly get and set data from/to selection buffer and not from/to copy buffer. Related: tdf#122239 Change-Id: Ia5298932ee277385c6f8a587d4fcb8204647c491 Reviewed-on: https://gerrit.libreoffice.org/66577 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-21tdf#121561 sw DOCX: output toc-end inside last toc paragraphSerge Krot
During export of the TOC into DOCX all TOC field parts should be placed inside one STD frame: field start-begin, field-separate and field-end mark. Updated unit test. Change-Id: I10e37a48160e1dc4f0074c4e2e7621a59f79c2ee Reviewed-on: https://gerrit.libreoffice.org/66587 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-21oox smartart, org chart: fix position and size of connector shapesMiklos Vajna
Finally the bugdoc rendering result is reasonable and even looks like a tree as it should. Change-Id: I4e7a729afd3d2c5af2e7f41903737bd56be406fa Reviewed-on: https://gerrit.libreoffice.org/66664 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-21ofz#9707 avoid timeout on excessive EndGroups without matching BeginGroupsCaolán McNamara
Change-Id: I6b660ba86ba639935da509623f1041b6fc1debc0 Reviewed-on: https://gerrit.libreoffice.org/66669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21ofz#11275 erase via positionCaolán McNamara
rather than searching pointer each time Change-Id: I0db8990b39cce024fbf0bfc6ebd091a5fa210c02 Reviewed-on: https://gerrit.libreoffice.org/66665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-21WaE: loplugin:casttovoidCaolán McNamara
Change-Id: I823a809048905a93f1413e3332dcb5fe18748a4a
2019-01-21Related tdf#120625: improve querying supported data flavoursKatarina Behrens
Change-Id: Ia46b136f64c2750ed466d86967de9dfe90b4ce65 Reviewed-on: https://gerrit.libreoffice.org/65003 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-01-21fix -Werror=extraNoel Grandin
error: base class ‘class salhelper::SimpleReferenceObject’ should be explicitly initialized in the copy constructor after commit 3b16e997f69efe2e3f6cdf64fe8fb2727b6ebaa7 Date: Fri Jan 18 15:38:07 2019 +0200 cleanup SwAuthEntry manual ref-counting Change-Id: I291a8a4f6c2a6ec38506265f6a0382f89774ecd4
2019-01-21Add a (dummy) WordBasic.FileSave()Tor Lillqvist
Change-Id: I021d63c9d57f1e0435bcc5f97abc57bc39fece01
2019-01-21Add TODO FIXMETor Lillqvist
Change-Id: I1492c604ac39ce72fe2cfe8804ac15e8c41b9a46
2019-01-21Add a dummy WordBasic.ToolsOptionsViewTor Lillqvist
Does nothing. Needed for customer application to proceed. Once we are further along in getting it to work, we can investigate what the parameters passed to this ToolsOptionsView method actually are. (This WordBasic thing is something that has been deprecated since last century, I suspect, so no wonder it is hard to find authoritative documentation on it.) Change-Id: I62a6d6d9abb9364afca110570fa341a2375a77a6
2019-01-21Try ignoring RuntimeException in ComḿandBars(), VB6 clients don't like them?Tor Lillqvist
Change-Id: Ia577174fac926295db439349f6caca178b363ba0
2019-01-21Don't throw an exception, just ignore trying to set an unhandled WindowStateTor Lillqvist
End-user VB6 applications might not like the exception. Better to just ignore. Change-Id: I42718de7855079e38c7983db39180c184ab7224f
2019-01-21Add Documents.OpenOld() method and Application.CustomizationContext propertyTor Lillqvist
OpenOld() just forwards to the regular Open(), passing empty extra parameters. CustomizationContext is fully dummy for now. Change-Id: I167494700853768d971fe16afea35e90a647a00e
2019-01-21sw: make members private in DocxSdrExport::ImplMiklos Vajna
Which shows that m_rSdrExport was unused. Change-Id: I74c305dd2088764c8971bcad09e60b7714eae05d Reviewed-on: https://gerrit.libreoffice.org/66661 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-21Slience bogus -Werror=maybe-uninitializedStephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, e.g. at: > In file included from include/rtl/ustring.hxx:37, > from include/cppuhelper/factory.hxx:26, > from unoxml/source/rdf/librdf_repository.hxx:24, > from unoxml/source/rdf/librdf_repository.cxx:20: > include/rtl/string.hxx: In static member function ‘static std::shared_ptr<{anonymous}::librdf_TypeConverter::Node> {anonymous}::librdf_TypeConverter::extractNode_NoLock(const com::sun::star::uno::Reference<com::sun::star::rdf::XNode>&)’: > include/rtl/string.hxx:294:27: error: ‘*((void*)(& type)+8).rtl::OString::pData’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > rtl_string_release( pData ); > ~~~~~~~~~~~~~~~~~~^~~~~~~~~ > unoxml/source/rdf/librdf_repository.cxx:2094:30: note: ‘*((void*)(& type)+8).rtl::OString::pData’ was declared here > boost::optional<OString> type; > ^~~~ This appears to be a common pattern of false positives with uses of boost::optional, common enough to disable the warning globally for affected compilers, even if there would also be useful findings by that warning (e.g., <https://gerrit.libreoffice.org/#/c/66619/> "Fix -Werror=maybe-uninitialized"). I didn't bother to file a GCC bug for the reproducer used in configure.ac, <https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=maybe-uninitialized> already shows lots of open bugs in that area, and the documentation at <https://gcc.gnu.org/onlinedocs/gcc-8.2.0/gcc/Warning-Options.html> states that "GCC may not be able to determine when the code is correct in spite of appearing to have an error." (Clang appears to not support -Wmaybe-uninitialized at all, so exclude it from the configure.ac check, to not have the check's failure result in an unsupported -Wno-maybe-uninitialized end up on the compiler command line.) Change-Id: Ifb9ca4c342750eae54f7e1a01506101310484c7e Reviewed-on: https://gerrit.libreoffice.org/66621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Avoid -Werror=stringop-truncationStephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized. These are not actually problems, as in both cases strncpy(p,...,N-1) is used to copy a string into an area p of length N that has initially been zero-initialized, so p[N-1] will already contain NUL. But add the (redundant) p[N-1]=NUL just in case, and to silence GCC (where the documentation explicitly recommends this additional write as a way to silence the warning). Unfortunately, in hstyle.cxx at least GCC 8.2 with --enable-optimized would still emit the warning, even though it uses the recommended way of handling it, so needs to be silenced with a #pragma. Change-Id: Ie41f420c732c2bfb699903ebd21ce1a89dd2b236 Reviewed-on: https://gerrit.libreoffice.org/66620 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Fix -Werror=maybe-uninitializedStephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized: > In file included from vcl/source/gdi/pngread.cxx:27: > include/vcl/pngread.hxx: In member function ‘bool vcl::PNGReaderImpl::ReadNextChunk()’: > include/vcl/pngread.hxx:49:12: error: ‘aDummyChunk.vcl::PNGReader::ChunkData::nType’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > struct ChunkData > ^~~~~~~~~ The immediately relevant part is initializing sal_uInt32 nType = 0; in the ChunkData ctor, but while at it, also make the Read*Int32 calls in PNGReaderImpl::ReadNextChunk more robust. Change-Id: Id6ad10a4382a8d063fd70c7bac595c3693475ca3 Reviewed-on: https://gerrit.libreoffice.org/66619 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Avoid -Werror=format-{overflow,truncation}=Stephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, by making the buffers large enough for the (hypothetical) largest values of the various date/time components Change-Id: I82e9b08fa099546b2d6f29c702e1440df9e6c6e0 Reviewed-on: https://gerrit.libreoffice.org/66618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21Avoid -Werror=format-truncation=Stephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, about trying to output up to 4 bytes into a destionation of size 3 Change-Id: I42c3c9bb7a0355a7d4a1574c6c65d6f74a97f1dc Reviewed-on: https://gerrit.libreoffice.org/66617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21tdf#42949 Fix IWYU warnings in sd/source/{core,helper}/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie9b605eb5340f9e47a977020a8f3688c2412a3c9 Reviewed-on: https://gerrit.libreoffice.org/66635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-21Simplify containers iterations in sc/source/filter/x*Arkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: Ide655aa3633f548ac38c71b452b0ecfc91ee9128 Reviewed-on: https://gerrit.libreoffice.org/66636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-21o3tl::make_unique -> std::make_unique in dbaccess...frameworkGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e Reviewed-on: https://gerrit.libreoffice.org/66545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-21cleanup SwAuthEntry manual ref-countingNoel Grandin
And remove the "handle" nonsense and just pass plain honest pointers to a real type around Change-Id: Ic49443f5f8b20890d8335088331fff81585e8981 Reviewed-on: https://gerrit.libreoffice.org/66615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-21use comphelper::containerToSequence in OGenericUnoControllerNoel Grandin
Change-Id: If58a22a3d9536ade5f63a3708fd0b6c53f2e21c3 Reviewed-on: https://gerrit.libreoffice.org/66585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-21tdf#122616 UI Enhancement: Print dialog texts changed as requested in commentsSass Dávid
Print dialog text's capitalization changed to follow the styles used in GNOME user interface elements. Change-Id: I718c4776eaa28e98c5209d160cd47e27782b1101 Reviewed-on: https://gerrit.libreoffice.org/66093 Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-21Fix typoAndrea Gelmini
Change-Id: I14fba5feb45ee2f8de5f017b6da95bd1fe4908f8 Reviewed-on: https://gerrit.libreoffice.org/66660 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-20Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Removed executable permission on image files Change-Id: Ia148161e36c046bfd6374c686c5074d8524dbf06 Reviewed-on: https://gerrit.libreoffice.org/66638 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-20Update git submodulesMark-R
* Update helpcontent2 from branch 'master' - tdf#121065 Replace SetOperations, Relations Symbols with SVGs Replace SetOperations, Relations Symbols PNG images with SVG and updated 03090800.xhp, 03090200.xhp and Package_html_media.mk Change-Id: I2066c1e692a4549a5ab9e020adf1d25ceb7d75c0 Reviewed-on: https://gerrit.libreoffice.org/66643 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-20Update git submodulesRicardo Palomares
* Update dictionaries from branch 'master' - Bring shipped Spanish dictionary up to version 2.4 Change-Id: Ie814270a83d7459d402e8e92dab4959f2f0793e5 Reviewed-on: https://gerrit.libreoffice.org/66654 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-20Fix typos in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I9e6779003639e4b90e8fcbe3ef8a7f7dc1ed85f3 Reviewed-on: https://gerrit.libreoffice.org/66652 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-20tdf#92542 add index elements to table context menus in sw modulesandreas kainz
Change-Id: I19809e68542d5795310dcfccbaec70fa931c5147 Reviewed-on: https://gerrit.libreoffice.org/66651 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-01-20Check id in outer loopArkadiy Illarionov
Change-Id: I24ecf429d26c19823cd76128d2b5e0ec3bdf82c7 Reviewed-on: https://gerrit.libreoffice.org/66639 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-30 18:57:54 +0000