summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-29xmloff: create XMLImpressExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I44c3ac24c19f4ecd1d0d01a9a686b486f3b35c48 Reviewed-on: https://gerrit.libreoffice.org/78236 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28loplugin:returnconstval (macOS)Stephan Bergmann
Remove the spurious "const" that dates back to a poor change in 9177329a425cf70b515d1f266132838894fe54c6 "vcl: FontCharMap to use intrusive_ptr ImplFontCharMap": > --- a/vcl/inc/quartz/salgdi.h > +++ b/vcl/inc/quartz/salgdi.h > @@ -73,7 +73,7 @@ public: > CoreTextStyle* CreateTextStyle( const FontSelectPattern& ) const; > int GetFontTable( const char pTagName[5], unsigned char* ) const; > > - const ImplFontCharMap* GetImplFontCharMap() const; > + const ImplFontCharMapPtr GetImplFontCharMap() const; > bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) > const; > bool HasChar( sal_uInt32 cChar ) const; > Change-Id: I6a533a917ec42513b0783332c35e0a6803504324 Reviewed-on: https://gerrit.libreoffice.org/78235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#118169: ActiveX form control saved incorrectly with accented lettersTamás Zolnai
Write out unicode strings without any compression. Change-Id: I93cadc40bacbd679724c3404fd870cba48065650 Reviewed-on: https://gerrit.libreoffice.org/78234 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-28Fix typoAndrea Gelmini
Change-Id: Ic1256a994fb6813437320c29bfc73d414faf46dd Reviewed-on: https://gerrit.libreoffice.org/78232 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-28sd lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Impress in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I04b92c85b6627e145b5271a6f84780257e8f0d55 Reviewed-on: https://gerrit.libreoffice.org/78231 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28INetURLObject::setFSysPath is unused nowStephan Bergmann
...after 056e1fff2ed232f2a50db933fbade1c71c0c2a65 "Simplify code removing the last segment from a URL" Change-Id: I3abe84ada119356191d8df9c0a8ee62dcf18d108 Reviewed-on: https://gerrit.libreoffice.org/78228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid dynamic_cast in AttributeOutputBase::ConvertURLMike Kaganski
This unifies the code for any format using the function. Note: RTF code currently doesn't use the function, so an empty string is used in its ctor. Change-Id: I8776c095d4527313d06b0620059a892a48a9eaa1 Reviewed-on: https://gerrit.libreoffice.org/78229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-28sw lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Writer in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I615af4a0692216f794c78955d337e6b8dbc8db5e Reviewed-on: https://gerrit.libreoffice.org/78230 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Send Bcp47 codes with regionSzymon Kłos
Change-Id: I816eddab3d88534bff6c1f1dba81b45107cdb372 Reviewed-on: https://gerrit.libreoffice.org/78227 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28INetURLObject FSysStyle ctor is unused nowStephan Bergmann
...after 90e33df14a1bdff55c4759102658dba7510a733a "Always using translateToInternal should be fine in SalGtkPicker::uritounicode" Change-Id: I3712109ef875ce8961d2da904a38400e0cf97496 Reviewed-on: https://gerrit.libreoffice.org/78166 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Handle LANGUAGE_NONE caseSzymon Kłos
Change-Id: I4dde96d488fc1e956bc2385c5e311eeadacd4be0 Reviewed-on: https://gerrit.libreoffice.org/78226 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Simplify code removing the last segment from a URLStephan Bergmann
This code had been introduced with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX", but it is not clear to me what part of <https://bugs.documentfoundation.org/show_bug.cgi?id=86087> "FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx" it is meant to address. None of the tests in `make check` trigger the > else > { > // DOC > WW8Export* pWW8Export = dynamic_cast<WW8Export*>(&GetExport()); > if ( pWW8Export ) > { > SwWW8Writer& rWriter = pWW8Export->GetWriter(); > sExportedDocumentURL = rWriter.GetMedia()->GetURLObject().GetPath(); > } > } block. But what the code presumably wants to do is to create, for the DOC case, an anAbsoluteParent that is rWriter.GetMedia()->GetURLObject() with the final URL path segment removed: INetURLObject::GetPath returns the "dirname" part of a file URL's path (i.e., everything but the last path segment), and with a trailing slash removed, in the form of a filesystem pathname. That means that > INetURLObject anAbsoluteParent( sExportedDocumentURL ); creates an invalid anAbsoluteParent (because the input is not a URL), so > if ( anAbsoluteParent.GetURLPath().isEmpty() ) is true (but why not use a more obvious check of anAbsoluteParent.HasError(), or should this code also be relevant for the DOCX case?), so the following block > { > // DOC filter returns system path (without file:///) > anAbsoluteParent.setFSysPath( sExportedDocumentURL, FSysStyle::Detect ); > anAbsoluteParent.setFinalSlash(); > } recreated the URL from the filesystem pathname and added back the trailing slash. Change-Id: I9346a23680a65b6fd1ba0fa33f4565df50bd9e51 Reviewed-on: https://gerrit.libreoffice.org/78210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#127192 Printing in main threadJuergen Funk
the wollmux has change the dialogs form swing to the LO-Dialogs, and when printig with MS-PDF then LO hang on this line. The reason is wollmux run in it own thread, but this thread has no win-message-pump, when the printer-driver would open the FileSave-Dialog then it hangs, because the message-pump is missing in this thread. The swing has made it own win-message-pump for this thread. Change-Id: Ia5131464dcc5f166133a3302d29550e945dd1026 Reviewed-on: https://gerrit.libreoffice.org/78170 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de> Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-08-28Blind fix for ENABLE_MERGELIBSStephan Bergmann
...after 55402d82c5a81322ff7bca3c277a8813bd967a09 "tdf#42949 Fix IWYU warnings in vcl/source/[o-w]*/" had caused tb62 to fail with > C:/cygwin64/home/buildslave/source/libo-core/vcl/source/window/builder.cxx(1604): error C3861: "SVLIBRARY": Bezeichner wurde nicht gefunden. [...] > C:/cygwin64/home/buildslave/source/libo-core/vcl/source/window/builder.cxx(2294): error C3861: "SVLIBRARY": Bezeichner wurde nicht gefunden. Change-Id: I2102454bf12dc3a04d630ab09cb427471fef99d4 Reviewed-on: https://gerrit.libreoffice.org/78223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Send ISO language code on state changedSzymon Kłos
[ Miklos: commit 13c77cc3b34555aefd898a15c6ad898049f8aed6 (Send iso code for languages, 2019-07-19) only changed the behavior in case the LOK client asks for a list of languages explicitly. This one affects the case when the language under the cursor changes and core initiates the core -> client information sending. ] Also contains: Fix language unit test Change-Id: I45b4263026928de898fe89e25c21d97c82e1beeb Change-Id: I2f82cee1fda613636fc421449a2d8a56b0a35b7f Reviewed-on: https://gerrit.libreoffice.org/78222 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28New loplugin:stdfunctionStephan Bergmann
...finding dubious additions to namespace std (concentrating on functions for now). C++17 [namespace.std]/1: "The behavior of a C ++ program is undefined if it adds declarations or definitions to namespace std or to a namespace within namespace std unless otherwise specified." This found ad4c7b97752b4da73808402604d6f96b39d920f5 "Avoid declaring function templates in namespace std" 042e30a3dc057aef4a02d95960e4dd4fb8d083ae "Avoid adding a function template declaration to namespace std" cae9240a76cdb0eeed92421930d3b4cbef0ac201 "Avoid adding a function declaration to namespace std" Change-Id: Ic2ba54e2a8bf931d5c58cedf499c0d1229eb2166 Reviewed-on: https://gerrit.libreoffice.org/78220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Add DISABLE_DYNLOADING guard for notebookbar addons builderSzymon Kłos
Change-Id: I99487a8adaa24f155eec2182899127c5bab6a21f Reviewed-on: https://gerrit.libreoffice.org/78219 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-28Send iso code for languagesSzymon Kłos
[ Miklos: the motivation for this change is that LOK clients may display information on their UI depending on screen size. Mobile clients may want to have a more compact display, where showing the full language name takes too much space, and showing some kind of language code is a better way. ] Change-Id: Iec93ad05d83a8ce871eab33bd12e99aee9aafa86 Reviewed-on: https://gerrit.libreoffice.org/78217 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Always using translateToInternal should be fine in SalGtkPicker::uritounicodeStephan Bergmann
When SalGtkPicker::uritounicode was originally introduced in 27994c3831e55174af313e74e09905003ff34440 "INTEGRATION: CWS cmcfixes4: #i46017# to and from system locale encoding when url is file:///", it only contained the g_filename_from_uri code and no translateToInternal fallback (though the SalGtkPicker::unicodetouri counterpart, already introduced then, only used INetURLObject::getExternalURL, the precursor to today's translateToExternal, from the beginning). The translateToInternal fallback was only added later with e68b4920b0a726578094013b819b1e0833929acb "INTEGRATION: CWS c07v007_SRC680: #b6465588# cope with URI encoded in non UTF8 encoding". But I see no reason to not always use just translateToInternal in uritounicode (matching the translateToExternal in unicodetouri). Trying with both LC_ALL=en_US.UTF-8 and LC_ALL=en_US.ISO-8859-1 and the gtk3 VCL plugin (on GTK 3.24.10), the only difference between using the g_filename_from_uri and the translateToInternal code is that the former produces an IURI sURL where non- ASCII Unicode characters are written as such (later on in the LO code to be encoded as %XX...), whereas the latter produces an sURL where those non-ASCII Unicode characters are already encoded as %XX... One difference is for filenames containing bytes that cannot be represented in the current LC_CTYPE encoding. g_filename_from_uri reports them as U+FFFD REPLACEMENT CHARACTER, so producing an IURI sURL containing "�" (that is later on in the LO code encoded as %EF%BF%BD), while translateToInternal keeps the single %XX representing the original byte intact. (And even though LO can't properly handle such a file URL with non--UTF-8 payload, this change is a small- step win of keeping the URL at least intact and not garbling it completely with "�" aka %EF%BF%BD). Change-Id: If27fc64c75e986dbb467e147a7e43df3a01db640 Reviewed-on: https://gerrit.libreoffice.org/78216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid adding a function declaration to namespace stdStephan Bergmann
Change-Id: Id6839850f249f2065de05a0fd929e68ca1003ec6 Reviewed-on: https://gerrit.libreoffice.org/78213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid adding a function template declaration to namespace stdStephan Bergmann
Change-Id: I1368276c859d3c81f4ebfbeca47bb99e781f2fed Reviewed-on: https://gerrit.libreoffice.org/78214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#42949 Fix IWYU warnings in vcl/source/[o-w]*/Gabor Kelemen
Plus a quick recheck for files in vcl/source/[a-g]*/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1ae951047be2e034da5f3b0422613ddb0a091ad Reviewed-on: https://gerrit.libreoffice.org/78065 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28sw: prefix members of SwUndoFlyBaseMiklos Vajna
See tdf#94879 for motivation. Change-Id: I266ba820629ec6f8505d091fb6090ed8626b4742 Reviewed-on: https://gerrit.libreoffice.org/78211 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28Fix other signature of basicide_macro_organizerStephan Bergmann
...after 97710225f015c8716c80e55ecdb78832f2edc731 "sfx2: fix DISABLE_DYNLOADING build" had changed it to 'void const *' but the concurrently submitted 036e635678aedc414e2d55217e4f7f8359ed1b9a "Fix signature of basicide_macro_organizer" fixed the underlying issue that had been introduced with df905f41a33d0d7d2cde7fad80c5b3dc3c837c10 "loplugin:constmethod in sfx2" and had caused DISABLE_DYNLOADING builds to fail Change-Id: If5d8c3289d7c77f5e6526bf7f4e0c48292dc5f71 Reviewed-on: https://gerrit.libreoffice.org/78209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28ContentInfo::Equals uses std::equalAdrien Ollier
Change-Id: Ia99cd1cb9594d6398ff351f6ded7888a75c83dd6 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/76504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-28GtkWidget for the priority of extension under Extension Tab.Sumit Chauhan
The new structure : PriorityMergedHBox --OptionalBox --ToolBoxExtension --Extension1 --OptionalBox ..... Change-Id: I72760e4f0d60eb6f1f82c1e928601d41a2e4b6ce Reviewed-on: https://gerrit.libreoffice.org/76987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-28Record patch as upstreamedMike Kaganski
Change-Id: Ia84db6c3d8051b872a838b530a8c44ce4a4b2821 Reviewed-on: https://gerrit.libreoffice.org/78198 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-28Typo: HAPICOLOR_WITHE->HAPICOLOR_WHITE (vbahelper)Julien Nabet
Change-Id: I51a43e190345a1e981f9bd524d8b2feaf0eb2521 Reviewed-on: https://gerrit.libreoffice.org/78207 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-28Remove unnecessary braces.Kohei Yoshida
As to the reason why they were there can be explained by the commit 48b35ed43db87d21a943e66cfa4f59213dcfe3a1. They braces did make sense before that commit. Change-Id: Ie889d9e2404436c1cc0249dcf71bf18ebfd40636 Reviewed-on: https://gerrit.libreoffice.org/78212 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27Fix typosAndrea Gelmini
Change-Id: If2fcd9aaf920f30b49a7bb828ba174939b13a3e7 Reviewed-on: https://gerrit.libreoffice.org/78091 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-27Use lambda expression here instead of a function object.Kohei Yoshida
Change-Id: I469cc9fa0506153e6dc4ff8fe6d5bad19c02b285 Reviewed-on: https://gerrit.libreoffice.org/78208 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27tdf#74045 Make ImageMaps in slideshow clickableSamuel Mehrbrodt
Change-Id: I151983ce34a58c0f0d4b1e912f43525de4c0ad28 Reviewed-on: https://gerrit.libreoffice.org/78157 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-27Fix signature of basicide_macro_organizerStephan Bergmann
see the function definition in basctl/source/basicide/basobj2.cxx Change-Id: If19f0a82d5498795ceef26342e0152fb12ef983d Reviewed-on: https://gerrit.libreoffice.org/78204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27no need to add a new virtual method (tdf#119388 related)Noel Grandin
we can re-use the existing GetObjIdentifier infrastructure Change-Id: Ie604d643186a925da41a1e67ccd5f2461ceb20f1 Reviewed-on: https://gerrit.libreoffice.org/78193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27Fix ASan heap-use-after-freeStephan Bergmann
...when opening a document via "File - Open..." with "Tools - Options... - LibreOffice - General - Open/Save Dialogs - Use LibreOffice dialogs" enabled: > ==7004==ERROR: AddressSanitizer: heap-use-after-free on address 0x61700023a370 at pc 0x7f88c788db4a bp 0x7ffd8c7d0020 sp 0x7ffd8c7d0018 > READ of size 8 at 0x61700023a370 thread T0 > #0 in rtl::Reference<PlacesListBox>::get() const at include/rtl/ref.hxx:171:16 > #1 in VclPtr<PlacesListBox>::operator bool() const at include/vcl/vclptr.hxx:187:28 > #2 in CustomContainer::GetFocus() at fpicker/source/office/iodlg.cxx:433:39 > #3 in vcl::Window::CompatGetFocus() at vcl/source/window/window.cxx:3731:5 > #4 in vcl::Window::ImplGrabFocus(GetFocusFlags) at vcl/source/window/mouse.cxx:380:17 > #5 in vcl::Window::GrabFocus() at vcl/source/window/window.cxx:2991:5 > #6 in vcl::Window::dispose() at vcl/source/window/window.cxx:448:26 > #7 in Control::dispose() at vcl/source/control/ctrl.cxx:62:13 > #8 in SvtFileView::dispose() at svtools/source/contnr/fileview.cxx:879:14 [...] > 0x61700023a370 is located 496 bytes inside of 648-byte region [0x61700023a180,0x61700023a408) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in std::default_delete<SvtExpFileDlg_Impl>::operator()(SvtExpFileDlg_Impl*) const at gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:81:2 > #2 in std::__uniq_ptr_impl<SvtExpFileDlg_Impl, std::default_delete<SvtExpFileDlg_Impl> >::reset(SvtExpFileDlg_Impl*) at gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:178:4 > #3 in std::unique_ptr<SvtExpFileDlg_Impl, std::default_delete<SvtExpFileDlg_Impl> >::reset(SvtExpFileDlg_Impl*) at gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:444:7 > #4 in SvtFileDialog::dispose() at fpicker/source/office/iodlg.cxx:523:11 [...] Change-Id: I022eac69123d87f75bda5067a672496030e1a8ec Reviewed-on: https://gerrit.libreoffice.org/78199 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Fix typo (translateToExternal vs. translateToInternal)Stephan Bergmann
...introduced with e4f37435a0fdd66b2d58633c991c6df720790f39 "fdo#46808, Use service constructor for uri::ExternalUriReferenceTranslator": > @@ -82,7 +82,7 @@ OString SalGtkPicker::unicodetouri(const OUString &rURL) > INetURLObject aURL(rURL); > if (INET_PROT_FILE == aURL.GetProtocol()) > { > - OUString aNewURL = uno::Reference<uri::XExternalUriReferenceTranslator>(uno::Reference<XMultiComponentFactory>(comphelper::getProcessServiceFactory(), UNO_QUERY_THROW)->createInstanceWithContext(OUString("com.sun.star.uri.ExternalUriReferenceTranslator"), m_xContext ), UNO_QUERY_THROW)->translateToExternal( rURL ); > + OUString aNewURL = uri::ExternalUriReferenceTranslator::create( m_xContext )->translateToInternal(rURL); > > if( !aNewURL.isEmpty() ) > { Change-Id: Ib709df9ef600f2b6b61878cbb8f99d3ff7ab5c2f Reviewed-on: https://gerrit.libreoffice.org/78203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Use getSystemPathFromFileURL() which is exactly what we need.Kohei Yoshida
Change-Id: I09b77435d1dcd1c5e717fe4f976620bcdcecfb54 Reviewed-on: https://gerrit.libreoffice.org/78206 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27Consolidate ImplCalcLineSpacing()Khaled Hosny
Move getting UPEM and font tables to the functions and use HarfBuzz API to get them. In the future we might stop reading the tables ourselves and use HarfBuzz metrics API instead. Change-Id: I3f4511628fd33200bae94cdcd96479ba3e6d2fba Reviewed-on: https://gerrit.libreoffice.org/78081 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-08-27tdf#91843 sd sidebar: fix unexpected borders around the slide layout previewsMiklos Vajna
Regression from commit e5bb5c52aeaeb60c8592b004efd88c30242e03a1 (add RenderContext to Window::PushPaintHelper, use Erase correctly, 2015-05-18), the problem was similar to tdf#92079, except here the missing background was a solid color, not a bitmap. Change-Id: I2221b3eabed84cf039cb8c3881442c9e23c6ec13 Reviewed-on: https://gerrit.libreoffice.org/78205 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-27Return empty HarfBuzz font instead of nullptrKhaled Hosny
hb_font_get_empty() returns an empty, singleton font object that can be safely passed to HarfBuzz API that would otherwise crash if given a nullptr. Keep the assert to catch calls to this code in debug builds, since it is really a bug for LogicalFontInstance implementations without a backed HarfBuzz font to call code that requires it. Change-Id: I93e2b3204eb08b0c4c54587bc0f60cbf3c18c7d7 Reviewed-on: https://gerrit.libreoffice.org/78178 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-08-27Let PrintFontManager::addFontFile directly take a file URLStephan Bergmann
...instead of converting from a file URL to a filesystem pathname at the (sole) call site and then back to a file URL in addFontFile Change-Id: I468dbfc183b062668209c6bd84fcfed122ceff37 Reviewed-on: https://gerrit.libreoffice.org/78202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27loplugin:referencecasting find more redundant static_castNoel Grandin
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae Reviewed-on: https://gerrit.libreoffice.org/78191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27use SdrCircKind enum more widelyNoel Grandin
and make it a scoped enum Change-Id: I6325ff86ff8566135f6d01a576c659539dcb3ed9 Reviewed-on: https://gerrit.libreoffice.org/78176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27sfx2: fix DISABLE_DYNLOADING buildMiklos Vajna
Change-Id: I61df3f0f213d1b49d2e2ffec0554bdcd92d3d11f
2019-08-27You can just check for nCheckPos being 0 for non-error condition.Kohei Yoshida
If I read the method doc of PutEntry correctly, the boolean return type only indicates whether the string being inserted is a new one or not. You can still set the format even when the string already exists in the format table. Change-Id: Id3165323aada47e8d4fe19683008011bd69caac2 Reviewed-on: https://gerrit.libreoffice.org/78160 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27"HyperLinkURL" already is a URL hereStephan Bergmann
...at least in all cases encountered during CppunitTest_sw_ooxmllinks, so why bother going via an assumed filesystem pathname? (Rather, add some CPPUNIT_ASSERT to clarify expectations.) This code had originally been added with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX". Change-Id: I03e4389338e5549ad3a530bed054a17518f21c96 Reviewed-on: https://gerrit.libreoffice.org/78196 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27loplugin:constmethod in sfx2Noel Grandin
Change-Id: Ic129a8e136dc3f3b0a36fdb83e7aa71027ada59a Reviewed-on: https://gerrit.libreoffice.org/78190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27Avoid declaring function templates in namespace stdStephan Bergmann
...that don't even depend on program-defined types Change-Id: I102ce7e97280e7b80f8270ab3b7bbdc111d4d68c Reviewed-on: https://gerrit.libreoffice.org/78168 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Record patch as upstreamedStephan Bergmann
Change-Id: Ib28e86de29cdb5d91e05b341c75b87590e8b3aa6 Reviewed-on: https://gerrit.libreoffice.org/78189 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27Use a direct way to get at the temp dirStephan Bergmann
...in code originally added with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX", by introducing utl::TempFile::GetTempNameBaseDirectory Change-Id: Ic0e8b54896a3829c081255404ef92b96f1724a2a Reviewed-on: https://gerrit.libreoffice.org/78174 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-11 21:29:40 +0000